Re: [libvirt] [PATCH 1/4 v3] pci: Add two new pci utils pciDeviceGetVirtualFunctionInfo and pciConfigAddressToSysfsFile

2012-03-06 Thread Laine Stump
On 03/05/2012 08:12 PM, Roopa Prabhu wrote: From: Roopa Prabhu ropra...@cisco.com pciDeviceGetVirtualFunctionInfo returns pf netdevice name and virtual function index for a given vf. This is just a wrapper around existing functions to return vf's pf and vf_index with one api call

Re: [libvirt] [PATCH 2/4 v3] virtnetdev: Add support functions for mac and portprofile associations on a hostdev

2012-03-06 Thread Laine Stump
On 03/05/2012 08:12 PM, Roopa Prabhu wrote: From: Roopa Prabhu ropra...@cisco.com This patch adds the following: - functions to set and get vf configs - Functions to replace and store vf configs (Only mac address is handled today. But the functions can be easily extended for vlans and

Re: [libvirt] [PATCH 3/4 v3] virnetdevvportprofile: Changes to support portprofiles for hostdevs

2012-03-06 Thread Laine Stump
On 03/05/2012 08:12 PM, Roopa Prabhu wrote: From: Roopa Prabhu ropra...@cisco.com This patch includes the following changes - removes some netlink functions which are now available in virnetdev.c - Adds a vf argument to all port profile functions For 802.1Qbh devices, the port profile calls

Re: [libvirt] [PATCHv2 00/17] Support for interface type='hostdev'

2012-03-06 Thread Laine Stump
On 02/28/2012 03:14 PM, Laine Stump wrote: This series of patches enhances the interface device to support a sort of intelligent hostdev, i.e. PCI passthrough where device-type specific initialization is done prior to assigning the device to the guest, in particular to allow setting the MAC

Re: [libvirt] [PATCH 4/4 v3] qemu_hostdev: Add support to install port profile and mac address on hostdevs

2012-03-06 Thread Laine Stump
On 03/05/2012 08:12 PM, Roopa Prabhu wrote: From: Roopa Prabhu ropra...@cisco.com These changes are applied only if the hostdev has a parent net device. If the parent netdevice has virtual port information, the original virtualport associate functions are called (these set and restore both

Re: [libvirt] [PATCH 1/3 V7] add nodeGetCPUmap() for getting available CPU IDs in a cpumap.

2012-03-06 Thread Richard W.M. Jones
On Fri, Mar 02, 2012 at 10:54:22AM +0800, Lai Jiangshan wrote: +/* + * Linux maintains cpu bit map. For example, if cpuid=5's flag is not set + * and max cpu is 7. The map file shows 0-4,6-7. This function parses + * it and returns cpumap. + */ +static const char * +linuxParseCPUmap(int

Re: [libvirt] [PATCH 4/4 v3] qemu_hostdev: Add support to install port profile and mac address on hostdevs

2012-03-06 Thread Laine Stump
On 03/05/2012 08:12 PM, Roopa Prabhu wrote: From: Roopa Prabhu ropra...@cisco.com These changes are applied only if the hostdev has a parent net device. If the parent netdevice has virtual port information, the original virtualport associate functions are called (these set and restore both

[libvirt] [PATCH] add screendump async to qemu

2012-03-06 Thread Alon Levy
RHBZ: 800338 Adds a new capability to qemu, QEMU_CAPS_SCREENDUMP_ASYNC, available if the qmp command screendump-async exists. If that cap exists qemuDomainScreenshot uses it. The implementation consists of a hash from filename to struct holding the stream and temporary fd. The fd is closed and

Re: [libvirt] [PATCH 0/4 v3] Support mac and port profile for interface type='hostdev'

2012-03-06 Thread Laine Stump
On 03/05/2012 08:12 PM, Roopa Prabhu wrote: This series implements the below : 01/4 pci: Add two new pci util pciDeviceGetVirtualFunctionInfo and pciConfigAddressToSysfsFile 02/4 virtnetdev: Add support functions for mac and portprofile associations on a hostdev 03/4 virnetdevvportprofile:

Re: [libvirt] [PATCHv2 01/15] docs: use correct terminology for 1024 bytes

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: Yes, I like kilobytes better than kibibytes (when I say kilobytes, I generally mean 1024). But since the term is ambiguous, it can't hurt to say what we mean, by using both the correct name and calling out the numeric equivalent. * src/libvirt.c

Re: [libvirt] [PATCH 1/3 V7] add nodeGetCPUmap() for getting available CPU IDs in a cpumap.

2012-03-06 Thread Richard W.M. Jones
This all appears to work. I built my own libvirt with the three remaining patches and was able to read pCPU information for a running domain. I have pushed the required bits upstream in ocaml-libvirt and virt-top: http://git.annexia.org/?p=ocaml-libvirt.git;a=summary

Re: [libvirt] [PATCHv2 02/15] api: add overflow error

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: Overflow can be user-induced, so it deserves more than being called an internal error. Note that in general, 32-bit platforms have Definitely. Internal error is always somewhat scary to users. far more places to trigger this error (anywhere the

Re: [libvirt] [PATCH 0/4 v3] Support mac and port profile for interface type='hostdev'

2012-03-06 Thread Roopa Prabhu
On 3/6/12 3:05 AM, Laine Stump la...@laine.org wrote: On 03/05/2012 08:12 PM, Roopa Prabhu wrote: This series implements the below : 01/4 pci: Add two new pci util pciDeviceGetVirtualFunctionInfo and pciConfigAddressToSysfsFile 02/4 virtnetdev: Add support functions for mac and

Re: [libvirt] [PATCHv2 03/15] util: new function for scaling numbers

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: Scaling an integer based on a suffix is something we plan on reusing in several contexts: XML parsing, virsh CLI parsing, and possibly elsewhere. Make it easy to reuse, as well as adding in support for powers of 1000. * src/util/util.h

Re: [libvirt] [PATCHv2 04/15] xml: share 'unit' in RNG

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: The code supported unit='E' for exabyte, but the RNG did not; conversely, the RNG supported z and y but the code did not (I'm jealous if you have that much storage, particularly since it won't fit in 64-bit off_t). Also, the code supported allocation

Re: [libvirt] [Patch]: spice agent-mouse support [v3]

2012-03-06 Thread Osier Yang
On 2012年03月05日 16:17, Zhou Peng wrote: Signed-off-by: Zhou Pengzhoup...@nfs.iscas.ac.cn spice agent-mouse support Usage: graphics type='spice' mouse mode='client'|'server'/ graphics/ diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6fcca94..0adf859 100644 ---

[libvirt] [PATCH] xml: Clean up schemas to use shared data types instead of local

2012-03-06 Thread Peter Krempa
The schema files contained duplicate data types that can be shared from the basictypes.rng file. --- docs/schemas/capability.rng | 43 + docs/schemas/interface.rng | 16 docs/schemas/nodedev.rng| 54 +++---

Re: [libvirt] [PATCHv2 01/15] docs: use correct terminology for 1024 bytes

2012-03-06 Thread Christophe Fergeau
On Mon, Mar 05, 2012 at 05:34:16PM -0700, Eric Blake wrote: @@ -3619,7 +3619,7 @@ error: /** * virDomainSetMaxMemory: * @domain: a domain object or NULL - * @memory: the memory size in kilobytes + * @memory: the memory size in kibibytes (blocks of 1024) of 1024 bytes? I don't know how

Re: [libvirt] [PATCHv2 01/15] docs: use correct terminology for 1024 bytes

2012-03-06 Thread Peter Krempa
On 03/06/2012 03:34 PM, Christophe Fergeau wrote: On Mon, Mar 05, 2012 at 05:34:16PM -0700, Eric Blake wrote: @@ -3619,7 +3619,7 @@ error: /** * virDomainSetMaxMemory: * @domain: a domain object or NULL - * @memory: the memory size in kilobytes + * @memory: the memory size in kibibytes

Re: [libvirt] [PATCH] xml: Clean up schemas to use shared data types instead of local

2012-03-06 Thread Osier Yang
On 2012年03月06日 22:15, Peter Krempa wrote: The schema files contained duplicate data types that can be shared from the basictypes.rng file. --- docs/schemas/capability.rng | 43 + docs/schemas/interface.rng | 16 docs/schemas/nodedev.rng|

Re: [libvirt] [PATCH] xml: Clean up schemas to use shared data types instead of local

2012-03-06 Thread Eric Blake
On 03/06/2012 08:00 AM, Osier Yang wrote: On 2012年03月06日 22:15, Peter Krempa wrote: The schema files contained duplicate data types that can be shared from the basictypes.rng file. --- IIRC, unsignedLong allows the the + sign, and leading spaces, which we may not want. Actually,

Re: [libvirt] [PATCHv2 05/15] xml: output memory unit for clarity

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: Make it obvious to 'dumpxml' readers what unit we are using, since our default of KiB for memory (1024) differs from qemu's default of MiB; while we use bytes for storage. Tests were updated via: $ find tests/*data tests/*out -name '*.xml' | \ xargs

Re: [libvirt] [PATCHv2 06/15] storage: support more scaling suffixes

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: Disk manufacturers are fond of quoting sizes in powers of 10, rather than powers of 2 (after all, 2.1 GB sounds larger than 2.0 GiB, even though the exact opposite is true). So, we might as well follow coreutils lead in supporting three types of suffix:

Re: [libvirt] [PATCHv2 07/15] xml: drop unenforced minimum memory limit from RNG

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: The test domain allowsmemory0/memory, but the RNG was stating that memory had to be at least 4096000 bytes. Hypervisors should enforce their own limits, rather than complicating the RNG. Meanwhile, some copy and paste had introduced some fishy

Re: [libvirt] [PATCHv2 05/15] xml: output memory unit for clarity

2012-03-06 Thread Eric Blake
On 03/06/2012 08:14 AM, Peter Krempa wrote: On 03/06/2012 01:34 AM, Eric Blake wrote: Make it obvious to 'dumpxml' readers what unit we are using, since our default of KiB for memory (1024) differs from qemu's default of MiB; while we use bytes for storage. Tests were updated via: +++

[libvirt] Build error on OSX in src/util/virnetlink.c

2012-03-06 Thread Duncan Rance
Hi, I'm building on OSX with no libnl. I had to do this to get src/util/virnetlink.c to compile: diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 1575bad..59f3e39 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -545,9 +545,9 @@ int virNetlinkCommand(struct

Re: [libvirt] [PATCHv2 08/15] xml: use long long internally, to centralize overflow checks

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: On 64-bit platforms, unsigned long and unsigned long long are identical, so we don't have to worry about overflow checks. On 32-bit platforms, anywhere we narrow unsigned long long back to unsigned long, we have to worry about overflow; it's easier to do

Re: [libvirt] Build error on OSX in src/util/virnetlink.c

2012-03-06 Thread Eric Blake
On 03/06/2012 09:15 AM, Duncan Rance wrote: Hi, I'm building on OSX with no libnl. I had to do this to get src/util/virnetlink.c to compile: diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 1575bad..59f3e39 100644 --- a/src/util/virnetlink.c +++

Re: [libvirt] [PATCHv2 09/15] xml: use better types for memory values

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: Using 'unsigned long' for memory values is risky on 32-bit platforms, as a PAE guest can have more than 4GiB memory. Our API is (unfortunately) locked at 'unsigned long' and a scale of 1024, but the rest of our system should consistently use 64-bit

[libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-06 Thread Christophe Fergeau
This is needed to be able to add the SPICE agent channels --- libvirt-gconfig/Makefile.am|2 + ...ibvirt-gconfig-domain-chardev-source-spicevmc.c | 80 ...ibvirt-gconfig-domain-chardev-source-spicevmc.h | 70 +

[libvirt] [libvirt-glib 1/3] Fix GVIR_CONFIG_DOMAIN_CHANNEL_TARGET_GUESTFWD name

2012-03-06 Thread Christophe Fergeau
It was called GVIR_CONFIG_DOMAIN_CONSOLE_TARGET_GUESTFWD, which in turn confused glib-mkenums, leading to a wrong value being generated in the XML when trying to use this enumeration. --- libvirt-gconfig/libvirt-gconfig-domain-channel.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[libvirt] [libvirt-glib 3/3] Add GVirConfigDomainRedirdev

2012-03-06 Thread Christophe Fergeau
This is used to add the SPICE USB redirection channel. Even if the libvirt doc doesn't document it with the other devices deriving from GVirConfigDomainChardev, I think it makes sense to have this class derivers from GVirConfigDomainChardev too since it needs a GVirConfigDomainChardevSource, and

Re: [libvirt] [libvirt-glib 1/3] Fix GVIR_CONFIG_DOMAIN_CHANNEL_TARGET_GUESTFWD name

2012-03-06 Thread Zeeshan Ali (Khattak)
On Tue, Mar 6, 2012 at 6:38 PM, Christophe Fergeau cferg...@redhat.com wrote: It was called GVIR_CONFIG_DOMAIN_CONSOLE_TARGET_GUESTFWD, which in turn confused glib-mkenums, leading to a wrong value being generated in the XML when trying to use this enumeration. ACK! -- Regards, Zeeshan Ali

[libvirt] [PATCH] rpc: Fix VPATH building issue

2012-03-06 Thread Guannan Ren
The XDR routine .c file generated by rpcgen includes the corresponding Header file. however, the path in include directive of the header file is picked up based on the path of .x file. In the situation of VPATH Builds it will include full path of the header file rather than relative

Re: [libvirt] [PATCHv2 10/15] xml: allow scaled memory on input

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: Output is still in kibibytes, but input can now be in different scales for ease of typing. * src/conf/domain_conf.c (virDomainParseMemory): New helper. (virDomainDefParseXML): Use it when parsing. * docs/schemas/domaincommon.rng: Expand XML; rename

Re: [libvirt] [PATCHv2 05/15] xml: output memory unit for clarity

2012-03-06 Thread Peter Krempa
On 03/06/2012 04:14 PM, Peter Krempa wrote: On 03/06/2012 01:34 AM, Eric Blake wrote: Make it obvious to 'dumpxml' readers what unit we are using, since our default of KiB for memory (1024) differs from qemu's default of MiB; while we use bytes for storage. Tests were updated via: $ find

Re: [libvirt] [PATCH] add screendump async to qemu

2012-03-06 Thread Eric Blake
On 03/06/2012 04:02 AM, Alon Levy wrote: RHBZ: 800338 Adds a new capability to qemu, QEMU_CAPS_SCREENDUMP_ASYNC, available if the qmp command screendump-async exists. If that cap exists qemuDomainScreenshot uses it. The implementation consists of a hash from filename to struct holding the

Re: [libvirt] [PATCHv2 11/15] virsh: add option aliases

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: In the past, we have created some virsh options with less-than-stellar names. For back-compat reasons, those names must continue to parse, but we don't want to document them in help output. This introduces a new option type, an alias, which points to a

Re: [libvirt] [PATCHv2 12/15] virsh: use option aliases

2012-03-06 Thread Peter Krempa
On 03/06/2012 01:34 AM, Eric Blake wrote: Command line interfaces should use dash, not underscore, as many keyboard layouts allow that to be typed with fewer shift key presses. Also, the US spelling of --tunneled gets more google hits than the UK spelling of --tunnelled. * tools/virsh.c

[libvirt] [PATCH v2 wait-for-qemu] add screendump async to qemu

2012-03-06 Thread Alon Levy
RHBZ: 800338 Adds a new capability to qemu, QEMU_CAPS_SCREENDUMP_ASYNC, available if the qmp command screendump-async exists. If that cap exists qemuDomainScreenshot uses it. The implementation consists of a hash from filename to struct holding the stream and temporary fd. The fd is closed and

[libvirt] Qemu, libvirt, and CPU models

2012-03-06 Thread Eduardo Habkost
Hi, Sorry for the long message, but I didn't find a way to summarize the questions and issues and make it shorter. For people who don't know me: I have started to work recently on the Qemu CPU model code. I have been looking at how things work on libvirt+Qemu today w.r.t. CPU models, and I have

Re: [libvirt] [PATCH] rpc: Fix VPATH building issue

2012-03-06 Thread Eric Blake
On 03/06/2012 10:07 AM, Guannan Ren wrote: The XDR routine .c file generated by rpcgen includes the corresponding Header file. however, the path in include directive of the header file is picked up based on the path of .x file. In the situation of VPATH Builds it will include

Re: [libvirt] [PATCH RFC]: Support numad

2012-03-06 Thread Bill Gray
I think numad will probably work best with just the #vcpus and the #MBs of memory in the guest as the requested job size parameters. Sorry for lack of clarity here... Numad should work -- pending bugs -- with any numbers passed. If the requested parameters are bigger than actual physical

[libvirt] [libvirt-glib] Keep domain devices list sorted

2012-03-06 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org While we don't guarantee the order of devices in the list returned from gvir_domain_get_devices(), its not a bad idea to keep them sorted the same way we get them from configuration (XML). --- libvirt-gobject/libvirt-gobject-domain.c |2 +- 1

Re: [libvirt] [libvirt-glib] Keep domain devices list sorted

2012-03-06 Thread Eric Blake
On 03/06/2012 03:27 PM, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org While we don't guarantee the order of devices in the list returned from gvir_domain_get_devices(), its not a bad idea to keep them sorted the same way we get them from configuration (XML).

Re: [libvirt] [libvirt-glib] Keep domain devices list sorted

2012-03-06 Thread Zeeshan Ali (Khattak)
On Wed, Mar 7, 2012 at 1:03 AM, Eric Blake ebl...@redhat.com wrote: On 03/06/2012 03:27 PM, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org While we don't guarantee the order of devices in the list returned from gvir_domain_get_devices(), its not a bad idea to

Re: [libvirt] [PATCH 2/3 V7] qemu driver for virDomainGetCPUstats using cpuacct cgroup.

2012-03-06 Thread Eric Blake
On 03/01/2012 07:54 PM, Lai Jiangshan wrote: From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com * Now, only cpu_time is supported. * cpuacct cgroup is used for providing percpu cputime information. * include/libvirt/libvirt.h.in - defines VIR_DOMAIN_CPU_STATS_CPUTIME Stale commit

Re: [libvirt] [PATCH 3/3 V7] cpu-stats command shows cpu statistics information of a domain.

2012-03-06 Thread Eric Blake
On 03/01/2012 07:54 PM, Lai Jiangshan wrote: From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Total: cpu_time 14.312 CPU0: cpu_time 3.253 CPU1: cpu_time 1.923 CPU2: cpu_time 7.424 CPU3: cpu_time 1.712

Re: [libvirt] [Patch]: spice agent-mouse support [v3]

2012-03-06 Thread Zhou Peng
On Tue, Mar 6, 2012 at 10:08 PM, Osier Yang jy...@redhat.com wrote: On 2012年03月05日 16:17, Zhou Peng wrote: Signed-off-by: Zhou Pengzhoup...@nfs.iscas.ac.cn spice agent-mouse support Usage: graphics type='spice'   mouse mode='client'|'server'/ graphics/ diff --git

Re: [libvirt] [PATCH] Add migration APIs for libxl driver

2012-03-06 Thread Chunyan Liu
Chun Yan Liu cy...@suse.com 3/6/2012 2:29 PM I didn't get a chance to test this yet, but have some initial review comments. Signed-off-by: Chunyan Liu ---   src/libxl/libxl_driver.c |  617 ++   src/libxl/libxl_driver.h |   17 ++-   2 files

[libvirt] [PATCH] docs: Fix typo

2012-03-06 Thread Osier Yang
It used lt for , reported by Kyla Zhang weiz...@redhat.com -- Pushed under trivial rule. --- docs/formatdomain.html.in |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6434ae5..42f38d3 100644 ---

[libvirt] [libvirt-glib] All string getters should return 'const'

2012-03-06 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org There is no need for all the memory (de)allocations and especially forcing the app developers to free the strings. They can always g_strdup() the returned string if they need. --- libvirt-gconfig/libvirt-gconfig-domain-disk.c | 13 ++---

Re: [libvirt] [PATCH] Add migration APIs for libxl driver

2012-03-06 Thread Jim Fehlig
Chunyan Liu wrote: Chun Yan Liu cy...@suse.com 3/6/2012 2:29 PM I didn't get a chance to test this yet, but have some initial review comments. Signed-off-by: Chunyan Liu --- src/libxl/libxl_driver.c | 617 ++

[libvirt] [PATCH] rpc: allow truncated return for virDomainGetCPUStats

2012-03-06 Thread Eric Blake
The RPC code assumed that the array returned by the driver would be fully populated; that is, ncpus on entry resulted in ncpus * return value on exit. However, while we don't support holes in the middle of ncpus, we do want to permit the case of ncpus on entry being longer than the array returned

Re: [libvirt] [PATCH 1/3 V7] add nodeGetCPUmap() for getting available CPU IDs in a cpumap.

2012-03-06 Thread Eric Blake
On 03/06/2012 05:10 AM, Richard W.M. Jones wrote: This all appears to work. I built my own libvirt with the three remaining patches and was able to read pCPU information for a running domain. The libvirt side is now pushed. Rich: The documentation in libvirt.c correctly says that calling

Re: [libvirt] [PATCH] rpc: allow truncated return for virDomainGetCPUStats

2012-03-06 Thread Osier Yang
On 03/07/2012 12:48 PM, Eric Blake wrote: The RPC code assumed that the array returned by the driver would be fully populated; that is, ncpus on entry resulted in ncpus * return value on exit. However, while we don't support holes in the middle of ncpus, we do want to permit the case of ncpus

Re: [libvirt] [PATCH] rpc: allow truncated return for virDomainGetCPUStats

2012-03-06 Thread Osier Yang
On 03/07/2012 02:46 PM, Osier Yang wrote: On 03/07/2012 12:48 PM, Eric Blake wrote: The RPC code assumed that the array returned by the driver would be fully populated; that is, ncpus on entry resulted in ncpus * return value on exit. However, while we don't support holes in the middle of

Re: [libvirt] [PATCH 1/3] virsh: add option aliases

2012-03-06 Thread Osier Yang
On 03/03/2012 09:02 AM, Eric Blake wrote: In the past, we have created some virsh options with less-than-stellar names. For back-compat reasons, those names must continue to parse, but we don't want to document them in help output. This introduces a new option type, an alias, which points to a

Re: [libvirt] [PATCH 2/3] virsh: use option aliases

2012-03-06 Thread Osier Yang
On 03/03/2012 09:02 AM, Eric Blake wrote: Command line interfaces should use dash, not underscore, as many keyboard layouts allow that to be typed with fewer shift key presses. Also, the US spelling of --tunneled gets more google hits than the UK spelling of --tunnelled. * tools/virsh.c

[libvirt] [PATCH v2] Attach vm-id to Open vSwitch interfaces.

2012-03-06 Thread Ansis Atteka
This patch will allow OpenFlow controllers to identify which interface belongs to a particular VM by using the Domain UUID. ovs-vsctl get Interface vnet0 external_ids {attached-mac=52:54:00:8C:55:2C, iface-id=83ce45d6-3639-096e-ab3c-21f66a05f7fa, iface-status=active,

Re: [libvirt] [PATCH 3/3] virsh: add command aliases, and rename nodedev-detach

2012-03-06 Thread Osier Yang
On 03/03/2012 09:02 AM, Eric Blake wrote: Just because our public API has a typo doesn't mean that virsh has to keep the typo. * tools/virsh.c (VSH_CMD_FLAG_ALIAS): New flag. (nodedevCmds): Use it. (cmdHelp): Omit alias commands. (cmdNodeDeviceDettach): Rename... (cmdNodeDeviceDetach): ...to

Re: [libvirt] [Patch]: spice agent-mouse support [v3]

2012-03-06 Thread Osier Yang
On 03/07/2012 10:02 AM, Zhou Peng wrote: On Tue, Mar 6, 2012 at 10:08 PM, Osier Yangjy...@redhat.com wrote: On 2012年03月05日 16:17, Zhou Peng wrote: Signed-off-by: Zhou Pengzhoup...@nfs.iscas.ac.cn spice agent-mouse support Usage: graphics type='spice' mouse mode='client'|'server'/

Re: [libvirt] [PATCH] rpc: Fix VPATH building issue

2012-03-06 Thread Guannan Ren
On 03/07/2012 04:56 AM, Eric Blake wrote: On 03/06/2012 10:07 AM, Guannan Ren wrote: The XDR routine .c file generated by rpcgen includes the corresponding Header file. however, the path in include directive of the header file is picked up based on the path of .x file. In the