[libvirt] [PATCH 1/4] rename qemuGetNumadAdvice to virDomainGetNumadAdvice

2013-02-27 Thread Gao feng
qemuGetNumadAdvice will be used by LXC driver,rename it to virDomainGetNumaAdvice and move it to domain_conf.c Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/conf/domain_conf.c | 31 +++ src/conf/domain_conf.h | 2 ++ src/libvirt_private.syms | 1 +

[libvirt] [PATCH 0/4] Add cpuset support for LXC

2013-02-27 Thread Gao feng
This patchset intend to add cpuset support for LXC. in order to don't create too many redundant codes, this patchset also rename some functions. Gao feng (4): rename qemuGetNumadAdvice to virDomainGetNumadAdvice LXC: allow uses advisory nodeset from querying numad remove the redundant codes

[libvirt] [PATCH 4/4] LXC: add cpuset support for lxc

2013-02-27 Thread Gao feng
this patch adds cpuset support for LXC. also set cpuset cgroup before we set cpu affinity and numa policy. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_cgroup.c | 57 +++- src/lxc/lxc_cgroup.h | 2 +- src/lxc/lxc_controller.c

[libvirt] [PATCH 2/4] LXC: allow uses advisory nodeset from querying numad

2013-02-27 Thread Gao feng
Allow lxc using the advisory nodeset from querying numad. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 54 +--- 1 file changed, 47 insertions(+), 7 deletions(-) diff --git a/src/lxc/lxc_controller.c

[libvirt] [PATCH 3/4] remove the redundant codes

2013-02-27 Thread Gao feng
Intend to reduce the redundant code,use virDomainSetupNumaMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/conf/domain_conf.c | 113 +++ src/conf/domain_conf.h |

Re: [libvirt] [PATCH] qemu: -numa doesn't (yet) support disjoint range

2013-02-27 Thread Michal Privoznik
On 27.02.2013 04:08, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=896092 mentions that qemu 1.4 and earlier only accept a simple start-stop range for the cpu=... argument of -numa. Libvirt would attempt to use -numa cpu=1,3 for a disjoint range, which did not work as

Re: [libvirt] [PATCH] add dtb support

2013-02-27 Thread Yin Olivia-R63875
Thanks for the comments. Best Regards, Olivia -Original Message- From: car...@cardoe.com [mailto:car...@cardoe.com] On Behalf Of Doug Goldstein Sent: Wednesday, February 27, 2013 1:06 PM To: Yin Olivia-R63875 Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH] add dtb

[libvirt] [PATCH v2 1/2] QEMU: add -dtb option support

2013-02-27 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- src/conf/domain_conf.c |4 src/conf/domain_conf.h |1 + src/qemu/qemu_capabilities.c |3 +++ src/qemu/qemu_capabilities.h |1 + src/qemu/qemu_command.c |6 ++ 5 files changed, 15 insertions(+),

[libvirt] [PATCH v2 0/2] QEMU: add -dtb option support

2013-02-27 Thread Olivia Yin
Sometime qemu need load specific device tree binary image. These patches provides -dtb option support and update docs/tests. Olivia Yin (2): QEMU: add -dtb option support update documents and test cases for -dtb support src/conf/domain_conf.c |4

[libvirt] [PATCH v2 2/2] update documents and test cases for -dtb support

2013-02-27 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- docs/formatdomain.html.in|5 docs/schemas/domaincommon.rng|5 tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.args |1 + tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.xml | 28

Re: [libvirt] [PATCH] libvirt.c: Make VIR_MIGRATE_NON_SHARED_{INC, DISK} mutually exclusive

2013-02-27 Thread Michal Privoznik
On 26.02.2013 18:51, Eric Blake wrote: On 02/26/2013 09:27 AM, Michal Privoznik wrote: These two flags in fact are mutually exclusive. Requesting them both doesn't make any sense regardless of hypervisor driver. Hence, we have to make it within libvirt.c file instead of fixing it in each

Re: [libvirt] Entering freeze for libvirt-1.0.3

2013-02-27 Thread Viktor Mihajlovski
On 02/27/2013 12:31 AM, Eric Blake wrote: Yes, avoiding the trap of releasing XML early, only to force ourselves into supporting that design forever, seems like a reasonable reason to revert while waiting for the more complete design to get a thorough review. Thanks, Eric. -- Mit

[libvirt] [PATCH] tests: fix leaks in storagevolxml2argvtest

2013-02-27 Thread Ján Tomko
Reported by John Ferlan. --- tests/storagevolxml2argvtest.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/storagevolxml2argvtest.c b/tests/storagevolxml2argvtest.c index 416bb6f..77ba800 100644 --- a/tests/storagevolxml2argvtest.c +++ b/tests/storagevolxml2argvtest.c @@ -89,6

Re: [libvirt] [PATCH] tests: fix leaks in storagevolxml2argvtest

2013-02-27 Thread Peter Krempa
On 02/27/13 10:18, Ján Tomko wrote: Reported by John Ferlan. --- tests/storagevolxml2argvtest.c | 4 1 file changed, 4 insertions(+) ACK. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 1/3] security_dac: Remember owner prior chown() and restore on relabel

2013-02-27 Thread Michal Privoznik
On 27.02.2013 01:23, Eric Blake wrote: On 02/26/2013 09:08 AM, Michal Privoznik wrote: Currently, if we label a file to match qemu process DAC label, we do not store the original owner anywhere. So when relabeling back, the only option we have is to relabel to root:root which is obviously

Re: [libvirt] [PATCH] tests: fix leaks in storagevolxml2argvtest

2013-02-27 Thread Ján Tomko
On 02/27/13 10:23, Peter Krempa wrote: On 02/27/13 10:18, Ján Tomko wrote: Reported by John Ferlan. --- tests/storagevolxml2argvtest.c | 4 1 file changed, 4 insertions(+) ACK. Peter Thanks, pushed now. Jan -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH v3 0/4] qemu: -dtb option support

2013-02-27 Thread Olivia Yin
Sometime QEMU need load specific device tree binary images. These patches provide -dtb option support and update docs/tests. Olivia Yin (4): QEMU: add -dtb option support qemu: add dtb capability docs: add -dtb option support to QEMU tests: add dtb test case src/conf/domain_conf.c

[libvirt] [PATCH v3 4/4] tests: add dtb test case

2013-02-27 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.args |1 + tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.xml | 28 ++ tests/qemuxml2argvtest.c |2 + 3 files changed, 31 insertions(+), 0

[libvirt] [PATCH v3 1/4] QEMU: add -dtb option support

2013-02-27 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- src/conf/domain_conf.c |4 src/conf/domain_conf.h |1 + src/qemu/qemu_command.c |6 ++ 3 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH v3 2/4] qemu: add dtb capability

2013-02-27 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- src/qemu/qemu_capabilities.c |3 +++ src/qemu/qemu_capabilities.h |1 + 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 40022c1..f6a6ab7 100644 ---

[libvirt] [PATCH v3 3/4] docs: add -dtb option support to QEMU

2013-02-27 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- docs/formatdomain.html.in |5 + docs/schemas/domaincommon.rng |5 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 595f151..93b10ac 100644 ---

[libvirt] a script for libvirt-llxc + systemd on Fedora18

2013-02-27 Thread Kamezawa Hiroyuki
Hi. At playing libvirt-lxc on Fedora18, I found that the user needs some workarounds to run /sbin/init as the root process of container. With Fedora15, I found this https://gist.github.com/peo3/1142202. And I know virt-sandbox-service have some clever way to understand RPM to make domain running

Re: [libvirt] Hard requirement on gcrypt.h?

2013-02-27 Thread Daniel P. Berrange
On Tue, Feb 26, 2013 at 04:42:43PM -0700, Eric Blake wrote: On 02/25/2013 06:14 PM, Eugene Marcotte wrote: On Mon, 2013-02-25 at 17:42 -0700, Eric Blake wrote: On 02/25/2013 05:38 PM, Eugene Marcotte wrote: Hi, I'm building libvirt for the first time and figuring out what libraries

Re: [libvirt] [PATCH RFC 1/3] security_dac: Remember owner prior chown() and restore on relabel

2013-02-27 Thread Daniel P. Berrange
On Tue, Feb 26, 2013 at 05:08:40PM +0100, Michal Privoznik wrote: Currently, if we label a file to match qemu process DAC label, we do not store the original owner anywhere. So when relabeling back, the only option we have is to relabel to root:root which is obviously wrong. However, bare

Re: [libvirt] [PATCH RFC 1/3] security_dac: Remember owner prior chown() and restore on relabel

2013-02-27 Thread Daniel P. Berrange
On Tue, Feb 26, 2013 at 05:23:18PM -0700, Eric Blake wrote: On 02/26/2013 09:08 AM, Michal Privoznik wrote: Currently, if we label a file to match qemu process DAC label, we do not store the original owner anywhere. So when relabeling back, the only option we have is to relabel to root:root

Re: [libvirt] [PATCH RFC 1/3] security_dac: Remember owner prior chown() and restore on relabel

2013-02-27 Thread Michal Privoznik
On 27.02.2013 11:21, Daniel P. Berrange wrote: On Tue, Feb 26, 2013 at 05:08:40PM +0100, Michal Privoznik wrote: Currently, if we label a file to match qemu process DAC label, we do not store the original owner anywhere. So when relabeling back, the only option we have is to relabel to

Re: [libvirt] [PATCH v2] qemu: Don't fail to shutdown domains with unresponsive agent

2013-02-27 Thread Michal Privoznik
On 27.02.2013 00:22, Eric Blake wrote: On 02/26/2013 04:02 AM, Michal Privoznik wrote: Currently, qemuDomainShutdownFlags() chooses the agent method of shutdown whenever the agent is configured. However, this assumption is not enough as the guest agent may be unresponsive at the moment. So

Re: [libvirt] [PATCH RFC 1/3] security_dac: Remember owner prior chown() and restore on relabel

2013-02-27 Thread Daniel P. Berrange
On Wed, Feb 27, 2013 at 11:30:31AM +0100, Michal Privoznik wrote: On 27.02.2013 11:21, Daniel P. Berrange wrote: On Tue, Feb 26, 2013 at 05:08:40PM +0100, Michal Privoznik wrote: Currently, if we label a file to match qemu process DAC label, we do not store the original owner anywhere. So

[libvirt] [PATCHv4] virtio-rng: Add rate limiting options for virtio-RNG

2013-02-27 Thread Peter Krempa
Qemu's implementation of virtio RNG supports rate limiting of the entropy used. This patch exposes the option to tune this functionality. This patch is based on qemu commit 904d6f588063fb5ad2b61998acdf1e73fb4 The rate limiting is exported in the XML as: devices ... rng model='virtio'

Re: [libvirt] [PATCHv4] virtio-rng: Add rate limiting options for virtio-RNG

2013-02-27 Thread Peter Krempa
On 02/27/13 11:42, Peter Krempa wrote: Qemu's implementation of virtio RNG supports rate limiting of the entropy used. This patch exposes the option to tune this functionality. This patch is based on qemu commit 904d6f588063fb5ad2b61998acdf1e73fb4 The rate limiting is exported in the XML

Re: [libvirt] [PATCH] util: Add docs for virXMLProp string

2013-02-27 Thread Peter Krempa
On 02/21/13 11:13, Peter Krempa wrote: To avoid confusion about usage of this function explicitly document that this function returns copy of the attribute string. --- src/util/virxml.c | 10 ++ 1 file changed, 10 insertions(+) Ping? -- libvir-list mailing list

Re: [libvirt] [PATCH] util: Add docs for virXMLProp string

2013-02-27 Thread Michal Privoznik
On 21.02.2013 11:13, Peter Krempa wrote: To avoid confusion about usage of this function explicitly document that this function returns copy of the attribute string. --- src/util/virxml.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/util/virxml.c b/src/util/virxml.c

[libvirt] Release candidate 2 of 1.0.3 is available

2013-02-27 Thread Daniel Veillard
I have just tagged git and pushed the tarball. The rpms for F17 are at the usual place too: ftp://libvirt.org/libvirt/ I gave a try to the set of rpms and this seems to work fine for relatively simple tests. Please give it more testing and let's keep change to git to bug fixes to

[libvirt] [PATCHv2] qemu: fix graphics port allocation

2013-02-27 Thread Ján Tomko
Only release ports that have been allocated before. This fixes these issues: * trying to release ports when qemuProcessStart fails before port allocation * trying to release the SPICE TLS port if spice_tls is 0 * failing to release SPICE port with autoport=off (when only one of them is -1)

[libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, PIIX3/PIIX4_USB capabilities are enabled for other platforms. Actually, it is only supported for X86. So this patch is to clear the capabilities for non-X86 platforms. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH 1/1] Remove contiguous CPU indexes assumption

2013-02-27 Thread Li Zhang
Hi Eric, This should belong to bug-fix, could it be pushed to 1.0.3? Thanks. On Wed, Feb 27, 2013 at 11:18 AM, Li Zhang zhlci...@gmail.com wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com When getting CPUs' information, it assumes that CPU indexes are not contiguous. But for ppc64

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Li Zhang
Hi Eric, This is also one bug-fix, could you help review and push to 1.0.3? Thanks. :-) On Wed, Feb 27, 2013 at 7:52 PM, Li Zhang zhlci...@gmail.com wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, PIIX3/PIIX4_USB capabilities are enabled for other platforms. Actually, it is

Re: [libvirt] [PATCH v3 9/8] hellolibvirt: Adjust some comments and condition usage

2013-02-27 Thread John Ferlan
On 02/26/2013 07:54 PM, Eric Blake wrote: On 02/26/2013 07:20 AM, John Ferlan wrote: I would have put '---' here, since... The information was only in the email not part of the git history. In the future I'll remember to put that after the '---'. examples/hellolibvirt/hellolibvirt.c |

[libvirt] ANNOUNCE: Perl binding Sys-Virt release 1.0.2

2013-02-27 Thread Daniel P. Berrange
I am pleased to announce that release 1.0.2 of Sys-Virt, the libvirt Perl API binding is now available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-1.0.2.tar.gz Changed in this release: - Add all new APIs and constants in libvirt 1.0.2 Further information,

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Jiri Denemark
On Wed, Feb 27, 2013 at 19:52:22 +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, PIIX3/PIIX4_USB capabilities are enabled for other platforms. Actually, it is only supported for X86. So this patch is to clear the capabilities for non-X86 platforms. ... diff

Re: [libvirt] [PATCH] util: Add docs for virXMLProp string

2013-02-27 Thread Peter Krempa
On 02/27/13 12:05, Michal Privoznik wrote: On 21.02.2013 11:13, Peter Krempa wrote: To avoid confusion about usage of this function explicitly document that this function returns copy of the attribute string. --- src/util/virxml.c | 10 ++ 1 file changed, 10 insertions(+) ...

Re: [libvirt] Release candidate 2 of 1.0.3 is available

2013-02-27 Thread Michal Privoznik
On 27.02.2013 12:20, Daniel Veillard wrote: I have just tagged git and pushed the tarball. The rpms for F17 are at the usual place too: ftp://libvirt.org/libvirt/ I gave a try to the set of rpms and this seems to work fine for relatively simple tests. Please give it more

Re: [libvirt] Release candidate 2 of 1.0.3 is available

2013-02-27 Thread Daniel Veillard
On Wed, Feb 27, 2013 at 03:26:24PM +0100, Michal Privoznik wrote: On 27.02.2013 12:20, Daniel Veillard wrote: I have just tagged git and pushed the tarball. The rpms for F17 are at the usual place too: ftp://libvirt.org/libvirt/ I gave a try to the set of rpms and this seems

Re: [libvirt] Release candidate 2 of 1.0.3 is available

2013-02-27 Thread Michal Privoznik
On 27.02.2013 15:47, Daniel Veillard wrote: On Wed, Feb 27, 2013 at 03:26:24PM +0100, Michal Privoznik wrote: Just a side note. Running git-bisect gets me to this: a9e97e0c3057dfaefc7217b7db7fbba001cf8f0b is the first bad commit commit a9e97e0c3057dfaefc7217b7db7fbba001cf8f0b Author:

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 26/02/2013 20:35, Anthony Liguori ha scritto: See also discussion on multi-valued keys in command line option arguments and config files in v1 thread. Hopefully we can reach a conclusion soon, and then we'll see whether this patch is what we

Re: [libvirt] Release candidate 2 of 1.0.3 is available

2013-02-27 Thread Daniel P. Berrange
On Wed, Feb 27, 2013 at 03:26:24PM +0100, Michal Privoznik wrote: On 27.02.2013 12:20, Daniel Veillard wrote: I have just tagged git and pushed the tarball. The rpms for F17 are at the usual place too: ftp://libvirt.org/libvirt/ I gave a try to the set of rpms and this seems

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 16:42, Anthony Liguori ha scritto: There's such thing as list support in QemuOpts. The only way QemuOptsVisitor was able to implement it was to expose QemuOpts publicly via options_int.h and rely on a implementation detail. There are fixed types supported by QemuOpts. It just

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Eduardo Habkost
On Wed, Feb 27, 2013 at 09:42:50AM -0600, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 26/02/2013 20:35, Anthony Liguori ha scritto: See also discussion on multi-valued keys in command line option arguments and config files in v1 thread. Hopefully we can

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Eduardo Habkost
On Wed, Feb 27, 2013 at 04:57:15PM +0100, Paolo Bonzini wrote: Il 27/02/2013 16:42, Anthony Liguori ha scritto: There's such thing as list support in QemuOpts. The only way QemuOptsVisitor was able to implement it was to expose QemuOpts publicly via options_int.h and rely on a

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Markus Armbruster
Anthony Liguori aligu...@us.ibm.com writes: Paolo Bonzini pbonz...@redhat.com writes: Il 26/02/2013 20:35, Anthony Liguori ha scritto: See also discussion on multi-valued keys in command line option arguments and config files in v1 thread. Hopefully we can reach a conclusion soon,

[libvirt] [PATCH] Fix autodestroy of QEMU guests

2013-02-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virQEMUCloseCallbacksRunOne method was passing a uuid string to virDomainObjListFindByUUID, when it actually expected to get a raw uuid buffer. This was not caught by the compiler because the method was using a 'void *uuid' instead of first casting

Re: [libvirt] Compile libvirt V1.0.1 error

2013-02-27 Thread Eric Blake
On 02/26/2013 11:36 PM, harryxiyou wrote: On Wed, Feb 27, 2013 at 11:04 AM, Eric Blake ebl...@redhat.com wrote: [...] You trimmed too much of your make line to tell us what was happening. It might also help to run 'make V=1' to get the full command line being attempted. I have to wonder if

Re: [libvirt] [PATCH] qemu: -numa doesn't (yet) support disjoint range

2013-02-27 Thread Eric Blake
On 02/27/2013 01:14 AM, Michal Privoznik wrote: On 27.02.2013 04:08, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=896092 mentions that qemu 1.4 and earlier only accept a simple start-stop range for the cpu=... argument of -numa. Libvirt would attempt to use -numa cpu=1,3 for

[libvirt] [PATCH] Fix typo in internal VIR_QEMU_PROCESS_START_AUTODESROY constant

2013-02-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com s/VIR_QEMU_PROCESS_START_AUTODESROY/VIR_QEMU_PROCESS_START_AUTODESTROY/ Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_driver.c| 4 ++-- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_process.c | 4 ++--

[libvirt] [PATCH] Avoid spamming logs with cgroups warnings

2013-02-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The code for putting the emulator threads in a separate cgroup would spam the logs with warnings 2013-02-27 16:08:26.731+: 29624: warning : virCgroupMoveTask:887 : no vm cgroup in controller 3 2013-02-27 16:08:26.731+: 29624: warning :

Re: [libvirt] [PATCH v3 2/4] qemu: add dtb capability

2013-02-27 Thread Eric Blake
On 02/27/2013 01:28 AM, Olivia Yin wrote: Signed-off-by: Olivia Yin hong-hua@freescale.com --- src/qemu/qemu_capabilities.c |3 +++ src/qemu/qemu_capabilities.h |1 + 2 files changed, 4 insertions(+), 0 deletions(-) [not a patch review, but a general comment] You did deep

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 17:19, Eduardo Habkost ha scritto: If it is meant as a prototype only, and the final command-line syntax would be with repeated keys, that's okay. I think that Eduardo/Markus/I are focusing on the user interface, you're focusing in the implementation. In the meanwhile,

[libvirt] [PATCH] Don't try to add non-existant devices to ACL

2013-02-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The QEMU driver has a list of devices nodes that are whitelisted for all guests. The kernel has recently started returning an error if you try to whitelist a device which does not exist. This causes a warning in libvirt logs and an audit error for any

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Eduardo Habkost
On Wed, Feb 27, 2013 at 05:58:39PM +0100, Paolo Bonzini wrote: Il 27/02/2013 17:19, Eduardo Habkost ha scritto: If it is meant as a prototype only, and the final command-line syntax would be with repeated keys, that's okay. I think that Eduardo/Markus/I are focusing on the user

[libvirt] Warnings messages in logs from DHCP snooping code

2013-02-27 Thread Daniel P. Berrange
I'm noticing that VMs which have nwfilters associated with them will apparently always cause the following errors to appear in the logs upon VM shutdown: 2013-02-27 17:02:18.709+: 9669: error : virNWFilterDHCPSnoopEnd:2131 : internal error ifname vnet0 not in key map 2013-02-27

Re: [libvirt] [PATCH v3 2/4] qemu: add dtb capability

2013-02-27 Thread Eric Blake
On 02/27/2013 09:56 AM, Eric Blake wrote: @@ -944,6 +945,8 @@ virQEMUCapsComputeCmdFlags(const char *help, } if (strstr(help, -uuid)) virQEMUCapsSet(qemuCaps, QEMU_CAPS_UUID); +if (strstr(help, -dtb)) +virQEMUCapsSet(qemuCaps, QEMU_CAPS_DTB); This won't

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 27/02/2013 16:42, Anthony Liguori ha scritto: There's such thing as list support in QemuOpts. The only way QemuOptsVisitor was able to implement it was to expose QemuOpts publicly via options_int.h and rely on a implementation detail. There are

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Anthony Liguori
Markus Armbruster arm...@redhat.com writes: Anthony Liguori aligu...@us.ibm.com writes: Which is indistinguishable from a straight string property. This means it's impossible to introspect because the type is context-sensitive. What's more, there is no API outside of QemuOptsVisitor that

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Anthony Liguori
Eduardo Habkost ehabk...@redhat.com writes: On Wed, Feb 27, 2013 at 04:57:15PM +0100, Paolo Bonzini wrote: Il 27/02/2013 16:42, Anthony Liguori ha scritto: There's such thing as list support in QemuOpts. The only way QemuOptsVisitor was able to implement it was to expose QemuOpts publicly

Re: [libvirt] [PATCH v3 1/4] QEMU: add -dtb option support

2013-02-27 Thread Daniel P. Berrange
On Wed, Feb 27, 2013 at 04:28:37PM +0800, Olivia Yin wrote: Signed-off-by: Olivia Yin hong-hua@freescale.com --- src/conf/domain_conf.c |4 src/conf/domain_conf.h |1 + src/qemu/qemu_command.c |6 ++ 3 files changed, 11 insertions(+), 0 deletions(-) The split of

Re: [libvirt] [PATCH] Don't try to add non-existant devices to ACL

2013-02-27 Thread Eric Blake
On 02/27/2013 09:59 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The QEMU driver has a list of devices nodes that are whitelisted for all guests. The kernel has recently started returning an error if you try to whitelist a device which does not exist. This

Re: [libvirt] [PATCH] Fix typo in internal VIR_QEMU_PROCESS_START_AUTODESROY constant

2013-02-27 Thread Peter Krempa
On 02/27/13 17:53, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com s/VIR_QEMU_PROCESS_START_AUTODESROY/VIR_QEMU_PROCESS_START_AUTODESTROY/ Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_driver.c| 4 ++-- src/qemu/qemu_migration.c | 2 +-

Re: [libvirt] [PATCH 1/4] rename qemuGetNumadAdvice to virDomainGetNumadAdvice

2013-02-27 Thread Daniel P. Berrange
On Wed, Feb 27, 2013 at 04:09:35PM +0800, Gao feng wrote: qemuGetNumadAdvice will be used by LXC driver,rename it to virDomainGetNumaAdvice and move it to domain_conf.c Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/conf/domain_conf.c | 31 +++

[libvirt] seclabel inside a //disk/source element

2013-02-27 Thread Richard W.M. Jones
According to the docs, it should be possible to do: disk device=disk type=file source file=/path/to/some/file seclabel relabel=no/ NB /source target dev=sda bus=scsi/ driver name=qemu type=qcow2/ /disk However I tried it, and it simply doesn't work.

Re: [libvirt] [PATCH 2/4] LXC: allow uses advisory nodeset from querying numad

2013-02-27 Thread Daniel P. Berrange
On Wed, Feb 27, 2013 at 04:09:36PM +0800, Gao feng wrote: Allow lxc using the advisory nodeset from querying numad. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 54 +--- 1 file changed, 47 insertions(+), 7

Re: [libvirt] [PATCH 1/4] rename qemuGetNumadAdvice to virDomainGetNumadAdvice

2013-02-27 Thread Daniel P. Berrange
On Wed, Feb 27, 2013 at 05:11:06PM +, Daniel P. Berrange wrote: On Wed, Feb 27, 2013 at 04:09:35PM +0800, Gao feng wrote: qemuGetNumadAdvice will be used by LXC driver,rename it to virDomainGetNumaAdvice and move it to domain_conf.c Signed-off-by: Gao feng gaof...@cn.fujitsu.com

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 18:08, Anthony Liguori ha scritto: No, no, no. This makes ':' special, which means you can't have lists of anything containing ':'. Your cure is worse than the disease. Let go of that syntactic high-fructose corn syrup, stick to what we have and works just fine, thank

Re: [libvirt] [PATCH 3/4] remove the redundant codes

2013-02-27 Thread Daniel P. Berrange
On Wed, Feb 27, 2013 at 04:09:37PM +0800, Gao feng wrote: Intend to reduce the redundant code,use virDomainSetupNumaMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/conf/domain_conf.c |

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Eduardo Habkost
On Wed, Feb 27, 2013 at 11:04:08AM -0600, Anthony Liguori wrote: Eduardo Habkost ehabk...@redhat.com writes: On Wed, Feb 27, 2013 at 04:57:15PM +0100, Paolo Bonzini wrote: Il 27/02/2013 16:42, Anthony Liguori ha scritto: There's such thing as list support in QemuOpts. The only way

Re: [libvirt] seclabel inside a //disk/source element

2013-02-27 Thread Daniel P. Berrange
On Wed, Feb 27, 2013 at 05:14:55PM +, Richard W.M. Jones wrote: According to the docs, it should be possible to do: disk device=disk type=file source file=/path/to/some/file seclabel relabel=no/ NB /source target dev=sda bus=scsi/ driver name=qemu

Re: [libvirt] [PATCH] Avoid spamming logs with cgroups warnings

2013-02-27 Thread Eric Blake
On 02/27/2013 09:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The code for putting the emulator threads in a separate cgroup would spam the logs with warnings 2013-02-27 16:08:26.731+: 29624: warning : virCgroupMoveTask:887 : no vm cgroup in

Re: [libvirt] [PATCH] Fix typo in internal VIR_QEMU_PROCESS_START_AUTODESROY constant

2013-02-27 Thread Eric Blake
On 02/27/2013 09:53 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com s/VIR_QEMU_PROCESS_START_AUTODESROY/VIR_QEMU_PROCESS_START_AUTODESTROY/ Signed-off-by: Daniel P. Berrange berra...@redhat.com --- +++ b/src/qemu/qemu_process.h @@ -47,7 +47,7 @@ int

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Eric Blake
On 02/27/2013 10:04 AM, Anthony Liguori wrote: Whatever I use to implement it, I still need to know how the command-line syntax will look like, because we need to tell libvirt developers how they should write the QEMU command-line. Command line syntax is not committed until it appears in a

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 27/02/2013 18:08, Anthony Liguori ha scritto: No, no, no. This makes ':' special, which means you can't have lists of anything containing ':'. Your cure is worse than the disease. Let go of that syntactic high-fructose corn syrup, stick to

Re: [libvirt] [PATCH] Fix autodestroy of QEMU guests

2013-02-27 Thread Eric Blake
On 02/27/2013 09:26 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virQEMUCloseCallbacksRunOne method was passing a uuid string to virDomainObjListFindByUUID, when it actually expected to get a raw uuid buffer. This was not caught by the compiler because the

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 18:38, Anthony Liguori ha scritto: The solution is there is no way to override a previously specified key. Something like -device virtio-scsi-pci,num_queues=1,num_queues=2 now works, let's make it an error instead. That breaks compatibility. The above may seem silly but

Re: [libvirt] seclabel inside a //disk/source element

2013-02-27 Thread Richard W.M. Jones
On Wed, Feb 27, 2013 at 05:24:26PM +, Daniel P. Berrange wrote: On Wed, Feb 27, 2013 at 05:14:55PM +, Richard W.M. Jones wrote: According to the docs, it should be possible to do: disk device=disk type=file source file=/path/to/some/file seclabel relabel=no/

Re: [libvirt] [Qemu-devel] q35 machine type and libvirt.

2013-02-27 Thread Laine Stump
On 02/06/2013 02:13 PM, Laine Stump wrote: Now that qemu is getting the q35 machine type, libvirt needs to support it. In an attempt to make sure that libvirt actually does something useful with qemu's new machine type, I'm revisiting this topic and trying to get a more thorough understanding.

Re: [libvirt] [Dnsmasq-discuss] Chaining instances?

2013-02-27 Thread Laine Stump
On 02/25/2013 09:08 PM, Gao Yongwei wrote: I thinks it's better that if we can put dnsmasq args or options in a conf file, so we can do some custom through this conf file. I've added a Bug 913446 in redhat bugzilla,but seems no one take care of this bug? This has been discussed extensively

Re: [libvirt] [PATCH RESEND] Add support for option tag in network config

2013-02-27 Thread Laine Stump
On 02/26/2013 03:38 PM, Pieter Hollants wrote: [Bcc problems] Ah, indeed, I never got some of those mails, just saw my original patch merged last Sunday and already wondered why nobody commented :) For brevity, I'll summarize the points we've been discussing. Forgive me if I oversee

[libvirt] [RFC] DHCP Relay agent functionality

2013-02-27 Thread TJ
Recently I needed to implement functionality to operate a DHCP relay instead of dnsmasq's DHCP server on the virtual networks managed by libvirt. The primary benefit of operating a relay is that the central DHCP and DNS servers for the physical network can manage IP address allocation and

Re: [libvirt] [Qemu-devel] q35 machine type and libvirt.

2013-02-27 Thread Alex Williamson
On Wed, 2013-02-27 at 13:20 -0500, Laine Stump wrote: On 02/06/2013 02:13 PM, Laine Stump wrote: Now that qemu is getting the q35 machine type, libvirt needs to support it. In an attempt to make sure that libvirt actually does something useful with qemu's new machine type, I'm revisiting

Re: [libvirt] [RFC] DHCP Relay agent functionality

2013-02-27 Thread Eric Blake
On 02/27/2013 01:53 PM, TJ wrote: Recently I needed to implement functionality to operate a DHCP relay instead of dnsmasq's DHCP server on the virtual networks managed by libvirt. The primary benefit of operating a relay is that the central DHCP and DNS servers for the physical network

Re: [libvirt] [PATCHv2] qemu: fix graphics port allocation

2013-02-27 Thread Eric Blake
On 02/27/2013 04:51 AM, Ján Tomko wrote: Only release ports that have been allocated before. This fixes these issues: * trying to release ports when qemuProcessStart fails before port allocation * trying to release the SPICE TLS port if spice_tls is 0 * failing to release SPICE port with

[libvirt] [PATCH] Fix starting qemu instances when apparmor driver is enabled

2013-02-27 Thread Jim Fehlig
With the apparmor security driver enabled, qemu instances fail to start # grep ^security_driver /etc/libvirt/qemu.conf security_driver = apparmor # virsh start test-kvm error: Failed to start domain test-kvm error: internal error security label already defined for VM The model field of

Re: [libvirt] [Qemu-devel] q35 machine type and libvirt.

2013-02-27 Thread Anthony Liguori
Alex Williamson alex.william...@redhat.com writes: On Wed, 2013-02-27 at 13:20 -0500, Laine Stump wrote: On 02/06/2013 02:13 PM, Laine Stump wrote: Now that qemu is getting the q35 machine type, libvirt needs to support it. In an attempt to make sure that libvirt actually does something

Re: [libvirt] [Dnsmasq-discuss] Chaining instances?

2013-02-27 Thread Gao Yongwei
2013/2/28 Laine Stump la...@laine.org On 02/25/2013 09:08 PM, Gao Yongwei wrote: I thinks it's better that if we can put dnsmasq args or options in a conf file, so we can do some custom through this conf file. I've added a Bug 913446 in redhat bugzilla,but seems no one take care of

Re: [libvirt] [PATCH v2] qemu: Don't fail to shutdown domains with unresponsive agent

2013-02-27 Thread Eric Blake
On 02/27/2013 03:30 AM, Michal Privoznik wrote: On 27.02.2013 00:22, Eric Blake wrote: On 02/26/2013 04:02 AM, Michal Privoznik wrote: Currently, qemuDomainShutdownFlags() chooses the agent method of shutdown whenever the agent is configured. However, this assumption is not enough as the

Re: [libvirt] Compile libvirt V1.0.1 error

2013-02-27 Thread harryxiyou
On Thu, Feb 28, 2013 at 12:47 AM, Eric Blake ebl...@redhat.com wrote: [...] What a waste of resources - that forks a shell to do an echo every time that you use ${JVM_DIR}. Much simpler to write as: JVM_DIR=${JAVA_HOME} I am not familiar with automake so i just use shell to finish this job.

Re: [libvirt] [PATCH RFC 1/3] security_dac: Remember owner prior chown() and restore on relabel

2013-02-27 Thread Eric Blake
On 02/27/2013 02:25 AM, Michal Privoznik wrote: Are you really planning on storing a string uid:gid? Wouldn't it be simpler to store a uid_t and gid_t as read from struct stat, as long as the data is only in memory? And when storing the data to disk in XML to survive libvirtd restarts, it

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Li Zhang
I also hope that QEMU capabilities depend on the binary by QMP. But the flags in virQEMUCapsObjectTypes are all set in virQEMUCapsInitQMP. virQEMUCapsInitQMP - virQEMUCapsProbeQMPObjects - virQEMUCapsProcessStringFlags(qemuCaps,

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Li Zhang
On Thu, Feb 28, 2013 at 10:06 AM, Li Zhang zhlci...@gmail.com wrote: I also hope that QEMU capabilities depend on the binary by QMP. But the flags in virQEMUCapsObjectTypes are all set in virQEMUCapsInitQMP. virQEMUCapsInitQMP - virQEMUCapsProbeQMPObjects -

[libvirt] [PATCH 02/10] conf: Network - add ability to read/write XML DHCP state

2013-02-27 Thread TJ
From: TJ libv...@iam.tj Maintain backwards XML compatibility by assuming existing default values and only adding the additional XML properties if settings are not default. Signed-off-by: TJ li...@iam.tj --- src/conf/network_conf.c | 28 1 file changed, 24

[libvirt] [PATCH 03/10] conf: Network - add pointers to enabled virNetworkIpDef DHCP settings

2013-02-27 Thread TJ
From: TJ li...@iam.tj Having previously introduced DHCP enabled and relay state within the virNetworkIpDef structure - which can be one of many on each network - these pointers allow us to track and easily access the DHCP state for IPv4 and IPv6 when setting up the network without having to

[libvirt] [PATCH 04/10] conf: Network - keep track of active DHCP stanza in virNetworkDef

2013-02-27 Thread TJ
From: TJ li...@iam.tj To avoid iterating all virNetworkIpDef entries when determining DHCP state keep track of the first enabled DHCP stanza in the network definition itself, for both IPv4 and IPv6. A by-product of this change is it allows the XML to contain more than one IP-DHCP stanza. The

  1   2   >