On Thu, Jul 09, 2015 at 02:41:45PM +0100, Zeeshan Ali (Khattak) wrote:
The answer was that magnitude of ugliness is irrelevant. Surely you
know that this is not anything objective. To me a single #ifdef is
ugly enough but seems it's not for you so how do you expect either of
us to convince
Martin Kletzander (2):
conf: Add getter for network routes
network: Add another collision check into networkCheckRouteCollision
src/conf/network_conf.c | 26 ++
src/conf/network_conf.h | 3 +++
src/libvirt_private.syms | 1 +
The comment above that function says: This function can be a lot more
exhaustive, ..., so let's be.
Check for collisions between routes in the system and static routes
being added explicitly from the route/ element of the network XML.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1094205
On 07/03/2015 09:54 AM, Ján Tomko wrote:
From: Prerna Saxena pre...@linux.vnet.ibm.com
When virsh vol-clone is attempted on a raw file where capacity allocation,
the resulting cloned volume has a size that matches the virtual-size of
the parent; in place of matching its actual, disk size.
Add virNetworkDefGetRouteByIndex() similarly to
virNetworkDefGetIpByIndex(), but for routes.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/network_conf.c | 26 ++
src/conf/network_conf.h | 3 +++
src/libvirt_private.syms | 1 +
3 files changed, 30
On Wed, Jul 08, 2015 at 15:22:50 +0200, Jiri Denemark wrote:
If QEMU fails during incoming migration, the domain disappears including
a possibly useful error message read from QEMU log file. Let's remember
the error in virQEMUDriver so that Finish can report more than just no
such domain.
We create a virtual network of special type, which
has the same name as bridge name to create bridged
network adapter in vz. So when we delete such an
adapter we have to remove corresponding virtual
network.
So let's rename prlsdkDelNet to prlsdkCleanupBridgedNet
and don't check for return value.
This fixes
CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo
qemu/qemu_conf.c: In function 'qemuRemoveSharedDevice':
qemu/qemu_conf.c:1384:9: error: 'ret' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
---
This is only catched by Debian Wheezy's gcc 4.7.2,
On 07/07/2015 03:25 AM, Andrea Bolognani wrote:
Changes from v3 to v4:
* removed a printf() statement;
* fixed typo in a commit message.
Shivaprasad G Bhat (2):
Fix nodeinfo output on PPC64 KVM hosts
Add testcase for PPC64 kvm host nodeinfo
Never saw the v4 2/2 come
If one calls update-device with information that is not updatable,
libvirt reports success even though no data were updated. The example
used in the bug linked below uses updating device with boot order='2'/
which, in my opinion, is a valid thing to request from user's
perspective. Mainly since
09.07.2015 19:20, Dmitry Guryanov пишет:
We create a virtual network of special type, which
has the same name as bridge name to create bridged
network adapter in vz. So when we delete such an
adapter we have to remove corresponding virtual
network.
So let's rename prlsdkDelNet to
On Thu, Jul 09, 2015 at 18:36:00 +0200, Martin Kletzander wrote:
If one calls update-device with information that is not updatable,
libvirt reports success even though no data were updated. The example
used in the bug linked below uses updating device with boot order='2'/
which, in my
On Thu, Jul 09, 2015 at 19:22:30 +0200, Guido Günther wrote:
This fixes
CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo
qemu/qemu_conf.c: In function 'qemuRemoveSharedDevice':
qemu/qemu_conf.c:1384:9: error: 'ret' may be used uninitialized in this
function
Hi,
On Thu, Jul 09, 2015 at 07:28:34PM +0200, Peter Krempa wrote:
On Thu, Jul 09, 2015 at 19:22:30 +0200, Guido Günther wrote:
This fixes
CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo
qemu/qemu_conf.c: In function 'qemuRemoveSharedDevice':
qemu/qemu_conf.c:1384:9: error:
In commit 714b38cb232bcbbd7487af4c058fa6d0999b3326 I tried to avoid
having two disks with the same WWN in a VM. I forgot to check the
hotplug paths though which make it possible bypass that check. Reinforce
the fix by checking the wwn when attaching the disk.
Resolves:
At Wed, 08 Jul 2015 14:42:52 +0200,
Michal Privoznik wrote:
Claudio Bley (6):
JNA: fix wrong return type void vs. int
JNA: add CString class and fix memory leaks
JNA: simplify freeing memory for C strings
Use the CString class for Arrays of CStrings too
Implement
On Thu, Jul 09, 2015 at 02:00:10PM -0700, Peter Kieser wrote:
On 2015-06-30 2:49 AM, Daniel Veillard wrote:
On Tue, Jun 30, 2015 at 11:00:24AM +0200, Guido Günther wrote:
On Tue, Jun 30, 2015 at 03:00:09PM +0800, Daniel Veillard wrote:
On Mon, Jun 29, 2015 at 10:34:55PM +0200, Guido
Hey,
This patch series makes tests/test-gconfig valgrind-clean, and refactors two
setters in GVirConfigDomainVideo to make them use the helpers provided by
GVirConfigObject.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Jul 09, 2015 at 09:11:16 +0200, Jiri Denemark wrote:
Even if QEMU supports migration events it doesn't send them by default.
We have to enable them by calling migrate-set-capabilities. Let's enable
migration events everytime we can and clear QEMU_CAPS_MIGRATION_EVENT in
case
---
tests/test-gconfig.c | 2 ++
tests/xml/gconfig-domain-device-video.xml | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index de09c24..aca8f02 100644
--- a/tests/test-gconfig.c
+++ b/tests/test-gconfig.c
@@
The object returned by gvir_config_object_replace_child() must be
unref'ed when no longer needed.
---
libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-filesys.c
On Thu, Jun 18, 2015 at 04:12:10PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1142631
Commit id 'e0e290552' added a check to determine if the same bus
had the same target value. It seems that's not quite good enough
as the check should check the target name value
On Thu, Jul 09, 2015 at 05:19:29PM +0800, zhang bo wrote:
linux-ZyvZnF:~ # virsh list --all
IdName State
- redhat7;reboot shut off
- oscar-vm-5 shut off
As
On Thu, 2015-07-09 at 17:19 +0800, zhang bo wrote:
linux-ZyvZnF:~ # virsh list --all
IdName State
- redhat7;reboot shut off
- oscar-vm-5 shut off
As shown
Even if QEMU supports migration events it doesn't send them by default.
We have to enable them by calling migrate-set-capabilities. Let's enable
migration events everytime we can and clear QEMU_CAPS_MIGRATION_EVENT in
case migrate-set-capabilities does not support events.
Signed-off-by: Jiri
On Wed, Jul 08, 2015 at 15:30:26 -0400, John Ferlan wrote:
Since a future patch will need the device path generated when adding a
shared host device, remove the qemuAddSharedHostdev and inline the two
calls into qemuAddSharedHostdev and qemuRemoveSharedHostdev
Signed-off-by: John Ferlan
On Thu, Jul 09, 2015 at 11:44:30AM +0800, lhuang wrote:
On 07/08/2015 08:14 PM, Martin Kletzander wrote:
On Wed, Jun 17, 2015 at 11:56:17AM +0800, Luyao Huang wrote:
The helpers will be useful when implementing hotplug and coldplug of
shared memory devices.
Signed-off-by: Luyao Huang
On Thu, Jul 09, 2015 at 11:49:15AM +0800, Luyao Huang wrote:
When we use get blockjob info to a unexist disk path, we will
get a error like this:
# virsh blockjob r7 vdc
error: An error occurred, but the cause is unknown
This is because we do not set the error when jump to endjob.
As
On Jul 7, 2015 15:51, Ren, Qiaowei wrote:
On Jul 6, 2015 14:49, Prerna wrote:
On Sun, Jul 5, 2015 at 5:13 PM, Qiaowei Ren qiaowei@intel.com
mailto:qiaowei@intel.com wrote:
One RFC in
https://www.redhat.com/archives/libvir-list/2015-June/msg01509.html
CMT
On Wed, Jul 08, 2015 at 18:39:38 +0200, Jiri Denemark wrote:
Even if QEMU supports migration events it doesn't send them by default.
We have to enable them by calling migrate-set-capabilities. Let's enable
migration events everytime we can and clear QEMU_CAPS_MIGRATION_EVENT in
case
On Wed, Jul 08, 2015 at 07:00:36PM +0100, Zeeshan Ali (Khattak) wrote:
On Wed, Jul 8, 2015 at 3:42 PM, Christophe Fergeau cferg...@redhat.com
wrote:
but you haven't brought
anything forward to support that ugly hack statement in this specific
case,
#ifdef based solution is going to be
On Wed, Jul 08, 2015 at 15:30:27 -0400, John Ferlan wrote:
Set to ret = -1 and prove otherwise, like usual
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_conf.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
ACK
signature.asc
Description: Digital
On Wed, Jul 08, 2015 at 15:30:28 -0400, John Ferlan wrote:
Setting of 'val' is a boolean expression, so handle it that way and
adjust the check/return logic to be clearer
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_conf.c | 10 +++---
1 file changed, 7
On 07/09/2015 11:49 AM, Luyao Huang wrote:
When we use get blockjob info to a unexist disk path, we will
get a error like this:
# virsh blockjob r7 vdc
error: An error occurred, but the cause is unknown
This is because we do not set the error when jump to endjob.
As virDomainDiskByName
On 07/09/2015 02:37 PM, Martin Kletzander wrote:
On Thu, Jul 09, 2015 at 11:49:15AM +0800, Luyao Huang wrote:
When we use get blockjob info to a unexist disk path, we will
get a error like this:
# virsh blockjob r7 vdc
error: An error occurred, but the cause is unknown
This is because we do
Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use
PCI devices. This provides performance improvement as well as vhost-net with
irqfd support for virtio-net. However libvirt currently does not allow ARM virt
machine to have PCI devices. This patchset adds the necessary
Legacy -net option works correctly only with embedded device models, which
do not require any bus specification. Therefore, we should use -device for
PCI hardware
Signed-off-by: Pavel Fedin p.fe...@samsung.com
---
src/qemu/qemu_command.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Here we assume that if qemu supports generic PCI host controller,
it is a part of virt machine and can be used for adding PCI devices.
Signed-off-by: Pavel Fedin p.fe...@samsung.com
---
src/qemu/qemu_domain.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git
On 07/09/2015 02:09 PM, Martin Kletzander wrote:
On Thu, Jul 09, 2015 at 11:44:30AM +0800, lhuang wrote:
On 07/08/2015 08:14 PM, Martin Kletzander wrote:
On Wed, Jun 17, 2015 at 11:56:17AM +0800, Luyao Huang wrote:
The helpers will be useful when implementing hotplug and coldplug of
shared
Corresponding QEMU commits:
MPX 79e9ebebbf2a00c46fcedb6dc7dd5e12bbd30216
AVX512 9aecd6f8aef653cea58932f06a2740299dbe5fd3
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
src/cpu/cpu_map.xml | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/cpu/cpu_map.xml
On Wed, Jul 08, 2015 at 19:36:05 +0200, Jiri Denemark wrote:
Every single call to qemuDomainEventQueue() uses the following pattern:
if (event)
qemuDomainEventQueue(driver, event);
Let's move the check for valid event to qemuDomainEventQueue and
simplify all callers.
On Wed, Jul 08, 2015 at 19:36:06 +0200, Jiri Denemark wrote:
For quite a long time we don't need to postpone queueing events until
the end of the function since we no longer have the big driver lock.
Let's make the code of qemuMigrationFinish simpler by queuing events at
the time we generate
Running test-gconfig under valgrind reports a few leaks that this commit
fixes.
---
tests/test-gconfig.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index 0eec53e..de09c24 100644
--- a/tests/test-gconfig.c
+++ b/tests/test-gconfig.c
@@
GVirConfigDomainVideo is using raw libxml calls to set the 'heads' and
'vram' XML attributes rather than the helpers provided by
GVirConfigObject. This commit changes that, making the code a bit
simpler.
---
libvirt-gconfig/libvirt-gconfig-domain-video.c | 38 +++---
1 file
On Wed, Jul 08, 2015 at 15:30:25 -0400, John Ferlan wrote:
Split out the current function in order to share the code with hostdev
in a future patch. Failure to match the expected sgio value against what
is stored will cause an error which the caller would need to handle since
only the caller
This capability specifies that qemu can implement generic PCI host
controller. It is often used for virtual environments, including ARM.
Signed-off-by: Pavel Fedin p.fe...@samsung.com
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 3 insertions(+)
On Thu, Jul 9, 2015 at 8:05 AM, Christophe Fergeau cferg...@redhat.com wrote:
On Wed, Jul 08, 2015 at 07:00:36PM +0100, Zeeshan Ali (Khattak) wrote:
On Wed, Jul 8, 2015 at 3:42 PM, Christophe Fergeau cferg...@redhat.com
wrote:
but you haven't brought
anything forward to support that ugly
This patch reverts commit 4749d82a which tried to tweak the logic in
volume creation. We did realloc and update our object list before we executed
volume building within a specific storage backend. If that failed, we
had to update (again) our object list to the original state as it was before the
On Thu, Jul 09, 2015 at 01:48:16PM +0200, Erik Skultety wrote:
This patch reverts commit 4749d82a which tried to tweak the logic in
volume creation. We did realloc and update our object list before we executed
volume building within a specific storage backend. If that failed, we
had to update
On 09/07/15 14:13, Ján Tomko wrote:
On Thu, Jul 09, 2015 at 01:48:16PM +0200, Erik Skultety wrote:
This patch reverts commit 4749d82a which tried to tweak the logic in
volume creation. We did realloc and update our object list before we executed
volume building within a specific storage
On Wed, Jul 08, 2015 at 19:36:02 +0200, Jiri Denemark wrote:
When we save status XML at the point during migration where we have
already started the domain on destination, we can't really go back and
abort migration. Thus the only thing we can do is to log a warning and
report success.
On Thu, Jul 09, 2015 at 12:42:23PM +0100, Zeeshan Ali (Khattak) wrote:
Honestly, this is a very weird attitude, rather than trying to
come with hard facts, you prefer having some kind of poll and make an
arbitary uninformed decision.
I regret having to resort to some sort of poll as well
linux-ZyvZnF:~ # virsh list --all
IdName State
- redhat7;reboot shut off
- oscar-vm-5 shut off
As shown above,
1 we use command virsh define a.xml to define a guest
Without these changes 'make check' would not
run on Ubuntu because of a link failure as
the tests are directly using glib/libvirt
symbols.
---
tests/Makefile.am | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 63865e8..c146817
This is needed to be able to add UNIX channels
---
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-domain-chardev-source-unix.c | 84 ++
.../libvirt-gconfig-domain-chardev-source-unix.h | 68 ++
---
libvirt-gconfig/libvirt-gconfig-domain-video.c | 25 +
libvirt-gconfig/libvirt-gconfig-domain-video.h | 5 +
libvirt-gconfig/libvirt-gconfig.sym| 2 ++
3 files changed, 32 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-video.c
On Wed, Jul 08, 2015 at 19:36:00 +0200, Jiri Denemark wrote:
Separate code which makes incoming domain persistent into
qemuMigrationPersist.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
src/qemu/qemu_migration.c | 75
++-
1 file
On Wed, Jul 08, 2015 at 19:36:04 +0200, Jiri Denemark wrote:
Finish is the final state in v2 of our migration protocol. If something
fails, we have no option to abort the migration and resume the original
domain. Non fatal errors (such as failure to start guest CPUs or make
the domain
On Wed, Jul 08, 2015 at 19:36:01 +0200, Jiri Denemark wrote:
Offline migration migration is quite special because we don't really
need to do anything but make the domain persistent. Let's do it
separately from normal migration to avoid cluttering the code with
!(flags VIR_MIGRATE_OFFLINE).
On Wed, Jul 08, 2015 at 19:36:03 +0200, Jiri Denemark wrote:
Whenever something fails during incoming migration in Finish phase
before we started guest CPUs, we need to kill the domain in addition to
reporting the failure.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
On Thu, Jul 9, 2015 at 12:56 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Thu, Jul 09, 2015 at 12:42:23PM +0100, Zeeshan Ali (Khattak) wrote:
Honestly, this is a very weird attitude, rather than trying to
come with hard facts, you prefer having some kind of poll and make an
arbitary
On Wed, Jul 08, 2015 at 15:22:49 +0200, Jiri Denemark wrote:
This is a self-locking wrapper around virHashTable. Only a limited set
of APIs are implemented now (the ones which are used in the following
patch) as more can be added on demand.
Signed-off-by: Jiri Denemark jdene...@redhat.com
On 07/03/2015 09:51 AM, Pavel Hrdina wrote:
On Wed, Jul 01, 2015 at 05:39:49PM -0400, John Ferlan wrote:
On 06/29/2015 11:17 AM, Pavel Hrdina wrote:
Some guests lock the tray and QEMU eject command will simply fail to
eject the media. But the guest OS can handle this attempt to eject the
On 2015-06-30 2:49 AM, Daniel Veillard wrote:
On Tue, Jun 30, 2015 at 11:00:24AM +0200, Guido Günther wrote:
On Tue, Jun 30, 2015 at 03:00:09PM +0800, Daniel Veillard wrote:
On Mon, Jun 29, 2015 at 10:34:55PM +0200, Guido Günther wrote:
On Sun, Jun 28, 2015 at 01:00:01PM +0800, Daniel
On 2015-07-09 2:00 PM, Peter Kieser wrote:
On 2015-06-30 2:49 AM, Daniel Veillard wrote:
On Tue, Jun 30, 2015 at 11:00:24AM +0200, Guido Günther wrote:
On Tue, Jun 30, 2015 at 03:00:09PM +0800, Daniel Veillard wrote:
On Mon, Jun 29, 2015 at 10:34:55PM +0200, Guido Günther wrote:
On Sun,
On Wed, Jul 08, 2015 at 18:39:36 +0200, Jiri Denemark wrote:
The final version of migration event patches which got accepted upstream
had to be slightly modified -- the event is only emitted when events
migration capability is turned on (default is off). Thus a new patch had
to be added to
On Wed, Jul 08, 2015 at 09:44:09 +0200, Peter Krempa wrote:
On Wed, Jul 08, 2015 at 09:31:03 +0200, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
src/qemu/qemu_process.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
ACK,
Pushed, thanks.
On 07/09/2015 01:28 PM, Peter Krempa wrote:
On Thu, Jul 09, 2015 at 19:22:30 +0200, Guido Günther wrote:
This fixes
CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo
qemu/qemu_conf.c: In function 'qemuRemoveSharedDevice':
qemu/qemu_conf.c:1384:9: error: 'ret' may be used
On Wed, Jul 08, 2015 at 10:22:06 +0200, Peter Krempa wrote:
On Wed, Jul 08, 2015 at 10:14:16 +0200, Jiri Denemark wrote:
Libvirt's error messages do not end with a LF. However, when reading the
error from QEMU log, we would read the LF from the log and keep it in
the message.
On Wed, Jul 08, 2015 at 15:22:51 +0200, Jiri Denemark wrote:
virDomainMigrateFinish* APIs were unfortunately designed to return the
pointer to the domain on destination and NULL on error. This looks OK in
normal cases but the same API is also called when we know migration
failed and thus we
On Wed, Jul 08, 2015 at 15:22:52 +0200, Jiri Denemark wrote:
When QEMU exits on destination during migration, the source reports
either success (if the failure happened at the very end) or unhelpful
unexpectedly failed error message. However, the Finish API called on
the destination may report
Commit 45697fe5 added dom0 to driver-domains, but missed
setting its state to 'running'
virsh list
IdName State
0 Domain-0 shut off
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
72 matches
Mail list logo
