Re: [libvirt] [PATCH v2 2/4] libxl: channels support

On 09/22/2016 01:53 PM, Joao Martins wrote: > Allow libxl to handle channel element which creates a Xen > console visible to the guest as a low-bandwitdh communication > channel. If type is PTY we also fetch the tty after boot using > libxl_channel_getinfo to fetch the tty path. On socket case, >

Re: [libvirt] [PATCH v2 3/4] xenconfig: channels conversion support

On 09/22/2016 01:53 PM, Joao Martins wrote: > Add support for formating/parsing libxl channels. > > Syntax on xen libxl goes as following: > channel=["connection=pty|socket,path=/path/to/socket,name=XXX",...] > > Signed-off-by: Joao Martins > --- > Changes since v1: > *

Re: [libvirt] [PATCH v2 1/4] conf: add xen type for channels

On September 23, 2016 11:05:57 PM GMT+01:00, Jim Fehlig wrote: >On 09/22/2016 01:53 PM, Joao Martins wrote: >> So far only guestfwd and virtio were supported. Add an additional >> for Xen as libxl channels create Xen console visible to the guest. >> >> Signed-off-by: Joao

Re: [libvirt] [PATCH rfc v2 0/8] fspool: backend directory

On 09/23/2016 11:56 AM, Olga Krishtal wrote: > On 21/09/16 19:17, Maxim Nestratov wrote: >>> 20 сент. 2016 г., в 23:52, John Ferlan написал(а): >>> >>> >>> On 09/15/2016 03:32 AM, Olga Krishtal wrote: Hi everyone, we would like to propose the first implementation

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On 09/23/2016 02:43 PM, Martin Wilck wrote: On Fri, 2016-09-23 at 11:56 -0400, Laine Stump wrote: Martin's patch tries to solve the problem with "dhcp-authoritative" which, as far as I understand, tells dnsmasq "you are the keeper of *all* lease information on this network, so if you think the

Re: [libvirt] [PATCH rfc v2 0/8] fspool: backend directory

On 09/23/2016 11:45 AM, Daniel P. Berrange wrote: > On Fri, Sep 23, 2016 at 11:38:10AM -0400, John Ferlan wrote: >> >> >> On 09/21/2016 12:17 PM, Maxim Nestratov wrote: >>> 20 сент. 2016 г., в 23:52, John Ferlan написал(а): > On 09/15/2016 03:32 AM,

Re: [libvirt] [PATCH] libxl: increase usbdevice list only when finding such an input device

On 09/23/2016 06:11 AM, Cédric Bosdonnat wrote: > If passing an empty usbdevice_list to libxl, qemu will always get an > -usb parameter for HVM guests with only non-USB input devices. This > causes qemu to crash when passing pvusb device on HVM guests. It seems like libxl should be fixed :-). But

Re: [libvirt] [PATCH] qemuDomainUpdateDeviceConfig: Allow full disk update

On 09/02/2016 07:41 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1368417 > > So far, when it comes to 'virsh update-device --config' of disks > we are limiting ourselves for just the disk source update and > just for CDROMs and floppies. This makes no sense.

Re: [libvirt] [PATCH v2 4/4] xlconfigtest: add test for channel conversion

On 09/22/2016 01:53 PM, Joao Martins wrote: > Signed-off-by: Joao Martins > --- > tests/xlconfigdata/test-channel-pty.cfg | 13 > tests/xlconfigdata/test-channel-pty.xml | 33 +++ > tests/xlconfigdata/test-channel-unix.cfg |

Re: [libvirt] [PATCH v2 2/4] libxl: channels support

On September 23, 2016 11:12:00 PM GMT+01:00, Jim Fehlig wrote: >On 09/22/2016 01:53 PM, Joao Martins wrote: >> Allow libxl to handle channel element which creates a Xen >> console visible to the guest as a low-bandwitdh communication >> channel. If type is PTY we also fetch the

Re: [libvirt] [PATCH v2 1/4] conf: add xen type for channels

On 09/22/2016 01:53 PM, Joao Martins wrote: > So far only guestfwd and virtio were supported. Add an additional > for Xen as libxl channels create Xen console visible to the guest. > > Signed-off-by: Joao Martins > --- > docs/schemas/domaincommon.rng | 11 +++ >

[libvirt] [PATCH] storage_backend_rbd: remove unnessary translated message marker

From: Chen Hanxiao Remove unnessary translated message marker _() for the VIR_WARN messages. Signed-off-by: Chen Hanxiao --- src/storage/storage_backend_rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH v2 0/8] Pass the path of compress program (redo)

At 2016-09-23 19:30:48, "John Ferlan" wrote: >v1: http://www.redhat.com/archives/libvir-list/2016-September/msg00971.html > >Changes in v2: > > 1. Create a patch 5 which alters the qemuGetCompressionProgram to take a >new const char * parameter which will be used in the

Re: [libvirt] [PATCH 5/8] qemuhelptest: regenerate data for qemu-1.2.0

On Fri, Sep 23, 2016 at 08:38:01AM +0200, Martin Kletzander wrote: > On Thu, Sep 22, 2016 at 05:08:57PM +0200, Pavel Hrdina wrote: > >This patch also removes device data for qemu-1.2.0 as it was removed for > >qemu-kvm-1.2.0 by commit ae3e29e6e. They are not required because we > >parse only

Re: [libvirt] [PATCH 5/8] qemuhelptest: regenerate data for qemu-1.2.0

On Thu, Sep 22, 2016 at 05:08:57PM +0200, Pavel Hrdina wrote: This patch also removes device data for qemu-1.2.0 as it was removed for qemu-kvm-1.2.0 by commit ae3e29e6e. They are not required because we parse only version from help output and return with error that this qemu is too new to use

Re: [libvirt] [PATCH 0/8] cleanup and regenerate data for qemuhelptest

On Fri, Sep 23, 2016 at 08:42:40AM +0200, Martin Kletzander wrote: > On Thu, Sep 22, 2016 at 05:08:52PM +0200, Pavel Hrdina wrote: > >Pavel Hrdina (8): > > qemuhelptest: remove downstream test data > > qemuhelptest: regenerate data for qemu-0.12.1 > > qemuhelptest: regenerate data for qemu-1.0

Re: [libvirt] [PATCH 0/8] cleanup and regenerate data for qemuhelptest

On Thu, Sep 22, 2016 at 05:08:52PM +0200, Pavel Hrdina wrote: Pavel Hrdina (8): qemuhelptest: remove downstream test data qemuhelptest: regenerate data for qemu-0.12.1 qemuhelptest: regenerate data for qemu-1.0 qemuhelptest: regenerate data for qemu-1.1.0 qemuhelptest: regenerate data for

Re: [libvirt] [PATCH 8/8] qemuhelptest: regenerate data for qemu-kvm-1.2.0

On Thu, Sep 22, 2016 at 05:09:00PM +0200, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- tests/qemuhelpdata/qemu-kvm-1.2.0 | 1 + 1 file changed, 1 insertion(+) Similarly to qemu-1.2.0, just remove this file after fixing the test. diff --git

[libvirt] [PATCH] network: Add support for configuring dhcp lease time

The default dhcp lease time set by dnsmasq is only one hour, which can be pretty small for developers relying on ip address(es) to be consistent across reboots. This patch adds support for setting a lease time in the network definition. For now, all IP ranges under one will share a common

Re: [libvirt] [PATCH] libxl: find virDomainObj in libxlDomainShutdownThread

On Wed, Sep 21, 2016 at 03:29:49PM -0600, Jim Fehlig wrote: libxl events are delivered to libvirt via the libxlDomainEventHandler callback registered with libxl. Documenation in $xensrc/tools/libxl/libxl_event.h states that the callback "may occur on any thread in which the application calls

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: > The default dhcp lease time set by dnsmasq is only one hour, which can be > pretty small for developers relying on ip address(es) to be consistent > across reboots. This should be handled through the leases file which is supposed to

Re: [libvirt] [PATCH 0/8] cleanup and regenerate data for qemuhelptest

On Fri, Sep 23, 2016 at 09:46:41AM +0200, Pavel Hrdina wrote: On Fri, Sep 23, 2016 at 08:42:40AM +0200, Martin Kletzander wrote: On Thu, Sep 22, 2016 at 05:08:52PM +0200, Pavel Hrdina wrote: >Pavel Hrdina (8): > qemuhelptest: remove downstream test data > qemuhelptest: regenerate data for

Re: [libvirt] [PATCH] virsh: send-process-signal: add support for '-NUM' style of signal nums

On Fri, Sep 23, 2016 at 06:09:02PM +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > As kill(1), add support for sending signal > in form of "9" as well as "-9". I'm not a fan of this as it introduces ambiguity which could hurt us if we want to rewrite/extend the option

Re: [libvirt] [PATCH v2 02/20] virlog: Introduce virLogOutputNew

On 21/09/16 19:55, John Ferlan wrote: > > > On 08/18/2016 07:47 AM, Erik Skultety wrote: >> Continuing with the refactor, in order to later split output parsing and >> output > > s/Continuing with the refactor, i/I > >> defining, introduce a new function which will create a new virLogOutput

Re: [libvirt] [PATCH 5/8] qemuhelptest: regenerate data for qemu-1.2.0

On Fri, Sep 23, 2016 at 09:43:53AM +0200, Pavel Hrdina wrote: On Fri, Sep 23, 2016 at 08:38:01AM +0200, Martin Kletzander wrote: On Thu, Sep 22, 2016 at 05:08:57PM +0200, Pavel Hrdina wrote: >This patch also removes device data for qemu-1.2.0 as it was removed for >qemu-kvm-1.2.0 by commit

[libvirt] qemu - how add -object when no numa topology

Hi guys, I’m trying to figure out how to generate this arg line: “-object memory-backend-file,id=ram,mem-path=/var/lib/libvirt/qemu/,share=yes,size=14336 -numa node, memdev=ram” without numa. I see there are two functions which are capable of building backends: “qemuBuildNumaArgStr” and

Re: [libvirt] [PATCH v5 0/2] qemu/gluster: add option for tuning debug logging level

Review request. -- Prasanna On Thu, Sep 22, 2016 at 1:04 AM, Prasanna Kumar Kalever wrote: > This series run basic sanity and other tests: > 1. make syntax-check > 2. make check > 3. VIR_TEST_VERBOSE=1 ./tests/qemuargv2xmltest > 4. VIR_TEST_VERBOSE=1

Re: [libvirt] [PATCH 5/8] qemuhelptest: regenerate data for qemu-1.2.0

On Fri, Sep 23, 2016 at 10:22:51AM +0200, Martin Kletzander wrote: > On Fri, Sep 23, 2016 at 09:43:53AM +0200, Pavel Hrdina wrote: > >On Fri, Sep 23, 2016 at 08:38:01AM +0200, Martin Kletzander wrote: > >> On Thu, Sep 22, 2016 at 05:08:57PM +0200, Pavel Hrdina wrote: > >> >This patch also removes

[libvirt] [PATCH v2 7/8] qemu: Remove qemuCompressProgramAvailable

There's only one caller and the code is duplicitous just converting the recently converted cfg image name back into it's string value in order to get/find the path to the image. A subsequent patch can return this path. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c |

[libvirt] [PATCH v2 0/8] Pass the path of compress program (redo)

v1: http://www.redhat.com/archives/libvir-list/2016-September/msg00971.html Changes in v2: 1. Create a patch 5 which alters the qemuGetCompressionProgram to take a new const char * parameter which will be used in the warning message as the %s image format "style" (dump, save, snapshot)

[libvirt] [PATCH v2 8/8] qemu: Get/return compressedpath program

Based upon a patch from Chen Hanxiao , rather than need to call virFindFileInPath twice, let's just save the path and pass it along with the compressed type. (NB: the second call would be in virExec as called from virCommandRunAsync which is called from qemuMigrationToFile

[libvirt] [PATCH v2 3/8] qemu: Introduce helper qemuGetCompressionProgram

Split out the guts of getCompressionType to perform the same functionality in the new helper program with a subsequent patch goal to be reusable for other callers making similar checks/calls to ensure the compression type is valid and that the compression program cannot be found. Signed-off-by:

[libvirt] [PATCH v2 6/8] qemu: Use qemuGetCompressionProgram for error paths

Let's do some more code reuse - there are 3 other callers that care to check/get the compress program. Each of those though cares whether the requested cfg image is valid and exists. So, add a parameter to handle those cases. NB: We won't need to initialize the returned value in the case where

[libvirt] [PATCH v2 1/8] qemu: Move getCompressionType

A subsequent patch will adjust the 3 callers to just call from doCoreDump. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 70 ++ 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH v2 5/8] qemu: Alter qemuGetCompressionProgram warning message

Add a new parameter 'styleFormat' to be used when printing the warning message so that it's "clearer" what style of compression call caused the error. Add that style to both messages as a paremter. Also a VIR_WARN error message doesn't need to be translated (e.g. inside _()), so remove the need

[libvirt] [PATCH v2 2/8] qemu: Adjust doCoreDump to call getCompressionType

Rather than calling getCompressionType from each of the callers, just call it from doCoreDump. A subsequent patch will be adjust the code even more. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 18 ++ 1 file changed, 6 insertions(+), 12

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa wrote: > On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: >> The default dhcp lease time set by dnsmasq is only one hour, which can be >> pretty small for developers relying on ip address(es) to be consistent >> across

Re: [libvirt] [PATCH] Replacing for (; ; ) with while (1) for better code.

On Fri, Sep 23, 2016 at 01:17:40AM +0530, Nitesh Konkar wrote: As mentioned in https://libvirt.org/hacking.html, using while (1) is better than for (;;). I feel like there was a reason for not forbidding it (and also adding an exception for it in build-aux/check-spacing.pl, but I can't

[libvirt] [PATCH] virsh: send-process-signal: add support for '-NUM' style of signal nums

From: Chen Hanxiao As kill(1), add support for sending signal in form of "9" as well as "-9". Signed-off-by: Chen Hanxiao --- tools/virsh-domain.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal J Wani wrote: > On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa wrote: > > On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: > >> The default dhcp lease time set by dnsmasq is only one hour, which can be > >> pretty small

[libvirt] [PATCH v2 4/8] qemu: Remove getCompressionType

There's only one caller now anyway... Besides it's just a shell for getting the compress type. Subsequent patches will return the path to the compression program. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 25 +++-- 1 file changed, 7

[libvirt] [PATCH v2 09/11] qemuDomainDefAssignAddresses: Fetch caps from domain object

Just like we did two commits ago, don't try to fetch capabilities for non-existing binary. Re-use the ones we have for running domain. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff

[libvirt] [PATCH v2 03/11] virDomainDefParse{File, String}: Introduce @parseOpaque argument

We want to by pass the proper opaque pointer instead of NULL to virDomainDefParse and subsequently virDomainDefParseNode too. Signed-off-by: Michal Privoznik --- src/bhyve/bhyve_driver.c | 6 +++--- src/conf/domain_conf.c | 11 +++

[libvirt] [PATCH v2 04/11] virDomainDefCopy: Introduce @parseOpaque argument

We want to by pass the proper opaque pointer instead of NULL to virDomainDefParseString. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 7 --- src/conf/domain_conf.h | 1 + src/libxl/libxl_domain.c | 4 ++-- src/qemu/qemu_domain.c | 2 +-

[libvirt] [PATCH v2 11/11] conf: Skip post parse callbacks when creating copy

When creating a copy of virDomainDef we save ourselves the trouble of writing deep-copy functions and just format and parse back domain/device XML. However, the XML we are parsing was already fully formatted - there is no reason to run post parse callbacks (which fill in blanks - there are none!).

[libvirt] [PATCH v2 02/11] virDomainDefParseNode: Introduce @parseOpaque argument

We want to by pass the proper opaque pointer instead of NULL to virDomainDefParseXML and subsequently virDomainDefPostParse too. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c| 10 ++ src/conf/domain_conf.h| 1 + src/conf/snapshot_conf.c | 2

[libvirt] [PATCH v2 06/11] conf: Extend virDomainDeviceDefPostParse for parseOpaque

Just like virDomainDefPostParseCallback has gained new parseOpaque argument, we need to follow the logic with virDomainDeviceDefPostParse. Signed-off-by: Michal Privoznik --- src/bhyve/bhyve_domain.c | 3 ++- src/conf/domain_conf.c | 13 +

[libvirt] [PATCH v2 01/11] virDomainDefPostParse: Introduce @parseOpaque argument

Some callers might want to pass yet another pointer to opaque data to post parse callbacks. The driver generic one is not enough because two threads executing post parse callback might want see different data (e.g. domain object pointer that domain def belongs to). Signed-off-by: Michal Privoznik

[libvirt] [PATCH v2 10/11] domain_conf: Introduce VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE

This is an internal flag that prevents our two entry points to XML parsing (virDomainDefParse and virDomainDeviceDefParse) from running post parse callbacks. This is expected to be used in cases when we already have full domain/device XML and we are just parsing it back (i.e. virDomainDefCopy or

[libvirt] [PATCH v2 05/11] qemuDomainDefPostParse: Fetch qemuCaps from domain object

We can't rely on def->emulator path. It may be provided by user as we give them opportunity to provide their own XML for migration. Therefore the path may point to just whatever binary (or even to a non-existent file). Moreover, this path is meant for destination, but the capabilities lookup is

[libvirt] [PATCH v2 08/11] conf: Extend virDomainDefAssignAddressesCallback for parseOpaque

Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 8 ++-- src/qemu/qemu_domain.c | 3 ++- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d205222..b11a296

[libvirt] [PATCH v2 07/11] qemuDomainDeviceDefPostParse: Fetch caps from domain object

Just like we did two commits ago, don't try to fetch capabilities for non-existing binary. Re-use the ones we have for running domain. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH v2 00/11] Couple of migration fixes

v2 of: https://www.redhat.com/archives/libvir-list/2016-September/msg00802.html diff to v1: - Instead of introducing vir*Opaque() APIs, just add parseOpaque argument to everything that needs it - Pass qemuCaps directly instead of domain object Michal Privoznik (11): virDomainDefPostParse:

[libvirt] [PATCH] libxl: increase usbdevice list only when finding such an input device

If passing an empty usbdevice_list to libxl, qemu will always get an -usb parameter for HVM guests with only non-USB input devices. This causes qemu to crash when passing pvusb device on HVM guests. The solution is to allocate the list only when an item to put in it is found. ---

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Fri, Sep 23, 2016 at 4:51 PM, Peter Krempa wrote: > On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal J Wani wrote: >> On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa wrote: >> > On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: >> >> The default

[libvirt] [PATCH 00/12] Add length (duration) params for iotune throttling

https://bugzilla.redhat.com/show_bug.cgi?id=1349898 Do a little housekeeping and minor adjustments to existing code, then add the various "-length" options for the code. John Ferlan (12): docs: Fix typo in libvirt-domain.h parameter description include: Update description for max params

[libvirt] [PATCH 09/12] conf: Add a formatting macro for all the blkiotune values

Rather than copy-paste - use a macro Unfortunately due to how the RNG schema was written keeping the 'value' and 'value'_max next to each other in the XML causes a schema failure, so the FORMAT has to write out singly rather than optimizing to write out both values at once Signed-off-by: John

[libvirt] [PATCH 07/12] caps: Add new capability for the bps/iops throttling length

Add the capability to detect if the qemu binary can support the feature to use bps-max-length and friends. Signed-off-by: John Ferlan --- src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h| 1 +

[libvirt] [PATCH 01/12] docs: Fix typo in libvirt-domain.h parameter description

Change Marco to Macro Signed-off-by: John Ferlan --- include/libvirt/libvirt-domain.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index f1c35d9..52680cf 100644 ---

[libvirt] [PATCH 03/12] tests: Add blkdeviotune-max xml2xmltest

It was missing... Also since I'm using the soft link from qemuxml2xmloutdata to the qemuxml2argvdata file, modify the output file to have the necessary elements plus the mouse and keyboard. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 06/12] include: Add new definitions for duration for bps/iops throttling

Add new options to allow proving a duration/length in seconds to allow the bps/iops (and friends) to occur: total_bytes_sec_max_length write_bytes_sec_max_length read_bytes_sec_max_length total_iops_sec_max_length write_iops_sec_max_length read_iops_sec_max_length

[libvirt] [PATCH 05/12] qemu: Adjust how supportMaxOptions is used.

We're about to add more options, let's avoid having multiple if-then-else which each try to set up the qemuMonitorJSONMakeCommand call with all the parameters it knows about. Instead, use the fact that when a NULL is found in the argument list that processing of the remaining arguments stops and

[libvirt] [PATCH] qemu: Only use memory-backend-file with NUMA if needed

If this reminds you of a commit message from around a year ago, it's 41c2aa729f0af084ede95ee9a06219a2dd5fb5df and yes, we're dealing with "the same thing" again. Or f309db1f4d51009bad0d32e12efc75530b66836b and it's similar. There is a logic in place that if there is no real need for

Re: [libvirt] Cpu Modeling

On Thu, Sep 22, 2016 at 14:47:36 -0400, Jason J. Herne wrote: > Testing for runability: > - Simply try to start QEMU with KVM, compat machine, CPU model Yes, if the domain XML explicitly requests a specific CPU model. Additionally, we need to make sure a CPU model chosen by libvirt (host-model)

[libvirt] [PATCH 12/12] qemu: Add the length options to the iotune command line

https://bugzilla.redhat.com/show_bug.cgi?id=1349898 Add in the block I/O throttling length/duration parameter to the command line if supported. If not supported, fail command creation. Add the xml2argvtest for testing. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c

[libvirt] [PATCH 02/12] include: Update description for max params

The upstream qemu commit 'dce13204' changed the wording just slightly to add 'in bursts' essentially. Just following that model here. Signed-off-by: John Ferlan --- include/libvirt/libvirt-domain.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

[libvirt] [PATCH 04/12] qemu: Convert from shorthand to longer throttling names

We're about to add 6 new options and it appears (from testing) one cannot utilize both the shorthand (alias) and (much) longer names for the arguments. So modify the command builder to use the longer name and of course alter the test output .args to have the similarly innocuous long name. Also

[libvirt] [PATCH 08/12] qemu: Add length for bps/iops throttling parameters to driver

Add support for a duration/length for the bps/iops and friends. Modify the API in order to add the "blkdeviotune." specific definitions for the iotune throttling duration/length options total_bytes_sec_max_length write_bytes_sec_max_length read_bytes_sec_max_length

[libvirt] [PATCH 10/12] conf: Adjust the PARSE_IOTUNE macro

Unlike formatting we can parse in any order - this just makes it look like there are less lines. A subsequent patch will add 6 more fields to parse and that will look better. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 22 ++ 1 file changed,

[libvirt] [PATCH 11/12] conf: Add support for blkiotune "_length" options

Modify _virDomainBlockIoTuneInfo and rng schema to support the _length options for bps/iops throttling values. Document the new values. Signed-off-by: John Ferlan --- docs/formatdomain.html.in | 40 - docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH v2 02/20] virlog: Introduce virLogOutputNew

[...] >>> + >>> +ret->logInitMessage = true; >>> +ret->f = f; >>> +ret->c = c; >>> +ret->data = data; >> >> From future patches I see this can be a file or syslog fd. >> >> Anyway, because you're relying on the "->c" to be the free function for >> ->data, perhaps there should be a

Re: [libvirt] [PATCH rfc v2 0/8] fspool: backend directory

On Fri, Sep 23, 2016 at 11:38:10AM -0400, John Ferlan wrote: > > > On 09/21/2016 12:17 PM, Maxim Nestratov wrote: > > > >> 20 сент. 2016 г., в 23:52, John Ferlan написал(а): > >> > >> > >> > >>> On 09/15/2016 03:32 AM, Olga Krishtal wrote: > >>> Hi everyone, we would like

Re: [libvirt] [PATCH 3/9] qemuBuildChrChardevStr: Introduce @nowait argument

On 23.09.2016 00:50, John Ferlan wrote: > > > On 08/16/2016 11:41 AM, Michal Privoznik wrote: >> This alone makes not much sense. But the aim is to reuse this >> function in qemuBuildVhostuserCommandLine() where 'nowait' is not >> supported for vhost-user devices. >> >> Signed-off-by: Michal

Re: [libvirt] [PATCH v2] storage: vz storage pool support

On 20/09/16 23:30, John Ferlan wrote: On 07/14/2016 01:13 PM, Olga Krishtal wrote: This patch supports pool and volume management within Virtuozzo Storage. Virtuozzo Storage is a highly-available distributed software defined storage with built-in replication and disaster recovery. From

Re: [libvirt] [PATCH v2 01/11] virDomainDefPostParse: Introduce @parseOpaque argument

On Fri, Sep 23, 2016 at 15:24:54 +0200, Michal Privoznik wrote: > Some callers might want to pass yet another pointer to opaque > data to post parse callbacks. The driver generic one is not > enough because two threads executing post parse callback might > want see different data (e.g. domain

Re: [libvirt] [PATCH rfc v2 0/8] fspool: backend directory

On 09/21/2016 12:17 PM, Maxim Nestratov wrote: > >> 20 сент. 2016 г., в 23:52, John Ferlan написал(а): >> >> >> >>> On 09/15/2016 03:32 AM, Olga Krishtal wrote: >>> Hi everyone, we would like to propose the first implementation of fspool >>> with directory backend. >>> >>>

Re: [libvirt] [PATCH v2 02/11] virDomainDefParseNode: Introduce @parseOpaque argument

On Fri, Sep 23, 2016 at 15:24:55 +0200, Michal Privoznik wrote: > We want to by pass the proper opaque pointer instead of NULL to s/by // > virDomainDefParseXML and subsequently virDomainDefPostParse too. ... ACK Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 1/9] qemuDomainAttachNetDevice: Explicitly list allowed types for hotplug

On 23.09.2016 00:47, John Ferlan wrote: > > > On 08/16/2016 11:41 AM, Michal Privoznik wrote: >> Instead of blindly claim support for hot-plugging of every > > claiming > >> interface type out there we should copy approach we have for >> device types: white listing supported types and

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On 09/23/2016 08:24 AM, Nehal J Wani wrote: On Fri, Sep 23, 2016 at 4:51 PM, Peter Krempa wrote: On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal J Wani wrote: On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa wrote: On Fri, Sep 23, 2016 at 12:19:49 +0530,

Re: [libvirt] [PATCH rfc v2 0/8] fspool: backend directory

On 21/09/16 19:17, Maxim Nestratov wrote: 20 сент. 2016 г., в 23:52, John Ferlan написал(а): On 09/15/2016 03:32 AM, Olga Krishtal wrote: Hi everyone, we would like to propose the first implementation of fspool with directory backend. Filesystem pools is a facility to

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Fri, Sep 23, 2016 at 9:26 PM, Laine Stump wrote: > On 09/23/2016 08:24 AM, Nehal J Wani wrote: >> >> On Fri, Sep 23, 2016 at 4:51 PM, Peter Krempa wrote: >>> >>> On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal J Wani wrote: On Fri, Sep 23, 2016 at

Re: [libvirt] Cpu Modeling

On 09/23/2016 08:05 AM, Jiri Denemark wrote: On Thu, Sep 22, 2016 at 14:47:36 -0400, Jason J. Herne wrote: ... 1. We will invoke qemu to gather the host cpu data used for virsh capabilities. Today this data seems to be collected directly from the host hardware for most (all?) architectures.

Re: [libvirt] [PATCH] Replacing for (; ; ) with while (1) for better code.

Sure. I just read it in hacking.html and thought of sending this patch. On Fri, Sep 23, 2016 at 1:58 PM, Martin Kletzander wrote: > On Fri, Sep 23, 2016 at 01:17:40AM +0530, Nitesh Konkar wrote: > >> As mentioned in https://libvirt.org/hacking.html, >> using while (1) is

Re: [libvirt] Cpu Modeling

On Fri, Sep 23, 2016 at 02:05:59PM +0200, Jiri Denemark wrote: > On Thu, Sep 22, 2016 at 14:47:36 -0400, Jason J. Herne wrote: > > Testing for runability: > > - Simply try to start QEMU with KVM, compat machine, CPU model > > Yes, if the domain XML explicitly requests a specific CPU model. >

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On 9/23/2016 12:55 AM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Wednesday, September 21, 2016 12:23 AM >>> > I have > a hard time believing that a given vendor can even allocate unique type > ids for their own devices. Unique type id across

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Fri, 2016-09-23 at 11:56 -0400, Laine Stump wrote: > Martin's patch tries to solve the problem with "dhcp-authoritative"  > which, as far as I understand, tells dnsmasq "you are the keeper of  > *all* lease information on this network, so if you think the address > is  > unused, it really is

[libvirt] [libvirt-php][PATCH 00/14] Fix code styling in libvirt-php

Fixed some basic code styling issues in libvirt-php.c that made the code hard to read. Katerina Koukiou (14): libvirt-php.c: Fix coding style issues: space required after ',' libvirt-php.c: Fix coding style issues: spaces required around '==', '>=', '<=' etc. libvirt-php.c: Fix

[libvirt] [libvirt-php][PATCH 09/14] libvirt-php.c: Fix coding style issues: space required around '=' in assignments

Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 742 +++--- 1 file changed, 371 insertions(+), 371 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index e12c3ae..dea608e 100644 --- a/src/libvirt-php.c

[libvirt] [libvirt-php][PATCH 14/14] libvirt-php.c: Fix coding style issues in macros

Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 208 +- 1 file changed, 110 insertions(+), 98 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 2fb8d60..b0bbd8f 100644 --- a/src/libvirt-php.c

[libvirt] [libvirt-php][PATCH 12/14] libvirt-php.c: Fix coding style issues with operators

Space required around arithmetic and logical operators Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index

[libvirt] [libvirt-php][PATCH 06/14] libvirt-php.c: Fix code styling issues: if then else statement style issues

Follow the following rules in if - then - else statements: 1) The opening brackets stays in the same line with the if statement 2) The closing brace is empty on a line of its own except in the cases where it is followed by a continuation of the same statement. Example: if (x == y) { ... }

[libvirt] [libvirt-php][PATCH 03/14] libvirt-php.c: Fix coding style issues: space prohibited between function name and open parenthesis '('

Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 298 +++--- 1 file changed, 149 insertions(+), 149 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index a325b1f..b95774b 100644 --- a/src/libvirt-php.c

[libvirt] [libvirt-php][PATCH 01/14] libvirt-php.c: Fix coding style issues: space required after ', '

Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 414 +++--- 1 file changed, 207 insertions(+), 207 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index df2f32a..b28d4b4 100644 --- a/src/libvirt-php.c

[libvirt] [libvirt-php][PATCH 11/14] libvirt-php.c: Fix coding style issues: "(foo*)" should be "(foo *)"

Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index ced4031..1f1209f 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -1476,7

[libvirt] [libvirt-php][PATCH 10/14] libvirt-php.c: Fix code styling issues with for loops

for loop should be written with spaces ex: for (i = 0; i < MAX; i++) { ... } Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/src/libvirt-php.c

[libvirt] [libvirt-php][PATCH 08/14] libvirt-php.c Fix coding style issues with if statements

Trailing statements after 'if' should be on next line Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 266 -- 1 file changed, 176 insertions(+), 90 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c

[libvirt] [libvirt-php][PATCH 05/14] libvirt-php.c: Fix code styling issues: no space needed after '[' and before ']'

Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 235157e..9ee72be 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -1153,7 +1153,7 @@

[libvirt] [libvirt-php][PATCH 04/14] libvirt-php.c: Fix coding style issues: remove unwanted spaces after '(' and before ')'

Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 114 +++--- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index b95774b..235157e 100644 --- a/src/libvirt-php.c +++

[libvirt] [libvirt-php][PATCH 07/14] libvirt-php.c: Fix coding style issues with braces

Put the opening brace last on the line all non-function statement blocks (if, switch, for, while, do) Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 66 +++ 1 file changed, 22 insertions(+), 44 deletions(-) diff

[libvirt] [libvirt-php][PATCH 02/14] libvirt-php.c: Fix coding style issues: spaces required around '==', '>=', '<=' etc.

Signed-off-by: Katerina Koukiou --- src/libvirt-php.c | 122 +++--- 1 file changed, 61 insertions(+), 61 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index b28d4b4..a325b1f 100644 --- a/src/libvirt-php.c +++

  1   2   >