Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Wed, Sep 28, 2016 at 06:03:21PM +0200, Martin Wilck wrote: > On Wed, 2016-09-28 at 16:41 +0100, Daniel P. Berrange wrote: > > > Anyone who cares about VMs having the same IP address after resuming > > from suspend *must* configure persistent DHCP mappings for their > > guests. > > Relying on

[libvirt] [PATCH 4/4] vbox: update rest of the code to for prior changes.

This commit should be squashed to previous one. Keeping it separate for code-review purposes only as it's mostly noise due to changes of the struct definitions in previous patch: * vboxPrivate (aka old vboxGlobalData *data argument) no longer needs to be passed around as g_pVBoxGlobalData is

[libvirt] [PATCH 3/4] vbox: change API (un)initialization logic.

Since VBOX API initialization method (pfnComInitialize) is not thread-safe and must be called from the primary thread, calling it in every vboxConnectOpen (as we used to do) leads to segmentation faults when multiple connections are in use. Therefore the initalization and unitialization logic has

[libvirt] [PATCH 2/4] vbox: replace vboxGlobalData with vboxPrivate.

Since those stucts are identical at the moment, this patch basically does s/vboxGlobalData \*data/vboxPrivate *data/ with type casts in vboxDriverLock/Unlock calls to keep the code working and take care of unavoidable diff noise to set the stage for further commits that actually address the issue

[libvirt] [PATCH 0/4] vbox: address thread-safety issues.

This patch series solves (at least in my testing) vbox driver thread-safety issues that were also outlined on libvirt-users ML [1] and I was affected with. Those patches try to follow the suggestions made Matthias' [2] in that thread as close as possible. Here's where my patch differs from that

[libvirt] [PATCH 1/4] vbox: add vboxPrivate struct.

To be passed as per-connection context info instead of using vboxGlobalData that it will eventually replace in most cases. --- src/vbox/vbox_uniformed_api.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/vbox/vbox_uniformed_api.h

[libvirt] [PATCH] bhyve: chase cpuCompareXML rename

In commit 7f127de cpuCompareXML was renamed to virCPUCompareXML, so change the bhyve driver to use the new function and thus fix the build. --- Pushed under the build-breaker rule. src/bhyve/bhyve_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Wed, 2016-09-28 at 16:41 +0100, Daniel P. Berrange wrote: > Anyone who cares about VMs having the same IP address after resuming > from suspend *must* configure persistent DHCP mappings for their > guests. > Relying on automatic assignment will always fail in the end, may be > not immediately,

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Wed, 28 Sep 2016 13:06:31 -0700 Neo Jia wrote: > On Wed, Sep 28, 2016 at 01:55:47PM -0600, Alex Williamson wrote: > > On Wed, 28 Sep 2016 12:22:35 -0700 > > Neo Jia wrote: > > > > > On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P. Berrange wrote: > >

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On 09/28/2016 03:59 PM, Neo Jia wrote: On Wed, Sep 28, 2016 at 07:45:38PM +, Tian, Kevin wrote: From: Neo Jia [mailto:c...@nvidia.com] Sent: Thursday, September 29, 2016 3:23 AM On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P. Berrange wrote: On Thu, Sep 22, 2016 at 08:19:21AM -0600,

Re: [libvirt] [PATCH 3/3] sanlock: Properly init io_timeout

On 09/15/2016 10:35 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1292984 > > Hold on to your hats, because this is gonna be wild. > > In bd3e16a3 I've tried to expose sanlock io_timeout. What I had > not realized (because there is like no documentation for sanlock

Re: [libvirt] [PATCH 1/3] lock_driver_sanlock: Avoid global driver variable whenever possible

On 09/15/2016 10:35 AM, Michal Privoznik wrote: > Global variables are bad, we should avoid using them. > > Signed-off-by: Michal Privoznik > --- > src/locking/lock_driver_sanlock.c | 42 > --- > 1 file changed, 26 insertions(+), 16

Re: [libvirt] [PATCH 2/3] m4: Check for sanlock_write_lockspace

On 09/15/2016 10:35 AM, Michal Privoznik wrote: > Currently, we are checking for sanlock_add_lockspace_timeout > which is good for now. But in the next patches we are gonna use s/the next patches/a subsequent patch/ s/gonna/going to/ > sanlock_write_lockspace (which sets an initial value for

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Wed, 28 Sep 2016 12:59:59 -0700 Neo Jia wrote: > On Wed, Sep 28, 2016 at 07:45:38PM +, Tian, Kevin wrote: > > > From: Neo Jia [mailto:c...@nvidia.com] > > > Sent: Thursday, September 29, 2016 3:23 AM > > > > > > On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P.

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

> From: Neo Jia [mailto:c...@nvidia.com] > Sent: Thursday, September 29, 2016 3:23 AM > > On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P. Berrange wrote: > > On Thu, Sep 22, 2016 at 08:19:21AM -0600, Alex Williamson wrote: > > > On Thu, 22 Sep 2016 09:41:20 +0530 > > > Kirti Wankhede

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Wed, 28 Sep 2016 12:22:35 -0700 Neo Jia wrote: > On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P. Berrange wrote: > > On Thu, Sep 22, 2016 at 08:19:21AM -0600, Alex Williamson wrote: > > > On Thu, 22 Sep 2016 09:41:20 +0530 > > > Kirti Wankhede

[libvirt] [PATCH] vsh: Write out history on "quit" or "exit" in interactive mode

https://bugzilla.redhat.com/show_bug.cgi?id=1379895 Introduced by commit id '834c5720'. During the code motion and creation of vsh.c, the function 'vshDeinit()' in the (new) vsh.c was altered from whence it came in virsh.c such that calling 'vshReadlineDeinit(ctl)' was conditional on

[libvirt] [PATCH] Don't drop expired lease while reading custom leases file

Libvirt, on its own, shouldn't decide whether an expired lease should stay in the custom leases database or not. It should rather rely on the 'DEL' event from dnsmasq. --- src/util/virlease.c | 8 1 file changed, 8 deletions(-) diff --git a/src/util/virlease.c b/src/util/virlease.c

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Wed, Sep 28, 2016 at 07:45:38PM +, Tian, Kevin wrote: > > From: Neo Jia [mailto:c...@nvidia.com] > > Sent: Thursday, September 29, 2016 3:23 AM > > > > On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P. Berrange wrote: > > > On Thu, Sep 22, 2016 at 08:19:21AM -0600, Alex Williamson wrote:

Re: [libvirt] [PATCH 08/12] qemu: Add length for bps/iops throttling parameters to driver

>> +} else if (STREQ(param->field, >> + >> VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH)) { >> +info.write_iops_sec_max_length = param->value.ul; >> +set_iops_max_length = true; >> +if (virTypedParamsAddULLong(, , >> +

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

On Tue, Sep 20, 2016 at 10:47:53AM +0100, Daniel P. Berrange wrote: > On Tue, Sep 20, 2016 at 02:05:52AM +0530, Kirti Wankhede wrote: > > > > Hi libvirt experts, > > > > Thanks for valuable input on v1 version of RFC. > > > > Quick brief, VFIO based mediated device framework provides a way to >

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Wed, Sep 28, 2016 at 01:55:47PM -0600, Alex Williamson wrote: > On Wed, 28 Sep 2016 12:22:35 -0700 > Neo Jia wrote: > > > On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P. Berrange wrote: > > > On Thu, Sep 22, 2016 at 08:19:21AM -0600, Alex Williamson wrote: > > > > On

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Wed, Sep 28, 2016 at 04:31:25PM -0400, Laine Stump wrote: > On 09/28/2016 03:59 PM, Neo Jia wrote: > > On Wed, Sep 28, 2016 at 07:45:38PM +, Tian, Kevin wrote: > > > > From: Neo Jia [mailto:c...@nvidia.com] > > > > Sent: Thursday, September 29, 2016 3:23 AM > > > > > > > > On Thu, Sep 22,

[libvirt] [PATCH 08.5/12] qemu: Create a set of macros to handle setting block iotune values

Rework the code in a set of 3 macros that will use the "base" of 'bytes' or 'iops' and build up the prefixes of 'total_', 'read_', and 'write_' before adding the postfixes of '_sec', '_sec_max', and '_sec_max_length' and making the param->field comparison and adding of the field. Signed-off-by:

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P. Berrange wrote: > On Thu, Sep 22, 2016 at 08:19:21AM -0600, Alex Williamson wrote: > > On Thu, 22 Sep 2016 09:41:20 +0530 > > Kirti Wankhede wrote: > > > > > > My concern is that a type id seems arbitrary but we're

[libvirt] [PATCH] NSS: Add explicit check to not report expired lease

The NSS module shouldn't rely on custom leases database to not have entries for leases which have expired. --- tools/nss/libvirt_nss.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tools/nss/libvirt_nss.c b/tools/nss/libvirt_nss.c index 54c4a2a..57ba473 100644 ---

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Tue, Sep 27, 2016 at 09:15:18AM +0530, Nehal J Wani wrote: > > I did another experiment. My network xml limited the range to: > > > > > > > > So, we can safely assume that, if, at any given point of time, there > are two virtual machines with different mac addresses,

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Wed, Sep 28, 2016 at 04:23:32PM +0200, Martin Wilck wrote: > On Tue, 2016-09-27 at 09:15 +0530, Nehal J Wani wrote: > >  > > Seems like the previous experiment involved a happy accident indeed. > >  > > So, what are we going to do about libvirt+dnsmasq's handling of expired > leases now? IMHO

Re: [libvirt] [PATCH 1/3] qemu: store guest visible disk size from qemu monitor block info

On 28.09.2016 00:53, John Ferlan wrote: > > > On 09/27/2016 04:17 AM, Nikolay Shirokovskiy wrote: >> >> >> On 26.09.2016 23:07, John Ferlan wrote: >>> >>> >>> On 09/07/2016 05:24 AM, Nikolay Shirokovskiy wrote: --- src/qemu/qemu_domain.h | 1 +

Re: [libvirt] [PATCH 3/3] introduce pull backup

On 27.09.2016 01:04, John Ferlan wrote: > > > On 09/07/2016 05:24 AM, Nikolay Shirokovskiy wrote: >> Add API to start/stop exporting disks for a backup and add qemu >> implementation. >> >> The latter is not complete yet. At least backup disks are not >> cleaned up and libvirt restart is not

[libvirt] [PATCH] qemu_process: add pid of vm in domain log

From: Chen Hanxiao Add pid of VM in domain log. We used to show this info in debug log. For example: If a process send SIGKILL to a qemu process, we could find something in audit logs. Then the pid of VM in domain log will be helpful. Signed-off-by: Chen Hanxiao

Re: [libvirt] [PATCH] libxl: fix param assignment in domainGetSchedulerParameters

On 09/28/2016 12:33 AM, Jim Fehlig wrote: > Due to a copy and paste error, the scheduler 'cap' parameter > was over-writing the 'weight' parameter when preparing the > return parameters in libxlDomainGetSchedulerParametersFlags. > As a result, the scheduler weight was never shown when getting >

Re: [libvirt] [PATCH] doc: fix note about Xen credit scheduler

On 09/28/2016 12:50 AM, Jim Fehlig wrote: > Commit 6c504d6a added a note to the virsh man page about the > deprecation of 'cap' and 'weight' settings for the credit > scheduler. To this day, the default scheduler in Xen is credit > and it supports setting 'cap' and 'weight'. Remove the

Re: [libvirt] [libvirt-php][PATCH 00/11] Resolve reverse include order

2016-09-27 16:11 GMT+03:00 Michal Privoznik : > These are not pushed yet as they might be somewhat controversial. > I'll wait if somebody wants to review them. > > The ultimate goal is to, well drop libvirt-php.h completely. It > is needless. But before going there we must

[libvirt] [PATCH v2] virsh domdisplay: introduce '--all' for showing all possible graphical display

From: Chen Hanxiao For one VM, it could had more than one graphical display. Such as we coud add both vnc and spice display to a VM. This patch introduces '--all' for showing all possible graphical display of a active VM. Signed-off-by: Chen Hanxiao

Re: [libvirt] [PATCH] libvirt-storage.c:Lines too long, use 80 character columns.

On Wed, Sep 28, 2016 at 12:27:21AM +0530, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/libvirt-storage.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/src/libvirt-storage.c

Re: [libvirt] xen/libvirt freeze while attching network-device to vm´s - question about provided patches

On 09/28/2016 07:56 AM, guido.rossmuel...@gdata.de wrote: > Hello, > > we have tested the provided patches from Jim Fehlig. > Our testsetup based on an Fedora 23 with xen 4.6.1 and libvirt 2.1 > > The testsystem restores 15 vm´s (WindowsXP , HVM) in parallel, attached a > block-device to each vm

Re: [libvirt] [PATCH] doc: fix note about Xen credit scheduler

On 09/28/2016 05:49 AM, John Ferlan wrote: > > On 09/28/2016 12:50 AM, Jim Fehlig wrote: >> Commit 6c504d6a added a note to the virsh man page about the >> deprecation of 'cap' and 'weight' settings for the credit >> scheduler. To this day, the default scheduler in Xen is credit >> and it supports

Re: [libvirt] [PATCH] libxl: fix param assignment in domainGetSchedulerParameters

On 09/28/2016 05:47 AM, John Ferlan wrote: > > On 09/28/2016 12:33 AM, Jim Fehlig wrote: >> Due to a copy and paste error, the scheduler 'cap' parameter >> was over-writing the 'weight' parameter when preparing the >> return parameters in libxlDomainGetSchedulerParametersFlags. >> As a result, the

Re: [libvirt] xen/libvirt freeze while attching network-device to vm´s - question about provided patches

Hello, we have tested the provided patches from Jim Fehlig. Our testsetup based on an Fedora 23 with xen 4.6.1 and libvirt 2.1 The testsystem restores 15 vm´s (WindowsXP , HVM) in parallel, attached a block-device to each vm and an nic, run´s the vm 60 sec and then destroy them. The testsystem

Re: [libvirt] xen/libvirt freeze while attching network-device to vm´s - question about provided patches

Hi Jim, yes, i tested the patch https://www.redhat.com/archives/libvir-list/2016-September/msg00970.html all the best guido Von: Jim Fehlig [jfeh...@suse.com] Gesendet: Mittwoch, 28. September 2016 16:08 An: Rossmueller, Guido Cc: abolo...@redhat.com;

Re: [libvirt] xen/libvirt freeze while attching network-device to vm´s - question about provided patches

On 09/28/2016 08:15 AM, guido.rossmuel...@gdata.de wrote: > Hi Jim, > > yes, i tested the patch > https://www.redhat.com/archives/libvir-list/2016-September/msg00970.html Awesome! Thanks for testing and providing feedback. Regards, Jim -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

On Tue, 2016-09-27 at 09:15 +0530, Nehal J Wani wrote: >  > Seems like the previous experiment involved a happy accident indeed. >  So, what are we going to do about libvirt+dnsmasq's handling of expired leases now? Martin -- libvir-list mailing list libvir-list@redhat.com