Re: [libvirt] support for qemu werror and rerror

2016-09-29 Thread Laine Stump
On 09/29/2016 08:35 AM, Vasiliy Tolstov wrote: Sometimes ago qemu anounced support for action for disk: werror=action,rerror=action Specify which action to take on write and read errors. Valid actions are: "ignore" (ignore the error and try to continue), "stop" (pause QEMU), "report" (report

Re: [libvirt] [PATCH 3/3] sanlock: Properly init io_timeout

2016-09-29 Thread Michal Privoznik
On 28.09.2016 23:59, John Ferlan wrote: > > > On 09/15/2016 10:35 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1292984 >> >> Hold on to your hats, because this is gonna be wild. >> >> In bd3e16a3 I've tried to expose sanlock io_timeout. What I had >> not realized

Re: [libvirt] [PATCH V2 0/4]] qemu: report actual vcpu state in virVcpuInfo

2016-09-29 Thread Peter Krempa
On Thu, Sep 29, 2016 at 10:30:07 -0400, John Ferlan wrote: > > > On 09/20/2016 04:10 AM, Viktor Mihajlovski wrote: > > Currently, the virVcpuInfo returned by virDomainGetVcpus() will always > > report a state of VIR_VCPU_RUNNING for each defined domain vcpu even if > > the vcpu is currently in

Re: [libvirt] [PATCH v3 03/18] qemu: new functions qemuDomainMachineHasPCI[e]Root()

2016-09-29 Thread Andrea Bolognani
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote: > These functions provide a simple one line method of learning if the > current domain has a pci-root or pcie-root bus. > --- >  src/qemu/qemu_domain.c | 28 >  src/qemu/qemu_domain.h |  2 ++ >  2 files changed, 30

[libvirt] [PATCH v3.5 14/18] qemu: only force an available legacy-PCI slot on domains with pci-root

2016-09-29 Thread Laine Stump
Andrea had the right idea when he disabled the "reserve an extra unused slot" bit for aarch64/virt. For *any* PCI Express-based machine, it is pointless since 1) an extra legacy-PCI slot can't be used for hotplug, since hotplug into legacy PCI slots doesn't work on PCI Express machinetypes, and 2)

Re: [libvirt] summary of current vfio mdev upstreaming status

2016-09-29 Thread Tian, Kevin
> From: Neo Jia [mailto:c...@nvidia.com] > Sent: Thursday, September 29, 2016 5:17 PM > > On Thu, Sep 29, 2016 at 04:55:39PM +0800, Jike Song wrote: > > Hi all, > > > > In order to have a clear understanding about the VFIO mdev upstreaming > > status, I'd like to summarize it. Please share your

Re: [libvirt] [PATCH v3 01/18] conf: restrict what type of buses will accept a pci-bridge

2016-09-29 Thread Andrea Bolognani
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote: > A pci-bridge has *almost* the same rules as a legacy PCI endpoint > device for where it can be automatically connected, and until now both > had been considered identical. There is one pairing that is okay when > specifically requested by the

Re: [libvirt] [PATCH v5 0/2] qemu/gluster: add option for tuning debug logging level

2016-09-29 Thread Peter Krempa
On Thu, Sep 22, 2016 at 01:04:17 +0530, Prasanna Kumar Kalever wrote: > This series run basic sanity and other tests: > 1. make syntax-check > 2. make check > 3. VIR_TEST_VERBOSE=1 ./tests/qemuargv2xmltest > 4. VIR_TEST_VERBOSE=1 ./tests/qemuxml2argvtest > 5. VIR_TEST_VERBOSE=1

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Tian, Kevin
> From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Thursday, September 29, 2016 4:06 PM > > On Wed, Sep 28, 2016 at 12:48:33PM -0700, Neo Jia wrote: > > On Tue, Sep 20, 2016 at 10:47:53AM +0100, Daniel P. Berrange wrote: > > > On Tue, Sep 20, 2016 at 02:05:52AM +0530, Kirti Wankhede

[libvirt] [PATCH] allow snapshots of network sheepdog disks

2016-09-29 Thread Vasiliy Tolstov
Sometimes ago in f7c1410b0ee5b878e81f2eddf86c609947a9b27c ability to snapshot sheepdog disk removed. But sheepdog have ability to store vm state inside special object type. Vasiliy Tolstov (1): sheepdog: allow snapshot src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) --

Re: [libvirt] [PATCH V2 0/4]] qemu: report actual vcpu state in virVcpuInfo

2016-09-29 Thread John Ferlan
On 09/20/2016 04:10 AM, Viktor Mihajlovski wrote: > Currently, the virVcpuInfo returned by virDomainGetVcpus() will always > report a state of VIR_VCPU_RUNNING for each defined domain vcpu even if > the vcpu is currently in the halted state. > > As the monitor interface is in fact reporting the

Re: [libvirt] [PATCH V2 1/4] domain: Add new VCPU state "halted"

2016-09-29 Thread John Ferlan
On 09/20/2016 04:10 AM, Viktor Mihajlovski wrote: > QEMU virtual CPUs can assume a halted state, which - depending on > the architecture - can indicate whether a CPU is in use by the > guest operating system. > > A new VCPU state halted is introduced in preparation of the > support in the QEMU

Re: [libvirt] [PATCH V2 4/4] qemu: Ensure reported VCPU state is current in driver API

2016-09-29 Thread John Ferlan
On 09/20/2016 04:11 AM, Viktor Mihajlovski wrote: > Refresh the VCPU halted states in API functions returning domain > VCPU state information to make sure it's current. This affects > qemuDomainGetVcpus and qemuDomainGetStatsVcpu > > Signed-off-by: Viktor Mihajlovski

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Kirti Wankhede
7. Hot-plug It is same syntax to create a virtual device for hot-plug. >>> >>> How do groups work with hotplug? Can a device be creating into an >>> existing, running group? Can a device be removed from an existing, >>> running group?

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Daniel P. Berrange
On Thu, Sep 29, 2016 at 02:35:48PM +, Tian, Kevin wrote: > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Thursday, September 29, 2016 4:06 PM > > > > On Wed, Sep 28, 2016 at 12:48:33PM -0700, Neo Jia wrote: > > > On Tue, Sep 20, 2016 at 10:47:53AM +0100, Daniel P. Berrange

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Tian, Kevin
> From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Thursday, September 29, 2016 10:39 PM > > On Thu, Sep 29, 2016 at 02:35:48PM +, Tian, Kevin wrote: > > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > > Sent: Thursday, September 29, 2016 4:06 PM > > > > > > On Wed,

[libvirt] [PATCH] sheepdog: allow snapshot

2016-09-29 Thread Vasiliy Tolstov
partially revert f7c1410b0ee5b878e81f2eddf86c609947a9b27c because sheepdog allow to store vm state inside vdi Signed-off-by: Vasiliy Tolstov --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

Re: [libvirt] Cpu Modeling

2016-09-29 Thread Jiri Denemark
On Fri, Sep 23, 2016 at 15:23:45 -0300, Eduardo Habkost wrote: > On Fri, Sep 23, 2016 at 02:05:59PM +0200, Jiri Denemark wrote: > > It's not critical for query-cpu-model-expansion, but do we have an > > interface we can use to check whether the new commands are supported by > > a QEMU binary?

Re: [libvirt] [PATCH V2 2/4] qemu: Add monitor support for CPU halted state

2016-09-29 Thread John Ferlan
On 09/20/2016 04:10 AM, Viktor Mihajlovski wrote: > Extended the qemuMonitorCPUInfo with a halted flag. Extract the halted > flag for both text and JSON monitor. > > Signed-off-by: Viktor Mihajlovski > Signed-off-by: Boris Fiuczynski >

Re: [libvirt] [PATCH V2 3/4] qemu: Add domain support for VCPU halted state

2016-09-29 Thread John Ferlan
On 09/20/2016 04:11 AM, Viktor Mihajlovski wrote: > Adding a field to the domain's private vcpu object to hold the halted > state information. > Adding two functions in support of the halted state: > - qemuDomainGetVcpuHalted: retrieve the halted state from a > private vcpu object > -

Re: [libvirt] [PATCH 0/3] Fix io_timeout for sanlock

2016-09-29 Thread Michal Privoznik
On 29.09.2016 16:50, John Ferlan wrote: > > > On 09/29/2016 10:06 AM, Michal Privoznik wrote: >> On 15.09.2016 16:35, Michal Privoznik wrote: >>> Just read the 3/3. I didn't know whether I should laugh or cry. I did both. >>> >>> Michal Privoznik (3): >>> lock_driver_sanlock: Avoid global

Re: [libvirt] [PATCH v3 02/18] qemu: replace a lot of "def->controllers[i]" with equivalent "cont"

2016-09-29 Thread Andrea Bolognani
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote: > There's no functional change here. This pointer was just used so many > times that the extra long lines became annoying. > --- >  src/qemu/qemu_domain_address.c | 100 >+ >  1 file changed, 51

Re: [libvirt] [PATCH 0/3] Fix io_timeout for sanlock

2016-09-29 Thread Michal Privoznik
On 15.09.2016 16:35, Michal Privoznik wrote: > Just read the 3/3. I didn't know whether I should laugh or cry. I did both. > > Michal Privoznik (3): > lock_driver_sanlock: Avoid global driver variable whenever possible > m4: Check for sanlock_write_lockspace > sanlock: Properly init

Re: [libvirt] support for qemu werror and rerror

2016-09-29 Thread Vasiliy Tolstov
2016-09-29 16:38 GMT+03:00 Laine Stump : > Support is already there (since libvirt-0.9.7), handled by the error_policy, > and rerror_policy attributes of the subelement of a disk. search > for "rerror_policy" in http://www.libvirt.org/formatdomain.html for details. Sorry i miss

Re: [libvirt] [PATCH 7/7] qemu: Allow making vcpus hotpluggable with virDomainSetVcpusFlags

2016-09-29 Thread Shivaprasad G Bhat
On 09/29/2016 05:50 PM, Peter Krempa wrote: On Thu, Sep 29, 2016 at 17:37:53 +0530, Shivaprasad G Bhat wrote: On 09/29/2016 05:32 PM, Peter Krempa wrote: On Thu, Sep 29, 2016 at 16:29:13 +0530, Shivaprasad G Bhat wrote: On 09/21/2016 05:19 PM, Peter Krempa wrote: Implement support for

Re: [libvirt] [PATCH 0/3] Fix io_timeout for sanlock

2016-09-29 Thread John Ferlan
On 09/29/2016 10:06 AM, Michal Privoznik wrote: > On 15.09.2016 16:35, Michal Privoznik wrote: >> Just read the 3/3. I didn't know whether I should laugh or cry. I did both. >> >> Michal Privoznik (3): >> lock_driver_sanlock: Avoid global driver variable whenever possible >> m4: Check for

Re: [libvirt] Cpu Modeling

2016-09-29 Thread Jiri Denemark
On Fri, Sep 23, 2016 at 15:51:12 -0400, Jason J. Herne wrote: > On 09/23/2016 08:05 AM, Jiri Denemark wrote: > > The host-model part of the XML will show the result of > > query-cpu-model-expansion on "host" model, or the result of querying the > > hardware directly if we can't ask QEMU for that

Re: [libvirt] [PATCH 1/7] qemu: process: Fix off-by-one in vcpu order duplicate error message

2016-09-29 Thread Pavel Hrdina
On Wed, Sep 21, 2016 at 01:49:53PM +0200, Peter Krempa wrote: > The bitmap indexes for the order duplicate check are shifted to 0 since > vcpu order 0 is not allowed. The error message doesn't need such > treating though. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1370360 > --- >

Re: [libvirt] [PATCH 2/7] qemu: process: Don't use shifted indexes for vcpu order verification

2016-09-29 Thread Pavel Hrdina
On Wed, Sep 21, 2016 at 01:49:54PM +0200, Peter Krempa wrote: > Allocate a one larger bitmap rather than shifting the indexes back to > zero. > --- > src/qemu/qemu_process.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) ACK and safe for freeze. Pavel signature.asc Description:

Re: [libvirt] [PATCH 3/7] qemu: process: Enforce 'vcpu' order range to <1, maxvcpus>

2016-09-29 Thread Pavel Hrdina
On Wed, Sep 21, 2016 at 01:49:55PM +0200, Peter Krempa wrote: > The current code that validates duplicate vcpu order would not work > properly if the order would exceed def->maxvcpus. Limit the order to the > interval described. > --- > src/qemu/qemu_process.c | 8 ++-- > 1 file changed, 6

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Kirti Wankhede
On 9/29/2016 8:12 PM, Tian, Kevin wrote: >> From: Daniel P. Berrange [mailto:berra...@redhat.com] >> Sent: Thursday, September 29, 2016 10:39 PM >> >> On Thu, Sep 29, 2016 at 02:35:48PM +, Tian, Kevin wrote: From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Thursday,

Re: [libvirt] summary of current vfio mdev upstreaming status

2016-09-29 Thread Jike Song
On 09/29/2016 06:58 PM, Kirti Wankhede wrote: > > > On 9/29/2016 2:47 PM, Neo Jia wrote: >> On Thu, Sep 29, 2016 at 04:55:39PM +0800, Jike Song wrote: >>> Hi all, >>> >>> In order to have a clear understanding about the VFIO mdev upstreaming >>> status, I'd like to summarize it. Please share

Re: [libvirt] Cpu Modeling

2016-09-29 Thread Eduardo Habkost
On Thu, Sep 29, 2016 at 04:21:07PM +0200, Jiri Denemark wrote: [...] > > > Slightly related, I don't think we have a way to list CPU features > > > supported by QEMU over QMP, do we? "-cpu ?" will show them all, but I > > > couldn't find a QMP command that would give me the same list. > > > >

Re: [libvirt] [PATCH 0/4] vbox: address thread-safety issues.

2016-09-29 Thread Dawid Zamirski
On Wed, 2016-09-28 at 13:41 -0400, Dawid Zamirski wrote: > This patch series solves (at least in my testing) vbox driver > thread-safety issues that were also outlined on libvirt-users ML [1] > and I was affected with.  Just to give a more practical context on the issue I'm trying to solve with

[libvirt] [PATCH] docs: correct version requirements for

2016-09-29 Thread Laine Stump
When support was added for the kvm hidden='on' attribute in commit d07116, the version requirement was listed as "2.1.0 (QEMU only)". However, this was added when libvirt was at version 1.2.8 - it is *QEMU* that must be at version 2.1.0 or later. This went unnoticed for a very long time (over 2

Re: [libvirt] [PATCH] docs: correct version requirements for

2016-09-29 Thread John Ferlan
On 09/29/2016 01:50 PM, Laine Stump wrote: > When support was added for the kvm hidden='on' attribute in commit > d07116, the version requirement was listed as "2.1.0 (QEMU > only)". However, this was added when libvirt was at version 1.2.8 - it > is *QEMU* that must be at version 2.1.0 or

[libvirt] [PATCH v2]Pre-assign memory modules slot number and assign alias.

2016-09-29 Thread Nitesh Konkar
Find the smallest missing slot number and pre-assign slot numbers and assign aliases of memory modules. This keeps the slot number consistent with the alias. Signed-off-by: Nitesh Konkar --- src/qemu/qemu_alias.c | 54

Re: [libvirt] [PATCH V2 0/4]] qemu: report actual vcpu state in virVcpuInfo

2016-09-29 Thread John Ferlan
On 09/29/2016 11:04 AM, Peter Krempa wrote: > On Thu, Sep 29, 2016 at 10:30:07 -0400, John Ferlan wrote: >> >> >> On 09/20/2016 04:10 AM, Viktor Mihajlovski wrote: >>> Currently, the virVcpuInfo returned by virDomainGetVcpus() will always >>> report a state of VIR_VCPU_RUNNING for each defined

Re: [libvirt] [Qemu-devel] [PATCH v4 01/11] tests: Add test case for x86 feature parsing compatibility

2016-09-29 Thread Jonathan Neuschäfer
On Thu, Sep 29, 2016 at 06:14:49PM -0300, Eduardo Habkost wrote: > Add a new test case to ensure the existing behavior of the > feature parsing code wlil be kept. s/wlil/will/ > > Signed-off-by: Eduardo Habkost Jonathan Neuschäfer signature.asc Description: PGP

Re: [libvirt] [PATCH 3/3] introduce pull backup

2016-09-29 Thread John Ferlan
[...] >> >> Because it's also dependent upon an x-blockdev-del, it cannot be pushed >> upstream to libvirt. I know qemu work continues w/r/t blockdev-add and >> backups, but I don't follow it in detail (not enough time in the day!). > > Ok, at least the patch can be some kind of candidate to

Re: [libvirt] [PATCH 1/3] qemu: store guest visible disk size from qemu monitor block info

2016-09-29 Thread John Ferlan
> >> a lot of exposure to that code. I do know there's still upstream qemu >> work taking place. We really should be very careful about adding >> anything to libvirt before the upstream work is done. In particular any >> x-* command support. >> > > AFAIK full pull backups as well as

[libvirt] [PATCH v3 19/18] [RFC] qemu: assure there are always at least 4 open pcie-root-ports for hotplug

2016-09-29 Thread Laine Stump
For machinetypes with a pci-root bus (all legacy PCI), libvirt will make a "fake" reservation for one extra slot prior to assigning addresses to unaddressed PCI endpoint devices in the domain. This will trigger auto-adding of a pci-bridge for the final device to be assigned an address *if that

Re: [libvirt] [PATCH v2] virsh domdisplay: introduce '--all' for showing all possible graphical display

2016-09-29 Thread Michal Privoznik
On 28.09.2016 15:31, Chen Hanxiao wrote: > From: Chen Hanxiao > > For one VM, it could had more than one graphical display. > Such as we coud add both vnc and spice display to a VM. > > This patch introduces '--all' for showing all > possible graphical display of a active

Re: [libvirt] [PATCH 0/7] qemu: vcpu coldplug and ordering fixes

2016-09-29 Thread Peter Krempa
On Wed, Sep 21, 2016 at 13:49:52 +0200, Peter Krempa wrote: > Few fixes for various isues connected to coldplug and vcpu order. > > Peter Krempa (7): > qemu: process: Fix off-by-one in vcpu order duplicate error message > qemu: process: Don't use shifted indexes for vcpu order verification >

Re: [libvirt] [PATCH] vsh: Write out history on "quit" or "exit" in interactive mode

2016-09-29 Thread Erik Skultety
On 28/09/16 21:27, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1379895 > > Introduced by commit id '834c5720'. > > During the code motion and creation of vsh.c, the function 'vshDeinit()' > in the (new) vsh.c was altered from whence it came in virsh.c such that > calling

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Daniel P. Berrange
On Wed, Sep 28, 2016 at 12:48:33PM -0700, Neo Jia wrote: > On Tue, Sep 20, 2016 at 10:47:53AM +0100, Daniel P. Berrange wrote: > > On Tue, Sep 20, 2016 at 02:05:52AM +0530, Kirti Wankhede wrote: > > > > > > Hi libvirt experts, > > > > > > Thanks for valuable input on v1 version of RFC. > > > >

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Neo Jia
On Thu, Sep 29, 2016 at 09:03:40AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 28, 2016 at 12:22:35PM -0700, Neo Jia wrote: > > On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P. Berrange wrote: > > > On Thu, Sep 22, 2016 at 08:19:21AM -0600, Alex Williamson wrote: > > > > On Thu, 22 Sep 2016

Re: [libvirt] [libvirt-php][PATCH 00/11] Resolve reverse include order

2016-09-29 Thread Michal Privoznik
On 28.09.2016 14:00, Vasiliy Tolstov wrote: > 2016-09-27 16:11 GMT+03:00 Michal Privoznik : >> These are not pushed yet as they might be somewhat controversial. >> I'll wait if somebody wants to review them. >> >> The ultimate goal is to, well drop libvirt-php.h completely. It

Re: [libvirt] summary of current vfio mdev upstreaming status

2016-09-29 Thread Neo Jia
On Thu, Sep 29, 2016 at 04:55:39PM +0800, Jike Song wrote: > Hi all, > > In order to have a clear understanding about the VFIO mdev upstreaming > status, I'd like to summarize it. Please share your opinions on this, > and correct my misunderstandings. > > The whole vfio mdev series can be

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Daniel P. Berrange
On Wed, Sep 28, 2016 at 12:22:35PM -0700, Neo Jia wrote: > On Thu, Sep 22, 2016 at 03:26:38PM +0100, Daniel P. Berrange wrote: > > On Thu, Sep 22, 2016 at 08:19:21AM -0600, Alex Williamson wrote: > > > On Thu, 22 Sep 2016 09:41:20 +0530 > > > Kirti Wankhede wrote: > > > > >

[libvirt] [PATCH 2/2] qemu: Add support for preallocated fd memory

2016-09-29 Thread Jaroslav Safka
This second change introduces support for preallocated shared file descriptor based memory backing. It allows vhost-user to be used without hugepages. Used xml elements: --- src/qemu/qemu_command.c| 156 - src/qemu/qemu_command.h

[libvirt] [PATCH 0/2] Add support for preallocated fd memory

2016-09-29 Thread Jaroslav Safka
Hi the xml element to be extended with additional children is the memoryBacking element. We would like to introduce 3 new elements source,access and allocation If allocation is immediate then -mem-prealloc should be added to the qemu commanline. If source is file then

[libvirt] summary of current vfio mdev upstreaming status

2016-09-29 Thread Jike Song
Hi all, In order to have a clear understanding about the VFIO mdev upstreaming status, I'd like to summarize it. Please share your opinions on this, and correct my misunderstandings. The whole vfio mdev series can be logically divided into several parts, they work together to provide the mdev

[libvirt] [PATCH 1/2] conf: Add support for preallocated fd memory

2016-09-29 Thread Jaroslav Safka
This first change introduces xml parsing support for preallocated shared file descriptor based memory backing. It allows vhost-user to be used without hugepages. New xml elements: --- docs/schemas/domaincommon.rng | 37 + src/conf/domain_conf.c

Re: [libvirt] [Qemu-devel] summary of current vfio mdev upstreaming status

2016-09-29 Thread Xiao Guangrong
On 09/29/2016 04:55 PM, Jike Song wrote: Hi all, In order to have a clear understanding about the VFIO mdev upstreaming status, I'd like to summarize it. Please share your opinions on this, and correct my misunderstandings. The whole vfio mdev series can be logically divided into several

Re: [libvirt] [PATCH] qemu: Only use memory-backend-file with NUMA if needed

2016-09-29 Thread Martin Kletzander
On Wed, Sep 28, 2016 at 12:00:22PM +1000, Sam Bobroff wrote: On Fri, Sep 23, 2016 at 03:20:56PM +0200, Martin Kletzander wrote: If this reminds you of a commit message from around a year ago, it's 41c2aa729f0af084ede95ee9a06219a2dd5fb5df and yes, we're dealing with "the same thing" again. Or

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-29 Thread Martin Wilck
On Wed, 2016-09-28 at 17:10 +0100, Daniel P. Berrange wrote: > > I believe that setting "dhcp-authoritative" will be a major > > improvement > > for many setups. Without it, VMs are *never* able to reacquire > > their > > expired lease. With it, reacquiring the lease would work most of > > the >

[libvirt] [RFC] daemon: remove hardcode dep on libvirt-guests

2016-09-29 Thread Nikolay Shirokovskiy
Hi, all. In virtuozzo mgmt we do not use libvirt-guests service. First because we need do extra steps on domain start and second we want to decice whether to suspend or to shutdown a domain on per domain basis. Starting is not the problem but system shutdown is. As domain in systemd based systems

Re: [libvirt] [PATCH v2] virsh domdisplay: introduce '--all' for showing all possible graphical display

2016-09-29 Thread Chen Hanxiao
At 2016-09-29 14:27:56, "Michal Privoznik" wrote: >On 28.09.2016 15:31, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> For one VM, it could had more than one graphical display. >> Such as we coud add both vnc and spice display to a VM. >> >> This

Re: [libvirt] [RFC] daemon: remove hardcode dep on libvirt-guests

2016-09-29 Thread Jiri Denemark
On Thu, Sep 29, 2016 at 11:33:04 +0300, Nikolay Shirokovskiy wrote: > Hi, all. > > In virtuozzo mgmt we do not use libvirt-guests service. First because > we need do extra steps on domain start and second we want to decice > whether to suspend or to shutdown a domain on per domain basis. Starting

[libvirt] [PATCH 1/1] Add simple sample driver for mediated device framework

2016-09-29 Thread Kirti Wankhede
Sample driver creates mdev device that simulates serial port over PCI card. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I857f8f12f8b275f2498dfe8c628a5cdc7193b1b2 --- Documentation/mdev/Makefile | 14 +

[libvirt] [PATCH 0/1] Sample driver for mediated device framework

2016-09-29 Thread Kirti Wankhede
This sample driver is with reference to v7 patch of Mediated device support: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg03798.html https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg03799.html https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg03800.html

Re: [libvirt] [RFC] daemon: remove hardcode dep on libvirt-guests

2016-09-29 Thread Nikolay Shirokovskiy
On 29.09.2016 12:21, Jiri Denemark wrote: > On Thu, Sep 29, 2016 at 11:33:04 +0300, Nikolay Shirokovskiy wrote: >> Hi, all. >> >> In virtuozzo mgmt we do not use libvirt-guests service. First because >> we need do extra steps on domain start and second we want to decice >> whether to suspend or

Re: [libvirt] [PATCH] vsh: Write out history on "quit" or "exit" in interactive mode

2016-09-29 Thread John Ferlan
On 09/29/2016 03:06 AM, Erik Skultety wrote: > On 28/09/16 21:27, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1379895 >> >> Introduced by commit id '834c5720'. >> >> During the code motion and creation of vsh.c, the function 'vshDeinit()' >> in the (new) vsh.c was altered

Re: [libvirt] summary of current vfio mdev upstreaming status

2016-09-29 Thread Kirti Wankhede
On 9/29/2016 2:47 PM, Neo Jia wrote: > On Thu, Sep 29, 2016 at 04:55:39PM +0800, Jike Song wrote: >> Hi all, >> >> In order to have a clear understanding about the VFIO mdev upstreaming >> status, I'd like to summarize it. Please share your opinions on this, >> and correct my misunderstandings.

Re: [libvirt] [PATCH 7/7] qemu: Allow making vcpus hotpluggable with virDomainSetVcpusFlags

2016-09-29 Thread Shivaprasad G Bhat
On 09/21/2016 05:19 PM, Peter Krempa wrote: Implement support for VIR_DOMAIN_VCPU_HOTPLUGGABLE so that users can choose to make vcpus added by the API removable. --- src/qemu/qemu_driver.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git

Re: [libvirt] [RFC] daemon: remove hardcode dep on libvirt-guests

2016-09-29 Thread Daniel P. Berrange
On Thu, Sep 29, 2016 at 01:00:15PM +0300, Nikolay Shirokovskiy wrote: > > > On 29.09.2016 12:21, Jiri Denemark wrote: > > On Thu, Sep 29, 2016 at 11:33:04 +0300, Nikolay Shirokovskiy wrote: > >> Hi, all. > >> > >> In virtuozzo mgmt we do not use libvirt-guests service. First because > >> we need

Re: [libvirt] [Qemu-devel] summary of current vfio mdev upstreaming status

2016-09-29 Thread Neo Jia
On Thu, Sep 29, 2016 at 05:05:47PM +0800, Xiao Guangrong wrote: > > > On 09/29/2016 04:55 PM, Jike Song wrote: > > Hi all, > > > > In order to have a clear understanding about the VFIO mdev upstreaming > > status, I'd like to summarize it. Please share your opinions on this, > > and correct my

Re: [libvirt] [Qemu-devel] summary of current vfio mdev upstreaming status

2016-09-29 Thread Xiao Guangrong
On 09/29/2016 05:36 PM, Neo Jia wrote: On Thu, Sep 29, 2016 at 05:05:47PM +0800, Xiao Guangrong wrote: On 09/29/2016 04:55 PM, Jike Song wrote: Hi all, In order to have a clear understanding about the VFIO mdev upstreaming status, I'd like to summarize it. Please share your opinions on

Re: [libvirt] [RFC] daemon: remove hardcode dep on libvirt-guests

2016-09-29 Thread Nikolay Shirokovskiy
On 29.09.2016 13:06, Daniel P. Berrange wrote: > On Thu, Sep 29, 2016 at 01:00:15PM +0300, Nikolay Shirokovskiy wrote: >> >> >> On 29.09.2016 12:21, Jiri Denemark wrote: >>> On Thu, Sep 29, 2016 at 11:33:04 +0300, Nikolay Shirokovskiy wrote: Hi, all. In virtuozzo mgmt we do not

Re: [libvirt] [PATCH] vsh: Write out history on "quit" or "exit" in interactive mode

2016-09-29 Thread Erik Skultety
On 29/09/16 12:49, John Ferlan wrote: > > > On 09/29/2016 03:06 AM, Erik Skultety wrote: >> On 28/09/16 21:27, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1379895 >>> >>> Introduced by commit id '834c5720'. >>> >>> During the code motion and creation of vsh.c, the function

Re: [libvirt] [Qemu-devel] summary of current vfio mdev upstreaming status

2016-09-29 Thread Kirti Wankhede
On 9/29/2016 3:16 PM, Xiao Guangrong wrote: > > > On 09/29/2016 05:36 PM, Neo Jia wrote: >> On Thu, Sep 29, 2016 at 05:05:47PM +0800, Xiao Guangrong wrote: >>> >>> >>> On 09/29/2016 04:55 PM, Jike Song wrote: Hi all, In order to have a clear understanding about the VFIO mdev

Re: [libvirt] [PATCH] qemu: Only use memory-backend-file with NUMA if needed

2016-09-29 Thread Martin Kletzander
On Tue, Sep 27, 2016 at 04:29:07PM +0200, Michal Privoznik wrote: On 23.09.2016 15:20, Martin Kletzander wrote: If this reminds you of a commit message from around a year ago, it's 41c2aa729f0af084ede95ee9a06219a2dd5fb5df and yes, we're dealing with "the same thing" again. Or

[libvirt] support for qemu werror and rerror

2016-09-29 Thread Vasiliy Tolstov
Sometimes ago qemu anounced support for action for disk: werror=action,rerror=action Specify which action to take on write and read errors. Valid actions are: "ignore" (ignore the error and try to continue), "stop" (pause QEMU), "report" (report the error to the guest), "enospc" (pause QEMU only

Re: [libvirt] Cpu Modeling

2016-09-29 Thread Jason J. Herne
Polite Ping? :) On 09/23/2016 03:51 PM, Jason J. Herne wrote: On 09/23/2016 08:05 AM, Jiri Denemark wrote: On Thu, Sep 22, 2016 at 14:47:36 -0400, Jason J. Herne wrote: ... 1. We will invoke qemu to gather the host cpu data used for virsh capabilities. Today this data seems to be collected

Re: [libvirt] summary of current vfio mdev upstreaming status

2016-09-29 Thread Daniel P. Berrange
On Thu, Sep 29, 2016 at 04:55:39PM +0800, Jike Song wrote: > Hi all, > > In order to have a clear understanding about the VFIO mdev upstreaming > status, I'd like to summarize it. Please share your opinions on this, > and correct my misunderstandings. > > The whole vfio mdev series can be

Re: [libvirt] [PATCH 7/7] qemu: Allow making vcpus hotpluggable with virDomainSetVcpusFlags

2016-09-29 Thread Peter Krempa
On Thu, Sep 29, 2016 at 16:29:13 +0530, Shivaprasad G Bhat wrote: > > On 09/21/2016 05:19 PM, Peter Krempa wrote: > > Implement support for VIR_DOMAIN_VCPU_HOTPLUGGABLE so that users can > > choose to make vcpus added by the API removable. > > --- > > src/qemu/qemu_driver.c | 22

Re: [libvirt] [PATCH 7/7] qemu: Allow making vcpus hotpluggable with virDomainSetVcpusFlags

2016-09-29 Thread Peter Krempa
On Thu, Sep 29, 2016 at 17:37:53 +0530, Shivaprasad G Bhat wrote: > > > On 09/29/2016 05:32 PM, Peter Krempa wrote: > > On Thu, Sep 29, 2016 at 16:29:13 +0530, Shivaprasad G Bhat wrote: > >> On 09/21/2016 05:19 PM, Peter Krempa wrote: > >>> Implement support for VIR_DOMAIN_VCPU_HOTPLUGGABLE so

Re: [libvirt] [PATCH 7/7] qemu: Allow making vcpus hotpluggable with virDomainSetVcpusFlags

2016-09-29 Thread Shivaprasad G Bhat
On 09/29/2016 05:32 PM, Peter Krempa wrote: On Thu, Sep 29, 2016 at 16:29:13 +0530, Shivaprasad G Bhat wrote: On 09/21/2016 05:19 PM, Peter Krempa wrote: Implement support for VIR_DOMAIN_VCPU_HOTPLUGGABLE so that users can choose to make vcpus added by the API removable. ---

[libvirt] Malicious guests and entropy pool access risks

2016-09-29 Thread bancfc
Hello. While I've been enabling virtio-rng since it became available I recently understood that without restrictions a malicious guest can potentially starve other VMs' entropy by overusing /dev/random so I set the rate limit. Another question comes to mind. Does the way virtio-rng works pose

[libvirt] [PATCH] Fix Typo.

2016-09-29 Thread Nitesh Konkar
Signed-off-by: Nitesh Konkar --- src/libvirt-nodedev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c index 6ea14b3..bba9768 100644 --- a/src/libvirt-nodedev.c +++ b/src/libvirt-nodedev.c @@ -488,7

[libvirt] [PATCH v4 06/11] target-i386: Register properties for feature aliases manually

2016-09-29 Thread Eduardo Habkost
Instead of keeping the aliases inside the feature name arrays and require parsing the strings, just register alias properties manually. This simplifies the property registration code and will simplify code that needs to look up property names for CPUID bits. Signed-off-by: Eduardo Habkost

[libvirt] [PATCH v4 08/11] target-i386: Move warning code outside x86_cpu_filter_features()

2016-09-29 Thread Eduardo Habkost
x86_cpu_filter_features() will be reused by code that shouldn't print any warning. Move the warning code to a new x86_cpu_report_filtered_features() function, and call it from x86_cpu_realizefn(). Signed-off-by: Eduardo Habkost --- Changes v3 -> v4: * Made

[libvirt] [PATCH v4 04/11] target-i386: Make plus_features/minus_features QOM-based

2016-09-29 Thread Eduardo Habkost
Instead of using custom feature name lookup code for plus_features/minus_features, save the property names used in "[+-]feature" and use object_property_set_bool() to set them. Signed-off-by: Eduardo Habkost --- Changes series v3 -> v4: * New patch added to series ---

[libvirt] [PATCH v4 05/11] target-i386: Remove underscores from property names

2016-09-29 Thread Eduardo Habkost
Instead of translating the feature name entries when adding property names, store the actual property names in the feature name array. Signed-off-by: Eduardo Habkost --- Changes series v3 -> v4: * New patch added to series --- target-i386/cpu.c | 31

[libvirt] [PATCH v4 00/11] Add runnability info to query-cpu-definitions

2016-09-29 Thread Eduardo Habkost
This series extends query-cpu-definitions to include an extra field: "unavailable-features". The new field can be used to find out reasons that prevent the CPU model from running in the current host. This will return information based on the current machine and accelerator only. In the future we

[libvirt] [PATCH v4 10/11] qmp: Add runnability information to query-cpu-definitions

2016-09-29 Thread Eduardo Habkost
Add a new optional field to query-cpu-definitions schema: "unavailable-features". It will contain a list of QOM properties that prevent the CPU model from running in the current host. Cc: David Hildenbrand Cc: Michael Mueller Cc: Christian

[libvirt] [PATCH v4 07/11] target-i386: xsave: Add FP and SSE bits to x86_ext_save_areas

2016-09-29 Thread Eduardo Habkost
Instead of treating the FP and SSE bits as special cases, add them to the x86_ext_save_areas array. This will simplify the code that calculates the supported xsave components and the size of the xsave area. Signed-off-by: Eduardo Habkost --- Changes series v3 -> v4: * New

[libvirt] [PATCH v4 03/11] target-i386: Disable VME by default with TCG

2016-09-29 Thread Eduardo Habkost
VME is already disabled automatically when using TCG. So, instead of pretending it is there when reporting CPU model data on query-cpu-* QMP commands (making every CPU model to be reported as not runnable), we can disable it by default on all CPU models when using TCG. Do that by adding a

[libvirt] [PATCH v4 01/11] tests: Add test case for x86 feature parsing compatibility

2016-09-29 Thread Eduardo Habkost
Add a new test case to ensure the existing behavior of the feature parsing code wlil be kept. Signed-off-by: Eduardo Habkost --- Changes series v3 -> v4: * New patch added to series --- tests/test-x86-cpuid-compat.c | 39 +++ 1 file

Re: [libvirt] [PATCH 2/3] qemu: special error code in case of no job on cancel block job

2016-09-29 Thread John Ferlan
On 09/27/2016 05:06 AM, Nikolay Shirokovskiy wrote: > > > On 26.09.2016 23:07, John Ferlan wrote: >> >> >> On 09/07/2016 05:24 AM, Nikolay Shirokovskiy wrote: >>> Special error code helps gracefully handle race conditions on >>> blockjob cancelling. Consider for example pull backup. We want

[libvirt] [PATCH v4 02/11] target-i386: List CPU models using subclass list

2016-09-29 Thread Eduardo Habkost
Instead of using the builtin_x86_defs array, use the QOM subclass list to list CPU models on "-cpu ?" and "query-cpu-definitions". Signed-off-by: Andreas Färber [ehabkost: copied code from a patch by Andreas: "target-i386: QOM'ify CPU", from March 2012] Signed-off-by: Eduardo

[libvirt] [PATCH v4 11/11] target-i386: Return runnability information on query-cpu-definitions

2016-09-29 Thread Eduardo Habkost
Fill the "unavailable-features" field on the x86 implementation of query-cpu-definitions. Cc: Jiri Denemark Cc: libvir-list@redhat.com Signed-off-by: Eduardo Habkost --- Changes v3 -> v4: * Handle missing XSAVE components cleanly, but looking up the

[libvirt] [PATCH v4 09/11] target-i386: x86_cpu_load_features() function

2016-09-29 Thread Eduardo Habkost
When probing for CPU model information, we need to reuse the code that initializes CPUID fields, but not the remaining side-effects of x86_cpu_realizefn(). Move that code to a separate function that can be reused later. Signed-off-by: Eduardo Habkost --- Changes series v3 ->