Re: [libvirt] [RFC PATCH 01/10] libvirtd: Alter refcnt processing for domain server objects

On Wed, Jan 10, 2018 at 12:23:26PM -0500, John Ferlan wrote: > Once virNetDaemonAddServer returns, the @srv or @srvAdm have > either been added to the @dmn list increasing the refcnt or > there was an error. In either case, we can lower the refcnt > from virNetServerNew, but not set to NULL. Thus

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

On Mon, 2018-01-15 at 16:36 +0100, Michal Privoznik wrote: > > So, one way to solve this once and for all would be to: > > > > * try looking up readline through pkg-config. If that works, > > then we already know we're compiling against a recent > > readline version and everything will

Re: [libvirt] [RFC PATCH 02/10] libvirtd: Alter refcnt processing for server program objects

On Wed, Jan 10, 2018 at 12:23:27PM -0500, John Ferlan wrote: > Once virNetServerProgramNew returns, the program objects have > either been added to the @srv or @srvAdm list increasing the > refcnt or there was an error. In either case, we can lower the > refcnt from virNetServerProgramNew and set

Re: [libvirt] [RFC PATCH 03/10] netserver: Toggle service off during close

On Wed, Jan 10, 2018 at 12:23:28PM -0500, John Ferlan wrote: > Rather than waiting until virNetServerDispose to toggle the service > to off, let's do that when virNetServerServiceClose is called such > as during virNetServerClose. > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > CCing libvirt developers. ... > This case is slightly more problematic, however: the new feature > is actually migratable (under very controlled circumstances) > because of patch 2/2, but it is not migration-safe[1]. This > means

Re: [libvirt] [PATCH] vshReadlineOptionsGenerator: Don't add already specified options to the list

On Mon, Jan 15, 2018 at 10:34:29AM +0100, Michal Privoznik wrote: > The current state of art is as follows: > > 1) vshReadlineOptionsGenerator() generate all possible --options > for given command, and then > 2) vshReadlineOptionsPrune() clears out already provided ones > from the list. > >

Re: [libvirt] [RFC PATCH 04/10] qemu: Introduce virTheadPoolDrain

On Mon, Jan 15, 2018 at 05:51:28PM +0100, Erik Skultety wrote: > On Wed, Jan 10, 2018 at 12:23:29PM -0500, John Ferlan wrote: > > Split up virThreadPoolFree to create a Drain function which will > > be called from virNetServerClose in order to ensure the various > > worker threads are removed

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Mon, Jan 15, 2018 at 03:25:18PM +0100, Jiri Denemark wrote: > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > CCing libvirt developers. > ... > > This case is slightly more problematic, however: the new feature > > is actually migratable (under very controlled circumstances)

[libvirt] [PATCH perl] Spelling fixes

--- Changes | 4 ++-- HACKING | 4 ++-- lib/Sys/Virt.pm | 6 +++--- lib/Sys/Virt/Domain.pm | 14 +++--- lib/Sys/Virt/Interface.pm | 2 +- lib/Sys/Virt/NWFilter.pm| 2 +- lib/Sys/Virt/Network.pm | 4 ++--

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

On 01/15/2018 12:30 PM, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 10:26 +0100, Andrea Bolognani wrote: >> macOS has brew, though. I've kicked off a Travis build with this >> commit[1] included, let's see whether configure picks up readline >> installed from brew instead of the obsolete one

Re: [libvirt] [RFC PATCH 04/10] qemu: Introduce virTheadPoolDrain

On Wed, Jan 10, 2018 at 12:23:29PM -0500, John Ferlan wrote: > Split up virThreadPoolFree to create a Drain function which will > be called from virNetServerClose in order to ensure the various > worker threads are removed during the close rather than waiting > for the dispose function. > >

Re: [libvirt] [PATCH perl] Spelling fixes

On Mon, Jan 15, 2018 at 07:29:59PM +0200, Ville Skyttä wrote: > --- > Changes | 4 ++-- > HACKING | 4 ++-- > lib/Sys/Virt.pm | 6 +++--- > lib/Sys/Virt/Domain.pm | 14 +++--- > lib/Sys/Virt/Interface.pm | 2 +- >

[libvirt] [PATCH] libvirt-guests: make async stop work with transient guest domains

After being stopped, a transient guest domain doesn't appear in the list of guests anymore. Therefore, we can't get its state anymore. The branch handling this case displays an error message on stdout. This error message confuses the script which expects to get a list of "still up" guests. We just

Re: [libvirt] [PATCH perl] block_stats: Fix rd_req and wr_req compat hash keys

On Mon, Jan 15, 2018 at 07:50:10PM +0200, Ville Skyttä wrote: > When virDomainBlockStatsFlags with NULL params fails, the returned > read and write requests hash keys are said to be backwards compatible > with the key names success case. However, they were rd_reqs and > wr_reqs (in plural) as

[libvirt] [PATCH perl] block_stats: Fix rd_req and wr_req compat hash keys

When virDomainBlockStatsFlags with NULL params fails, the returned read and write requests hash keys are said to be backwards compatible with the key names success case. However, they were rd_reqs and wr_reqs (in plural) as opposed to the success case's rd_req and wr_req. There is also a similar

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

On 01/15/2018 05:39 PM, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 16:36 +0100, Michal Privoznik wrote: >>> So, one way to solve this once and for all would be to: >>> >>> * try looking up readline through pkg-config. If that works, >>> then we already know we're compiling against a

[libvirt] [PATCH v3 2/2] tests: Adding test case for virsh 'domrename' command.

This commit introduce the virsh-rename test script to test the 'domrename' command. The test contains one succedeed script to rename and another failed test. Signed-off-by: Julio Faracco --- tests/Makefile.am | 1 + tests/virsh-rename | 43

[libvirt] [PATCH v3 1/2] test: Implementing testDomainRename().

There is no method to rename inactive domains for test driver. After this patch, we can rename the domains using 'domrename'. virsh# domrename test anothertest Domain successfully renamed Signed-off-by: Julio Faracco --- src/test/test_driver.c | 84

[libvirt] [PATCH v3 0/2] Introducing testDomainRename().

This commit introduces the testDomainRename() for test driver. It includes: - testDomainRename() implementation. - Testcase script to test 'domrename' command. Julio Faracco (2): test: Implementing testDomainRename(). tests: Adding test case for virsh 'domrename' command.

[libvirt] [libvirt-tck] [PATCH] Add new option for virt-builder

>From 0cbe381e782a18cfa9730e8791a80ff01497d8fc Mon Sep 17 00:00:00 2001 From: Dan Zheng Date: Tue, 16 Jan 2018 13:39:50 +0800 Subject: [PATCH] Add new option for virt-builder Using --selinux-relabel is required by Fedora and RHEL guests to ensure SELinux labels correctly in

[libvirt] [PATCH] check/add for mdev_types capability

>From be62ea5394d52fa168079edc3aa7e558363a3026 Mon Sep 17 00:00:00 2001 From: Dan Zheng Date: Tue, 16 Jan 2018 12:21:21 +0800 Subject: [PATCH] nodedev: check/add for mdev_types capability This is similar to commit f44ec9c1. Commit id '500cbc06' introduced a new nested

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

On Mon, 2018-01-15 at 13:31 +0100, Michal Privoznik wrote: > > So, one way to solve this once and for all would be to: > > > > * try looking up readline through pkg-config. If that works, > > then we already know we're compiling against a recent > > readline version and everything will

[libvirt] [jenkins-ci PATCH] guests: Enable readline compat on FreeBSD CURRENT

FreeBSD 10 is the only version *not* to need the compat hack, so special-case it instead of the other way around. Signed-off-by: Andrea Bolognani --- guests/tasks/compat.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/guests/tasks/compat.yml

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

On Mon, Jan 15, 2018 at 02:20:01PM +0100, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 13:31 +0100, Michal Privoznik wrote: > > > So, one way to solve this once and for all would be to: > > > > > > * try looking up readline through pkg-config. If that works, > > > then we already know

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

CCing libvirt developers. On Mon, Jan 15, 2018 at 10:33:35AM +0100, Paolo Bonzini wrote: > On 15/01/2018 08:19, Kang, Luwei wrote: > >> If you are forwarding host info directly to the guest, the feature > >> is not migration-safe. The new feature needs to be added to > >>

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

On Sun, 2018-01-14 at 14:46 +0100, Michal Privoznik wrote: > Apparently we can't assume that people run readline recent enough > to have rl_completion_quote_character (added in readline-5.0 > released in 2011). However, we can't compile without it. So if > not present, disable readline. > >

Re: [libvirt] [PATCH v2] virsh: fix build without readline

On Sat, Jan 13, 2018 at 06:46:00PM +0400, Roman Bogorodskiy wrote: > Completion in virsh is enabled when readline is available. In order to > fix build when it's not available, do the following: > > * Unconditionally add virsh-completer.[ch] and >virt-admin-completer.[ch] to the build, and

Re: [libvirt] [jenkins-ci PATCH] guests: Install libtirpc when building libvirt

On Mon, Jan 15, 2018 at 09:12:18AM +0100, Andrea Bolognani wrote: > Recent glibc versions don't include an RPC library anymore, so > we need to make sure an alternative implementation is available > for libvirt to use. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [PATCH v2] virsh: fix build without readline

Erik Skultety wrote: > On Sat, Jan 13, 2018 at 06:46:00PM +0400, Roman Bogorodskiy wrote: > > Completion in virsh is enabled when readline is available. In order to > > fix build when it's not available, do the following: > > > > * Unconditionally add virsh-completer.[ch] and > >

Re: [libvirt] [PATCH] vshReadlineOptionsPrune: Fix possible leak

On 01/12/2018 10:07 PM, John Ferlan wrote: > > > On 01/12/2018 11:08 AM, Michal Privoznik wrote: >> The function should prune list of --options so that options >> already specified are not offered to user for completion again. >> However, if the list of offered options contains a string that >>

[libvirt] [PATCH] vshReadlineOptionsGenerator: Don't add already specified options to the list

The current state of art is as follows: 1) vshReadlineOptionsGenerator() generate all possible --options for given command, and then 2) vshReadlineOptionsPrune() clears out already provided ones from the list. Not only this brings needless memory complexity it is also not trivial to get

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

On 01/15/2018 12:30 PM, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 10:26 +0100, Andrea Bolognani wrote: >> macOS has brew, though. I've kicked off a Travis build with this >> commit[1] included, let's see whether configure picks up readline >> installed from brew instead of the obsolete one

Re: [libvirt] [PATCH 1/3] vsh: Mark cmdComplete arguments as unused

On Sun, Jan 14, 2018 at 02:46:43PM +0100, Michal Privoznik wrote: > When building without readline, this function does nothing but > return false. Without touching any of its arguments. Therefore, > we have to mark them as unused even though they might be used > when building with readline

Re: [libvirt] [PATCH 2/3] tools: Always compile {virsh, virt-admin}-completer.c

On Sun, Jan 14, 2018 at 02:46:44PM +0100, Michal Privoznik wrote: > The functions defined in these sources are referenced all over > the place, however, compiler only when building with readline. > Thus when building without it linker gets sad as it can't find > them. > > Signed-off-by: Michal

[libvirt] [jenkins-ci PATCH] guests: Install libtirpc when building libvirt

Recent glibc versions don't include an RPC library anymore, so we need to make sure an alternative implementation is available for libvirt to use. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 4 guests/vars/projects/libvirt.yml | 1 + 2 files

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

On Mon, 2018-01-15 at 10:26 +0100, Andrea Bolognani wrote: > macOS has brew, though. I've kicked off a Travis build with this > commit[1] included, let's see whether configure picks up readline > installed from brew instead of the obsolete one available in the > base system. Nope, it still picks