[libvirt] [PATCH] qemu: qemuDomainNamespaceUnlinkPaths: Return 0 in case of success

Commit 7a931a4204af refactored the code and probably forgot to add this line. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH 00/17] CPU models and features for Spectre, CVE-2017-5715

On Wed, Jan 10, 2018 at 10:52:29 +0100, Pavel Hrdina wrote: > On Tue, Jan 09, 2018 at 11:45:13PM +0100, Jiri Denemark wrote: > > This is the libvirt's part of the changes related to CVE-2017-5715. The > > new models can be used to pass the protective CPU features to guests. > > But remember, the

Re: [libvirt] [PATCH] remove bogus casts of arg to g_object_ref

On Wed, Jan 17, 2018 at 02:43:17PM +, Daniel P. Berrange wrote: > Latest version of glib uses typeof() magic to cast the > return value of g_object_ref to match its argument, > instead of returning a 'void *'. A few places in the > code were casting the arg to G_OBJECT() which was then >

Re: [libvirt] [PATCH libvirt] qemu: Fix segmentation fault when attaching a non iSCSI host device

On Wed, Jan 17, 2018 at 02:39 PM +0100, John Ferlan wrote: > On 01/17/2018 07:26 AM, Marc Hartmayer wrote: >> Add a check if it's a iSCSI hostdev and if it's not then don't use the >> union member 'iscsi'. The segmentation fault occured when accessing >> secinfo->type, but

[libvirt] [PATCH] apparmor: allow libvirt to send term signal to unconfined

Otherwise stopping domains with qemu://session fails like [164012.338157] audit: type=1400 audit(1516202208.784:99): apparmor="DENIED" operation="signal" profile="/usr/sbin/libvirtd" pid=18835 comm="libvirtd" requested_mask="send" denied_mask="send" signal=term peer="unconfined" ---

[libvirt] [PATCH] news: Update for 4.0.0

As usual, a bunch of changes slipped through the cracks during the development cycle. Update the release notes to include at least the most notable. Signed-off-by: Andrea Bolognani --- I'll push this tomorrow morning under the "can't possibly be worse than leaving it alone"

Re: [libvirt] [PATCH] qemu: avoid denial of service reading from QEMU monitor (CVE-2018-xxxx)

On 01/16/2018 06:01 PM, Daniel P. Berrange wrote: > We read from QEMU until seeing a \r\n pair to indicate a completed reply > or event. To avoid memory denial-of-service though, we must have a size > limit on amount of data we buffer. 10 MB is large enough that it ought > to cope with normal QEMU

Re: [libvirt] [PATCH] qemu: qemuDomainNamespaceUnlinkPaths: Return 0 in case of success

On 01/17/2018 04:47 PM, Marc Hartmayer wrote: > Commit 7a931a4204af refactored the code and probably forgot to add > this line. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- > src/qemu/qemu_domain.c | 2 +- > 1

Re: [libvirt] [PATCH] news: Update for 4.0.0

On 01/17/2018 05:01 PM, Andrea Bolognani wrote: > As usual, a bunch of changes slipped through the cracks during the > development cycle. Update the release notes to include at least the > most notable. > > Signed-off-by: Andrea Bolognani > --- > I'll push this tomorrow

Re: [libvirt] [PATCH] qemu: avoid denial of service reading from QEMU monitor (CVE-2018-xxxx)

On Wed, Jan 17, 2018 at 05:13:06PM +0100, Michal Privoznik wrote: > On 01/16/2018 06:01 PM, Daniel P. Berrange wrote: > > We read from QEMU until seeing a \r\n pair to indicate a completed reply > > or event. To avoid memory denial-of-service though, we must have a size > > limit on amount of data

Re: [libvirt] [PATCH] news: Update for 4.0.0

On Wed, 2018-01-17 at 17:12 +0100, Michal Privoznik wrote: > On 01/17/2018 05:01 PM, Andrea Bolognani wrote: > > > > > > + > > + > > + tools: Provide bash completion support > > + > > + > > + Both virsh and virt-admin now implement > > +

Re: [libvirt] [PATCH] qemu: avoid denial of service reading from QEMU monitor (CVE-2018-xxxx)

On 01/17/2018 10:13 AM, Michal Privoznik wrote: > On 01/16/2018 06:01 PM, Daniel P. Berrange wrote: >> We read from QEMU until seeing a \r\n pair to indicate a completed reply >> or event. To avoid memory denial-of-service though, we must have a size >> limit on amount of data we buffer. 10 MB is

[libvirt] [PATCH] remove bogus casts of arg to g_object_ref

Latest version of glib uses typeof() magic to cast the return value of g_object_ref to match its argument, instead of returning a 'void *'. A few places in the code were casting the arg to G_OBJECT() which was then incompatible with the variable we assigned the result to. The parameter casts were

Re: [libvirt] [PATCH] news: Update for 4.0.0

On 01/17/2018 05:19 PM, Andrea Bolognani wrote: > On Wed, 2018-01-17 at 17:12 +0100, Michal Privoznik wrote: >> On 01/17/2018 05:01 PM, Andrea Bolognani wrote: >>> >>> >>> + >>> + >>> + tools: Provide bash completion support >>> + >>> + >>> +

Re: [libvirt] [PATCH] AppArmor: Allow libvirtd to kill unconfined processes

Hi, On Mon, Jan 15, 2018 at 07:43:56AM +0100, intrigeri wrote: > Christian Ehrhardt: > > I recently had spotted this issue and discussed on IRC but couldn't > > recreate after a while when I wanted to debug. > > I've seen it the last few times I've started libvirtd.service on two > different

Re: [libvirt] [PATCH 01/17] cpu: add CPU features for indirect branch prediction protection

On 01/09/2018 04:45 PM, Jiri Denemark wrote: > From: Paolo Bonzini > > Added in QEMU commits TBD and TBD. I'm assuming the TBD will be resolved before you push? > > Signed-off-by: Paolo Bonzini > Signed-off-by: Jiri Denemark >

[libvirt] [PATCH v2 0/2] Support SMBIOS OEM strings

A followup to https://www.redhat.com/archives/libvir-list/2017-November/msg00720.html The QEMU patch is now merged (for next 2.12 release). Since v2: - Remove redundant error message report - Split QEMU from XML parts of patch Daniel P. Berrange (2): conf: add support for setting OEM

[libvirt] [PATCH v2 1/2] conf: add support for setting OEM strings SMBIOS data fields

The OEM strings table in SMBIOS allows the vendor to pass arbitrary strings into the guest OS. This can be used as a way to pass data to an application like cloud-init, or potentially as an alternative to the kernel command line for OS installers where you can't modify the install ISO image to

Re: [libvirt] [PATCH V2] nodedev: Fix failing to parse PCI address for non-PCI network devices

On 01/09/2018 04:35 AM, Erik Skultety wrote: On Mon, Jan 08, 2018 at 10:08:59AM -0700, Jim Fehlig wrote: Based loosely on a patch from Fei Li . Commit 8708ca01c added virNetDevSwitchdevFeature() to check if a network device has Switchdev capabilities. virNetDevSwitchdevFeature()

[libvirt] [PATCH V3] nodedev: Fix failing to parse PCI address for non-PCI network devices

Commit 8708ca01c added virNetDevSwitchdevFeature() to check if a network device has Switchdev capabilities. virNetDevSwitchdevFeature() attempts to retrieve the PCI device associated with the network device, ignoring non-PCI devices. It does so via the following call chain

[libvirt] Availability of libvirt-4.0.0 Release Candidate 2

I'm late but it is now tagged in git and signed tarball and rpms are pushed to the usual place: ftp://libvirt.org/libvirt/ This seems to work fine for me, I think I heard that the issue on MacOS is fixed, so with a bit of luck we can get through and make the release. If everything

Re: [libvirt] [PATCH] spec: enable bash completion only on new enough distros

On Wed, Jan 17, 2018 at 10:40:19AM +0100, Pavel Hrdina wrote: > RHEL-6 doesn't have bash-completion package by default, it has to be > installed from EPEL. > > Signed-off-by: Pavel Hrdina > --- > libvirt.spec.in | 10 ++ > 1 file changed, 10 insertions(+)

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

> > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > CCing libvirt developers. > > > > ... > > > > > This case is slightly more problematic, however: the new feature > > > > > is actually migratable (under very controlled circumstances) > > > > > because of patch 2/2,

[libvirt] [PATCH] spec: enable bash completion only on new enough distros

RHEL-6 doesn't have bash-completion package by default, it has to be installed from EPEL. Signed-off-by: Pavel Hrdina --- libvirt.spec.in | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index d4ef116b2d..ef96888d09 100644 ---

Re: [libvirt] [jenkins-ci PATCH] guests: install bash-completion when building libvirt

On Wed, Jan 17, 2018 at 10:42:41AM +0100, Pavel Hrdina wrote: > Libvirt recently added bash-completion support. On CentOS6 the > package is available only from EPEL repositories. > > Signed-off-by: Pavel Hrdina > --- > guests/vars/mappings.yml | 4 >

Re: [libvirt] [PATCH] docs: formatdomain: Document the CPU feature 'name' attribute

On Tue, Jan 16, 2018 at 03:35:20PM -0200, Eduardo Habkost wrote: > On Fri, Jan 12, 2018 at 08:31:16PM +0100, Kashyap Chamarthy wrote: > > Currently, the CPU feature 'name' XML attribute, as in: [...] > > --- > > docs/formatdomain.html.in | 17 + > > 1 file changed, 17

[libvirt] [PATCHv4 RESEND] vhost-user: add support reconnect for vhost-user ports

For vhost-user ports, Open vSwitch acts as the server and QEMU the client. When OVS crashes or restarts, the QEMU process should be reconnected to OVS. Signed-off-by: ZhiPeng Lu Signed-off-by: Michal Privoznik --- v1->v2: - modify xml format v2->v3:

Re: [libvirt] [RFC PATCH 03/10] netserver: Toggle service off during close

On 01/15/2018 11:35 AM, Erik Skultety wrote: > On Wed, Jan 10, 2018 at 12:23:28PM -0500, John Ferlan wrote: >> Rather than waiting until virNetServerDispose to toggle the service >> to off, let's do that when virNetServerServiceClose is called such >> as during virNetServerClose. >> >>

Re: [libvirt] [RFC PATCH 04/10] qemu: Introduce virTheadPoolDrain

On 01/15/2018 11:57 AM, Daniel P. Berrange wrote: > On Mon, Jan 15, 2018 at 05:51:28PM +0100, Erik Skultety wrote: >> On Wed, Jan 10, 2018 at 12:23:29PM -0500, John Ferlan wrote: >>> Split up virThreadPoolFree to create a Drain function which will >>> be called from virNetServerClose in order to

Re: [libvirt] [RFC PATCH 06/10] qemu: implement state driver shutdown function

On 01/10/2018 01:05 PM, Daniel P. Berrange wrote: > On Wed, Jan 10, 2018 at 12:23:31PM -0500, John Ferlan wrote: >> From: Nikolay Shirokovskiy >> >> Shutdown function should help API calls to finish when >> event loop is not running anymore. For this reason let's >>

Re: [libvirt] [PATCH libvirt] qemu: Fix segmentation fault when attaching a non iSCSI host device

On 01/17/2018 07:26 AM, Marc Hartmayer wrote: > Add a check if it's a iSCSI hostdev and if it's not then don't use the > union member 'iscsi'. The segmentation fault occured when accessing > secinfo->type, but this can vary from case to case. > > Signed-off-by: Marc Hartmayer

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

Hello John, I have questions: >>This and the Parse makes no sense when compared to the 3 possible options. That is, it's possible to have "tcp", "rdma", and "iser", but you only care about "iser". This is because for other types are optional, there was no this line here, therefor I added this

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Wed, Jan 17, 2018 at 10:32:56AM +, Kang, Luwei wrote: > > > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > > CCing libvirt developers. > > > > > ... > > > > > > This case is slightly more problematic, however: the new feature > > > > > > is actually migratable

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

> > > > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > > > CCing libvirt developers. > > > > > > ... > > > > > > > This case is slightly more problematic, however: the new > > > > > > > feature is actually migratable (under very controlled > > > > > > > circumstances)

[libvirt] [PATCH v2 2/2] qemu: add support for generating SMBIOS OEM strings command line

This wires up the previously added OEM strings XML schema to be able to generate comamnd line args for QEMU. This requires QEMU >= 2.12 release containing this patch: commit 2d6dcbf93fb01b4a7f45a93d276d4d74b16392dd Author: Daniel P. Berrange Date: Sat Oct 28 21:51:36

Re: [libvirt] [PATCH 2/3] nodedev: update mdev_types caps before dumpxml

Would you push this two patches before release of 4.0.0? Thanks, Zongyong Wu > -Original Message- > From: Erik Skultety [mailto:eskul...@redhat.com] > Sent: Thursday, January 11, 2018 6:07 PM > To: Wuzongyong (Euler Dept) > Cc: libvir-list@redhat.com; weijinfen

[libvirt] [PATCH libvirt] qemu: Fix segmentation fault when attaching a non iSCSI host device

Add a check if it's a iSCSI hostdev and if it's not then don't use the union member 'iscsi'. The segmentation fault occured when accessing secinfo->type, but this can vary from case to case. Signed-off-by: Marc Hartmayer Reviewed-by: Bjoern Walk

[libvirt] [jenkins-ci PATCH] guests: install bash-completion when building libvirt

Libvirt recently added bash-completion support. On CentOS6 the package is available only from EPEL repositories. Signed-off-by: Pavel Hrdina --- guests/vars/mappings.yml | 4 guests/vars/projects/libvirt.yml | 1 + 2 files changed, 5 insertions(+) diff --git

Re: [libvirt] [PATCH] rpm: updates wrt min required fedora version

On Thu, 2018-01-11 at 16:31 +, Daniel P. Berrange wrote: > Update the min fedora to 25. Use a macro to record the min versions so that > the > later error message is always in sync with the earlier version check. Clarify > the comment that refers to guessing of dist which does not actually

[libvirt] New GIT repos for libvirt wiki & virt tools planet

Hi Folks, Just let you all know that I've moved various libvirt related websites over to hosting on Red Hat's OpenShift v3 infrastructure. With the new v3 that is based on Kubernetes, I'm able to publish the GIT repos containing the core content & software setup. For wiki.libvirt.org: