Re: [libvirt] [PATCH 1/2] libxl: drop support for Xen < 4.6

On Tue, Mar 27, 2018 at 04:31:29PM -0600, Jim Fehlig wrote: > Currently the libxl driver claims support for Xen >= 4.4, but > Xen 4.4 and 4.5 are no longer supported upstream. Let's increase > the minimum supported version to 4.6. Generally libvirt would keep supporting things even if upstream

Re: [libvirt] [PATCH 3/4] qemu: hotplug: Introduce hot unplug for mediated devices

On Tue, Mar 27, 2018 at 11:41:45AM +0200, Peter Krempa wrote: > On Tue, Mar 27, 2018 at 10:57:15 +0200, Erik Skultety wrote: > > Mediated devices support hot-{plug,unplug} since their introduction in > > kernel 4.10, however this feature has been missing in libvirt since > > commit ec783d7c

Re: [libvirt] RFC: Extending UEFI XML specification

On Wed, Mar 28, 2018 at 16:15:50 +0530, Prerna wrote: > Hi Michal, > The , tags of os element in domain XML ( > https://libvirt.org/formatdomain.html#elementsOSBIOS) currently expects > absolute path of the local file which would be used to back the the pflash > disk representing the non-volatile

Re: [libvirt] [PATCH 3/4] qemu: hotplug: Introduce hot unplug for mediated devices

On Wed, Mar 28, 2018 at 11:47:47 +0200, Erik Skultety wrote: > On Tue, Mar 27, 2018 at 11:41:45AM +0200, Peter Krempa wrote: > > On Tue, Mar 27, 2018 at 10:57:15 +0200, Erik Skultety wrote: > > > Mediated devices support hot-{plug,unplug} since their introduction in > > > kernel 4.10, however this

Re: [libvirt] [jenkins-ci PATCH] Revert "local"

On Wed, 2018-03-28 at 10:53 +0200, Peter Krempa wrote: > > I've changed my setup to generate S-o-bs at format-patch time > > rather than commit time, so hopefully this won't happen again. > > And does that add the S-o-b to your local commits too? If it only > signs-off the formatted mails, it's

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

Hi Marc, Currently the block job handling needs to be sorted out before events can assume independent handling from RPC contexts. Sorry, I have not been able to revisit this in the past 2 months, but this is something I would very much like to fix. I will try looking up the exact dependency of the

Re: [libvirt] [jenkins-ci PATCH] Revert "local"

On Wed, Mar 28, 2018 at 10:42:51AM +0200, Andrea Bolognani wrote: > On Tue, 2018-03-27 at 20:48 +0200, Peter Krempa wrote: > > On Tue, Mar 27, 2018 at 18:19:43 +0200, Andrea Bolognani wrote: > > > This reverts commit c190e17fb8f689a0591dedded33d10cecafe3e20. > > > > > > As the original commit

Re: [libvirt] [PATCH 1/4] qemu: hotplug: Provide a string of a subsystem type instead of an int

On Tue, Mar 27, 2018 at 02:46:49PM +0100, Daniel P. Berrangé wrote: > On Tue, Mar 27, 2018 at 03:42:08PM +0200, Erik Skultety wrote: > > On Tue, Mar 27, 2018 at 10:24:54AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Mar 27, 2018 at 11:17:51AM +0200, Peter Krempa wrote: > > > > On Tue, Mar 27,

Re: [libvirt] [jenkins-ci PATCH] Revert "local"

On Tue, 2018-03-27 at 20:48 +0200, Peter Krempa wrote: > On Tue, Mar 27, 2018 at 18:19:43 +0200, Andrea Bolognani wrote: > > This reverts commit c190e17fb8f689a0591dedded33d10cecafe3e20. > > > > As the original commit message so eloquently explains, the > > diff contains the tweaks I need for my

Re: [libvirt] [jenkins-ci PATCH] Revert "local"

On Wed, Mar 28, 2018 at 10:42:51 +0200, Andrea Bolognani wrote: > On Tue, 2018-03-27 at 20:48 +0200, Peter Krempa wrote: > > On Tue, Mar 27, 2018 at 18:19:43 +0200, Andrea Bolognani wrote: > > > This reverts commit c190e17fb8f689a0591dedded33d10cecafe3e20. > > > > > > As the original commit

Re: [libvirt] [dbus PATCH] domain: remove G_GNUC_UNUSED for used attributes

On Tue, Mar 27, 2018 at 06:30:19PM +0200, Ján Tomko wrote: > A few functions use the G_GNUC_UNUSED marker for objectPath, > even though it's passed to virtDBusDomainGetVirDomain later. > > Signed-off-by: Ján Tomko > --- > Also passes the build with clang 5.0.1, once that lock

Re: [libvirt] [PATCH v2 2/3] qemu: Handle device mapper targets properly

On 03/27/2018 08:56 PM, Peter Krempa wrote: > On Mon, Mar 26, 2018 at 17:22:01 +0200, Michal Privoznik wrote: >> On 03/26/2018 05:17 PM, Peter Krempa wrote: >>> On Mon, Mar 26, 2018 at 16:43:02 +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1557769

[libvirt] [PATCH 1/4] vmx: check for present/enabled devices earlier

When parsing filesystems, network interfaces, serial ports, and parallel ports, check earlier whether they are present/enabled, delaying the allocation of the objects. This is mostly a small optimization, with no behaviour change. Signed-off-by: Pino Toscano ---

[libvirt] [PATCH 4/4] vmx: convert any amount of NICs

Scan the parsed VMX file, and gather the biggest index of the network interfaces there: this way, it is possible to parse all the available network interfaces, instead of just 4 maximum. Add the VMX file attached to RHBZ#1560917 as testcase esx-in-the-wild-8.

[libvirt] [PATCH 3/4] internal: add STRCASEPREFIX

Simple macro to check the prefix of a string in a case-insensitive way. Signed-off-by: Pino Toscano --- src/internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/internal.h b/src/internal.h index 589503041..1760e3b69 100644 --- a/src/internal.h +++

Re: [libvirt] RFC: Extending UEFI XML specification

On Wed, Mar 28, 2018 at 4:41 PM, Peter Krempa wrote: > On Wed, Mar 28, 2018 at 16:15:50 +0530, Prerna wrote: > > Hi Michal, > > The , tags of os element in domain XML ( > > https://libvirt.org/formatdomain.html#elementsOSBIOS) currently expects > > absolute path of the local

Re: [libvirt] RFC: Extending UEFI XML specification

On Wed, Mar 28, 2018 at 17:55:59 +0530, Prerna wrote: > On Wed, Mar 28, 2018 at 4:41 PM, Peter Krempa wrote: > > On Wed, Mar 28, 2018 at 16:15:50 +0530, Prerna wrote: [...] > > > > > > > > > > > > > > > > > > > In addition to this we should also support

[libvirt] [PATCH v2 0/3] Introduce hot plug support for mediated devices

Libvirt shouldn't forbid the operation as unsupported. In fact, from VFIO point of view, mdevs have supported hot plug since the beginning. Then it's up to the 3rd party vendor driver whether it can cope with this feature reliably or not. Since v1 [1]: - dropped the original patch 1 as that

[libvirt] [PATCH 0/4] vmx: allow more than 4 NICs (RHBZ#1560917)

Hi, the VMX parser, used in the esx driver, has currently hardcoded 4 NICs possible, ignoring extra more than that. The following series removes this limitation, allowing to parse all the 10 NICs in the VMX of RHBZ#1560917. Thanks, Pino Toscano (4): vmx: check for present/enabled devices

[libvirt] [PATCH 2/4] vmx: allocate space for network interfaces if needed

Dynamically grow the array of network interfaces for each interface read, instead of using a single array of size 4. This way, in the future it will be easier to not limit the number of network interfaces (which this patch still does not change). Signed-off-by: Pino Toscano

[libvirt] [PATCH v2 1/3] qemu: hotplug: Introduce hot plug support for mediated devices

Mediated devices support hot-{plug,unplug} since their introduction in kernel 4.10, however libvirt has still been missing support for this. Signed-off-by: Erik Skultety --- src/qemu/qemu_hotplug.c | 86 + 1 file changed, 86

[libvirt] [PATCH v2 2/3] qemu: hotplug: Introduce hot unplug for mediated devices

Mediated devices support hot-{plug,unplug} since their introduction in kernel 4.10, however libvirt has still been missing support for this. Signed-off-by: Erik Skultety --- src/qemu/qemu_hotplug.c | 47 +++ 1 file changed, 47

[libvirt] [PATCH v2 3/3] news: Update release news with mediated devices hot {plug, unplug}

Signed-off-by: Erik Skultety --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 108889574..5f41208c2 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -92,6 +92,16 @@ previously started domains to

Re: [libvirt] [PATCH v2 0/3] Introduce hot plug support for mediated devices

On Wed, Mar 28, 2018 at 15:02:33 +0200, Erik Skultety wrote: > Libvirt shouldn't forbid the operation as unsupported. In fact, from VFIO > point > of view, mdevs have supported hot plug since the beginning. Then it's up to > the > 3rd party vendor driver whether it can cope with this feature

Re: [libvirt] [PATCH 1/2] libxl: drop support for Xen < 4.6

On Wed, Mar 28, 2018 at 10:03:51AM +0100, Daniel P. Berrangé wrote: > On Tue, Mar 27, 2018 at 04:31:29PM -0600, Jim Fehlig wrote: > > Currently the libxl driver claims support for Xen >= 4.4, but > > Xen 4.4 and 4.5 are no longer supported upstream. Let's increase > > the minimum supported version

Re: [libvirt] [PATCH v2 0/3] Introduce hot plug support for mediated devices

On Wed, Mar 28, 2018 at 03:13:02PM +0200, Peter Krempa wrote: > On Wed, Mar 28, 2018 at 15:02:33 +0200, Erik Skultety wrote: > > Libvirt shouldn't forbid the operation as unsupported. In fact, from VFIO > > point > > of view, mdevs have supported hot plug since the beginning. Then it's up to > >

Re: [libvirt] [PATCH 0/4] vmx: allow more than 4 NICs (RHBZ#1560917)

On Wed, Mar 28, 2018 at 01:40:17PM +0200, Pino Toscano wrote: Hi, the VMX parser, used in the esx driver, has currently hardcoded 4 NICs possible, ignoring extra more than that. The following series removes this limitation, allowing to parse all the 10 NICs in the VMX of RHBZ#1560917. Thanks,

Re: [libvirt] [PATCH] snip my name and email

On Wed, Mar 28, 2018 at 7:52 PM, Daniel P. Berrangé wrote: > On Wed, Mar 28, 2018 at 07:49:09PM +0300, David Kiarie wrote: > > On Wed, Mar 28, 2018 at 7:46 PM, David Kiarie > > wrote: > > > > > > > > > > > On Wed, Mar 28, 2018 at 7:43 PM, Daniel P.

Re: [libvirt] [PATCH v6.1 2/9] libxl: pass driver config to libxlMakeDomBuildInfo

On 03/27/2018 05:55 PM, Marek Marczykowski-Górecki wrote: Preparation for global nestedhvm configuration - libxlMakeDomBuildInfo needs access to libxlDriverConfig. No functional change. Adjusting tests require slightly more mockup functions, because of libxlDriverConfigNew() call.

Re: [libvirt] [PATCH] snip my name and email

On Wed, Mar 28, 2018 at 07:49:09PM +0300, David Kiarie wrote: > On Wed, Mar 28, 2018 at 7:46 PM, David Kiarie > wrote: > > > > > > > On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé > > wrote: > > > >> On Wed, Mar 28, 2018 at 07:33:11PM +0300,

[libvirt] [PATCH 7/8] Remove qemuDomainSupportsNetdev

Now that we assume QEMU_CAPS_NETDEV, the only thing left to check is whether we need to use the legacy -net syntax because of a non-conforming armchitecture. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 20 +--- src/qemu/qemu_domain.c| 10

[libvirt] [PATCH 1/8] virQEMUCapsParseHelpStr: remove unused check_yajl parameter

Commit 6e769eba in Jan 2012 added an error message when using qemu 0.15 and newer with libvirt without JSON support. However commit 3399875 (July 2012) added the 'check_yajl' parameter to perform this check only on domain startup and commit 15ee6614 in Sep 2012 removed this last caller passing

[libvirt] [PATCH 2/7] tests: move sexpr2xml tests to WITH_LIBXL

In preparation of removing the legacy Xen driver, move the sexpr2xml tests from WITH_XEN to WITH_LIBXL. Even though the legacy driver will be removed, we'll want to maintain the ability to convert sexpr to XML. Requires fixing up the tests to account for different behavior of Xen vs libxl post

[libvirt] [PATCH 3/7] tests: move xmconfig tests to WITH_LIBXL

In preparation of removing the legacy Xen driver, move the xmconfig tests from WITH_XEN to WITH_LIBXL. Even though the legacy driver will be removed, we'll want to maintain the ability to convert xm config to XML. Requires fixing up the tests to account for different behavior of Xen vs libxl post

[libvirt] [PATCH 4/7] Remove xencaps tests and data files

Signed-off-by: Jim Fehlig --- tests/Makefile.am | 20 --- tests/testutilsxen.c | 64 - tests/testutilsxen.h | 2 - tests/vircapstest.c| 34 -

[libvirt] [PATCH 1/7] tests: move xml2sexpr tests to WITH_LIBXL

In preparation of removing the legacy Xen driver, move the xml2sexpr tests from WITH_XEN to WITH_LIBXL. Even though the legacy driver will be removed, we'll want to maintain the ability to convert sexpr <-> XML. There is some test file fallout due to differences in handling of default values

[libvirt] [PATCH 6/7] docs: remove mention of legacy Xen driver

Signed-off-by: Jim Fehlig --- docs/architecture.html.in | 28 -- docs/bugs.html.in | 3 +- docs/uri.html.in | 74 --- docs/windows.html.in | 2 +- 4 files changed, 9 insertions(+), 98

[libvirt] [PATCH 7/7] spec: remove legacy xen driver

Signed-off-by: Jim Fehlig --- libvirt.spec.in | 57 - 1 file changed, 4 insertions(+), 53 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b55a947ec..dcfa50022 100644 --- a/libvirt.spec.in +++

[libvirt] [PATCH 0/7] Remove the legacy xen driver

Long overdue first cut at remove the old xen driver. The first 3 patches move existing tests to WITH_LIBXL since we'll want to continue supporting conversion of the various xen config formats. The remain patches remove the cruft. Jim Fehlig (7): tests: move xml2sexpr tests to WITH_LIBXL

[libvirt] [PATCH 2/8] Mandate QEMU >= 0.15.0

In Nov 2015 commit fc604c1 mandated at least QEMU 0.12.0, which was released in Dec 2009. Increase the requirement to 0.15.0 (Aug 2011), which was the first release that stopped promising HMP compatibility. This lets us assume every QEMU supports JSON monitor. Signed-off-by: Ján Tomko

[libvirt] [PATCH 6/8] Remove unused qemuDomainNetVLAN

Signed-off-by: Ján Tomko --- src/qemu/qemu_domain.c | 6 -- src/qemu/qemu_domain.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 6b22f9dc3..e4a8c45cf 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH 0/8] Move the minimum QEMU version closer to 1.3.0

1.3.0 was released in December 2012, it merged KVM and QEMU and is above our 1.2.0 requirement for QMP capability probing. Ján Tomko (8): virQEMUCapsParseHelpStr: remove unused check_yajl parameter Mandate QEMU >= 0.15.0 Deprecate QEMU_CAPS_PCI_MULTIFUNCTION Deprecate QEMU_CAPS_NETDEV

[libvirt] [PATCH 3/8] Deprecate QEMU_CAPS_PCI_MULTIFUNCTION

Supported since QEMU 0.13, but we require QEMU 0.15. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 -- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 15 --

[libvirt] [PATCH 5/8] Clean up qemuDomainAttachNetDevice

Now that we assume -netdev support, we no longer set the VLAN or need the hostPlugged bool. Signed-off-by: Ján Tomko --- src/qemu/qemu_hotplug.c | 42 +- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git

[libvirt] [PATCH 4/8] Deprecate QEMU_CAPS_NETDEV

This makes qemuDomainSupportsNetdev identical to qemuDomainSupportsNicdev and leaves some code in qemuDomainAttachNetDevice to be cleaned up later. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 13 +- src/qemu/qemu_capabilities.h

[libvirt] [PATCH v2 3/9] interface: Alter virInterfaceObjListRemove processing

Current processing requires a "fire dance" unlocking the @obj, adding an @obj ref, locking the @interfaces, and relocking @obj in order to ensure proper lock ordering. This can be avoided by changing virInterfaceObjListRemove to take @name instead of @obj. Then, we can lock the @interfaces list,

[libvirt] [PATCH v2 0/9] Be consistent with vir*Obj*Remove* APIs

v1: https://www.redhat.com/archives/libvir-list/2018-March/msg01295.html NB: This can wait until 4.2.0 is release, but I figured I'd post this now just to put it on the radar and of course in hopes that someone will look during the idle moment or two before the release. Changes since v1:

[libvirt] [PATCH v2 1/9] secret: Rework LoadAllConfigs

Move the virSecretObjEndAPI into virSecretLoad and alter the processing in order to accomodate that. Signed-off-by: John Ferlan --- src/conf/virsecretobj.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/src/conf/virsecretobj.c

[libvirt] [PATCH v2 4/9] nodedev: Alter virNodeDeviceObjListRemove processing

Current processing requires a "fire dance" unlocking the @obj, adding an @obj ref, locking the @devs, and relocking @obj in order to ensure proper proper lock ordering. This can be avoided by changing virNodeDeviceObjListRemove to take @name instead of @obj. Then, we can lock the @devs list, look

[libvirt] [PATCH v2 2/9] secret: Alter virSecretObjListRemove processing

Current processing requires a "fire dance" unlocking the @obj, adding an @obj ref, locking the @secrets, and relocking @obj in order to ensure proper lock ordering. This can be avoided by changing virSecretObjListRemove to take a @uuidstr instead of @obj. Then, we can lock the @secrets list, look

[libvirt] [PATCH v2 6/9] storage: Clean up storagePoolCreateXML error processing

Rather than 3 separate, but same 4 lines of code - let's create an error label to make a common error path. This will help shortly when the error path changes slightly. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 27 +++ 1 file

[libvirt] [PATCH v2 8/9] conf: Move virStoragePoolObjRemove closer to AssignDef

A subsequent patch will need to use the local FindByUUIDLocked, so rather than create a forward decl or move when needed, let's just do it now for ease of future review. Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 38 +++--- 1

[libvirt] [PATCH v2 5/9] conf: Clean up virStoragePoolObjLoad error processing

Use an error label to converge all the clean up processing options. Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/src/conf/virstorageobj.c

[libvirt] [PATCH v2 7/9] test: Clean up testStoragePoolCreateXML error processing

Rather than 2 separate, but same 4 lines of code - let's create an error label to make a common error path. This will help shortly when the error path changes slightly. Signed-off-by: John Ferlan --- src/test/test_driver.c | 22 ++ 1 file changed, 10

[libvirt] [PATCH v2 9/9] storagepool: Alter virStoragePoolObjRemove processing

Current processing requires a "fire dance" unlocking the @obj, adding an @obj ref, locking the @pools, and relocking @obj in order to ensure proper lock ordering. This can be avoided by changing virStoragePoolObjRemove to take a @name instead of @obj. Then, we can lock the @pools list, look up

[libvirt] [PATCH 5/9] Introduce JSON_CFLAGS and JSON_LIBS

Just copy YAJL_CFLAGS and YAJL_LIBS at this time. Signed-off-by: Ján Tomko --- m4/virt-json.m4 | 2 ++ src/Makefile.am | 8 src/util/Makefile.inc.am | 4 ++-- tests/Makefile.am| 2 +- 4 files changed, 9 insertions(+), 7 deletions(-) diff

[libvirt] [PATCH 4/9] Introduce WITH_JSON

A library-agnostic constant used by all the code that requires a working virjson implementation, but does not depent on yajl. The only remaining usage outside virjson.c is the empty array test in virmacmaptest.c. Signed-off-by: Ján Tomko --- m4/virt-json.m4|

[libvirt] [PATCH 6/9] virt-json.m4: generalize yajl dependency

The QEMU driver needs a JSON library, not necessarily yajl. Check for yajl first, then explicitly check if we found a JSON library, to allow use of a different one. Signed-off-by: Ján Tomko --- m4/virt-json.m4 | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-)

[libvirt] [PATCH 7/9] build: link setuid_rpc_client against JSON_LIBS

I have no idea how it builds without and switching to Jansson exposes this. Signed-off-by: Ján Tomko --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index fd09bfd17..2d2805818 100644 --- a/src/Makefile.am +++

[libvirt] [PATCH 8/9] virjson: add support for Jansson

Check for the presence of Jansson library and prefer it to yajl if possible. The minimum required version is 2.7. Internally, virJSONValue still stores numbers as strings even though Jansson uses numeric variables for them. The configure script is particularly hideous, but will hopefully go

[libvirt] [PATCH 3/9] configure: rename LIBVIRT_*_YAJL to LIBVIRT_*_JSON

Rename the top-level functions that deal with yajl to prepare for the possibility of a different JSON library. Introduce a separate JSON libraries section in the configure summary and rename the m4 file to virt-json.m4. Signed-off-by: Ján Tomko --- configure.ac

[libvirt] [PATCH 0/9] Add Jansson support

Prefer Jansson, but allow fallback/choice of yajl. Support for yajl can hopefully be dropped after we ditch CentOS 6 which has no Jansson. Ján Tomko (9): virmacmaptest: depend on yajl for 'empty' test virjsontest: Use a more stable floating point number for testing configure: rename

[libvirt] [PATCH 2/9] virjsontest: Use a more stable floating point number for testing

We store all JSON numbers as strings. To allow using json libraries that store them in numeric types, use a more predictable and normalized value. Signed-off-by: Ján Tomko --- tests/virjsontest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH 9/9] virt-json.m4: simplify QEMU check

If we build with QEMU, it very probably needs JSON. Signed-off-by: Ján Tomko --- m4/virt-json.m4 | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/m4/virt-json.m4 b/m4/virt-json.m4 index a5ae3edcd..d87cf56eb 100644 ---

[libvirt] [PATCH 1/9] virmacmaptest: depend on yajl for 'empty' test

While an empty array is formatted with two newlines with yajl, jansson does not put any newlines between the brackets. Signed-off-by: Ján Tomko --- tests/virmacmaptest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/virmacmaptest.c b/tests/virmacmaptest.c index

Re: [libvirt] virNetSocketNewListenTCP tries just one address

On Tue, Mar 27, Ján Tomko wrote: > It cannot, but the admin of the network should be able to control both. The admin must not control my (test) host, nor must I control the DNS server in the network. But there are likely cases where the admin for DNS and libvirtd is the same person. > How can

[libvirt] [PATCH 09/11] tests: Use pcie-to-pci-bridge for aarch64-traditional-pci

Now that support for the pcie-to-pci-bridge controller has been implemented, adding the QEMU_CAPS_DEVICE_PCIE_PCI_BRIDGE capability to the existing test is enough to cause the guest to use pcie-to-pci-bridge instead of dmi-to-pci-bridge. Signed-off-by: Andrea Bolognani ---

[libvirt] [PATCH 00/11] qemu: Implement pcie-to-pci-bridge controller

Patches 1-4 are cleanups and preparation. For more information, take a peek at patch 8's commit message, which also includes a link to the relevant Bugzilla entry. Andrea Bolognani (11): docs: Tweak PCI controller model documentation tests: Add aarch64-traditional-pci test conf: Remove

[libvirt] [PATCH 05/11] qemu: Add QEMU_CAPS_DEVICE_PCIE_PCI_BRIDGE

This capability will be set when the pcie-pci-bridge device is available in the QEMU binary. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 +

[libvirt] [PATCH 11/11] news: Update for pcie-to-pci-bridge support

Signed-off-by: Andrea Bolognani --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 20524bf537..f8b4584f70 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,15 @@ + + +

[libvirt] [PATCH 07/11] conf: Add virDomainPCIAddressSet.isPCIeToPCIBridgeSupported

Just like the existing areMultipleRootsSupported, this will allow us to change the results of the driver-agnostic PCI address allocation logic based on whether the QEMU binary supports certain features. Signed-off-by: Andrea Bolognani --- src/conf/domain_addr.h | 2

[libvirt] [PATCH 06/11] qemu: Implement pcie-to-pci-bridge controller

The new controller will not yet be used automatically by libvirt, but at this point it's already possible to configure a guest to use it. Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 3 ++- docs/schemas/domaincommon.rng | 3 +++

[libvirt] [PATCH 08/11] conf: Prefer pcie-to-pci-bridge to dmi-to-pci-bridge

Both pcie-to-pci-bridge and dmi-to-pci-bridge can be used to create a traditional PCI topology in a pure PCIe guest such as those using the x86_64/q35 or aarch64/virt machine type; however, the former should be preferred, as it doesn't need to obey limitation of real hardware and is completely

[libvirt] [PATCH 02/11] tests: Add aarch64-traditional-pci test

This test shows what happens when you add a traditional PCI device such as pci-serial to a pure PCIe machine type such as aarch64/virt. Signed-off-by: Andrea Bolognani --- .../qemuxml2argvdata/aarch64-traditional-pci.args | 26 +

[libvirt] [PATCH 01/11] docs: Tweak PCI controller model documentation

Instead of first listing the models on their own, and then listing them again grouped by the libvirt release they were introduced in, have a single list. Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 20 1 file changed, 8

[libvirt] [PATCH 03/11] conf: Remove dubious code from virDomainPCIAddressSetGrow()

I haven't been able to come up with a single scenario in which the code in question would be executed; even if there was one, it would be due to the user specifying a *partial* PCI topology in the guest XML, which is of course entirely unsupportable and thus providing even the slightest hint that

[libvirt] [PATCH 10/11] news: Add 4.3.0 release

Signed-off-by: Andrea Bolognani --- docs/news.xml | 8 1 file changed, 8 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 1088895746..20524bf537 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -33,6 +33,14 @@ --> + + + + +

[libvirt] [PATCH 04/11] conf: Rename virDomainPCIAddressSet.areMultipleRootsSupported

We're going to add a similarly-named attribute later, and we'd like to be consistent. Signed-off-by: Andrea Bolognani --- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 2 +- src/qemu/qemu_domain_address.c | 2 +- 3 files changed, 3 insertions(+), 3

Re: [libvirt] [PATCH 1/2] libxl: drop support for Xen < 4.6

On Wed, Mar 28, 2018 at 08:10:34AM -0600, Jim Fehlig wrote: > On 03/28/2018 07:28 AM, Daniel P. Berrangé wrote: > > On Wed, Mar 28, 2018 at 10:03:51AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Mar 27, 2018 at 04:31:29PM -0600, Jim Fehlig wrote: > > > > Currently the libxl driver claims

Re: [libvirt] [PATCH] snip my name and email

On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote: > I'd like to snip my name and email from these files Any particular reason why ? > --- > src/xenconfig/xen_xl.c | 1 - > src/xenconfig/xen_xl.h | 1 - > 2 files changed, 2 deletions(-) It is also mentioned in test/xlconfigtest.c.

Re: [libvirt] [PATCH 1/2] libxl: drop support for Xen < 4.6

On 03/28/2018 07:28 AM, Daniel P. Berrangé wrote: On Wed, Mar 28, 2018 at 10:03:51AM +0100, Daniel P. Berrangé wrote: On Tue, Mar 27, 2018 at 04:31:29PM -0600, Jim Fehlig wrote: Currently the libxl driver claims support for Xen >= 4.4, but Xen 4.4 and 4.5 are no longer supported upstream.

Re: [libvirt] [PATCH] snip my name and email

On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote: > On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé > wrote: > > > On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote: > > > I'd like to snip my name and email from these files > > > > Any particular

Re: [libvirt] [PATCH] snip my name and email

On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé wrote: > On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote: > > On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé > > > wrote: > > > > > On Mon, Mar 26, 2018 at 10:29:06AM +0300, David

Re: [libvirt] [PATCH] snip my name and email

On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé wrote: > On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote: > > I'd like to snip my name and email from these files > > Any particular reason why ? > > Yes, I do have a particular reason why but it's not very

Re: [libvirt] [PATCH] snip my name and email

On Wed, Mar 28, 2018 at 7:33 PM, David Kiarie wrote: > > > On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé > wrote: > >> On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote: >> > I'd like to snip my name and email from these files >> >>

Re: [libvirt] [PATCH] snip my name and email

On Wed, Mar 28, 2018 at 7:46 PM, David Kiarie wrote: > > > On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé > wrote: > >> On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote: >> > On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé < >>

[libvirt] RFC: Extending UEFI XML specification

Hi Michal, The , tags of os element in domain XML ( https://libvirt.org/formatdomain.html#elementsOSBIOS) currently expects absolute path of the local file which would be used to back the the pflash disk representing the non-volatile RAM: /usr/lib/xen/boot/hvmloader

[libvirt] [PATCH] remote: remove outdated comment about Solaris

When removing a conditional in: commit da1ade7a52e040192c5e9396c15ec9225a0a2c48 Author: Daniel P. Berrangé Date: Fri Mar 23 10:50:59 2018 + remote: remove some __sun conditionals the corresponding comment was mistakenly left behind. Signed-off-by: Daniel

[libvirt] [PATCH 1/7] rpc: refactor way connection object is generated for remote dispatch

Calling a push_privconn method to directly push the connection object name into the arg list is inconvenient. Refactor so that we acquire the connection variable name upfront, and push it to the arg list separately. This allows various hardcoded usage of "priv->conn" to be parameterized.

[libvirt] [PATCH 3/7] remote: use a separate connection for network APIs

Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 19 +++ src/rpc/gendispatch.pl | 6 ++ 3 files changed, 18 insertions(+), 8 deletions(-) diff --git

[libvirt] [PATCH 2/7] remote: use a separate connection for interface APIs

Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 4 src/rpc/gendispatch.pl | 25 - 3 files changed, 29 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH 6/7] remote: use a separate connection for secret APIs

Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 19 +++ src/rpc/gendispatch.pl | 6 ++ 3 files changed, 18 insertions(+), 8 deletions(-) diff --git

[libvirt] [PATCH 5/7] remote: use a separate connection for nwfilter APIs

Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 3 +++ src/rpc/gendispatch.pl | 6 ++ 3 files changed, 10 insertions(+) diff --git a/src/remote/remote_daemon.h

[libvirt] [PATCH 4/7] remote: use a separate connection for nodedev APIs

Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 19 +++ src/rpc/gendispatch.pl | 6 ++ 3 files changed, 18 insertions(+), 8 deletions(-) diff --git

[libvirt] [PATCH 0/7] Prepare for daemon split

When we split up the daemons, libvirtd will need to forward different sets of APIs to different daemons. This means libvirtd is going to need to have multiple virConnectPtr instances open. This series prepares for that by introducing "separate" connections, which are actually just an extra

[libvirt] [PATCH 7/7] remote: use a separate connection for storage APIs

Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 17 ++--- src/rpc/gendispatch.pl | 6 ++ 3 files changed, 17 insertions(+), 7 deletions(-) diff --git