[libvirt] [jenkins-ci PATCH] guests: Don't backup files when changing them

Since our entire guest state is fully reproducible, keeping backups around is not very useful; moreover, on CentOS 6 it results in us hitting https://github.com/ansible/ansible/issues/31982 Signed-off-by: Andrea Bolognani --- guests/tasks/bootloader.yml | 2 --

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Fri, 2018-05-25 at 10:04 +0200, Pavel Hrdina wrote: > On Fri, May 25, 2018 at 09:13:51AM +0200, Andrea Bolognani wrote: > > However, I realize it might not be possible to register free > > functions for a native type without having to introduce something > > like > > > > typedef char *

Re: [libvirt] [jenkins-ci PATCH] guests: Don't backup files when changing them

On Fri, May 25, 2018 at 11:16:24AM +0200, Andrea Bolognani wrote: > Since our entire guest state is fully reproducible, keeping > backups around is not very useful; moreover, on CentOS 6 it > results in us hitting > > https://github.com/ansible/ansible/issues/31982 > > Signed-off-by: Andrea

Re: [libvirt] [REPOSTv2 PATCH v3 0/6] Add support for VM Generation ID (vmgenid)

On 05/25/2018 07:39 AM, Michal Privoznik wrote: > On 05/25/2018 01:10 PM, John Ferlan wrote: >> >> >> On 05/25/2018 04:24 AM, Michal Privoznik wrote: >>> On 05/17/2018 02:42 PM, John Ferlan wrote: Second reposting of:

Re: [libvirt] [REPOSTv2 PATCH v3 4/6] qemu: Add VM Generation ID to qemu command line

On 05/25/2018 12:58 PM, John Ferlan wrote: > > > On 05/25/2018 04:24 AM, Michal Privoznik wrote: >> On 05/17/2018 02:42 PM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1149445 >>> >>> If the domain requests usage of the genid functionality, >>> then add the QEMU '-device

Re: [libvirt] [REPOSTv2 PATCH v3 0/6] Add support for VM Generation ID (vmgenid)

On 05/25/2018 01:10 PM, John Ferlan wrote: > > > On 05/25/2018 04:24 AM, Michal Privoznik wrote: >> On 05/17/2018 02:42 PM, John Ferlan wrote: >>> Second reposting of: >>> >>> https://www.redhat.com/archives/libvir-list/2018-May/msg00813.html >>> >>> To update patches with more conflicts for

Re: [libvirt] [REPOSTv2 PATCH v3 3/6] qemu: Alter VM Generation ID for specific startup/launch transitions

On 05/25/2018 12:58 PM, John Ferlan wrote: > > > On 05/25/2018 04:24 AM, Michal Privoznik wrote: >> On 05/17/2018 02:42 PM, John Ferlan wrote: >>> Before we generate the command line for qemu, if the domain about to >>> be launched desires to utilize the VM Generation ID functionality, then >>>

Re: [libvirt] [libvirt-users] virRandomBits - not very random

Reviving an ancient thread: On 11/04/2014 02:18 AM, Daniel P. Berrange wrote: On Mon, Nov 03, 2014 at 11:09:12AM -0500, Brian Rak wrote: I just ran into an issue where I had about 30 guests get duplicate mac addresses assigned. These were scattered across 30 different machines. Some

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Fri, 2018-05-25 at 10:46 +0200, Pavel Hrdina wrote: > On Fri, May 25, 2018 at 10:32:04AM +0200, Andrea Bolognani wrote: > > I'm probably missing something, but couldn't you just have > > > > #define VIR_AUTOFREE(type) __attribute__((cleanup(virFree))) type > > > > which you would then use

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Fri, 2018-05-25 at 10:08 +0200, Pavel Hrdina wrote: > On Fri, May 25, 2018 at 09:01:03AM +0200, Andrea Bolognani wrote: > > On Wed, 2018-05-23 at 18:23 +0200, Peter Krempa wrote: > > > On Wed, May 23, 2018 at 18:05:17 +0200, Pavel Hrdina wrote: > > > > [...] > > > > VIR_AUTOFREE char *str =

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Fri, May 25, 2018 at 10:32:04AM +0200, Andrea Bolognani wrote: > On Fri, 2018-05-25 at 10:08 +0200, Pavel Hrdina wrote: > > On Fri, May 25, 2018 at 09:01:03AM +0200, Andrea Bolognani wrote: > > > On Wed, 2018-05-23 at 18:23 +0200, Peter Krempa wrote: > > > > On Wed, May 23, 2018 at 18:05:17

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Fri, May 25, 2018 at 11:03:01AM +0200, Andrea Bolognani wrote: > On Fri, 2018-05-25 at 10:46 +0200, Pavel Hrdina wrote: > > On Fri, May 25, 2018 at 10:32:04AM +0200, Andrea Bolognani wrote: > > > I'm probably missing something, but couldn't you just have > > > > > > #define VIR_AUTOFREE(type)

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Fri, 2018-05-25 at 11:17 +0200, Erik Skultety wrote: > I also like the alternative approach Andrea mentioned, especially since you > can reuse it for structures using plain scalar types, e.g. a structure like > > typedef _virSomething virSomething; > typedef virSomething * virSomethingPtr; >

[libvirt] [PATCH 0/2] capabilities: Provide info about host IOMMU support

Provide information about host IOMMU support in capabilities XML. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=967231 Filip Alac (2): capabilities: Provide info about host IOMMU support docs: news: Add entry about iommu_support docs/news.xml| 8

Re: [libvirt] [REPOSTv2 PATCH v3 3/6] qemu: Alter VM Generation ID for specific startup/launch transitions

On 05/17/2018 02:42 PM, John Ferlan wrote: > Before we generate the command line for qemu, if the domain about to > be launched desires to utilize the VM Generation ID functionality, then > handle both the regenerating the GUID value for backup recovery (restore > operation) and the startup after

Re: [libvirt] [REPOSTv2 PATCH v3 1/6] conf: Add VM Generation ID parse/format support

On 05/25/2018 04:24 AM, Michal Privoznik wrote: > On 05/17/2018 02:42 PM, John Ferlan wrote: >> The VM Generation ID is a mechanism to provide a unique 128-bit, >> cryptographically random, and integer value identifier known as >> the GUID (Globally Unique Identifier) to the guest OS. The value

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Fri, May 25, 2018 at 12:06:50PM +0200, Andrea Bolognani wrote: > On Fri, 2018-05-25 at 10:04 +0200, Pavel Hrdina wrote: > > On Fri, May 25, 2018 at 09:13:51AM +0200, Andrea Bolognani wrote: > > > However, I realize it might not be possible to register free > > > functions for a native type

Re: [libvirt] [PATCH] tools: virsh: Add virshCellnoCompleter.

On 05/25/2018 09:12 AM, Roland Schulz wrote: > Signed-off-by: Roland Schulz > --- > tools/virsh-completer.c | 59 + > tools/virsh-completer.h | 3 +++ > tools/virsh-host.c | 3 +++ > 3 files changed, 65 insertions(+) > > diff

[libvirt] [PATCH 1/2] capabilities: Provide info about host IOMMU support

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=967231 Signed-off-by: Filip Alac --- docs/schemas/capability.rng | 11 +++ src/conf/capabilities.c | 8 src/conf/capabilities.h | 5 + src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH 10/22] virsh: Introduce new hypervisor-cpu-compare command

On Thu, May 24, 2018 at 13:24:25 -0400, Collin Walling wrote: > On 05/16/2018 04:39 AM, Jiri Denemark wrote: > > This command is a virsh wrapper for virConnectCompareHypervisorCPU. > > > > Signed-off-by: Jiri Denemark > > --- > > tools/virsh-host.c | 113

[libvirt] [PATCH 2/2] docs: news: Add entry about iommu_support

Signed-off-by: Filip Alac --- docs/news.xml | 8 1 file changed, 8 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 693d4a373..babf13379 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -93,6 +93,14 @@ secret-event, pool-event and

Re: [libvirt] [REPOSTv2 PATCH v3 3/6] qemu: Alter VM Generation ID for specific startup/launch transitions

On 05/25/2018 04:24 AM, Michal Privoznik wrote: > On 05/17/2018 02:42 PM, John Ferlan wrote: >> Before we generate the command line for qemu, if the domain about to >> be launched desires to utilize the VM Generation ID functionality, then >> handle both the regenerating the GUID value for

Re: [libvirt] [PATCH 02/13] qemu: Introduce zPCI capability

On Thursday, 24 May 2018 14:24:27 CEST Xiao Feng Ren wrote: > From: Yi Min Zhao > > Let's introduce zPCI capability. > > Signed-off-by: Yi Min Zhao > Reviewed-by: Boris Fiuczynski > Reviewed-by: Stefan Zimmermann

Re: [libvirt] [PATCH 08/13] conf: Introduce parser, formatter for uid and fid

On Thursday, 24 May 2018 14:24:33 CEST Xiao Feng Ren wrote: > From: Yi Min Zhao > > This patch introduces new XML parser/formatter functions. Uid is > 16-bit and non-zero. Fid is 32-bit. They are added as two new > attributes of PCI address, and parsed/formatted along with

Re: [libvirt] [PATCH 04/22] virsh: Enhance documentation of cpu-models command

On Fri, May 25, 2018 at 11:36:21AM +0200, Jiri Denemark wrote: > On Thu, May 24, 2018 at 11:05:08 +0200, Kashyap Chamarthy wrote: [...] > > Ah, that is clearer; thank you. So if you think it is worth it, maybe > > adjust your doc patch to a variant of the following: > > > > Moreover, for

Re: [libvirt] [REPOSTv2 PATCH v3 4/6] qemu: Add VM Generation ID to qemu command line

On 05/25/2018 04:24 AM, Michal Privoznik wrote: > On 05/17/2018 02:42 PM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1149445 >> >> If the domain requests usage of the genid functionality, >> then add the QEMU '-device vmgenid' to the command line >> providing either the

Re: [libvirt] [REPOSTv2 PATCH v3 0/6] Add support for VM Generation ID (vmgenid)

On 05/25/2018 02:04 PM, John Ferlan wrote: > > > On 05/25/2018 07:39 AM, Michal Privoznik wrote: >> On 05/25/2018 01:10 PM, John Ferlan wrote: >>> >>> >>> On 05/25/2018 04:24 AM, Michal Privoznik wrote: On 05/17/2018 02:42 PM, John Ferlan wrote: > Second reposting of: > >

Re: [libvirt] [PATCH 10/22] virsh: Introduce new hypervisor-cpu-compare command

On Fri, May 25, 2018 at 12:35:09PM +0200, Jiri Denemark wrote: > On Thu, May 24, 2018 at 13:24:25 -0400, Collin Walling wrote: > > On 05/16/2018 04:39 AM, Jiri Denemark wrote: > > > This command is a virsh wrapper for virConnectCompareHypervisorCPU. > > > > > > Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH 04/22] virsh: Enhance documentation of cpu-models command

On Thu, May 24, 2018 at 11:05:08 +0200, Kashyap Chamarthy wrote: > On Wed, May 23, 2018 at 09:09:28PM +0200, Jiri Denemark wrote: > > On Wed, May 23, 2018 at 16:53:37 +0200, Kashyap Chamarthy wrote: > > > On Wed, May 23, 2018 at 02:43:23PM +0200, Jiri Denemark wrote: > > > > On Wed, May 23, 2018

Re: [libvirt] [PATCH 07/13] qemu: Add hotpluging support for PCI devices on S390 guests

Cornelia Huck [2018-05-24, 06:25PM +0200]: > On Thu, 24 May 2018 14:24:32 +0200 > Xiao Feng Ren wrote: > > > From: Yi Min Zhao > > > > This commit adds hotplug support for PCI devices on S390 guests. > > There's no need to

Re: [libvirt] [REPOSTv2 PATCH v3 0/6] Add support for VM Generation ID (vmgenid)

On 05/25/2018 04:24 AM, Michal Privoznik wrote: > On 05/17/2018 02:42 PM, John Ferlan wrote: >> Second reposting of: >> >> https://www.redhat.com/archives/libvir-list/2018-May/msg00813.html >> >> To update patches with more conflicts for patch 2 (capabilities) and >> patch 6 (news) >> >> Cover

Re: [libvirt] [REPOSTv2 PATCH v3 0/6] Add support for VM Generation ID (vmgenid)

[...] >>> of flags. If you fix the capability check like I'm suggesting in 4/6 you >>> have my ACK for the whole patch set. >> >> Ironically, as part of review of v2 patch 10, I was asked to remove the >> check from qemuBuildVMGenIDCommandLine: >> >>

Re: [libvirt] [PATCH v2 0/8] Fix some issues with rng grammar for output XML's,

On 05/21/2018 02:40 PM, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2018-May/msg01455.html > > Update patches to add data into schema for examples that I could generate. > For the vpxmigr and vzmigr, I wasn't sure what the capabilityschemadata > should look like, so I

Re: [libvirt] [PATCH 19/22] cpu: Add optional list of allowed features to virCPUBaseline

On Wed, May 16, 2018 at 10:39:38AM +0200, Jiri Denemark wrote: When computing a baseline CPU for a specific hypervisor we have to make sure to include only CPU features supported by the hypervisor. Otherwise the computed CPU could not be used for starting a new domain. Signed-off-by: Jiri

Re: [libvirt] [PATCH 22/22] news: Mention new CPU related APIs

On Wed, May 16, 2018 at 10:39:41AM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) With the copy & paste errors fixed: Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [libvirt] [PATCH 20/22] qemu_capabilities: Introduce virQEMUCapsGetCPUFeatures

On Wed, May 16, 2018 at 10:39:39AM +0200, Jiri Denemark wrote: The function creates a lost of all (or migratable only) CPU features s/lost/list/ supported by QEMU. It works by looking at the CPU model info returned by query-cpu-model-expansion QMP command. Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH 18/22] cpu: Update style in virCPUBaseline

On Wed, May 16, 2018 at 10:39:37AM +0200, Jiri Denemark wrote: To make it more consistent with the rest of the CPU driver code. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Ján Tomko

[libvirt] [PATCH 2/3] vmx: convert to typesafe virConf accessors

Signed-off-by: Fabiano Fidêncio --- src/vmx/vmx.c | 197 +++--- 1 file changed, 73 insertions(+), 124 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index df6a58a47..6247fa938 100644 --- a/src/vmx/vmx.c +++

[libvirt] [PATCH 3/3] xen_common: convert to typesafe virConf accessors

There are still some places using virConfGetValue() and then checking the specific type of the pointers and so on. Those place are not going to be changed as: - Directly using virConfGetValue*() would trigger virReportError() on their current code - Expanding virConfGetValue*() to support strings

[libvirt] [PATCH 0/3] Finish the conversion to virConfGetValue* functions

This patchset finishes the conversion to virConfGetValue* functions, started by Daniel Berrange a few months ago. Please, mind that although we could make virConfGetValue* functions more generic in order to support numbers and booleans as strings, that doesn't seem the safest path to take. The

[libvirt] [PATCH 1/3] xen_vm: convert to typesafe virConf accessors

Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_xm.c | 268 - 1 file changed, 132 insertions(+), 136 deletions(-) diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index 4becb40b4..fc88ac823 100644 ---

Re: [libvirt] [PATCH 13/22] remote: Implement virConnectBaselineHypervisorCPU

On Wed, May 16, 2018 at 10:39:32AM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 21 - src/remote_protocol-structs | 15 +++ 3 files changed, 36 insertions(+), 1

Re: [libvirt] [PATCH 16/22] cpu_x86: Add support for passing guest CPUs to virCPUx86Baseline

On Wed, May 16, 2018 at 10:39:35AM +0200, Jiri Denemark wrote: Modern host CPU models from domain capabilities XMLs are reported as guest CPU definitions with feature policies. This patch updates virCPUx86Baseline to properly handle such CPU models. Signed-off-by: Jiri Denemark

Re: [libvirt] [libvirt-users] virRandomBits - not very random

On 5/25/2018 8:58 AM, Eric Blake wrote: Reviving an ancient thread: On 11/04/2014 02:18 AM, Daniel P. Berrange wrote: On Mon, Nov 03, 2014 at 11:09:12AM -0500, Brian Rak wrote: I just ran into an issue where I had about 30 guests get duplicate mac addresses assigned.  These were scattered

Re: [libvirt] [PATCH 14/22] virsh: Introduce new hypervisor-cpu-baseline command

On Wed, May 16, 2018 at 10:39:33AM +0200, Jiri Denemark wrote: This command is a virsh wrapper for virConnectBaselineHypervisorCPU. Signed-off-by: Jiri Denemark --- tools/virsh-host.c | 96 ++ tools/virsh.pod| 47

Re: [libvirt] [PATCH v2 1/8] schema: Add physical sizing grammer for storagevol grammar

s/grammer/element/ ? On Mon, May 21, 2018 at 08:40:38AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1572491 Commit id '78661cb' added a physical output, but failed to update the schema resulting in a failure from virt-xml-validate. While at it - update the

Re: [libvirt] [PATCH 17/22] cpu: Add explicit arch parameter for virCPUBaseline

On Wed, May 16, 2018 at 10:39:36AM +0200, Jiri Denemark wrote: This is required for virCPUBaseline to accept a list of guest CPU definitions since they do not have arch set. Signed-off-by: Jiri Denemark --- src/bhyve/bhyve_driver.c | 2 +- src/cpu/cpu.c| 16

Re: [libvirt] [PATCH 11/22] qemu: Implement virConnectCompareHypervisorCPU

On Wed, May 16, 2018 at 10:39:30AM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 60 ++ 1 file changed, 60 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [PATCH 15/22] cpu: Rename cpuBaseline as virCPUBaseline

On Wed, May 16, 2018 at 10:39:34AM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/bhyve/bhyve_driver.c | 4 ++-- src/cpu/cpu.c| 10 +- src/cpu/cpu.h| 18 +- src/cpu/cpu_arm.c| 10 +-

Re: [libvirt] [PATCH 21/22] qemu: Implement virConnectBaselineHypervisorCPU

On Wed, May 16, 2018 at 10:39:40AM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 91 ++ 1 file changed, 91 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [libvirt-users] virRandomBits - not very random

On 05/25/2018 09:17 AM, Michal Privoznik wrote: We should probably seed it with data from /dev/urandom, and/or the new Linux getrandom() syscall (or BSD equivalent). I'm not quite sure that right after reboot there's going to be enough entropy. Every service that's starting wants some random

Re: [libvirt] [tck PATCH 0/3] Some misc fixes

On Mon, May 21, 2018 at 02:01:39PM +0100, Daniel P. Berrangé wrote: Just random things i found while testing the TCK against current git Daniel P. Berrangé (3): scripts: avoid using multicast MAC addresses scripts: strip quotes from URI before checking it scripts: fix block info test

Re: [libvirt] [PATCH 12/22] Introduce virConnectBaselineHypervisorCPU public API

On Wed, May 16, 2018 at 10:39:31AM +0200, Jiri Denemark wrote: The new API computes the most feature-rich CPU which is compatible with all given CPUs and can be provided by the specified hypervisor. It is a more useful version of vitConnectBaselineCPU, which doesn't consider any hypervisor

Re: [libvirt] [PATCH 11/22] qemu: Implement virConnectCompareHypervisorCPU

CC'ing Chris just in case. -- Respectfully, - Collin Walling -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 10/22] virsh: Introduce new hypervisor-cpu-compare command

>>> +switch (result) { >>> +case VIR_CPU_COMPARE_INCOMPATIBLE: >>> +vshPrint(ctl, >>> + _("CPU described in %s is incompatible with the CPU >>> provided " >>> + "by hypervisor on the host\n"), >>> + from); >> >> How much

Re: [libvirt] [PATCH 18/22] cpu: Update style in virCPUBaseline

On 05/16/2018 04:39 AM, Jiri Denemark wrote: > To make it more consistent with the rest of the CPU driver code. > > Signed-off-by: Jiri Denemark > --- > src/cpu/cpu.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Collin Walling

Re: [libvirt] [libvirt-users] virRandomBits - not very random

On 05/25/2018 02:58 PM, Eric Blake wrote: > Reviving an ancient thread: > > On 11/04/2014 02:18 AM, Daniel P. Berrange wrote: >> On Mon, Nov 03, 2014 at 11:09:12AM -0500, Brian Rak wrote: >>> I just ran into an issue where I had about 30 guests get duplicate mac >>> addresses assigned.  These

Re: [libvirt] [PATCH] tools: virsh: Add virshCellnoCompleter.

Please do not put periods at the end of commit summaries. On Fri, May 25, 2018 at 09:12:37AM +0200, Roland Schulz wrote: Signed-off-by: Roland Schulz --- tools/virsh-completer.c | 59 + tools/virsh-completer.h | 3 +++

Re: [libvirt] [RFC v3] external (pull) backup API

On 05/17/2018 05:43 PM, Eric Blake wrote: Here's my updated counterproposal for a backup API. In comparison to v2 posted by Nikolay: https://www.redhat.com/archives/libvir-list/2018-April/msg00115.html - changed terminology a bit: Nikolay's "BlockSnapshot" is now called a "Checkpoint", and

Re: [libvirt] [PATCH 0/3] Finish the conversion to virConfGetValue* functions

On Fri, May 25, 2018 at 3:27 PM, Fabiano Fidêncio wrote: > This patchset finishes the conversion to virConfGetValue* functions, > started by Daniel Berrange a few months ago. > > Please, mind that although we could make virConfGetValue* functions more > generic in order to

Re: [libvirt] [PATCH 12/22] Introduce virConnectBaselineHypervisorCPU public API

On 05/16/2018 04:39 AM, Jiri Denemark wrote: > The new API computes the most feature-rich CPU which is compatible with > all given CPUs and can be provided by the specified hypervisor. It is a > more useful version of vitConnectBaselineCPU, which doesn't consider any s/vit/vir > hypervisor

Re: [libvirt] [PATCH 08/22] Introduce virConnectCompareHypervisorCPU public API

>>> +if (ret == VIR_CPU_COMPARE_ERROR) >>> +goto error; >> >> Admittedly I did not look too closely, but will the compareHypervisorCPU >> functions actually >> return "VIR_CPU_COMPARE_ERROR" on error? If so, wouldn't it be more sensible >> to return a >>

Re: [libvirt] [PATCH 11/22] qemu: Implement virConnectCompareHypervisorCPU

Sorry for the delay. I've been experiencing issues with the mail server :( On 05/16/2018 04:39 AM, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_driver.c | 60 ++ > 1 file changed, 60 insertions(+) > >

Re: [libvirt] [PATCH 00/22] New CPU related APIs

Code-wise, these patches look good. I'd like to take the time next week to hook up my comparison patches and test them out properly (unless Chris gets to it first, then I'll just apply his patches and run some tests) On 05/16/2018 04:39 AM, Jiri Denemark wrote: > The current virConnectCompareCPU

Re: [libvirt] [PATCH 21/22] qemu: Implement virConnectBaselineHypervisorCPU

On 05/16/2018 04:39 AM, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_driver.c | 91 ++ > 1 file changed, 91 insertions(+) > Reviewed-by: Collin Walling -- Respectfully, - Collin

Re: [libvirt] [PATCH 14/22] virsh: Introduce new hypervisor-cpu-baseline command

On 05/16/2018 04:39 AM, Jiri Denemark wrote: > This command is a virsh wrapper for virConnectBaselineHypervisorCPU. > > Signed-off-by: Jiri Denemark > --- > tools/virsh-host.c | 96 ++ > tools/virsh.pod| 47

Re: [libvirt] [PATCH 19/22] cpu: Add optional list of allowed features to virCPUBaseline

On 05/16/2018 04:39 AM, Jiri Denemark wrote: > When computing a baseline CPU for a specific hypervisor we have to make > sure to include only CPU features supported by the hypervisor. Otherwise > the computed CPU could not be used for starting a new domain. > > Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH 20/22] qemu_capabilities: Introduce virQEMUCapsGetCPUFeatures

On 05/16/2018 04:39 AM, Jiri Denemark wrote: > The function creates a lost of all (or migratable only) CPU features > supported by QEMU. It works by looking at the CPU model info returned by > query-cpu-model-expansion QMP command. > > Signed-off-by: Jiri Denemark > --- >

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

On Fri, May 25, 2018 at 08:30:59AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > On Wed, May 23, 2018 at 05:53:34PM +0200, Markus Armbruster wrote: [...] > >> >> Worse, a machine type property that is static for all machine types now > >> >> could conceivably

Re: [libvirt] [PATCH 17/22] cpu: Add explicit arch parameter for virCPUBaseline

On 05/16/2018 04:39 AM, Jiri Denemark wrote: > This is required for virCPUBaseline to accept a list of guest CPU > definitions since they do not have arch set. > > Signed-off-by: Jiri Denemark > --- > src/bhyve/bhyve_driver.c | 2 +- > src/cpu/cpu.c| 16

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

Eduardo Habkost writes: > On Wed, May 23, 2018 at 05:53:34PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Wed, May 23, 2018 at 11:17:55AM +0200, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >>

Re: [libvirt] [PATCH] disk: Allow settling to occur after reading partitions

On 05/24/2018 05:43 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1400475 > > In order to avoid a possible error as a result of kernel interactions > with the partition helper, let's use virWaitForDevices to force things > to settle down before attempting to open and read

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Wed, 2018-05-23 at 18:23 +0200, Peter Krempa wrote: > On Wed, May 23, 2018 at 18:05:17 +0200, Pavel Hrdina wrote: [...] > > VIR_AUTOFREE char *str = NULL; > > For consistency I'd prefer if the argument is in parentheses similarly > to the ones below. Seconded. -- Andrea Bolognani / Red Hat

[libvirt] [PATCH] tools: virsh: Add virshCellnoCompleter.

Signed-off-by: Roland Schulz --- tools/virsh-completer.c | 59 + tools/virsh-completer.h | 3 +++ tools/virsh-host.c | 3 +++ 3 files changed, 65 insertions(+) diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Wed, 2018-05-23 at 18:05 +0200, Pavel Hrdina wrote: > I liked the way how GLib is solving the issue so we can simply use the > same approach since it looks reasonable. > > There would be three different macros that would be used to annotate > variable with attribute cleanup: > > VIR_AUTOFREE

Re: [libvirt] [PATCH] news: Add the event name completion

On 05/25/2018 07:41 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > docs/news.xml | 9 + > 1 file changed, 9 insertions(+) ACKed and pushed. Thanks, Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Fri, May 25, 2018 at 09:01:03AM +0200, Andrea Bolognani wrote: > On Wed, 2018-05-23 at 18:23 +0200, Peter Krempa wrote: > > On Wed, May 23, 2018 at 18:05:17 +0200, Pavel Hrdina wrote: > [...] > > > VIR_AUTOFREE char *str = NULL; > > > > For consistency I'd prefer if the argument is in

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Fri, May 25, 2018 at 09:13:51AM +0200, Andrea Bolognani wrote: > On Wed, 2018-05-23 at 18:05 +0200, Pavel Hrdina wrote: > > I liked the way how GLib is solving the issue so we can simply use the > > same approach since it looks reasonable. > > > > There would be three different macros that

[libvirt] [PATCH] spec: Enable libssh on future RHEL

Future RHEL will certainly be modern enough to support libssh. Signed-off-by: Jiri Denemark --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 0e4a84c98c..5e1e1df3f0 100644 --- a/libvirt.spec.in

Re: [libvirt] [REPOSTv2 PATCH v3 4/6] qemu: Add VM Generation ID to qemu command line

On 05/17/2018 02:42 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1149445 > > If the domain requests usage of the genid functionality, > then add the QEMU '-device vmgenid' to the command line > providing either the supplied or generated GUID value. > > Add tests for both

Re: [libvirt] [REPOSTv2 PATCH v3 1/6] conf: Add VM Generation ID parse/format support

On 05/17/2018 02:42 PM, John Ferlan wrote: > The VM Generation ID is a mechanism to provide a unique 128-bit, > cryptographically random, and integer value identifier known as > the GUID (Globally Unique Identifier) to the guest OS. The value > is used to help notify the guest operating system

Re: [libvirt] [REPOSTv2 PATCH v3 0/6] Add support for VM Generation ID (vmgenid)

On 05/17/2018 02:42 PM, John Ferlan wrote: > Second reposting of: > > https://www.redhat.com/archives/libvir-list/2018-May/msg00813.html > > To update patches with more conflicts for patch 2 (capabilities) and > patch 6 (news) > > Cover from the v3 posting: > > v2:

Re: [libvirt] [PATCH] spec: Enable libssh on future RHEL

On 05/25/2018 10:10 AM, Jiri Denemark wrote: > Future RHEL will certainly be modern enough to support libssh. Is there going to be any future RHEL? Who knows O:-) > > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1