To save precious space in the commit summary:
s/Fixing/fix/
s/inside/in/
And most importantly, I deleted the period at the end.
On Mon, Jun 11, 2018 at 05:35:33PM -0300, Julio Faracco wrote:
Since virConfGetValueBool() can return earlier, the parameter 'value'
might be not initialised properly
On Mon, Jun 11, 2018 at 04:21:47PM +0200, Pavel Hrdina wrote:
> D-Bus object path element can contain only [a-zA-Z0-9_] characters so
> we need to encode existing unique IDs. In case of UUID it's simple, we
> just change '-' into '_' but in case of storage volumes we need to use
> 'key' which is a
On Tue, Jun 12, 2018 at 07:16:38AM +0200, Pavel Hrdina wrote:
Commit <57a160b5248ba47d4e1c9d22d95847dad8e0524f> removed last usage
but did not remove the function itself.
Signed-off-by: Pavel Hrdina
---
libvirt-utils.c | 14 --
libvirt-utils.h | 1 -
2 files changed, 15 deletions(-)
On Tue, Jun 12, 2018 at 07:16:39AM +0200, Pavel Hrdina wrote:
If the function fails it should always set an exception.
Signed-off-by: Pavel Hrdina
---
typewrappers.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital si
On Tue, Jun 12, 2018 at 07:16:40AM +0200, Pavel Hrdina wrote:
In virConnectCredCallbackWrapper() we ignore the error case of
libvirt_charPtrUnwrap() function so we should also reset the exception.
Signed-off-by: Pavel Hrdina
---
libvirt-override.c | 4 +++-
1 file changed, 3 insertions(+), 1 del
On Tue, Jun 12, 2018 at 07:16:41AM +0200, Pavel Hrdina wrote:
Function libvirt_charPtrUnwrap() either fails or always sets the
unwrapped string so there is no need to check it explicitly.
Signed-off-by: Pavel Hrdina
---
libvirt-override.c | 12
libvirt-utils.c| 10 +++---
2 f
On 06/11/2018 02:01 PM, intrigeri wrote:
> Hi,
>
> Michal Prívozník:
>> On 06/11/2018 08:43 AM, Christian Ehrhardt wrote:
>>> On Mon, Jun 11, 2018 at 8:12 AM, Michal Prívozník
>>> wrote:
Also, it would be nice if you can use your real name.
>>>
>>> We had the real name discussion before, but
Eduardo Habkost has pointed out that the current documentation of
libvirt's CPU feature policy "require" vs. "force" does not match
QEMU's behaviour.
Update the documentation by spelling out the QEMU version dependency and
explain in which scenarios the usage of "policy = 'force'" is applicable
or
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StoragePool.xml | 7 +++
src/storagepool.c| 34 ++
tests/libvirttest.py | 17 +
tests/test_storage.py| 4
4 files changed, 62 insertions(+)
diff
StorageVols logically should be nested under StoragePools, however this
implementation does not nest the StorageVol interface under StorageVols.
Reason is that the current gdbus.c implementation would not allow nesting
of objects. Phrdina checked the posibility of rewritting the gdbus.c to
support
Signed-off-by: Katerina Koukiou
---
data/Makefile.am| 3 +-
data/org.libvirt.StorageVol.xml | 7 +++
src/Makefile.am | 3 +-
src/connect.c | 6 +++
src/connect.h | 1 +
src/storagevol.c| 96 ++
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StoragePool.xml | 6 ++
src/storagepool.c| 44
tests/test_storage.py| 8
3 files changed, 58 insertions(+)
diff --git a/data/org.libvirt.StoragePool.xml b/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 23 +++
tests/test_storage.py | 1 +
3 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
i
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StoragePool.xml | 9 +
src/storagepool.c| 41
tests/test_storage.py| 21
3 files changed, 71 insertions(+)
diff --git a/data/org.libvirt.Storage
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 26 ++
2 files changed, 32 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index fdde430..aed3f7a 100644
--- a/d
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StoragePool.xml | 6 ++
src/storagepool.c| 34 ++
2 files changed, 40 insertions(+)
diff --git a/data/org.libvirt.StoragePool.xml b/data/org.libvirt.StoragePool.xml
index 51d65ab..161ade5 10
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 44 +
tests/test_storage.py | 9 +
3 files changed, 58 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/or
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 23 +++
tests/test_storage.py | 1 +
3 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
i
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 29 +
2 files changed, 35 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index aed3f7a..8a4eab2 100644
---
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
tests/test_connect.py| 1 +
3 files changed, 36 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index d38
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 29 +
tests/test_storage.py | 7 +++
3 files changed, 42 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.Sto
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 30 ++
tests/test_connect.py| 14 ++
3 files changed, 50 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 25 +
tests/test_storage.py | 6 ++
3 files changed, 36 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVo
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 26 ++
2 files changed, 32 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index c1fecf3..fdde430 100644
--- a/d
The typedefs were present twice in the header file which causes failures
with some compilers, eg FreeBSD 10 CLang:
../../src/conf/domain_conf.h:2330:33: error: redefinition of typedef
'virDomainSevDef' is a C11 feature
+[-Werror,-Wtypedef-redefinition]
typedef struct _virDomainSevDef virDomainSev
Signed-off-by: Daniel P. Berrangé
---
Pushed as a build fix
src/qemu/Makefile.inc.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am
index 46797af4be..2afa67f195 100644
--- a/src/qemu/Makefile.inc.am
+++ b/src/qemu/Makefile.inc.am
@@ -40,6
On 06/12/2018 12:36 AM, Eduardo Habkost wrote:
> CCing libvir-list.
>
> On Mon, Jun 11, 2018 at 11:29:24PM +0200, Igor Mammedov wrote:
>> On Mon, 11 Jun 2018 16:06:07 -0300
>> Eduardo Habkost wrote:
>>
>>> On Mon, Jun 11, 2018 at 03:16:25PM +0200, Igor Mammedov wrote:
On Fri, 8 Jun 2018 10:2
A friendly reminder that the deadline for abstract submission is end
of day this Thursday, June 14th.
On Thu, May 17, 2018 at 12:52:35PM +0200, Paolo Bonzini wrote:
>
> KVM Forum 2018: Call For Participation
> October 24-26, 2018 -
On Mon, Jun 11, 2018 at 11:17:02AM -0500, Brijesh Singh wrote:
> Hi Erik,
>
>
> On 06/11/2018 09:10 AM, Erik Skultety wrote:
> > On Fri, Jun 08, 2018 at 10:14:35AM -0500, Brijesh Singh wrote:
> > >
> > > Re: Jano's below comment
> > >
> > > (Also, some of the patches have double "<< >>" around
Hi Martin,
Thanks for your comments, please see my update inline below.
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Monday, June 11, 2018 4:30 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang
This will make further changes easier; all coverage
lost due to this will be reintroduced later on.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 5 -
1 file changed, 5 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 0ae8b293b1..f62e8c6437 100644
--- a/.travis.yml
+++ b/.travi
Applies on top of
https://www.redhat.com/archives/libvir-list/2018-June/msg00579.html
See patch 2/3 for more information.
Andrea Bolognani (3):
travis: Drop Ubuntu 16.04 build
travis: Use pre-built Docker image
travis: Add CentOS 7 build
.travis.yml | 77 +++
Instead of starting from the minimal Ubuntu 18.04 base
image and installing all requirements at build time,
use a Docker image that has been specifically tailored
at building libvirt and thus already includes all
required packages.
Signed-off-by: Andrea Bolognani
---
The pre-built images have bee
Now that we use pre-built Docker images, it's very easy
to extend our test matrix; adding CentOS 7 is a good start.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index 1b0d1e824b..37fa1ccf8c 100644
--- a/.travis
On Tue, Jun 12, 2018 at 11:07:51AM +0100, Daniel P. Berrangé wrote:
> On Mon, Jun 11, 2018 at 11:17:02AM -0500, Brijesh Singh wrote:
> > Hi Erik,
> >
> >
> > On 06/11/2018 09:10 AM, Erik Skultety wrote:
> > > On Fri, Jun 08, 2018 at 10:14:35AM -0500, Brijesh Singh wrote:
> > > >
> > > > Re: Jano's
See my update inline.
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Monday, June 11, 2018 4:40 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Subject: Re: [libvirt] [PATCH 1/3] util
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Monday, June 11, 2018 4:45 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Subject: Re: [libvirt] [PATCH 2/3] tools: virsh: add command
On Wed, 2018-06-06 at 12:45 +0200, Andrea Bolognani wrote:
> Another thing to keep in mind is that moving the website build to
> a CentOS 7 container would allow us to remove the last remnants
> of CentOS 6 support from libvirt-jenkins-ci.git and delete the
> corresponding virtual machine from the
On Tue, Jun 12, 2018 at 12:24:14PM +0200, Andrea Bolognani wrote:
> On Wed, 2018-06-06 at 12:45 +0200, Andrea Bolognani wrote:
> > Another thing to keep in mind is that moving the website build to
> > a CentOS 7 container would allow us to remove the last remnants
> > of CentOS 6 support from libvi
On Thu, May 24, 2018 at 15:52:55 -0600, Jim Fehlig wrote:
> On 05/24/2018 04:27 AM, Ian Jackson wrote:
> > Ian Jackson writes ("Likely build race, "/usr/bin/ld: cannot find -lvirt""):
> >> tl;dr:
> >>
> >> I think there is a bug in libvirt's build system which, with
> >> low probability, causes a b
On Tue, 2018-06-12 at 11:41 +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 12, 2018 at 12:24:14PM +0200, Andrea Bolognani wrote:
> > I've started building Docker containers with all libvirt build
> > dependencies already installed[1], mainly for use in Travis CI;
> > the CentOS 7 container could ea
https://bugzilla.redhat.com/show_bug.cgi?id=1588336
This API takes @source argument which tells it where to get
domain IP addresses from. However, not all sources are capable of
providing all the information we report, for instance ARP table
has no notion of IP address prefixes. Document this limi
The first two patches tune up the XML elements to use camelCase
instead of dashes as the word separators.
Hopefully our QEMU capability probing is right and we can fix error
reporting in patch 3.
The rest are minor cleanups and renames to use SEV instead of Sev
in internal identifier names.
I di
We have enough elements using underscores instead of camelCase,
do not bring dashes into the mix.
Signed-off-by: Ján Tomko
---
docs/formatdomaincaps.html.in | 2 +-
docs/schemas/domaincaps.rng| 2 +-
src/conf/domain_capabilities.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
di
Do not mask the errors.
If we'd expect query-sev-capabilities to fail, we should not
call it in the first place.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilitie
Adjust the documentation, parser and tests to change:
launch-security -> launchSecurity
reduced-phys-bits -> reducedPhysBits
dh-cert -> dhCert
Also fix the headline in formatdomain.html to be more generic,
and some leftover closing elements in the documentation.
Signed-off-by: Ján Tomko
---
doc
Free tmp even on failure.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f0fb806fcd..ac2ef35f70 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2153
Make the function prefix match the file it's in.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_process.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 480bc8c1ad..5d4b6a9499 100644
--- a/src/qemu/qemu_process.c
It is only used in one place.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 35d46c465d..7131c2a8ee 100644
--- a/src/qemu/qemu_capabili
Some identifiers use Sev, some SEV. Prefer the latter.
Signed-off-by: Ján Tomko
---
src/conf/domain_conf.c | 8
src/conf/domain_conf.h | 8
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_process.c | 2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/con
A common cleanup path for both the success and the error case.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_process.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 5d4b6a9499..7468e14447 100644
--- a/src/qemu/
Signed-off-by: Ján Tomko
---
src/qemu/qemu_monitor_json.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index c5480a2d0e..3ad01b9dd3 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -6423,7 +6423,6 @@
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 4 ++--
src/qemu/qemu_process.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 1cb721c152..a557a0387a 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_c
On Tue, Jun 12, 2018 at 01:26:05PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-06-12 at 11:41 +0100, Daniel P. Berrangé wrote:
> > On Tue, Jun 12, 2018 at 12:24:14PM +0200, Andrea Bolognani wrote:
> > > I've started building Docker containers with all libvirt build
> > > dependencies already inst
On Mon, 2018-06-11 at 13:52 +0200, Christian Ehrhardt wrote:
> The base vfio has not much functionality but to provide a custom
> container by opening this path.
> See https://www.kernel.org/doc/Documentation/vfio.txt for more.
>
> Systems with static hostdevs will get /dev/vfio/vfio by virt-aa-
>
On Tue, 2018-06-12 at 13:22 +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 12, 2018 at 01:26:05PM +0200, Andrea Bolognani wrote:
> > > I was actually intending to take a simpler approach - just compile a
> > > newer gnutls into /opt and let the website build use that.
> >
> > Sure, that would prob
On Tue, 12 Jun 2018 11:17:15 +0200
Michal Privoznik wrote:
> On 06/12/2018 12:36 AM, Eduardo Habkost wrote:
> > CCing libvir-list.
> >
> > On Mon, Jun 11, 2018 at 11:29:24PM +0200, Igor Mammedov wrote:
> >> On Mon, 11 Jun 2018 16:06:07 -0300
> >> Eduardo Habkost wrote:
> >>
> >>> On Mon, Ju
On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote:
> We can keep daemonizing flow in QEMU as it's now.
> But Eduardo's idea about libvirt created socked + letting QEMU connect to it
> has a merit. It should fix current deadlock issue with as monitor
> won't be depending on lead exit eve
On 06/12/2018 06:11 AM, Jiri Denemark wrote:
I hit the same race twice on aarch64 and ppc64 and I can confirm the
installation phase fails if libvirt.la is installed later than libraries
which link to it. However, the dependencies seem to be set correctly in
the Makefiles. But it looks like they
On 06/12/2018 02:42 PM, Igor Mammedov wrote:
>>>
>>> Do we really need to make -daemonize and -preconfig work
>>> together? libvirt uses -daemonize only for its initial
>>> capability probing, which shouldn't require -preconfig at all.
>>>
>>> Even on that case, I wonder why libvirt doesn't simpl
On Tue, Jun 12, 2018 at 15:04:42 +0200, Michal Privoznik wrote:
> On 06/12/2018 02:42 PM, Igor Mammedov wrote:
>
> >>>
> >>> Do we really need to make -daemonize and -preconfig work
> >>> together? libvirt uses -daemonize only for its initial
> >>> capability probing, which shouldn't require -pre
On Tue, Jun 12, 2018 at 03:04:42PM +0200, Michal Privoznik wrote:
> On 06/12/2018 02:42 PM, Igor Mammedov wrote:
>
> >>>
> >>> Do we really need to make -daemonize and -preconfig work
> >>> together? libvirt uses -daemonize only for its initial
> >>> capability probing, which shouldn't require -p
On 06/12/2018 01:36 AM, Pavel Hrdina wrote:
> On Mon, Jun 11, 2018 at 03:38:16PM -0400, Anya Harter wrote:
>> Currently, all virObjectEventStateQueue callers and
>> virObjectEventStateQueueRemote callers need to do NULL checking.
>>
>> In this patch series, all NULL checking has been moved to
>
On 06/11/2018 10:42 AM, Ján Tomko wrote:
> On Wed, Jun 06, 2018 at 10:44:10AM -0400, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1559867
>>
>> Add a check if the incoming with specified
>> already exists and if so fail the attach.
>>
>
> Looking at the reproducer steps,
At daemon startup we query logind for host PM support status. Without
a service dependency host startup can trigger libvirtd errors like:
error : virNodeSuspendSupportsTarget:336 : internal error: Cannot probe for
supported suspend types
warning : virQEMUCapsInit:949 : Failed to get host power man
We're no longer running the corresponding job.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-centos-6/main.yml | 1 -
guests/vars/projects/libvirt+website.yml | 5 -
2 files changed, 6 deletions(-)
delete mode 100644 guests/vars/projects/libvirt+website.yml
diff --git a/gu
As suggested in
https://www.redhat.com/archives/libvir-list/2018-June/msg00943.html
Andrea Bolognani (3):
projects: Drop libvirt-master-build-website job
guests: Drop libvirt+website project
guests: Drop CentOS 6 support
guests/host_vars/libvirt-centos-6/install.yml | 3 -
guests/host_
The job has been failing ever since libvirt has made
GnuTLS 3.2.0 mandatory with commit 60d9ad6f1e42, so
it no longer provides any value.
Signed-off-by: Andrea Bolognani
---
projects/libvirt.yaml | 11 ---
1 file changed, 11 deletions(-)
diff --git a/projects/libvirt.yaml b/projects/lib
It hasn't been a target platform for a while now, and the
last job that was running on it has been dropped too.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-centos-6/install.yml | 3 -
guests/host_vars/libvirt-centos-6/main.yml| 2 -
guests/inventory
On Tue, Jun 12, 2018 at 07:57:40 -0500, Eric Blake wrote:
> On 06/12/2018 06:11 AM, Jiri Denemark wrote:
>
> > I hit the same race twice on aarch64 and ppc64 and I can confirm the
> > installation phase fails if libvirt.la is installed later than libraries
> > which link to it. However, the depend
Thanks everybody,
pushed with the commit message cleaned up and acks/reviews added.
On Tue, Jun 12, 2018 at 2:39 PM, Jamie Strandboge
wrote:
> On Mon, 2018-06-11 at 13:52 +0200, Christian Ehrhardt wrote:
> > The base vfio has not much functionality but to provide a custom
> > container by openin
On 06/12/2018 07:00 AM, Ján Tomko wrote:
The first two patches tune up the XML elements to use camelCase
instead of dashes as the word separators.
Hopefully our QEMU capability probing is right and we can fix error
reporting in patch 3.
The rest are minor cleanups and renames to use SEV inste
Add support for the recently introduced AMD SEV APIs
Erik Skultety (2):
Add support for virDomainGetLaunchSecurityInfo
Add support for virNodeGetSEVInfo
generator.py | 2 ++
libvirt-override-api.xml | 12
libvirt-override.c | 73 +++
This binding allows to query the AMD's SEV firmware for various platform
specific things, like a PDH certificate and a certificate chain to
establish a trusted connection with the firmware. Because the API uses
typed params, it's exempted from generation.
Signed-off-by: Erik Skultety
---
generat
Libvirt recently introduced support for getting launch security
parameters, most notably AMD SEV VM memory measurement. This API can't
be generated as it's using typed parameters which we need to allocate.
Signed-off-by: Erik Skultety
---
generator.py | 1 +
libvirt-override-api.xml
https://bugzilla.redhat.com/show_bug.cgi?id=1559867
When attaching a device to the domain we need to be sure
to use the correct domain definition (vm->def or vm->newDef)
when calling virDomainDeviceDefParse because the post parse
processing algorithms that may assign an address for the
device will
v1: https://www.redhat.com/archives/libvir-list/2018-June/msg00465.html
The first patch is essentially a repeat of the v1 patch, but with
a more correct commit message. During testing if the same address
was supplied for the --config it wasn't checked.
The second patch rearranges qemuDomainAttach
Add a check during qemuDomainAttachDeviceConfig whether the
new/incoming device would have an existing
already and if so fail the attach. This can happen
if two hostdev's are added supplying the same address or
if the new hostdev address could possibly be a duplicate
of an existing SCSI .
Signed
On Tue, Jun 12, 2018 at 04:16:53PM +0200, Jiri Denemark wrote:
> On Tue, Jun 12, 2018 at 07:57:40 -0500, Eric Blake wrote:
> > On 06/12/2018 06:11 AM, Jiri Denemark wrote:
> >
> > > I hit the same race twice on aarch64 and ppc64 and I can confirm the
> > > installation phase fails if libvirt.la is
On 06/11/2018 03:38 PM, Anya Harter wrote:
>>From remote_driver.c
>
> And replace all calls with virObjectEventStateQueue such that:
>
> remoteEventQueue(priv, event, callbackID);
>
> becomes:
>
> virObjectEventStateQueue(priv->eventState, event, callbackID);
Just a quick edit...
T
On Tue, 2018-06-12 at 09:47 -0400, Cole Robinson wrote:
> At daemon startup we query logind for host PM support status. Without
> a service dependency host startup can trigger libvirtd errors like:
>
> error : virNodeSuspendSupportsTarget:336 : internal error: Cannot probe for
> supported suspend
*** BLURB HERE ***
Michal Privoznik (2):
qemuDomainUpdateDeviceFlags: Parse device as live if needed
conf: Forbid device alias change on device-update
src/conf/domain_conf.c | 12 +++-
src/conf/domain_conf.h | 3 ++-
src/lxc/lxc_driver.c | 6 +++---
src/qemu/qemu_driver.c | 28 ++
https://bugzilla.redhat.com/show_bug.cgi?id=1585108
When updating a live device users might pass different alias than
the one the device has. Currently, this is silently ignored which
goes against our behaviour for other parts of the device where we
explicitly allow only certain changes and error
When updating device it's worth parsing live info too as users
might want to update it as well.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f0fb80
On Thu, May 17, 2018 at 05:55:39PM -0400, John Ferlan wrote:
>
>
> On 05/17/2018 01:37 PM, Daniel P. Berrangé wrote:
> > On Thu, May 17, 2018 at 01:31:04PM -0400, Laine Stump wrote:
> >> On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote:
> >>> A typical XML representation of the virNWFilterBinding
And replace all calls with virObjectEventStateQueue such that:
qemuDomainEventQueue(driver, event);
becomes:
virObjectEventStateQueue(driver->domainEventState, event);
And remove NULL checking from all callers.
Signed-off-by: Anya Harter
---
src/qemu/qemu_blockjob.c | 4 +-
src/qem
Currently, there are four wrapper functions which call
virObjectEventStateQueue:
- testObjectEventQueue
- libxlDomainEventQueue
- qemuDomainEventQueue
- umlDomainEventQueue
This patch series removes these wrappers makes all calls directly to
virObjectEventStateQueue.
Since virObje
And replace all calls with virObjectEventStateQueue such that:
testObjectEventQueue(privconn, event);
becomes:
virObjectEventStateQueue(privconn->eventState, event);
Signed-off-by: Anya Harter
---
src/test/test_driver.c | 80 +++---
1 file changed,
And replace all calls with virObjectEventStateQueue such that:
libxlDomainEventQueue(driver, event);
becomes:
virObjectEventStateQueue(driver->domainEventState, event);
And remove NULL checking from all callers.
Signed-off-by: Anya Harter
---
src/libxl/libxl_domain.c| 24 ++--
And replace all calls with virObjectEventStateQueue such that:
umlDomainEventQueue(driver, event);
becomes:
virObjectEventStateQueue(driver->domainEventState, event);
And remove NULL checking from all callers.
Signed-off-by: Anya Harter
---
src/uml/uml_driver.c | 33 -
On Tue, Jun 12, 2018 at 10:58:46AM +0200, Kashyap Chamarthy wrote:
> Eduardo Habkost has pointed out that the current documentation of
> libvirt's CPU feature policy "require" vs. "force" does not match
> QEMU's behaviour.
>
> Update the documentation by spelling out the QEMU version dependency an
On 06/12/2018 07:32 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1588336
>
> This API takes @source argument which tells it where to get
> domain IP addresses from. However, not all sources are capable of
> providing all the information we report, for instance ARP table
On 06/12/2018 10:32 AM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1559867
>
> When attaching a device to the domain we need to be sure
> to use the correct domain definition (vm->def or vm->newDef)
> when calling virDomainDeviceDefParse because the post parse
> processing alg
On 05/09/2018 10:56 AM, Marc Hartmayer wrote:
> The force boot emulation is only required for virDomainCreateWithFlags
> as the flag VIR_DOMAIN_START_FORCE_BOOT was introduced with the commit
> 27c85260532f879be5674a4eed0811c21fd34f94 (2011). But
> virDomainCreateXMLWithFiles is newer and theref
On 06/12/2018 06:06 PM, Laine Stump wrote:
> On 06/12/2018 10:32 AM, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1559867
>>
>> When attaching a device to the domain we need to be sure
>> to use the correct domain definition (vm->def or vm->newDef)
>> when calling virDomainD
On Wed, Jun 13, 2018 at 12:53 AM +0200, John Ferlan wrote:
> On 05/09/2018 10:56 AM, Marc Hartmayer wrote:
>> The force boot emulation is only required for virDomainCreateWithFlags
>> as the flag VIR_DOMAIN_START_FORCE_BOOT was introduced with the commit
>> 27c85260532f879be5674a4eed0811c21fd34f94
On Mon, Jun 11, 2018 at 11:59:06PM +0530, Sukrit Bhatnagar wrote:
> On Mon, 11 Jun 2018 at 16:35, Pavel Hrdina wrote:
> >
> > On Mon, Jun 11, 2018 at 12:59:11PM +0200, Martin Kletzander wrote:
> > > On Mon, Jun 11, 2018 at 12:53:47PM +0200, Erik Skultety wrote:
> > > > On Mon, Jun 11, 2018 at 12:4
On Tue, Jun 12, 2018 at 01:32:59PM -0400, Anya Harter wrote:
Currently, there are four wrapper functions which call
virObjectEventStateQueue:
- testObjectEventQueue
- libxlDomainEventQueue
- qemuDomainEventQueue
- umlDomainEventQueue
This patch series removes these wrappers makes all
98 matches
Mail list logo
