On Wed, Jun 13, 2018 at 12:53 AM +0200, John Ferlan wrote:
> On 05/09/2018 10:56 AM, Marc Hartmayer wrote:
>> The force boot emulation is only required for virDomainCreateWithFlags
>> as the flag VIR_DOMAIN_START_FORCE_BOOT was introduced with the commit
>>
On Mon, Jun 11, 2018 at 11:59:06PM +0530, Sukrit Bhatnagar wrote:
> On Mon, 11 Jun 2018 at 16:35, Pavel Hrdina wrote:
> >
> > On Mon, Jun 11, 2018 at 12:59:11PM +0200, Martin Kletzander wrote:
> > > On Mon, Jun 11, 2018 at 12:53:47PM +0200, Erik Skultety wrote:
> > > > On Mon, Jun 11, 2018 at
On Tue, Jun 12, 2018 at 04:23:37PM +0200, Erik Skultety wrote:
Libvirt recently introduced support for getting launch security
parameters, most notably AMD SEV VM memory measurement. This API can't
be generated as it's using typed parameters which we need to allocate.
Signed-off-by: Erik
On Wed, Jun 13, 2018 at 09:02:12AM +0200, Ján Tomko wrote:
> On Tue, Jun 12, 2018 at 04:23:37PM +0200, Erik Skultety wrote:
> > Libvirt recently introduced support for getting launch security
> > parameters, most notably AMD SEV VM memory measurement. This API can't
> > be generated as it's using
On Tue, Jun 12, 2018 at 01:32:59PM -0400, Anya Harter wrote:
Currently, there are four wrapper functions which call
virObjectEventStateQueue:
- testObjectEventQueue
- libxlDomainEventQueue
- qemuDomainEventQueue
- umlDomainEventQueue
This patch series removes these wrappers makes
On Tue, Jun 12, 2018 at 04:06:45PM +0200, Andrea Bolognani wrote:
> As suggested in
>
> https://www.redhat.com/archives/libvir-list/2018-June/msg00943.html
>
> Andrea Bolognani (3):
> projects: Drop libvirt-master-build-website job
> guests: Drop libvirt+website project
> guests: Drop
From: Chen Hanxiao
s/httsp/https
Signed-off-by: Chen Hanxiao
---
src/libvirt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index ffb002f4e1..52f4dd2808 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -1098,7 +1098,7 @@
On Tue, Jun 12, 2018 at 10:32:06AM -0400, John Ferlan wrote:
Add a check during qemuDomainAttachDeviceConfig whether the
new/incoming device would have an existing
already and if so fail the attach. This can happen
if two hostdev's are added supplying the same address or
if the new hostdev
On Mon, Jun 04, 2018 at 06:25 PM +0200, "Daniel P. Berrangé"
wrote:
> On Thu, Apr 26, 2018 at 08:16:54PM -0400, John Ferlan wrote:
>>
>>
>> On 04/26/2018 12:09 PM, Marc Hartmayer wrote:
>> > On Thu, Apr 26, 2018 at 05:06 PM +0200, John Ferlan
>> > wrote:
>> >> On 04/12/2018 08:40 AM, Marc
On Wed, Jun 13, 2018 at 12:54:54PM +0200, Andrea Bolognani wrote:
> On Mon, 2018-06-11 at 12:12 +0200, Pavel Hrdina wrote:
> > Another issue that we need to take into account is that the external
> > free functions might not be 'NULL' safe which we need to somehow ensure
> > if they will be used
On 06/13/2018 07:15 AM, Ján Tomko wrote:
> On Tue, Jun 12, 2018 at 06:06:02PM -0400, Laine Stump wrote:
>> On 06/12/2018 10:32 AM, John Ferlan wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1559867
>>>
>>> When attaching a device to the domain we need to be sure
>>> to use the correct
On Wed, Jun 13, 2018 at 01:54:37PM +0200, Michal Privoznik wrote:
On 06/13/2018 05:00 AM, Bo YU wrote:
Hello,
The libvirt is a cool tool, i like it.
Thank you :-)
Here is output of strace:
Nothing odd looking here. Can you run 'virsh list', then attach gdb to
libvirtd and run 't a a bt'
This binding allows to query the AMD's SEV firmware for various platform
specific things, like a PDH certificate and a certificate chain to
establish a trusted connection with the firmware. Because the API uses
typed params, it's exempted from generation.
Signed-off-by: Erik Skultety
---
Add support for the recently introduced AMD SEV APIs.
since v1:
- fixed indentation issues
- built against a refreshed master and fixed some compilation errors
- added virNodeGetSEVInfo to the XML api override list
Erik Skultety (2):
Add support for virDomainGetLaunchSecurityInfo
Add support
Libvirt recently introduced support for getting launch security
parameters, most notably AMD SEV VM memory measurement. This API can't
be generated as it's using typed parameters which we need to allocate.
Signed-off-by: Erik Skultety
---
generator.py | 1 +
On 06/13/2018 04:15 AM, Ján Tomko wrote:
> On Tue, Jun 12, 2018 at 10:32:06AM -0400, John Ferlan wrote:
>> Add a check during qemuDomainAttachDeviceConfig whether the
>> new/incoming device would have an existing
>> already and if so fail the attach. This can happen
>> if two hostdev's are
On Tue, Jun 12, 2018 at 06:06:02PM -0400, Laine Stump wrote:
On 06/12/2018 10:32 AM, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1559867
When attaching a device to the domain we need to be sure
to use the correct domain definition (vm->def or vm->newDef)
when calling
On Wed, Jun 13, 2018 at 12:12:51PM +0100, Daniel P. Berrangé wrote:
On Tue, Jun 12, 2018 at 02:00:16PM +0200, Ján Tomko wrote:
Adjust the documentation, parser and tests to change:
launch-security -> launchSecurity
reduced-phys-bits -> reducedPhysBits
dh-cert -> dhCert
Also fix the headline in
On some systems, EXIT_SUCCESS and EXIT_FAILURE require inclusion
of stdlib.h
Signed-off-by: Ján Tomko
---
Pushed as a build breaker fix.
tests/test_util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/test_util.c b/tests/test_util.c
index 9611192..b7fafb6 100644
---
On 06/13/2018 03:45 PM, Bo YU wrote:
> On Wed, Jun 13, 2018 at 01:54:37PM +0200, Michal Privoznik wrote:
>> On 06/13/2018 05:00 AM, Bo YU wrote:
>>> Hello,
>>> The libvirt is a cool tool, i like it.
>>
>> Thank you :-)
>>
>>>
>>> Here is output of strace:
>>>
>>
>> Nothing odd looking here. Can
On Sun, Jun 10, 2018 at 12:14:22PM +0100, Radostin Stoyanov wrote:
> Hi all,
>
> This patch series aims to resolve
> https://bugzilla.redhat.com/show_bug.cgi?id=1328946
>
> For background information about the issue see v1 of this RFC.
>
On Wed, Jun 13, 2018 at 02:30:23PM +0300, Mathieu Tarral wrote:
> Hi !
>
> I'm trying to reproduce a bug that i'm facing with libvirt 3.0.0 on
> Debian stretch.
> I compiled the latest stable libvirt (4.4.0), and installed it:
>
> ./autogen.sh
> ./configure --prefix=$HOME/usr
On 06/13/2018 05:00 AM, Bo YU wrote:
> Hello,
> The libvirt is a cool tool, i like it.
Thank you :-)
>
> Here is output of strace:
>
Nothing odd looking here. Can you run 'virsh list', then attach gdb to
libvirtd and run 't a a bt' and share the output please?
I wonder if this is the bug that
Jiri Denemark writes ("Re: [libvirt] Likely build race, "/usr/bin/ld: cannot
find -lvirt""):
> On Tue, Jun 12, 2018 at 07:57:40 -0500, Eric Blake wrote:
> > Can you add that line directly into Makefile.am, or does doing that
> > cause automake to complain and/or omit its normal rules because it
On 06/07/2018 08:17 AM, Marc Hartmayer wrote:
> On Wed, May 09, 2018 at 09:51 PM +0200, John Ferlan
> wrote:
>> On 05/07/2018 11:24 AM, Marc Hartmayer wrote:
>>> On Mon, Apr 30, 2018 at 03:20 PM +0200, John Ferlan
>>> wrote:
On 04/25/2018 11:55 AM, Marc Hartmayer wrote:
> 1. Don't
On Wed, 2018-06-13 at 16:35 +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> s/httsp/https
You need a leading slash as well :)
> Signed-off-by: Chen Hanxiao
> ---
> src/libvirt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libvirt.c b/src/libvirt.c
>
On Tue, Jun 12, 2018 at 04:06:45PM +0200, Andrea Bolognani wrote:
> As suggested in
>
> https://www.redhat.com/archives/libvir-list/2018-June/msg00943.html
>
> Andrea Bolognani (3):
> projects: Drop libvirt-master-build-website job
> guests: Drop libvirt+website project
> guests: Drop
On Tue, Jun 12, 2018 at 12:12:12PM +0200, Andrea Bolognani wrote:
> Instead of starting from the minimal Ubuntu 18.04 base
> image and installing all requirements at build time,
> use a Docker image that has been specifically tailored
> at building libvirt and thus already includes all
> required
On Tue, Jun 12, 2018 at 02:00:15PM +0200, Ján Tomko wrote:
> We have enough elements using underscores instead of camelCase,
> do not bring dashes into the mix.
>
> Signed-off-by: Ján Tomko
> ---
> docs/formatdomaincaps.html.in | 2 +-
> docs/schemas/domaincaps.rng| 2 +-
>
On Tue, Jun 12, 2018 at 02:00:16PM +0200, Ján Tomko wrote:
> Adjust the documentation, parser and tests to change:
> launch-security -> launchSecurity
> reduced-phys-bits -> reducedPhysBits
> dh-cert -> dhCert
>
> Also fix the headline in formatdomain.html to be more generic,
> and some leftover
On Wed, 2018-06-13 at 12:59 +0200, Pavel Hrdina wrote:
> On Wed, Jun 13, 2018 at 12:54:54PM +0200, Andrea Bolognani wrote:
> > On Mon, 2018-06-11 at 12:12 +0200, Pavel Hrdina wrote:
> > > That way we can use any existing free function regardless whether it
> > > checks if the variable is NULL or
On Wed, Jun 13, 2018 at 08:26:40AM -0400, John Ferlan wrote:
Or we could focus our energy elsehwere.
I like this option... Fix the one offs when/if they show up and move
on. If someone, some day has the desire to write patches that will
revamp device address assignment, good luck!
I
On 06/13/2018 08:36 AM, Ján Tomko wrote:
> On Wed, Jun 13, 2018 at 08:26:40AM -0400, John Ferlan wrote:
>>>
>>> Or we could focus our energy elsehwere.
>>>
>>
>> I like this option... Fix the one offs when/if they show up and move
>> on. If someone, some day has the desire to write patches
We can reasonably expect the next major release of CentOS
to be somewhat close to current Fedora releases in terms of
packaging, and to ditch the soon-to-be-unsupported Python 2
in favor of Python 3.
Rewrite some of the mappings based on these expectations.
Signed-off-by: Andrea Bolognani
---
On Tue, Jun 12, 2018 at 02:00:21PM +0200, Ján Tomko wrote:
> A common cleanup path for both the success and the error case.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_process.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé
On Tue, Jun 12, 2018 at 02:00:17PM +0200, Ján Tomko wrote:
> Do not mask the errors.
>
> If we'd expect query-sev-capabilities to fail, we should not
> call it in the first place.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_capabilities.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On Tue, Jun 12, 2018 at 02:00:18PM +0200, Ján Tomko wrote:
> It is only used in one place.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_capabilities.c | 14 ++
> 1 file changed, 2 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|:
On Tue, Jun 12, 2018 at 02:00:19PM +0200, Ján Tomko wrote:
> Free tmp even on failure.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Wed, Jun 13, 2018 at 02:58:55PM +0200, Andrea Bolognani wrote:
> On Wed, 2018-06-13 at 11:32 +0100, Daniel P. Berrangé wrote:
> > On Tue, Jun 12, 2018 at 12:12:12PM +0200, Andrea Bolognani wrote:
> > > The pre-built images have been hand-crafted using the
> > > build dependencies recorded in
Firstly, this function changes node for relative XPaths but
doesn't restore the original one in case VIR_ALLOC(def) fails.
Secondly, @type is leaked. Thirdly, dh-cert and session
attributes are strdup()-ed needlessly, virXPathString already
does that so we can use the retval immediately.
On Wed, Jun 13, 2018 at 12:54:54PM +0200, Andrea Bolognani wrote:
> On Mon, 2018-06-11 at 12:12 +0200, Pavel Hrdina wrote:
> > Another issue that we need to take into account is that the external
> > free functions might not be 'NULL' safe which we need to somehow ensure
> > if they will be used
Hi !
I'm trying to reproduce a bug that i'm facing with libvirt 3.0.0 on
Debian stretch.
I compiled the latest stable libvirt (4.4.0), and installed it:
./autogen.sh
./configure --prefix=$HOME/usr --localstatedir=/var
make
sudo make install
But when i try to run ~/usr/bin/virsh version, it
On Wed, Jun 13, 2018 at 12:51:58PM +0200, Michal Privoznik wrote:
The buffer is not freed anywhere. Nor in the error paths. Also
the usage virCommand with respect to buffer is very odd.
==2504== 1,100 bytes in 1 blocks are definitely lost in loss record 167 of 175
==2504==at 0x4C2CE3F:
On Wed, Jun 13, 2018 at 12:51:57PM +0200, Michal Privoznik wrote:
The variable points to a buffer not a domain object therefore its
current name is misleading.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
On 06/13/2018 08:34 AM, Kevin Wolf wrote:
> We deprecated a bunch of -drive options in 2.10, so let's remove them
> for 3.0.
>
> Kevin Wolf (3):
> block: Remove deprecated -drive geometry options
> block: Remove deprecated -drive option addr
> block: Remove deprecated -drive option serial
>
On Wed, 2018-06-13 at 11:16 +0100, Daniel P. Berrangé wrote:
> On Wed, Jun 13, 2018 at 12:13:37PM +0200, Andrea Bolognani wrote:
> > On Wed, 2018-06-13 at 16:35 +0800, Chen Hanxiao wrote:
> > > From: Chen Hanxiao
> > >
> > > s/httsp/https
> >
> > You need a leading slash as well :)
>
>
The buffer is not freed anywhere. Nor in the error paths. Also
the usage virCommand with respect to buffer is very odd.
==2504== 1,100 bytes in 1 blocks are definitely lost in loss record 167 of 175
==2504==at 0x4C2CE3F: malloc (vg_replace_malloc.c:298)
==2504==by 0x4C2F1BF: realloc
*** BLURB HERE ***
Michal Privoznik (3):
qemuBuildSevCommandLine: s/obj/buf/
qemuBuildSevCommandLine: fix buffer leak
conf: Rework virDomainSEVDefParseXML()
src/conf/domain_conf.c | 30 +-
src/qemu/qemu_command.c | 25 +++--
2 files
The variable points to a buffer not a domain object therefore its
current name is misleading.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
Hello,
On Wed, Jun 13, 2018 at 01:54:37PM +0200, Michal Privoznik wrote:
On 06/13/2018 05:00 AM, Bo YU wrote:
Hello,
The libvirt is a cool tool, i like it.
Thank you :-)
Here is output of strace:
Nothing odd looking here. Can you run 'virsh list', then attach gdb to
libvirtd and run 't
On Wed, Jun 13, 2018 at 12:13:37PM +0200, Andrea Bolognani wrote:
> On Wed, 2018-06-13 at 16:35 +0800, Chen Hanxiao wrote:
> > From: Chen Hanxiao
> >
> > s/httsp/https
>
> You need a leading slash as well :)
s/leading/trailing :-P
Regards,
Daniel
--
|: https://berrange.com -o-
On Mon, 2018-06-11 at 12:12 +0200, Pavel Hrdina wrote:
> Another issue that we need to take into account is that the external
> free functions might not be 'NULL' safe which we need to somehow ensure
> if they will be used with attribute cleanup.
>
> The original design is probably wrong and was
Hello,
The libvirt is a cool tool, i like it.
But, i have some question to ask.
First, i install
libvirt-dev virtinst libvirt-daemon libvirt-daemon-system
using debian-apt.It works for me a long time.But, i wanted to modify
rx_queue_size in net(maybe controled by qemu).So, i git clone
On Wed, 2018-06-13 at 11:32 +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 12, 2018 at 12:12:12PM +0200, Andrea Bolognani wrote:
> > The pre-built images have been hand-crafted using the
> > build dependencies recorded in the libvirt-jenkins-ci
> > repository: of course that's not something that
On Wed, Jun 13, 2018 at 12:51:59PM +0200, Michal Privoznik wrote:
Firstly, this function changes node for relative XPaths but
doesn't restore the original one in case VIR_ALLOC(def) fails.
This should not matter, since we're going to abort parsing anyway.
Secondly, @type is leaked. Thirdly,
On Tue, Jun 12, 2018 at 02:00:23PM +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 4 ++--
> src/qemu/qemu_process.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com
On Tue, Jun 12, 2018 at 02:00:22PM +0200, Ján Tomko wrote:
> Some identifiers use Sev, some SEV. Prefer the latter.
>
> Signed-off-by: Ján Tomko
> ---
> src/conf/domain_conf.c | 8
> src/conf/domain_conf.h | 8
> src/qemu/qemu_command.c | 2 +-
> src/qemu/qemu_process.c | 2
On Tue, Jun 12, 2018 at 02:00:20PM +0200, Ján Tomko wrote:
> Make the function prefix match the file it's in.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_process.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
On Tue, Jun 12, 2018 at 02:00:24PM +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_monitor_json.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
When testing a domain XML with TPM we overwrite UNIX socket path
to mimic what qemuTPMEmulatorPrepareHost() is doing (because
*PrepareHost() functions are not called from the test). But we
are not doing it fully - we need to set the chardev's type too so
that virDomainTPMDefFree() can free the
On 13/06/18 11:46, Daniel P. Berrangé wrote:
> On Sun, Jun 10, 2018 at 12:14:22PM +0100, Radostin Stoyanov wrote:
>> Hi all,
>>
>> This patch series aims to resolve
>> https://bugzilla.redhat.com/show_bug.cgi?id=1328946
>>
>> For background information about the issue see v1 of this RFC.
>>
Hi Daniel,
>
> What version of QEMU do you have installed ? Libvirt has recently
> become more aggressive at requiring modern QEMU versions, so its
> possible if your old libvirt was running against old QEMU, that
> might not be supported with new libvirt.
I'm using QEMU 2.8 here.
That might
FWIW: While I'm not the best at naming things, it would seem to me that
this should be named "Nowait" rather than "Instant".
On 06/07/2018 07:59 AM, Michal Privoznik wrote:
> The aim of this API is to allow caller do best effort. Some
s/allow caller/allow the caller/
s/do best effort/to avoid
On Wed, Jun 13, 2018 at 03:50:04PM +0200, Michal Privoznik wrote:
On 06/13/2018 03:45 PM, Bo YU wrote:
On Wed, Jun 13, 2018 at 01:54:37PM +0200, Michal Privoznik wrote:
On 06/13/2018 05:00 AM, Bo YU wrote:
Hello,
The libvirt is a cool tool, i like it.
Thank you :-)
Here is output of
On Wed, Jun 13, 2018 at 11:17:30AM -0300, Eduardo Habkost wrote:
> On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote:
> > > We can keep daemonizing flow in QEMU as it's now.
> > > But Eduardo's idea about libvirt
2018-06-13 18:07 GMT+03:00 Daniel P. Berrangé :
> On Wed, Jun 13, 2018 at 05:59:37PM +0300, Mathieu Tarral wrote:
>> >> >
>> >> > What version of QEMU do you have installed ? Libvirt has recently
>> >> > become more aggressive at requiring modern QEMU versions, so its
>> >> > possible if your old
>> >
>> > What version of QEMU do you have installed ? Libvirt has recently
>> > become more aggressive at requiring modern QEMU versions, so its
>> > possible if your old libvirt was running against old QEMU, that
>> > might not be supported with new libvirt.
>>
>> I'm using QEMU 2.8 here.
>>
On Wed, Jun 13, 2018 at 05:59:37PM +0300, Mathieu Tarral wrote:
> >> >
> >> > What version of QEMU do you have installed ? Libvirt has recently
> >> > become more aggressive at requiring modern QEMU versions, so its
> >> > possible if your old libvirt was running against old QEMU, that
> >> >
$SUBJ: s/add/Add
Might be nice to add something here... You could even add your qemu
commit id that added this for QEMU 2.12, e.g.
QEMU 2.12 commit id bf1e7140e provides balloon statistics for how much
memory can be quickly reclaimed without additional I/O, so let's add
reporting that to the
On Wed, Jun 13, 2018 at 03:18:02PM +0100, Radostin Stoyanov wrote:
> > Ideally qemu-nbd would automatically exit when the last use of /dev/nbdNNN
> > was release (ie when filesystem was unmounted). This is something you can
> > enable for loopback devices, but I'm not sure it works for NBD. THis
On 06/07/2018 07:59 AM, Michal Privoznik wrote:
> Provide a small comment on the function and its parameters.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 18 --
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git
On 06/07/2018 07:59 AM, Michal Privoznik wrote:
> The variable is initialized to -1 already. There's no way it can
> be overwritten by the time control gets to the line I'm removing.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 1 -
> 1 file changed, 1 deletion(-)
>
On Wed, Jun 13, 2018 at 06:13:04PM +0300, Mathieu Tarral wrote:
> 2018-06-13 18:07 GMT+03:00 Daniel P. Berrangé :
> > On Wed, Jun 13, 2018 at 05:59:37PM +0300, Mathieu Tarral wrote:
> >> >> >
> >> >> > What version of QEMU do you have installed ? Libvirt has recently
> >> >> > become more
On 05/17/2018 05:43 PM, Eric Blake wrote:
Here's my updated counterproposal for a backup API.
/**
* virDomainBackupBegin:
* @domain: a domain object
* @diskXml: description of storage to utilize and expose during
* the backup, or NULL
* @checkpointXml: description of a
On Tue, Jun 12, 2018 at 11:00:14AM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/Makefile.am| 3 +-
data/org.libvirt.StorageVol.xml | 7 +++
src/Makefile.am | 3 +-
src/connect.c | 6 +++
src/connect.h
On Wed, 2018-06-13 at 14:28 +0100, Daniel P. Berrangé wrote:
> On Wed, Jun 13, 2018 at 02:58:55PM +0200, Andrea Bolognani wrote:
> > Pretty much exactly how I've created the images you can find on
> > Docker Hub, except for
> >
> > > RUN mkdir /build
> > > WORKDIR /build
> >
> > this bit,
$SUBJ: "Introduce" and "NO_WAIT"
On 06/07/2018 07:59 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1552092
>
> If there's a long running job it might cause us to wait 30
> seconds before we give up acquiring job. This may cause trouble
s/job/the job/
s/may cause
On 06/07/2018 07:59 AM, Michal Privoznik wrote:
> This new switch can be used to set
> VIR_CONNECT_GET_ALL_DOMAINS_STATS_BEST_EFFORT flag for stats
> fetching API.
I'll reiterate my preference for nowait
>
> Signed-off-by: Michal Privoznik
> ---
> tools/virsh-domain-monitor.c | 7 +++
On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote:
> > We can keep daemonizing flow in QEMU as it's now.
> > But Eduardo's idea about libvirt created socked + letting QEMU connect to it
> > has a merit. It should fix
On Wed, Jun 13, 2018 at 05:40:52PM +0300, Mathieu Tarral wrote:
> Hi Daniel,
>
> >
> > What version of QEMU do you have installed ? Libvirt has recently
> > become more aggressive at requiring modern QEMU versions, so its
> > possible if your old libvirt was running against old QEMU, that
> >
On Tue, Jun 12, 2018 at 11:00:15AM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StoragePool.xml | 6 ++
src/storagepool.c| 44
tests/test_storage.py| 8
3 files changed, 58
Upcoming patches will add support for incremental backups via
a new API; but first, we need a landing page that gives an
overview of capturing various pieces of guest state, and which
APIs are best suited to which tasks.
Signed-off-by: Eric Blake
---
docs/docs.html.in | 5 ++
Prepare for introducing a bunch of new public APIs related to
backup checkpoints by first introducing a new internal type
and errors associated with that type. Checkpoints are modeled
heavily after virDomainSnapshotPtr (both represent a point in
time of the guest), although a snapshot exists with
The remote code generator had to be taught about the new
virDomainCheckpointPtr type, at which point the remote driver
code for backups can be generated.
Signed-off-by: Eric Blake
---
src/remote/remote_daemon_dispatch.c | 15 +++
src/remote/remote_driver.c | 31 -
Creating a checkpoint does not modify guest-visible state,
but does modify host resources. Rather than reuse existing
domain:write, domain:block_write, or domain:snapshot access
controls, it seems better to introduce a new access control
specific to tasks related to checkpoints and incremental
On Wed, Jun 13, 2018 at 03:23:09PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jun 13, 2018 at 11:17:30AM -0300, Eduardo Habkost wrote:
> > On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote:
> > > > We can keep
Introduce a few more new public APIs related to incremental backups.
This builds on the previous notion of a checkpoint (without an
existing checkpoint, the new API is a full backup, differing only
from virDomainCopy in the point of time chosen); and also allows
creation of a new checkpoint at the
I'm offline the rest of this week, but wanted to post the
progress I've made on patches towards the Incremental Backup RFC:
https://www.redhat.com/archives/libvir-list/2018-May/msg01403.html
Comments welcome, including any naming suggestions
Still to go:
- Add .rng file for validating the XML
Prepare for new checkpoint and backup APIs by describing the XML
that will represent a checkpoint. This is modeled heavily after
the XML for virDomainSnapshotPtr, since both represent a point in
time of the guest. But while a snapshot exists with the intent
of rolling back to that state, a
Upcoming patches plan to introduce virDomainCheckpointPtr as a new
object for use in incremental backups, along with documentation
how incremental backups differ from snapshots. But first, we need
to rename any existing mention of a 'system checkpoint' to instead
be a 'full system state
Introduce a bunch of new public APIs related to backup checkpoints.
Checkpoints are modeled heavily after virDomainSnapshotPtr (both
represent a point in time of the guest), although a snapshot exists
with the intent of rolling back to that state, while a checkpoint
exists to make it possible to
Getting back to this discussion:
On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote:
> > Hi,
> >
> > > > Add to that shortcuts like -cdrom
> > > > stop working,
> > >
> > > Maybe is fixable.
> >
> > Already
On Wed, 13 Jun 2018 10:41:49 +0200
Gerd Hoffmann wrote:
> So we have a boot display when using a vgpu as primary display.
>
> Use vfio-pci-ramfb instead of vfio-pci to enable it.
Using a different device here seems like it almost guarantees a very
complicated path to support under libvirt.
On Wed, Jun 13, 2018 at 01:50:47PM -0600, Alex Williamson wrote:
> On Wed, 13 Jun 2018 10:41:49 +0200
> Gerd Hoffmann wrote:
>
> > So we have a boot display when using a vgpu as primary display.
> >
> > Use vfio-pci-ramfb instead of vfio-pci to enable it.
>
> Using a different device here
On 06/08/2018 09:45 AM, Michal Privoznik wrote:
> The point is to break QEMU_JOB_* into smaller pieces which
> enables us to achieve higher throughput. For instance, if there
> are two threads, one is trying to query something on qemu
> monitor while the other is trying to query something on
On 06/08/2018 09:45 AM, Michal Privoznik wrote:
> These jobs can be used to mark job type over qemu agent.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 4 +++-
> src/qemu/qemu_domain.h | 2 ++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git
On 06/08/2018 09:45 AM, Michal Privoznik wrote:
> There are two sets of functions here:
> 1) some functions talk on both monitor and agent monitor,
> 2) some functions only talk on agent monitor.
>
> For functions from set 1) we need to use
> qemuDomainObjBeginJobWithAgent() and for functions
On 06/13/2018 09:00 AM, John Ferlan wrote:
>
> On 06/13/2018 08:36 AM, Ján Tomko wrote:
>> On Wed, Jun 13, 2018 at 08:26:40AM -0400, John Ferlan wrote:
Or we could focus our energy elsehwere.
>>> I like this option... Fix the one offs when/if they show up and move
>>> on. If someone,
On 06/08/2018 09:45 AM, Michal Privoznik wrote:
> This enum will list all possible jobs for guest agent. The idea
> is when a thread needs to talk to guest agent only it will take
> the QEMU_AGENT_JOB instead of QEMU_JOB helping better
> concurrency.
Consider:
Introduce guest agent specific
This patchset finishes the conversion to virConfGetValue* functions,
started by Daniel Berrange a few months ago.
Please, mind that although we could make virConfGetValue* functions more
generic in order to support numbers and booleans as strings, that
doesn't seem the safest path to take. The
1 - 100 of 103 matches
Mail list logo
