Re: [libvirt] [PATCH for 5.7.0 0/2] virsh: Rename --precopy-bandwidth migration option

2019-09-02 Thread Jim Fehlig
On 9/2/19 9:08 AM, Jiri Denemark wrote: > The (pre-copy) bandwidth was historically the only bandwidth we > supported and thus it is called just "bandwidth" in all other places. > E.g., virsh migrate-setspeed or in the migration typed parameter name. > Let's make the new option for virsh migrate

[libvirt] [PATCH 0/2] Remove xenapi driver

2019-09-02 Thread Jim Fehlig
Remove the xenapi driver is unmaintained and has no known user base. We are stuck with references in include/libvirt/virterror.h and src/util/virerror.c but otherwise I think I've nuked xenapi everywhere. Jim Fehlig (2): xenapi: remove driver news: Mention removal of xenapi driver cfg.mk

[libvirt] [PATCH 2/2] news: Mention removal of xenapi driver

2019-09-02 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 92d566c2fe..303078036d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -63,6 +63,16 @@ KVM device assignment from libvirt too.

[libvirt] [PATCH 1/2] xenapi: remove driver

2019-09-02 Thread Jim Fehlig
The xenapi driver has not seen any development since its initial contribution 9 years ago. There have been no bug reports, no patches, and no queries about the driver on the developer or user mailing lists. Remove the driver from the libvirt sources. Signed-off-by: Jim Fehlig --- cfg.mk

Re: [libvirt] Availability of libvirt 5.7.0 Release Candidate 2

2019-09-02 Thread Andrea Bolognani
On Sun, 2019-09-01 at 21:13 +0200, Daniel Veillard wrote: > I have just tagged RC2 in git and pushed the signed tarball and source rpm > to > the usual place: > https://libvirt.org/sources/ > > Seems fine in my minimal testing, there is two red spots in CI at > CI

Re: [libvirt] Error when creating VM with persistent memory

2019-09-02 Thread Michal Privoznik
On 8/31/19 7:33 PM, Seema Pandit wrote: Hi Michal, Thank you for the reply. I was having issues compiling qemu code on fedora29. So instead of dropping prealloc in virsh, tried adding prealloc=yes in qemu command line. prealloc=yes works. It does not lead to using more system memory when using

Re: [libvirt] Availability of libvirt 5.7.0 Release Candidate 2

2019-09-02 Thread Michal Privoznik
On 9/1/19 9:13 PM, Daniel Veillard wrote: I have just tagged RC2 in git and pushed the signed tarball and source rpm to the usual place: https://libvirt.org/sources/ Sorry for raising this issue this late, but I found out only during weekend when I tried to build libvirt on my home

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-09-02 Thread Kevin Wolf
Am 30.08.2019 um 20:11 hat John Snow geschrieben: > > > On 8/30/19 6:07 AM, Christophe de Dinechin wrote: > > Without having looked at the code much, I think I would > > > > 1. extend the existing QAPI error to support warnings, deprecations and > >info messages. The first problem I see is

Re: [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

2019-09-02 Thread Kevin Wolf
Am 23.08.2019 um 11:22 hat Vladimir Sementsov-Ogievskiy geschrieben: > 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: > > To get rid of implicit filters related workarounds in future let's > > deprecate them now. > > Interesting, could we deprecate implicit filter without deprecation of >

Re: [libvirt] [PATCH v2 10/10] tests: Introduce resolution test for VGA model

2019-09-02 Thread Julio Faracco
This patch is missing XML files for VGA test case. I will wait for review until submit a V3. -- Julio Cesar Faracco Em sex, 30 de ago de 2019 às 18:43, escreveu: > > From: Julio Faracco > > New test case was added to cover 'xres' and 'yres' properties for VGA > model due to latest QEMU

Re: [libvirt] [PATCH] qemu: domain: Fix potential NULL deref when parsing job private data

2019-09-02 Thread John Ferlan
On 9/2/19 10:13 AM, Peter Krempa wrote: > A specially crafted XML which would reference a non-existing disk but > request the mirror to be registered with the blockjob could potentially > make the parser dereference NULL. Fix it by moving the code slightly and > just treat it as a wrong job

Re: [libvirt] [PATCH] qemu: domain: Fix potential NULL deref when parsing job private data

2019-09-02 Thread Erik Skultety
On Mon, Sep 02, 2019 at 04:13:55PM +0200, Peter Krempa wrote: > A specially crafted XML which would reference a non-existing disk but > request the mirror to be registered with the blockjob could potentially > make the parser dereference NULL. Fix it by moving the code slightly and > just treat it

[libvirt] [PATCH for 5.7.0 0/2] virsh: Rename --precopy-bandwidth migration option

2019-09-02 Thread Jiri Denemark
The (pre-copy) bandwidth was historically the only bandwidth we supported and thus it is called just "bandwidth" in all other places. E.g., virsh migrate-setspeed or in the migration typed parameter name. Let's make the new option for virsh migrate consistent. Jiri Denemark (2): virsh: Rename

[libvirt] [PATCH 2/2] news: Rename --precopy-bandwidth migration option

2019-09-02 Thread Jiri Denemark
The (pre-copy) bandwidth was historically the only bandwidth we supported and thus it is called just "bandwidth" in all other places. E.g., virsh migrate-setspeed or in the migration typed parameter name. Let's make the new option for virsh migrate consistent. Signed-off-by: Jiri Denemark ---

[libvirt] [PATCH 1/2] virsh: Rename --precopy-bandwidth migration option

2019-09-02 Thread Jiri Denemark
The (pre-copy) bandwidth was historically the only bandwidth we supported and thus it is called just "bandwidth" in all other places. E.g., virsh migrate-setspeed or in the migration typed parameter name. Let's make the new option for virsh migrate consistent. Signed-off-by: Jiri Denemark ---

Re: [libvirt] [PATCH 6/7] build: link to glib library

2019-09-02 Thread Ján Tomko
On Thu, Aug 29, 2019 at 07:02:49PM +0100, Daniel P. Berrangé wrote: Add the main glib.h to internal.h so that all common code can use it. Signed-off-by: Daniel P. Berrangé --- src/Makefile.am| 2 ++ src/internal.h | 1 + src/lxc/Makefile.inc.am| 2 ++

Re: [libvirt] [PATCH 5/7] build: probe for glib-2 library in configure

2019-09-02 Thread Daniel P . Berrangé
On Mon, Sep 02, 2019 at 04:05:12PM +0200, Ján Tomko wrote: > On Thu, Aug 29, 2019 at 07:02:48PM +0100, Daniel P. Berrangé wrote: > > Prepare for linking with glib by probing for it at configure > > time. Per supported platforms target, the min glib versions on > > relevant distros are: > > > >

[libvirt] [PATCH] util: Set backing file name for LOOP_GET_STATUS64 queries.

2019-09-02 Thread jcfaracco
From: Julio Faracco This is an issue for LXC loop devices when you are trying to get loop devices info using `ioctl`. Modern apps uses `/sys/dev/block` to grab information about devices, but if you use the method mention you won't be able to retrive the associated file with that loop device. See

[libvirt] [PATCH python] spec: Build python2 package in fedora < 31

2019-09-02 Thread Nir Soffer
Since commit ee0cfbe65c5d (spec: Unconditionally build python2 on Fedora) python2-libvirt is not built on any Fedora version. Fix the spec to drop python2-libvirt on Fedora 31. Signed-off-by: Nir Soffer --- libvirt-python.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [libvirt] [PATCH for 5.7.0 0/2] virsh: Rename --precopy-bandwidth migration option

2019-09-02 Thread Daniel P . Berrangé
On Mon, Sep 02, 2019 at 05:08:12PM +0200, Jiri Denemark wrote: > The (pre-copy) bandwidth was historically the only bandwidth we > supported and thus it is called just "bandwidth" in all other places. > E.g., virsh migrate-setspeed or in the migration typed parameter name. > Let's make the new

Re: [libvirt] [RFC] On present using dummy hostdev usb device

2019-09-02 Thread Daniel P . Berrangé
On Mon, Sep 02, 2019 at 02:11:01PM +, Roman Kagan wrote: > On Fri, Aug 30, 2019 at 04:19:23PM +0100, Daniel P. Berrangé wrote: > > On Fri, Aug 30, 2019 at 05:08:52PM +0200, Michal Privoznik wrote: > > > On 8/30/19 2:30 PM, Roman Kagan wrote: > > > > On Fri, Aug 30, 2019 at 10:09:06AM +0100,

Re: [libvirt] [PATCH 7/7] util: use glib allocation functions

2019-09-02 Thread Ján Tomko
On Thu, Aug 29, 2019 at 07:02:50PM +0100, Daniel P. Berrangé wrote: GLib requires that any memory allocated with g_new/g_malloc/etc is free'd by g_free. This means mixing virAlloc with g_free, or g_new with virFree will violate API rules. The easy way to dea with this is to simply make our

Re: [libvirt] [PATCH 7/7] util: use glib allocation functions

2019-09-02 Thread Daniel P . Berrangé
On Mon, Sep 02, 2019 at 04:52:47PM +0200, Ján Tomko wrote: > On Thu, Aug 29, 2019 at 07:02:50PM +0100, Daniel P. Berrangé wrote: > > GLib requires that any memory allocated with g_new/g_malloc/etc > > is free'd by g_free. This means mixing virAlloc with g_free, > > or g_new with virFree will

Re: [libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory

2019-09-02 Thread Michal Privoznik
On 9/2/19 4:16 PM, Daniel P. Berrangé wrote: On Mon, Sep 02, 2019 at 02:07:08PM +, Jim Fehlig wrote: On 8/31/19 2:11 AM, Michal Prívozník wrote: On 8/26/19 1:49 PM, Ján Tomko wrote: The 'From:' field shows your e-mail in uppercase. On Fri, Aug 23, 2019 at 07:50:12PM +, Jim Fehlig

Re: [libvirt] [glib PATCH 0/2] Add gvir_config_domain_os_get_firmware() + _domain_os_get_machine() test

2019-09-02 Thread Fabiano Fidêncio
On Mon, Aug 26, 2019 at 7:03 PM Fabiano Fidêncio wrote: > > This series adds a way to retrive the DomainOs' Firmware set (with > tests) and, while touching that code, also adds one more check for > gvir_config_domain_os_get_machine(). > > Fabiano Fidêncio (2): > gconfig: Add

Re: [libvirt] [glib PATCH 0/2] Add gvir_config_domain_os_get_firmware() + _domain_os_get_machine() test

2019-09-02 Thread Michal Privoznik
On 8/26/19 7:03 PM, Fabiano Fidêncio wrote: This series adds a way to retrive the DomainOs' Firmware set (with tests) and, while touching that code, also adds one more check for gvir_config_domain_os_get_machine(). Fabiano Fidêncio (2): gconfig: Add _domain_os_get_firmware()

Re: [libvirt] [PATCH 4/7] util: make string functions abort on OOM

2019-09-02 Thread Ján Tomko
On Thu, Aug 29, 2019 at 07:02:47PM +0100, Daniel P. Berrangé wrote: The functions are left returning an "int" to avoid an immediate big-bang cleanup. They'll simply never return anything other than 0. Signed-off-by: Daniel P. Berrangé --- src/util/virstring.c | 93

Re: [libvirt] [RFC] On present using dummy hostdev usb device

2019-09-02 Thread Roman Kagan
On Fri, Aug 30, 2019 at 04:19:23PM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 30, 2019 at 05:08:52PM +0200, Michal Privoznik wrote: > > On 8/30/19 2:30 PM, Roman Kagan wrote: > > > On Fri, Aug 30, 2019 at 10:09:06AM +0100, Daniel P. Berrangé wrote: > > > > On Fri, Aug 30, 2019 at 08:44:03AM

Re: [libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory

2019-09-02 Thread Daniel P . Berrangé
On Mon, Sep 02, 2019 at 02:07:08PM +, Jim Fehlig wrote: > On 8/31/19 2:11 AM, Michal Prívozník wrote: > > On 8/26/19 1:49 PM, Ján Tomko wrote: > >> The 'From:' field shows your e-mail in uppercase. > >> > >> On Fri, Aug 23, 2019 at 07:50:12PM +, Jim Fehlig wrote: > >>> Signed-off-by: Jim

Re: [libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory

2019-09-02 Thread Jim Fehlig
On 9/2/19 8:16 AM, Daniel P. Berrangé wrote: > On Mon, Sep 02, 2019 at 02:07:08PM +, Jim Fehlig wrote: >> On 8/31/19 2:11 AM, Michal Prívozník wrote: >>> On 8/26/19 1:49 PM, Ján Tomko wrote: The 'From:' field shows your e-mail in uppercase. On Fri, Aug 23, 2019 at 07:50:12PM

Re: [libvirt] [rust PATCH] Add list_all_volumes method for storage_pool::StoragePool

2019-09-02 Thread Sahid Orentino Ferdjaoui
On Thu, Aug 29, 2019 at 02:05:12AM -0700, Sage Imel wrote: > From: Sage Imel > > Always returns the full list of volumes, > can't just ask it how many volumes are in the pool > > Signed-off-by: Sage Imel > --- That looks to be a nice add, thank you for this contribution, can you just consider

Re: [libvirt] [PATCH 1/7] util: purge all code for testing OOM handling

2019-09-02 Thread Ján Tomko
On Thu, Aug 29, 2019 at 07:02:44PM +0100, Daniel P. Berrangé wrote: The OOM handling requires special build time options which we never enable in our CI. Even once enabled the tests are incredibly slow and typically require manual inspection of the results to weed out false positives. Since

Re: [libvirt] [PATCH 5/7] build: probe for glib-2 library in configure

2019-09-02 Thread Ján Tomko
On Thu, Aug 29, 2019 at 07:02:48PM +0100, Daniel P. Berrangé wrote: Prepare for linking with glib by probing for it at configure time. Per supported platforms target, the min glib versions on relevant distros are: RHEL-8: 2.56.1 RHEL-7: 2.50.3 Debian (Buster): 2.58.3 Debian (Stretch):

Re: [libvirt] [PATCH v4 2/2] snapshot: Store both config and live XML in the snapshot domain

2019-09-02 Thread Daniel Henrique Barboza
On 8/29/19 5:55 PM, Maxiwell S. Garcia wrote: The snapshot-create operation of running guests saves the live XML and uses it to replace the active and inactive domain in case of revert. So, the config XML is ignored by the snapshot process. This commit changes it and adds the config XML in

Re: [libvirt] [PATCH v4 1/2] qemu: formatting XML from domain def choosing the root name

2019-09-02 Thread Daniel Henrique Barboza
On 8/29/19 5:55 PM, Maxiwell S. Garcia wrote: The function virDomainDefFormatInternal() has the predefined root name "domain" to format the XML. But to save both active and inactive domain in the snapshot XML, the new root name "inactiveDomain" was created. So, the new function

Re: [libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory

2019-09-02 Thread Jim Fehlig
On 8/31/19 2:11 AM, Michal Prívozník wrote: > On 8/26/19 1:49 PM, Ján Tomko wrote: >> The 'From:' field shows your e-mail in uppercase. >> >> On Fri, Aug 23, 2019 at 07:50:12PM +, Jim Fehlig wrote: >>> Signed-off-by: Jim Fehlig >>> --- >>> cfg.mk   |  2 +- >>>

[libvirt] [PATCH] qemu: domain: Fix potential NULL deref when parsing job private data

2019-09-02 Thread Peter Krempa
A specially crafted XML which would reference a non-existing disk but request the mirror to be registered with the blockjob could potentially make the parser dereference NULL. Fix it by moving the code slightly and just treat it as a wrong job XML. Found by Coverity. Reported-by: John Ferlan

Re: [libvirt] [PATCH 3/7] util: remove several unused _QUIET allocation macro variants

2019-09-02 Thread Ján Tomko
On Thu, Aug 29, 2019 at 07:02:46PM +0100, Daniel P. Berrangé wrote: Only a few of the _QUIET allocation macros are used. Since we're no longer reporting OOM as errors, we want to eliminate all the _QUIET variants. This starts with the easy, unused, cases. Signed-off-by: Daniel P. Berrangé ---

Re: [libvirt] [PATCH 2/7] util: make allocation functions abort on OOM

2019-09-02 Thread Ján Tomko
On Thu, Aug 29, 2019 at 07:02:45PM +0100, Daniel P. Berrangé wrote: The functions are left returning an "int" to avoid an immediate big-bang cleanup. They'll simply never return anything other than 0, except for virInsertN which can still return an error if the requested insertion index is out

[libvirt] [PATCH 0/1] Rewrite virt-host-validate in Go & Go packaging complication

2019-09-02 Thread Daniel P . Berrangé
This series contains code I mostly wrote some 6 months ago as an experiment. I've tidied it up and attempted to integrate it into the libvirt build system. Overall I much prefer the new impl of virt-host-validate, as explained in the commit message, I've wanted todo it this way for a long time,

[libvirt] [PATCH v2] util: Set backing file name for LOOP_GET_STATUS64 queries.

2019-09-02 Thread jcfaracco
From: Julio Faracco This is an issue for LXC loop devices when you are trying to get loop devices info using `ioctl`. Modern apps uses `/sys/dev/block` to grab information about devices, but if you use the method mention you won't be able to retrive the associated file with that loop device. See

Re: [libvirt] Error when creating VM with persistent memory

2019-09-02 Thread Seema Pandit
After adding the memoryBacking tag in xml as below (in addition, to other xml changes to add nvdimm), virsh could allocate AD memory larger than the system RAM and VMs could start successfully. This adds share=yes in command line. -object