Hi Andrea,
Thank you for the review.
On 6/3/20 2:45 PM, Andrea Bolognani wrote:
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
+++ b/tests/qemuxml2argvtest.c
@@ -1650,6 +1655,12 @@ mymain(void)
DO_TEST("hostdev-vfio-zpci-autogenerate",
Hi Andrea,
Thank you for the review.
On 6/3/20 2:45 PM, Andrea Bolognani wrote:
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
+++ b/tests/qemuxml2argvtest.c
@@ -1676,6 +1676,10 @@ mymain(void)
DO_TEST_PARSE_ERROR("hostdev-vfio-zpci-set-zero",
Hi Andrea,
Thank you for the review.
On 6/3/20 2:15 PM, Andrea Bolognani wrote:
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
+static bool
+qemuDomainDeviceDefValidateZPCIUid(virZPCIDeviceAddressPtr zpci)
+{
+if (zpci->uid_set &&
+(zpci->uid >
Hi Andrea,
Thank you for the review.
On 6/3/20 12:11 PM, Andrea Bolognani wrote:
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
Add test to verify ZPCI address validation with uid set to 0x0
Signed-off-by: Bjoern Walk
Signed-off-by: Shalini Chellathurai Saroja
Hi Andrea,
Thank you for the review.
On 6/3/20 12:09 PM, Andrea Bolognani wrote:
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
-if (uid &&
-virStrToLong_uip(uid, NULL, 0, ) < 0) {
-virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-
On Fri, May 29, 2020 at 12:10:06PM +0200, Paulo de Rezende Pinatti wrote:
> From: Boris Fiuczynski
>
> Add checking in virt-host-validate for secure guest support
> on s390 for IBM Secure Execution.
>
> Signed-off-by: Boris Fiuczynski
> Tested-by: Viktor Mihajlovski
> Reviewed-by: Paulo de
Ping
On 6/1/20 2:50 PM, Daniel Henrique Barboza wrote:
Hi,
This series implements a convenience feature for the case where
the user defines an incomplete NUMA topology in the domain,
when the sum of all cpus in each NUMA cell is less than the
maximum vcpus count of the domain.
This is an
Ping
On 6/2/20 10:30 AM, Daniel Henrique Barboza wrote:
No functional changes made from the previous version. Just a
rebase and a trivial conflict fix in news.xml after Libvirt
6.4.0 release.
changes in v6:
- fixed news.xml conflict after 6.4.0 release, moved the change
to 6.5.0
- added
Ping for reviews.
On 29/05/20 12:10, Paulo de Rezende Pinatti wrote:
This series introduces the concept of a 'Secure Guest' feature
which covers on s390 IBM Secure Execution and on x86 AMD Secure
Encrypted Virtualization.
Besides adding documentation for IBM Secure Execution it also adds
On Fri, May 29, 2020 at 12:10:05PM +0200, Paulo de Rezende Pinatti wrote:
> Implement secure guest check for AMD SEV (Secure Encrypted
> Virtualization) in order to invalidate the qemu capabilities
> cache in case the availability of the feature changed.
>
> For AMD SEV the verification consists
On Fri, May 29, 2020 at 12:10:07PM +0200, Paulo de Rezende Pinatti wrote:
> From: Boris Fiuczynski
>
> Add checking in virt-host-validate for secure guest support
> on x86 for AMD Secure Encrypted Virtualization.
>
> Signed-off-by: Boris Fiuczynski
> Reviewed-by: Paulo de Rezende Pinatti
>
On Fri, May 29, 2020 at 12:10:08PM +0200, Paulo de Rezende Pinatti wrote:
> From: Boris Fiuczynski
>
> Update document with changes in qemu capability caching and the added
> secure guest support checking for AMD SEV in virt-host-validate.
>
> Signed-off-by: Boris Fiuczynski
> ---
Reviewed-by:
IPv6 does support masquerade since Linux 3.9.0 / ip6tables 1.4.18,
which is Fedora 18 / RHEL-7 vintage, which covers all our supported
Linux versions.
Signed-off-by: Daniel P. Berrangé
---
src/util/viriptables.c | 33 +++--
1 file changed, 11 insertions(+), 22
This introduces CI jobs that replace the current jobs used on Jenkins
for every platform except FreeBSD.
A merge request workflow requires the user to fork the primary git
repo into their personal namespace. In general the changes need to
be tested against the current libvirt git master. If the
Now that we have support for IPv6 in the iptables helpers, and a new
option in the XML schema, we can wire up support for it in the network
driver.
Signed-off-by: Daniel P. Berrangé
---
src/network/bridge_driver_linux.c | 23 +-
.../nat-ipv6-masquerade-linux.args| 228
Historically IPv6 did not support NAT, so when IPv6 was added to
libvirt's virtual networks, when requesting
libvirt will NOT apply NAT to IPv6 traffic, only IPv4 traffic.
This is an annoying historical design decision as it means we
cannot enable IPv6 automatically. We thus need to introduce a
The virtual network has never supported NAT with IPv6 since this feature
didn't exist at the time. NAT has been available since RHEL-7 vintage
though, and it is desirable to be able to use it.
This series enables it with
Note that I do NOT actually change the default.xml to enable
Since nobody sets custom dmidecode path anymore, we can drop all
code that exists only because of that.
Signed-off-by: Michal Privoznik
---
src/util/virsysinfo.c | 10 ++
src/util/virsysinfopriv.h | 3 +--
tests/sysinfotest.c | 2 +-
3 files changed, 4 insertions(+), 11
Setting OEM strings for a domain was introduced in
v4.1.0-rc1~315. However, any application that wanted to use them
(e.g. to point to an URL where a config file is stored) had to
'dmidecode -u --oem-string N' (where N is index of the string).
Well, we can expose them under our XML and if the
Problem with custom dmidecode scripts is that they are hard to
modify, especially if we will want them to act differently based
on passed arguments. So far, we have two scripts which do no more
than 'cat $sysinfo' where $sysinfo is saved dmidecode output.
The virCommandSetDryRun() can be used to
On Mon, 8 Jun 2020 08:03:44 -0400
Igor Mammedov wrote:
> Deprecation period is run out and it's a time to flip the switch
> introduced by cd5ff8333a. Disable legacy option for new machine
> types (since 5.1) and amend documentation.
>
> '-numa node,memdev' shall be used instead of disabled
On a Friday in 2020, Peter Krempa wrote:
Commit b50a8354f6d added call to qemuDomainDiskBlockJobIsSupported prior
to filling the 'disk' variable resulting in a crash when attempting a
block commit.
https://gitlab.com/libvirt/libvirt/-/issues/31
Signed-off-by: Peter Krempa
---
Since we now use Cirrus CI for macOS jobs, we no longer need to
keep Travis CI around.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 58 -
1 file changed, 58 deletions(-)
delete mode 100644 .travis.yml
diff --git a/.travis.yml
On 6/8/20 7:03 AM, Igor Mammedov wrote:
Deprecation period is run out and it's a time to flip the switch
introduced by cd5ff8333a. Disable legacy option for new machine
types (since 5.1) and amend documentation.
'-numa node,memdev' shall be used instead of disabled option
with new machine
On Fri, May 29, 2020 at 12:10:03PM +0200, Paulo de Rezende Pinatti wrote:
> Introduce two utility functions to parse a kernel command
> line string according to the kernel code parsing rules in
> order to enable the caller to perform operations such as
> verifying whether certain argument=value
On Fri, May 29, 2020 at 12:10:09PM +0200, Paulo de Rezende Pinatti wrote:
> From: Viktor Mihajlovski
>
> Protected virtualization/IBM Secure Execution for Linux protects
> guest memory and state from the host.
>
> Add some basic information about technology and a brief guide
> on setting up
On Mon, 8 Jun 2020 08:55:08 -0400
"Michael S. Tsirkin" wrote:
> On Mon, Jun 08, 2020 at 08:03:44AM -0400, Igor Mammedov wrote:
> > Deprecation period is run out and it's a time to flip the switch
> > introduced by cd5ff8333a. Disable legacy option for new machine
> > types (since 5.1) and amend
Some variables defined in the function can be freed
automatically when going out of scope. This renders @result
variable and cleanup label needless.
Signed-off-by: Michal Privoznik
---
tests/sysinfotest.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git
When trying to decode DMI table, just before constructing
virCommand() the decoder is looked for in PATH using
virFindFileInPath(). Well, this is not necessary because
virCommandRun() will do this too (in virExec()).
Signed-off-by: Michal Privoznik
---
src/util/virsysinfo.c | 12 ++--
1
There is no real need to have two separate functions. They can be
merged together which not only saves couple of lines, but
prepares the structure of the code for future expansion. See next
commits.
Signed-off-by: Michal Privoznik
---
tests/sysinfotest.c | 70
Virtually every variable defined in the function can be freed
automatically when going out of scope.
Signed-off-by: Michal Privoznik
---
src/util/virsysinfo.c | 36 +---
1 file changed, 13 insertions(+), 23 deletions(-)
diff --git a/src/util/virsysinfo.c
v2 of:
https://www.redhat.com/archives/libvir-list/2020-June/msg00038.html
diff to v1:
- cleaned up sysinfotest so that it can use virCommandSetDryRun()
- Handle multiline strings (per Dan's suggestion in review of v1)
Michal Prívozník (7):
virSysinfoReadDMI: Use more g_auto*()
We use cirrus-run to trigger Cirrus CI jobs from GitLab CI jobs,
making it possible to extend our platform coverage to include
FreeBSD without having to maintain our own runners; additionally,
we'll be able to ditch Travis CI and, since results for Cirrus CI
jobs are reflected back to the GitLab
This is an alternative approach to the one proposed by Erik[1].
Advantages of this approach:
* we don't have to build and maintain our own FreeBSD runners;
* we make it possible, after some straightforward one-time setup,
for any contributor to have their branches build on FreeBSD and
Deprecation period is run out and it's a time to flip the switch
introduced by cd5ff8333a. Disable legacy option for new machine
types (since 5.1) and amend documentation.
'-numa node,memdev' shall be used instead of disabled option
with new machine types.
Signed-off-by: Igor Mammedov
On Mon, Jun 08, 2020 at 10:02:07AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 04, 2020 at 03:23:05PM +0200, Erik Skultety wrote:
> > With the introduction of automated CI pipelines, we are now ready to
> > switch to using merge requests for the project. With this switch we no
> > longer wish
On Thu, Jun 04, 2020 at 03:23:05PM +0200, Erik Skultety wrote:
> With the introduction of automated CI pipelines, we are now ready to
> switch to using merge requests for the project. With this switch we no
> longer wish to have patches sent to the mailing list, and thus the
> git-publish config
The old information about managing PO files was outdated, as we're
managing files in a different way with Weblate. This also introduces a
badge showing the translation progress across languages.
Signed-off-by: Daniel P. Berrangé
---
README.rst | 3 ++
docs/contribute.html.in |
On Mon, Jun 08, 2020 at 11:58:36AM +0100, Daniel P. Berrangé wrote:
> A bunch of random stuff that was missed in my first series converting
> to weblate.
>
> Daniel P. Berrangé (4):
> po: update docs to refer to Weblate instead of Zanata
> po: remove obsolete zanata push/pull rules
> po:
On Fri, 5 Jun 2020 18:47:58 +0200
Greg Kurz wrote:
> On Fri, 5 Jun 2020 12:03:21 -0400
> Igor Mammedov wrote:
>
> > Deprecation period is run out and it's a time to flip the switch
> > introduced by cd5ff8333a. Disable legacy option for new machine
> > types (since 5.1) and amend
On Mon, Jun 08, 2020 at 12:10:53PM +0200, Erik Skultety wrote:
> On Mon, Jun 08, 2020 at 10:02:07AM +0100, Daniel P. Berrangé wrote:
> > On Thu, Jun 04, 2020 at 03:23:05PM +0200, Erik Skultety wrote:
> > > With the introduction of automated CI pipelines, we are now ready to
> > > switch to using
We're no longer using Zanata, so remove the old push/pull rules.
Signed-off-by: Daniel P. Berrangé
---
po/Makefile.am | 16
1 file changed, 16 deletions(-)
diff --git a/po/Makefile.am b/po/Makefile.am
index e4d444dad6..97e05a32f6 100644
--- a/po/Makefile.am
+++
On Fri, 5 Jun 2020 12:03:21 -0400
Igor Mammedov wrote:
> Deprecation period is run out and it's a time to flip the switch
> introduced by cd5ff8333a. Disable legacy option for new machine
> types (since 5.1) and amend documentation.
>
> '-numa node,memdev' shall be used instead of disabled
On Mon, Jun 08, 2020 at 08:03:44AM -0400, Igor Mammedov wrote:
> Deprecation period is run out and it's a time to flip the switch
> introduced by cd5ff8333a. Disable legacy option for new machine
> types (since 5.1) and amend documentation.
>
> '-numa node,memdev' shall be used instead of
Now that we're storing libvirt.pot in git, it will be in srcdir instead
of builddir. Weblate is responsible for running msgmerge when the .pot
file changes, so add a warning that this target is not for general usage.
---
po/Makefile.am | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
A bunch of random stuff that was missed in my first series converting
to weblate.
Daniel P. Berrangé (4):
po: update docs to refer to Weblate instead of Zanata
po: remove obsolete zanata push/pull rules
po: remove obsolete zanata config file
po: fix update-po target to take account of
Signed-off-by: Daniel P. Berrangé
---
po/zanata.xml | 7 ---
1 file changed, 7 deletions(-)
delete mode 100644 po/zanata.xml
diff --git a/po/zanata.xml b/po/zanata.xml
deleted file mode 100644
index 421980a3e3..00
--- a/po/zanata.xml
+++ /dev/null
@@ -1,7 +0,0 @@
-
On Mon, Jun 08, 2020 at 05:42:31PM +0200, Andrea Bolognani wrote:
> To see this in action, check out the
>
> https://gitlab.com/abologna/libvirt/-/pipelines/153963978
>
> pipeline, and in particular the
>
> https://gitlab.com/abologna/libvirt/-/jobs/585678408
>
On Mon, Jun 08, 2020 at 07:14:20PM +0200, Andrea Bolognani wrote:
> > > +freebsd_11_task:
> > > + install_script:
> > > +- pkg install -y
> > > + augeas
> > > + autoconf
> > > + automake
> [...]
> >
> > For the dockerfiles, we're auto-generating using lcitool.
> >
Signed-off-by: Daniel P. Berrangé
---
Pushed as a CI fix
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 6abf97df85..262e66f3cc 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1505,7 +1505,7 @@ exit 0
%files
On 6/8/20 7:52 PM, Daniel Henrique Barboza wrote:
For the attached patch:
Reviewed-by: Daniel Henrique Barboza
I'm not against the diff, but ...
On 6/6/20 7:30 AM, Bihong Yu wrote:
There are some wrong usage of ATTRIBUTE_NONNULL, which may cause the
compilation fail. The
On Mon, 2020-06-08 at 17:34 +0100, Daniel P. Berrangé wrote:
> On Mon, Jun 08, 2020 at 05:42:31PM +0200, Andrea Bolognani wrote:
> > To see this in action, check out the
> >
> > https://gitlab.com/abologna/libvirt/-/pipelines/153963978
> >
> > pipeline, and in particular the
> >
> >
On 6/5/20 2:56 PM, Laine Stump wrote:
Juan Quintela noticed that when he restarted libvirt he was getting
extra iptables rules added by libvirt even though he didn't have any
libvirt networks that used iptables rules. It turns out this also
happens if the firewalld service is restarted. The
On Mon, Jun 08, 2020 at 05:42:32PM +0200, Andrea Bolognani wrote:
> We use cirrus-run to trigger Cirrus CI jobs from GitLab CI jobs,
> making it possible to extend our platform coverage to include
> FreeBSD without having to maintain our own runners; additionally,
> we'll be able to ditch Travis
On Mon, 2020-06-08 at 17:41 +0100, Daniel P. Berrangé wrote:
> On Mon, Jun 08, 2020 at 05:42:32PM +0200, Andrea Bolognani wrote:
> > +.cirrus_build_default_job_template: _build_default_job_definition
> > + stage: native_build
> > + image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master
On 6/6/20 7:52 AM, Bihong Yu wrote:
There are some wrong usage of ATTRIBUTE_NONNULL, which may cause the
compilation fail. The
ATTRIBUTE_NONNULL is the define of __attribute__((__nonnull__(m))), which
declares that the
input pointer parameter of funciton should not be NULL. If we declare
For the attached patch:
Reviewed-by: Daniel Henrique Barboza
On 6/6/20 7:30 AM, Bihong Yu wrote:
There are some wrong usage of ATTRIBUTE_NONNULL, which may cause the
compilation fail. The
ATTRIBUTE_NONNULL is the define of __attribute__((__nonnull__(m))), which
declares that the
input
On 6/5/20 2:56 PM, Laine Stump wrote:
Juan Quintela noticed that when he restarted libvirt he was getting
extra iptables rules added by libvirt even though he didn't have any
libvirt networks that used iptables rules. It turns out this also
happens if the firewalld service is restarted. The
Put a link to the firewall page in the "Virtual network" section,
mentioning that the forward types 'nat', 'route' and 'isolated'
will change firewall settings in the host.
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 7 +++
1 file changed, 7 insertions(+)
diff
On 6/8/20 2:39 PM, Daniel Henrique Barboza wrote:
On 6/5/20 2:56 PM, Laine Stump wrote:
Juan Quintela noticed that when he restarted libvirt he was getting
extra iptables rules added by libvirt even though he didn't have any
libvirt networks that used iptables rules. It turns out this also
On 6/8/20 5:19 PM, Laine Stump wrote:
On 6/8/20 2:39 PM, Daniel Henrique Barboza wrote:
On 6/5/20 2:56 PM, Laine Stump wrote:
Juan Quintela noticed that when he restarted libvirt he was getting
extra iptables rules added by libvirt even though he didn't have any
libvirt networks that used
On 6/8/20 10:51 AM, Daniel P. Berrangé wrote:
Historically IPv6 did not support NAT, so when IPv6 was added to
libvirt's virtual networks, when requesting
libvirt will NOT apply NAT to IPv6 traffic, only IPv4 traffic.
This is an annoying historical design decision as it means we
cannot enable
(After typing a lot here and spewing out some ideas, I've gotten my mind
back on track and realized that I've mostly been talking about the
design of *other* network-related stuff rather than reviewing IPv6-NAT
enablement! I just saw your comments as a good starting point for
getting out some
63 matches
Mail list logo
