Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-12 Thread Laine Stump
On 1/11/23 1:33 PM, Daniel P. Berrangé wrote: On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: Initial support for network devices using passt (https://passt.top) for the backend connection will require: * new attributes of the subelement: * "type" that can have the value

Re: Entering freeze for libvirt-9.0.0

2023-01-12 Thread Daniel P . Berrangé
On Thu, Jan 12, 2023 at 10:51:55AM +0100, Peter Krempa wrote: > On Wed, Jan 11, 2023 at 18:47:22 +, Daniel P. Berrangé wrote: > > On Tue, Jan 10, 2023 at 09:28:22AM +0100, Jiri Denemark wrote: > > > I have just tagged v9.0.0-rc1 in the repository and pushed signed > > > tarballs and source

Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-12 Thread Jiri Denemark
On Thu, Jan 12, 2023 at 09:45:39 -0500, Laine Stump wrote: > On 1/11/23 1:33 PM, Daniel P. Berrangé wrote: > > On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: > >> + >> upstream='eth42'/> > > > > I don't think that 'upstream' is really describing a property of the > > backend.

Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-12 Thread Stefano Brivio
On Thu, 12 Jan 2023 09:45:39 -0500 Laine Stump wrote: > On 1/11/23 1:33 PM, Daniel P. Berrangé wrote: > > On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: > >> Initial support for network devices using passt (https://passt.top) > >> for the backend connection will require: > >> >

[libvirt PATCH 1/3] conf: remove attribute

2023-01-12 Thread Laine Stump
This attribute was added to support setting the --interface option for passt, but in a post-push/pre-9.0-release review, danpb pointed out that it would be better to use the existing attribute to set --interface rather than creating a new attribute (in the wrong place). So we remove

[libvirt PATCH 0/3] Remove per danpb's request, and a couple small cleanups

2023-01-12 Thread Laine Stump
The first patch implements what danpb suggested yesterday - using instead of to populate the passt --interface option. The other two are small cleanups I noticed while making the changes in patch 1. jdenemar: feel free to push once they've been reviewed, rather than waiting for me to get up, so

[libvirt PATCH 2/3] qemu: remove commented-out option in passt qemu commandline setup

2023-01-12 Thread Laine Stump
This commented-out option was pointed out by jtomko during review, but I missed taking it out when addressing his comments. Signed-off-by: Laine Stump --- src/qemu/qemu_passt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c index

[libvirt PATCH 3/3] tests: remove unused qemu .args file

2023-01-12 Thread Laine Stump
net-user-passt.args was generated early during testing of the passt qemu commandline, when qemuxml2argvtest was using DO_TEST("net-user-passt"). This was later changed to DO_TEST_CAPS_LATEST(), so the file net-user-passt.x86_64-latest.args is used instead, but the original (now unused) test file

Re: Entering freeze for libvirt-9.0.0

2023-01-12 Thread Peter Krempa
On Wed, Jan 11, 2023 at 18:47:22 +, Daniel P. Berrangé wrote: > On Tue, Jan 10, 2023 at 09:28:22AM +0100, Jiri Denemark wrote: > > I have just tagged v9.0.0-rc1 in the repository and pushed signed > > tarballs and source RPMs to https://libvirt.org/sources/ > > > > Please give the release

[PATCH v1 2/4] qemu: Support active disk internal snapshots

2023-01-12 Thread Or Ozeri
libvirt supports taking external disk snapshots on a running VM, using qemu's "blockdev-snapshot" command. qemu also supports "blockdev-snapshot-internal-sync" to do the same for internal snapshots. This commit wraps this (old) qemu capability to allow libvirt users to take internal disk snapshots

[PATCH v1 4/4] qemu: switch offline internal disk snapshots to use snapshotName

2023-01-12 Thread Or Ozeri
Previous commit added snapshotName attribute to internal disk snapshots. This commit changes the qemu domain to use this new attribute for offline internal disk snapshots. Signed-off-by: Or Ozeri --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v1 1/4] conf: add snapshotName attribute for internal disk snapshot

2023-01-12 Thread Or Ozeri
Add a new attribute to snapshot disks XML element, which allows specifying the name that will be used to refer to internal snapshots. Signed-off-by: Or Ozeri --- docs/formatsnapshot.rst | 5 + src/conf/schemas/domainsnapshot.rng | 4 src/conf/snapshot_conf.c|

[PATCH v1 0/4] Introduce active disk internal snapshot support

2023-01-12 Thread Or Ozeri
Internal disk snapshots are currently only supported on non-active VMs. This patch series extends this support for active VMs running with qemu. This implementation for the qemu driver works even when there are other disks which ask for external snapshot. Thus we remove the restriction

[PATCH v1 3/4] qemu: allow mixing active internal and external active disk snapshots

2023-01-12 Thread Or Ozeri
Previous commit added support for active internal disk snapshots, using the same qmp_transaction used also for external snapshots. The same transaction can be used to mix internal and external snapshots. To allow this, this commit simply removes the check that disallows mixing for active

Re: [libvirt PATCH] ci: integration: Set an expiration on logs artifacts

2023-01-12 Thread Daniel P . Berrangé
On Thu, Jan 12, 2023 at 08:05:34AM +0100, Erik Skultety wrote: > The default expiry time is 30 days. Since the RPM artifacts coming from > the previous pipeline stages are set to expire in 1 day we can set the > failed integration job log artifacts to the same value. The sentiment > here is that

[PATCH v1] qemu: block: fix error when blockcopy target is librbd encrypted

2023-01-12 Thread Or Ozeri
Encryption secrets are considered a format dependency, even when being used by the storage node itself, as in the case of using encryption engine=librbd. Currently, the storage node is created (blockdev-add) before creating the format dependencies (including encryption secrets). As a result, when

Re: [PATCH V7 09/12] spec: Remove libvirt-daemon dependency from drivers

2023-01-12 Thread Andrea Bolognani
On Wed, Jan 11, 2023 at 02:11:13PM -0700, Jim Fehlig wrote: > On 1/11/23 11:21, Andrea Bolognani wrote: > > Should we keep relationship with virtlockd.socket for the time being, > > turning it from a Requires to a Wants, and only drop it once we are > > confident that the presets have been updated

Re: [PATCH] docs: drvqemu: Fix a typo

2023-01-12 Thread Andrea Bolognani
On Thu, Jan 12, 2023 at 12:10:21PM +0800, Han Han wrote: > Fixes: a677ea92 > > Signed-off-by: Han Han > --- > docs/drvqemu.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Andrea Bolognani and pushed. -- Andrea Bolognani / Red Hat / Virtualization