Re: [libvirt] Job Control, Google Summer of Code

2014-05-20 Thread David kiarie
Success Tucker. I am also working on snapshot support on the libvirt xenlight driver as part of GSoC On Tue, May 20, 2014 at 7:40 PM, Eric Blake ebl...@redhat.com wrote: On 05/20/2014 09:03 AM, Tucker DiNapoli wrote: Hello everyone, My name is Tucker DiNapoli and I'm going to be working on

[libvirt] Track an error

2014-06-27 Thread David kiarie
Hi there, Just a silly question, do we have a simpler way of checking where exactly a test is failing.The tests are failing after hacking stuff around. I have this error ../build-aux/test-driver: line 95: 20128 Segmentation fault $@ $log_file 21 Yes am having a segfault! I don't know

Re: [libvirt] Track an error

2014-06-30 Thread David kiarie
Thanks for that debugging tip. On Mon, Jun 30, 2014 at 12:10 PM, Martin Kletzander mklet...@redhat.com wrote: On Sat, Jun 28, 2014 at 08:52:32AM +0300, David kiarie wrote: Hi there, Just a silly question, do we have a simpler way of checking where exactly a test is failing.The tests

[libvirt] [PREPOST 02/17] src/xenxs:Introduce function

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenParseXMMem(virConfPtr conf,); This function parses the xm memory options signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 26 -- 1 file changed, 16 insertions(+), 10

[libvirt] [PREPOST 03/17] src/xenxm:Refactor network config parsing code

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com I introduced the function xenFormatXMVif(virConfPtr conf, ..); which parses network configuration signed-off-by: David Kiarie davidkiar...@gmail.com --- src/xenxs/xen_xm.c | 298 - 1 file

[libvirt] [PREPOST 05/17] src/xenxs:Refactor PCI parsing code

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce the function xenParseXMPCI(.); which parses PCI config signed-off-by:David Kiarie davidkiar...@gmail.com --- src/xenxs/xen_xm.c | 192 +++-- 1 file changed, 99 insertions(+), 93

[libvirt] [PREPOST 10/17] src/xenxs:Refactor xenParseXM( )

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com A couple of miscellaneous fixed and wrap code common code into xenParseConfigCommon(...).I will drop some of the functions later though signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 134

[libvirt] [PREPOST 07/17] src/xenxs:Refactor disk config parsing code

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce the function xenParseXMDisk(..); Parses disk config signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 204 - 1 file changed, 108 insertions(+), 96

[libvirt] [PREPOST 11/17] src/xenxs:Refactor code formating general information

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com refactor code parsing uuid, memory and name options signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git

[libvirt] [PREPOST 04/17] src/xenxs:Refactor code parsing time and event actions config

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce the functions xenParseXMTimeOffset(...); xenParseXMEventActions(..); These parse the time config and Event actions configs respectively signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 128

[libvirt] [PREPOST 13/17] src/xenxs:Refactor code formating event actions config

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenFormatXMEventActions(.) which formats actions following certain events signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 60 ++ 1 file changed,

[libvirt] [PREPOST 16/17] src/xenxs:Refactor Vfb config parsing code

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenFormatXMVfb(...); which formats Vfb config signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 207 +++-- 1 file changed, 107 insertions(+), 100

[libvirt] [PREPOST 08/17] src/xenxs:Refactor graphics config parsing code

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMVfb(.); which parses the graphics config signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 247 - 1 file changed, 131 insertions(+), 116

[libvirt] [PREPOST 06/17] src/xenxs:Refactor code parsing CPU config

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce xenParseXMCPUFeatures(.); This function parses config related to CPU and power management signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 116 - 1 file

[libvirt] [PREPOST 09/17] src/xenxs:Refactor OS and Miscellaneous deivices config

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce functions xenParseXMOS(.) and xenParseXMMisc(.) to parse the OS and Miscellaneous devices configs signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 146 ++---

[libvirt] [PREPOST 12/17] src/xenxs:Refactor virtual time config options formating code

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenFormatXMTimeOffset(..) which formats virtual time config signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 149 - 1 file changed, 78 insertions(+),

[libvirt] [PREPOST 17/17] src/xenxs:Refactor disk config formating code

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenFormatXMDomainDisks(virConfPtr conf, .); which formats disk config signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 62 +++--- 1 file changed, 36

[libvirt] [PREPOST 14/17] src/xenxs:Refactor code formating char devices config

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenFormatXMCharDev(); which formats char devices config signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 155 - 1 file changed, 82 insertions(+), 73

[libvirt] [PREPOST 01/17] src/xenxs:Introduce function

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenParseXMGeneral(virConfPtr conf, ...); This function parses the xm general options such as uuid and name signed-off-by: David Kiarie davidkiar...@gmail.com --- src/xenxs/xen_xm.c | 65

[libvirt] [PREPOST 15/17] src/xenxs:Refactor Vif formating code

2014-07-10 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce the function xenFormatXMDomainNet(..) I think this could be done in a cleaner way signed-of-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 49 +++-- 1 file changed, 31

Re: [libvirt] [PREPOST 15/17] src/xenxs:Refactor Vif formating code

2014-07-15 Thread David kiarie
Thanks for the review, am applying changes to address your comments. On Tue, Jul 15, 2014 at 1:49 AM, Jim Fehlig jfeh...@suse.com wrote: David Kiarie wrote: From: Kiarie Kahurani davidkiar...@gmail.com Introduce the function xenFormatXMDomainNet(..) On the parsing side, you called

Re: [libvirt] [PREPOST 05/17] src/xenxs:Refactor PCI parsing code

2014-07-16 Thread David kiarie
Looking at both of your comments, I go with VIR_WARN On Wed, Jul 16, 2014 at 12:26 AM, Eric Blake ebl...@redhat.com wrote: On 07/11/2014 11:09 AM, Jim Fehlig wrote: David Kiarie wrote: + +/* pci=[':00:1b.0',':00:13.0'] */ +if (!(key = list-str

Re: [libvirt] [PREPOST 03/17] src/xenxm:Refactor network config parsing code

2014-07-16 Thread David kiarie
I think you comments on PCI parsing code could also apply here On Wed, Jul 16, 2014 at 12:19 AM, Jim Fehlig jfeh...@suse.com wrote: Jim Fehlig wrote: David Kiarie wrote: From: Kiarie Kahurani davidkiar...@gmail.com I introduced the function xenFormatXMVif(virConfPtr conf

Re: [libvirt] [PREPOST 03/17] src/xenxm:Refactor network config parsing code

2014-07-16 Thread David kiarie
The use of virReportError, On Wed, Jul 16, 2014 at 4:33 PM, David kiarie davidkiar...@gmail.com wrote: I think you comments on PCI parsing code could also apply here On Wed, Jul 16, 2014 at 12:19 AM, Jim Fehlig jfeh...@suse.com wrote: Jim Fehlig wrote: David Kiarie wrote: From: Kiarie

[libvirt] [PATCH v2 00/25] Refactor the xm parser

2014-07-26 Thread David Kiarie
Kiarie Kahurani (25): src/xenxs:Refactor code parsing memory config src/xenxs:Refactor code parsing event actions config src/xenxs:Refactor code parsing virtual time controls config src/xenxs:Refactor code parsing PCI devices config src/xenxs:Refactor code parsing CPU features config

[libvirt] [PATCH v2 02/25] src/xenxs:Refactor code parsing event actions config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenParseXMEventActions(virConfPtr conf,..); which parses events config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 65 +++--- 1 file

[libvirt] [PATCH v2 03/25] src/xenxs:Refactor code parsing virtual time controls config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenParseXMTimeOffset(virConfPtr conf,..); which parses virtual config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 73 -- 1 file

[libvirt] [PATCH v2 01/25] src/xenxs:Refactor code parsing memory config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenParseXMMem(virConfPtr conf,..); which parses memory config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 28 ++-- 1 file changed, 18 insertions(+), 10

[libvirt] [PATCH v2 14/25] src/xenxs:Refactor code formating general config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMGeneralMeta(virConfPtr conf, ...); which formats UUID and name instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 24 +++- 1 file changed, 15 insertions(+), 9

[libvirt] [PATCH v2 10/25] src/xenxs:Refactor code parsing Vif

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMVif(virConfPtr conf, ...) which parses char Vif config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 161 - 1 file changed, 86

[libvirt] [PATCH v2 06/25] src/xenxs:Refactor code parsing disk config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenParseXMDisk(virConfPtr conf,..); which parses XM disk config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 302 - 1 file changed, 157

[libvirt] [PATCH v2 07/25] src/xenxs:Refactor code parsing Vfb config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMVfb(virConfPtr conf,...) which parses Vfb config signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 296 - 1 file changed, 154

[libvirt] [PATCH v2 09/25] src/xenxs:Refactor code parsing Char device related config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMCharDev(virConfPtr conf,...) which parses char devices config instead and also got rid of some unused variables signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 176

[libvirt] [PATCH v2 15/25] src/xenxs:Refactor code formating memory config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMMem(virConfPtr conf, ...); which formats mem and max-mem instead.This could be joined into XenFormatXMGeneralMeta but I separated them for consistency signed-off-by: David Kiariedavidkiar...@gmail.com ---

[libvirt] [PATCH v2 12/25] src/xenxs:Refactor code parsing general config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMGeneralMeta(virConfPtr conf,..) which parses features like hvm= ?, builder and sets the default machine type incase its not specified signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 43

[libvirt] [PATCH v2 04/25] src/xenxs:Refactor code parsing PCI devices config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenParseXMPCI(virConfPtr conf,..); which parses PCI config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 185 +++-- 1 file changed, 94

[libvirt] [PATCH v2 05/25] src/xenxs:Refactor code parsing CPU features config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenParseXMPCI(virConfPtr conf,..); which parses CPU Features and allocation config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 126 +++-- 1

[libvirt] [PATCH v2 11/25] src/xenxs:Refactor code parsing emulated hardware config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMEmulatedDevices(virConfPtr conf,...) which parses the emulated hardware instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 93 +++--- 1

[libvirt] [PATCH v2 16/25] src/xenxs:Reafactor code formating virtual time config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMTimeOffset(virConfPtr conf, ...); which formats time offset config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 156 - 1

[libvirt] [PATCH v2 19/25] src/xenxs:Refactor code formating Vfb config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMVfb(virConfPtr conf, ); which formats Vfb config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 218 + 1 file changed, 119

[libvirt] [PATCH v2 08/25] src/xenxs:Refactor code parsing OS related config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMOS(virConfPtr conf,...) which parses OS config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 132 ++--- 1 file changed, 75

[libvirt] [PATCH v2 13/25] src/xenxs:Organise functions to avoid duplication

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com In the refactored code I have wrapped common code in one function that I will use latter signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 60 +- src/xenxs/xen_xm.h | 2 ++

[libvirt] [PATCH v2 17/25] src/xenxs:Refactor code formating event actions config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMEventActions(virConfPtr conf, ...); which formats event actions config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 64 ++ 1

[libvirt] [PATCH v2 20/25] src/xenxs:Refactor code formating CPU config and features

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMCPUFeatures(virConfPtr conf,.); which formats the config instead. I have also made a few changes on the layout of the tests to enable grouping of the code into a function. --- src/xenxs/xen_xm.c

[libvirt] [PATCH v2 22/25] src/xenxs:Refactor code formating emulated devices config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMEmulatedDevices(virConfPtr conf,...) which formats emulated devices config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 86

[libvirt] [PATCH v2 21/25] src/xenxs:Refactor code formating disk list

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMDiskList(virConfPtr conf, .); which formats xm disk config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 73 ++ 1 file

[libvirt] [PATCH v2 23/25] src/xenxs:Refactor char devices formating code

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMCharDev(virConfPtr conf,.); which formats char devices related config signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 163 + 1

[libvirt] [PATCH v2 18/25] src/xenxs:Refactor code formating Vif config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMVif(virConfPtr conf, ); which formats Vif config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 60 ++ 1 file changed, 38

[libvirt] [PATCH v2 24/25] src/xenxs:Refactor code formating OS config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMOS( ); which formats config options related to OS signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 72 --

[libvirt] [PATCH v2 25/25] src/xenxs:Export code to be reused

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com Introduce function xenFormatConfigCommon( ); which wraps code to be reused.Again I have being forced to make changes on the layout of the tests signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c

[libvirt] [PATCH V3 00/24] xen_xm parsing code refactor

2014-08-06 Thread David Kiarie
Kiarie Kahurani (24): src/xenxs:Refactor code parsing memory config src/xenxs:Refactor code parsing virtual time config src/xenxs:Refactor code parsing event actions src/xenxs:Refactor code parsing PCI config src/xenxs:Refactor code parsing CPU features src/xenxs:Refactor code parsing

[libvirt] [PATCH V3 06/24] src/xenxs:Refactor code parsing xm disk config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMDisk(virConfPtr conf, ); which parses xm disk config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 322 - 1 file changed,

[libvirt] [PATCH V3 03/24] src/xenxs:Refactor code parsing event actions

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMEventActions(virConfPtr conf,) which parses events leading to certain actions signed-off-by: David Kiariedavidkia...@gmail.com --- src/xenxs/xen_xm.c | 61 +-

[libvirt] [PATCH V3 02/24] src/xenxs:Refactor code parsing virtual time config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMTimeOffset(virConfPtr conf,...); which parses time offset config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 71 +- 1 file

[libvirt] [PATCH V3 01/24] src/xenxs:Refactor code parsing memory config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMMem(virConfPtr conf,.); which parses memory config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 83 +- 1 file changed, 45

[libvirt] [PATCH V3 04/24] src/xenxs:Refactor code parsing PCI config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce funtion xenParseXMPCI(virConfPtr conf, ); which parses PCI config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 185 +++-- 1 file changed, 95

[libvirt] [PATCH V3 05/24] src/xenxs:Refactor code parsing CPU features

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMCPUFeatures(virConfPtr conf,.); which parses CPU features instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 127 +++-- 1 file

[libvirt] [PATCH V3 10/24] src/xenxs:Refactor code parsing emulated hardware config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMEmulatedHardware(virConfPtr conf,.); which parses emulated devices config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 82

[libvirt] [PATCH V3 12/24] src/xenxs:Refactor code parsing OS config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMOS(virConfPtr conf,...); which parses the OS config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 80 ++ 1 file changed,

[libvirt] [PATCH V3 13/24] src/xenxs:Export code for reuse

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com wrap code tagged for resuse into onef function and export it signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 71 -- src/xenxs/xen_xm.h | 2 ++ 2 files changed, 44

[libvirt] [PATCH V3 08/24] src/xenxs:Refactor code parsing Char devices config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMCharDev(virConfPtr conf,.); which parses Char devices config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 174 - 1 file

[libvirt] [PATCH V3 18/24] src/xenxs:Refactor code formating Char devices config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMCharDev(virConfPtr conf,); which formats Char devices config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 163 ++--- 1 file

[libvirt] [PATCH V3 15/24] src/xenxs:Refactor code formating memory config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce fucntion xenFormatXMMem(virConfPtr conf,...); which parses memory config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 24 ++-- 1 file changed, 18 insertions(+), 6

[libvirt] [PATCH V3 19/24] src/xenxs:Refactor code formating xm disk config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMDomainDisks(virConfPtr conf,.); which formats domain disks config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 72 +- 1

[libvirt] [PATCH V3 20/24] src/xenxs:Refactor code formating CPU features config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce functions xenFormatXMCPUFeatures(virConfPtr conf, ..); which formats CPU features config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 118 -

[libvirt] [PATCH V3 07/24] src/xenxs:Refactor code parsing Vfb config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMVfb(virConfPtr conf,..); which parses Vfb config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 301 +++-- 1 file changed, 155

[libvirt] [PATCH V3 14/24] src/xenxs:Refactor code formating general VM config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMGeneralMeta(virConfPtr conf,..); which parses uuid and name instead signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 53 - 1 file

[libvirt] [PATCH V3 17/24] src/xenxs:Refactor code formating event actions config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMEventActions(virConfPtr conf,.); which formats event actions instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 63 +++--- 1 file

[libvirt] [PATCH V3 21/24] src/xenxs:Refactor code formating OS config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMOS(virConfPtr conf,); which formats OS config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 95 --

[libvirt] [PATCH V3 09/24] src/xenxs:Refactor code parsing Vif config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMVif(virConfPtr conf,); which parses Vfb config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 283 +++-- 1 file changed, 143

[libvirt] [PATCH V3 22/24] src/xenxs:Refactor code formating Vfb config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMVfb(virConfPtr conf,.); which formats Vfb config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 171 ++--- 1 file changed, 97

[libvirt] [PATCH V3 23/24] src/xenxs:Refactor code formating emulated devices config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMEmulatedHardware(virConfPtr conf,); which formats emulated hardware config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 150

[libvirt] [PATCH V3 16/24] src/xenxs:Refactor code formating virtual time config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMTimeOffset(virConfPtr conf,); which formats time config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 153 - 1 file

[libvirt] [PATCH V3 24/24] src/xenxs:Export code

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com export code for reuse and some formating fix signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 59 +- src/xenxs/xen_xm.h | 4 +-

[libvirt] [PATCH V3 11/24] src/xenxs:Refactor code parsing general config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMGeneralMeta(virConfPtr conf, ...); which parses general metadata instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 58 -- 1 file

Re: [libvirt] [PATCH 12/24] src/xenxs: Refactor code parsing OS config

2014-08-09 Thread David Kiarie
On Fri, Aug 08, 2014 at 03:50:44PM -0600, Jim Fehlig wrote: Kiarie Kahurani wrote: introduce function xenParseXMOS(virConfPtr conf,...); which parses the OS config instead signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Kiarie Kahurani

Re: [libvirt] [PATCH V5 01/12] src/xenxs: Export code for reuse

2014-08-11 Thread David kiarie
On Tue, Aug 12, 2014 at 12:21 AM, Kiarie Kahurani davidkiar...@gmail.com wrote: wrap code tagged for resuse into one function and export it Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com --- src/xenxs/xen_xm.c | 73 +++---

[libvirt] Initializing qemu driver

2014-08-12 Thread David kiarie
Hi there, I get this errors trying to intialialize libvirtd $libvirtd -vvv 2014-08-12 21:57:47.887+: 6449: info : libvirt version: 1.2.8 2014-08-12 21:57:47.887+: 6449: warning : virGetHostname:665 : getaddrinfo failed for 'linux-xzc4': Name or service not known 2014-08-12

Re: [libvirt] Initializing qemu driver

2014-08-12 Thread David kiarie
Ooh got something on the list, I build without qemu as I only care about Xen. On Wed, Aug 13, 2014 at 1:00 AM, David kiarie davidkiar...@gmail.com wrote: Hi there, I get this errors trying to intialialize libvirtd $libvirtd -vvv 2014-08-12 21:57:47.887+: 6449: info : libvirt version

Re: [libvirt] [PATCH V5 04/12] src/xenxs: Refactor code formating virtual time config

2014-08-14 Thread David Kiarie
On Wed, Aug 13, 2014 at 05:15:58PM -0600, Jim Fehlig wrote: Kiarie Kahurani wrote: introduce function xenFormatXMTimeOffset(virConfPtr conf,); which formats time config instead Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com --- src/xenxs/xen_xm.c | 153

Re: [libvirt] [PATCH V5 08/12] src/xenxs: Refactor code formating CPU features config

2014-08-14 Thread David Kiarie
On Wed, Aug 13, 2014 at 05:35:52PM -0600, Jim Fehlig wrote: Kiarie Kahurani wrote: introduce functions xenFormatXMCPUFeatures(virConfPtr conf, ..); which formats CPU features config instead Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com --- src/xenxs/xen_xm.c

Re: [libvirt] [PATCH V5 09/12] src/xenxs: Refactor code formating OS config

2014-08-14 Thread David Kiarie
On Thu, Aug 14, 2014 at 12:15:32AM -0600, Jim Fehlig wrote: Kiarie Kahurani wrote: introduce function xenFormatXMOS(virConfPtr conf,); I split this into three functions: - xenFormatXMEmulator - xenFormatXMCDROM - xenFormatXMOS Formating of emulator and cdrom can be

[libvirt] Libvirtd not initializing after 65b7d553

2014-08-21 Thread David Kiarie
For some I cannot be able able to use virsh after 65b7d553. Libvirtd initializes without errors but I guess something is going unreported $libvirtd -d 2014-08-21 09:29:22.748+: 468: info : libvirt version: 1.2.8 2014-08-21 09:29:22.748+: 468: warning : virGetHostname:665 :

Re: [libvirt] Libvirtd not initializing after 65b7d553

2014-08-21 Thread David kiarie
Ooh forgot to say that this happens on a Xen system On Thu, Aug 21, 2014 at 12:36 PM, David Kiarie davidkiar...@gmail.com wrote: For some I cannot be able able to use virsh after 65b7d553. Libvirtd initializes without errors but I guess something is going unreported $libvirtd -d 2014-08

Re: [libvirt] Libvirtd not initializing after 65b7d553

2014-08-21 Thread David kiarie
berra...@redhat.com wrote: On Thu, Aug 21, 2014 at 11:48:15AM +0200, Michal Privoznik wrote: On 21.08.2014 11:40, David kiarie wrote: Ooh forgot to say that this happens on a Xen system On Thu, Aug 21, 2014 at 12:36 PM, David Kiarie davidkiar...@gmail.com wrote: For some I cannot be able

Re: [libvirt] [PATCH V2 0/4] Xen-xl parser

2014-09-11 Thread David kiarie
Aah, just noticed the tests are not working On Thu, Sep 11, 2014 at 7:10 AM, Kiarie Kahurani davidkiar...@gmail.com wrote: Kiarie Kahurani (4): src/xenconfig: Export helper functions src/xenconfig: Xen-xl parser src/xenconfig: Introduce xen-xl on virsh command line tests: Tests for

Re: [libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-09-12 Thread David Kiarie
On Thu, Sep 11, 2014 at 06:14:12PM -0600, Jim Fehlig wrote: Kiarie Kahurani wrote: Introduce a xen xl parser [...] diff --git a/configure.ac b/configure.ac index f93c6c2..0daf411 100644 --- a/configure.ac +++ b/configure.ac @@ -2177,6 +2177,13 @@ if test -z $PERL; then

Re: [libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-10-02 Thread David kiarie
Hmm, any consensus on this? On Fri, Sep 12, 2014 at 4:17 PM, Eric Blake ebl...@redhat.com wrote: On 09/11/2014 06:14 PM, Jim Fehlig wrote: But also as mentioned before, I can't figure out how to convince automake to tell flex to generate the header file as well as the .c file. Eric, do you

Re: [libvirt] [PATCH V3 2/4] src/xenconfig: Xen-xl parser

2015-01-06 Thread David kiarie
On Sun, Jan 4, 2015 at 9:00 PM, Jim Fehlig jfeh...@suse.com wrote: Michal Privoznik wrote: On 16.12.2014 05:30, Jim Fehlig wrote: diff --git a/src/xenconfig/xen_xl_disk.l b/src/xenconfig/xen_xl_disk.l new file mode 100644 index 000..164aa32 --- /dev/null +++

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-05 Thread David Kiarie
On Sat, May 5, 2018 at 12:15 PM, David Kiarie <davidkiar...@gmail.com> wrote: > Replace references to my name and email with a pseudonym > Sorry, I just want my real name and email off these files and I keep making silly mistakes. > > Signed-off-by: David Kiarie <d

[libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-05 Thread David Kiarie
Replace references to my name and email with a pseudonym Signed-off-by: David Kiarie <davidkiar...@gmail.com> --- src/xenconfig/xen_xl.c | 2 +- src/xenconfig/xen_xl.h | 2 +- tests/xlconfigtest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xenconfig/xen_

[libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-05 Thread David Kiarie
Replace references to my name and email with a pseudonym Signed-off-by: David Kiarie <davidkiar...@gmail.com> --- src/xenconfig/xen_xl.c | 2 +- src/xenconfig/xen_xl.h | 2 +- tests/xlconfigtest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xenconfig/xen_

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-07 Thread David Kiarie
On Mon, May 7, 2018 at 10:29 AM, Peter Krempa <pkre...@redhat.com> wrote: > On Sat, May 05, 2018 at 12:17:05 +0300, David Kiarie wrote: > > On Sat, May 5, 2018 at 12:15 PM, David Kiarie <davidkiar...@gmail.com> > > wrote: > > > > > Replace refere

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-07 Thread David Kiarie
On Mon, May 7, 2018 at 5:55 PM, David Kiarie <davidkiar...@gmail.com> wrote: > > > On Mon, May 7, 2018 at 10:29 AM, Peter Krempa <pkre...@redhat.com> wrote: > >> On Sat, May 05, 2018 at 12:17:05 +0300, David Kiarie wrote: >> > On Sat, May 5, 2018 at 12:15 P

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 1:15 PM, David Kiarie <davidkiar...@gmail.com> wrote: > > > On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé <berra...@redhat.com> > wrote: > >> On Wed, May 09, 2018 at 10:38:59AM +0200, Peter Krempa wrote: >> > On Wed, May 0

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé <berra...@redhat.com> wrote: > On Wed, May 09, 2018 at 10:38:59AM +0200, Peter Krempa wrote: > > On Wed, May 09, 2018 at 08:51:01 +0100, Daniel Berrange wrote: > > > On Wed, May 09, 2018 at 09:14:29AM +

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 1:18 PM, David Kiarie <davidkiar...@gmail.com> wrote: > > > On Wed, May 9, 2018 at 1:15 PM, David Kiarie <davidkiar...@gmail.com> > wrote: > >> >> >> On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé <berra...@redhat.com

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 1:43 PM, Daniel P. Berrangé <berra...@redhat.com> wrote: > On Wed, May 09, 2018 at 01:36:35PM +0300, David Kiarie wrote: > > On Wed, May 9, 2018 at 1:18 PM, David Kiarie <davidkiar...@gmail.com> > wrote: > > > > > > > > &g

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Tue, May 8, 2018 at 6:09 PM, Jim Fehlig <jfeh...@suse.com> wrote: > On 05/08/2018 03:22 AM, David Kiarie wrote: > >> >> >> On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig <jfeh...@suse.com > jfeh...@suse.com>> wrote: >> >> On 05/07/2018 08

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig <jfeh...@suse.com> wrote: > On 05/07/2018 08:57 AM, David Kiarie wrote: > >> >> >> On Mon, May 7, 2018 at 5:55 PM, David Kiarie <davidkiar...@gmail.com >> <mailto:davidkiar...@gmail.com>> wrote: >&g

  1   2   >