[libvirt] [PATCH] virNetworkGetDHCPLeases: fix docstring format

2019-06-18 Thread Ilias Stamatis
The docstring of virNetworkGetDHCPLeases is not correctly formatted and as a result the example code snippet appears as normal text under the "Returns:" section. This patch fixes the problem. Signed-off-by: Ilias Stamatis --- src/libvirt-netw

[libvirt] [PATCH 1/3] test_driver: validate @source in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 8ef843b203..437df9cdf9 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3383,7 +3383,7

[libvirt] [PATCH 0/3] test_driver: improve testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
not defined IPv6 addresses will be returned instead of IPv4 - the @source argument is validated - only networks of type VIR_DOMAIN_NET_TYPE_NETWORK are considered Ilias Stamatis (3): test_driver: validate @source in testDomainInterfaceAddresses test_driver: return addresses only for nets of

[libvirt] [PATCH 2/3] test_driver: return addresses only for nets of type network

2019-06-19 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 437df9cdf9..0c2cfdd2f7 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3409,10 +3409,10

[libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
unique addresses *most of the time*. Additionally, return IPv6 addresses too when needed. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 78 +++--- 1 file changed, 73 insertions(+), 5 deletions(-) diff --git a/src/test/test_driver.c b/src/test

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 1:19 PM Ilias Stamatis wrote: > > testDomainInterfaceAddresses always returns the same hard-coded > addresses. Change the behavior such as if there is a DHCP range defined, > addresses are returned from that pool. > > The specific address returned d

Re: [libvirt] [PATCH 0/3] test_driver: improve testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 1:18 PM Ilias Stamatis wrote: > > This patch series introduces the following improvements to the > testDomainInterfaceAddresses function: > > - if a dhcp range is defined for the network, addresses are returned > from there (instead of hard-coded a

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik wrote: > > On 6/19/19 1:18 PM, Ilias Stamatis wrote: > > testDomainInterfaceAddresses always returns the same hard-coded > > addresses. Change the behavior such as if there is a DHCP range defined, > > addresses are

Re: [libvirt] [PATCH 2/3] test_driver: return addresses only for nets of type network

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik wrote: > > On 6/19/19 1:18 PM, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 9 + > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff

[libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
unique addresses *most of the time*. Additionally, properly handle IPv6 networks which were previously ignored completely. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 44 +- 1 file changed, 39 insertions(+), 5 deletions(-) diff --git a/src/test

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 4:19 PM Michal Privoznik wrote: > > On 6/19/19 4:04 PM, Ilias Stamatis wrote: > > On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik > > wrote: > >> > >> On 6/19/19 1:18 PM, Ilias Stamatis wrote: > >>> testDomainInter

Re: [libvirt] [PATCH] test_driver: implement virDomainGetMemoryParameters

2019-06-20 Thread Ilias Stamatis
On Tue, Jun 18, 2019 at 5:19 PM Ján Tomko wrote: > > On Thu, Jun 13, 2019 at 04:06:59PM +0200, Ilias Stamatis wrote: > >Signed-off-by: Ilias Stamatis > >--- > > src/test/test_driver.c | 46 ++ > > 1 file changed, 46 inserti

[libvirt] [PATCH] test_driver: call virCheckFlags on testDomainReboot

2019-06-20 Thread Ilias Stamatis
Currently the flags argument is completely ignored, but it should be checked for any unsupported flags that might have been passed. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test

[libvirt] [PATCH RFC] test_driver: check that the domain is running in testDomainGetTime

2019-06-20 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- Currently in the test driver in APIs that would normally require guest agents and similar we are just checking if the domain is active (using virDomainObjCheckActive). But a domain will be active even if stopped, so I would say that most of the time this is not

[libvirt] [PATCH] test_driver: fix some bugs on testDomainGetDiskErrors

2019-06-20 Thread Ilias Stamatis
ERROR_NONE is used which contradicts the documentation of the API that says that disks with no errors are not reported This patch fixes all of them and additionally reports errors only for every second disk (instead of reporting errors for all disks) which was the initial intention. Signed-off

Re: [libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-20 Thread Ilias Stamatis
On Thu, Jun 20, 2019 at 5:57 PM Michal Privoznik wrote: > > On 6/19/19 6:45 PM, Ilias Stamatis wrote: > > testDomainInterfaceAddresses always returns the same hard-coded > > addresses. Change the behavior such as if there is a DHCP range defined, > > addresses are

Re: [libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-21 Thread Ilias Stamatis
On Fri, Jun 21, 2019 at 10:03 AM Michal Privoznik wrote: > > On 6/20/19 7:36 PM, Ilias Stamatis wrote: > > On Thu, Jun 20, 2019 at 5:57 PM Michal Privoznik > > wrote: > >> > >> On 6/19/19 6:45 PM, Ilias Stamatis wrote: > >>> testDomainInter

[libvirt] [PATCH v2] test_driver: implement virNetworkGetDHCPLeases

2019-06-24 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 141 + 1 file changed, 141 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4b1f2724a0..180940f859 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt] [PATCH v2] test_driver: implement virNetworkGetDHCPLeases

2019-06-24 Thread Ilias Stamatis
On Mon, Jun 24, 2019 at 9:10 PM Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 141 + > 1 file changed, 141 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver

[libvirt] [PATCH 1/2] test_driver: use addr_offset for non-network infs too

2019-06-24 Thread Ilias Stamatis
The addr_offset can be used even for the hard-coded addresses in an attempt to always return unique ips. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index

[libvirt] [PATCH 0/2] test_driver: A couple of small changes in testDomainInterfaceAddresses

2019-06-24 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: use addr_offset for non-network infs too test_driver: use virDomainNetDefPtr instead of virDomainNetDef * src/test/test_driver.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 2/2] test_driver: use virDomainNetDefPtr instead of virDomainNetDef *

2019-06-24 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index d3bc6e7bce..868dadd682 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3433,7 +3433,7

[libvirt] [PATCH 0/2] test_driver: add a disk device and implement

2019-06-25 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: add a disk device in the default config test_driver: implement virDomainGetFSInfo src/test/test_driver.c | 71 ++ 1 file changed, 71 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH 1/2] test_driver: add a disk device in the default config

2019-06-25 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4b1f2724a0..1b1ff3003e 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -438,6 +438,11 @@ static const char

[libvirt] [PATCH 2/2] test_driver: implement virDomainGetFSInfo

2019-06-25 Thread Ilias Stamatis
Always return / and /boot as the mount points imitating a default Fedora installation. Use the first disk found, otherwise if no disk device of type VIR_DOMAIN_DISK_DEVICE_DISK is present, return 0 mount points. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 66

[libvirt] [RFC] test_driver: Thoughts on the implementation of some FS-related APIs

2019-06-26 Thread Ilias Stamatis
Hello, I was thinking about how to implement the following APIs in the test driver: -virDomainFSFreeze -virDomainFSThaw -virDomainFSTrim The first two are conceptually paired. They both get a mountpoints argument. The QEMU driver (which is the only driver implementing this currently) ignores this

[libvirt] [PATCH] test_driver: implement virDomainGetNumaParameters

2019-06-27 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4b1f2724a0..d0d4d9e270 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH] test_driver: implement virDomainGetInterfaceParameters

2019-06-27 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- This is almost identical to the QEMU's driver implementation. I wonder if we can somehow avoid copying that much code. src/test/test_driver.c | 100 + 1 file changed, 100 insertions(+) diff --git a/src

[libvirt] [PATCH] test_driver: virDomainGetPerfEvents

2019-06-28 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4b1f2724a0..215171839c 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH] virDomainGetPerfEvents docstring: virTypedParameterFlags are also supported

2019-06-28 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 50767a75ed..e2594a3392 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -9730,7 +9730,7

Re: [libvirt] [PATCH] test_driver: virDomainGetPerfEvents

2019-06-28 Thread Ilias Stamatis
On Fri, Jun 28, 2019 at 6:15 PM Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 48 ++ > 1 file changed, 48 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver

[libvirt] [PATCH v2] test_driver: implement virDomainGetNumaParameters

2019-06-28 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4b1f2724a0..dc6d3b078c 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2] test_driver: implement virDomainGetInterfaceParameters

2019-06-28 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- The only thing changed since v1 is calling virDomainObjGetOneDef to get the appropriate def pointer. src/test/test_driver.c | 104 + 1 file changed, 104 insertions(+) diff --git a/src/test/test_driver.c b/src/test

[libvirt] [PATCH v2] test_driver: implement virDomainGetMemoryParameters

2019-06-30 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- Things changed since v1: - virDomainObjGetOneDef is used in order to get the appropriate def - the TEST_ASSIGN_MEM_PARAM macro got removed src/test/test_driver.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a

Re: [libvirt] [PATCH] test_driver: virDomainGetPerfEvents

2019-07-01 Thread Ilias Stamatis
On Mon, Jul 1, 2019 at 3:55 PM Erik Skultety wrote: > > On Fri, Jun 28, 2019 at 09:38:30PM +0200, Ilias Stamatis wrote: > > On Fri, Jun 28, 2019 at 6:15 PM Ilias Stamatis > > wrote: > > the subject should say "Implement " Right. I do that always, just this tim

[libvirt] [PATCH] qemu: remove a redundant call from qemuDomainGetPerfEvents

2019-07-01 Thread Ilias Stamatis
Calling virDomainObjUpdateModificationImpact directly inside the function body is redundant, since the same function call is embedded into virDomainObjGetOneDef. Signed-off-by: Ilias Stamatis --- src/qemu/qemu_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] test_driver: fix some bugs on testDomainGetDiskErrors

2019-07-02 Thread Ilias Stamatis
On Tue, Jul 2, 2019 at 10:04 AM Erik Skultety wrote: > > On Thu, Jun 20, 2019 at 05:11:57PM +0200, Ilias Stamatis wrote: > > The current implementation has the following bugs: > > > > - the vm variable is accessed after calling virDomainObjEndAPI on it > > > >

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetMemoryParameters

2019-07-02 Thread Ilias Stamatis
On Mon, Jul 1, 2019 at 5:50 PM Erik Skultety wrote: > > On Mon, Jul 01, 2019 at 12:19:19AM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > > > Things changed since v1: > > > > - virDomainObjGetOneDef is used in

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetInterfaceParameters

2019-07-02 Thread Ilias Stamatis
On Tue, Jul 2, 2019 at 9:11 AM Erik Skultety wrote: > > On Fri, Jun 28, 2019 at 10:01:04PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > > > The only thing changed since v1 is calling virDomainObjGetOneDef to get > > the approp

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetMemoryParameters

2019-07-02 Thread Ilias Stamatis
On Tue, Jul 2, 2019 at 12:07 PM Erik Skultety wrote: > > On Tue, Jul 02, 2019 at 10:43:08AM +0200, Ilias Stamatis wrote: > > On Mon, Jul 1, 2019 at 5:50 PM Erik Skultety wrote: > > > > > > On Mon, Jul 01, 2019 at 12:19:19AM +0200, Ilias Stamatis wrote: > &g

[libvirt] [PATCH 1/4] test_driver: introduce TEST_SET_PARAM macro

2019-07-02 Thread Ilias Stamatis
This macro can be used by most or all of the DomainGetXXXParameters APIs. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4b1f2724a0..29b388e2d3 100644 --- a/src/test

[libvirt] [PATCH 4/4] test_driver: implement testDomainGetInterfaceParameters

2019-07-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 8c3a41b34b..59937ea968 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 0/4] test_driver: implement some DomainGetParametersAPIs

2019-07-02 Thread Ilias Stamatis
Ilias Stamatis (4): test_driver: introduce TEST_SET_PARAM macro test_driver: implement virDomainGetMemoryParameters test_driver: implement virDomainGetNumaParameters test_driver: implement testDomainGetInterfaceParameters src/test/test_driver.c | 157

[libvirt] [PATCH 2/4] test_driver: implement virDomainGetMemoryParameters

2019-07-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 40 1 file changed, 40 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 29b388e2d3..3c60d8dd0a 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 3/4] test_driver: implement virDomainGetNumaParameters

2019-07-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 3c60d8dd0a..8c3a41b34b 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainGetFSInfo

2019-07-02 Thread Ilias Stamatis
On Tue, Jul 2, 2019 at 2:41 PM Erik Skultety wrote: > > On Tue, Jun 25, 2019 at 11:58:07PM +0200, Ilias Stamatis wrote: > > Always return / and /boot as the mount points imitating a default > > Fedora installation. Use the first disk found, otherwise if no disk

Re: [libvirt] [PATCH 4/4] test_driver: implement testDomainGetInterfaceParameters

2019-07-02 Thread Ilias Stamatis
On Tue, Jul 2, 2019 at 2:50 PM Erik Skultety wrote: > > On Tue, Jul 02, 2019 at 02:29:02PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 64 ++ > > 1 file changed, 64 inse

[libvirt] [PATCH v2 1/4] test_driver: introduce TEST_SET_PARAM macro

2019-07-02 Thread Ilias Stamatis
This macro can be used by most or all of the DomainGetXXXParameters APIs. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4b1f2724a0..c0608a4bea 100644 --- a/src/test

[libvirt] [PATCH v2 2/4] test_driver: implement virDomainGetMemoryParameters

2019-07-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c0608a4bea..44090a7d71 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 3/4] test_driver: implement virDomainGetNumaParameters

2019-07-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 47 ++ 1 file changed, 47 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 44090a7d71..15894d98ad 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 4/4] test_driver: implement testDomainGetInterfaceParameters

2019-07-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 58 ++ 1 file changed, 58 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 15894d98ad..d2a7d2f840 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 0/4] test_driver: implement some DomainGetParametersAPIs

2019-07-02 Thread Ilias Stamatis
Changes since v1: - undefine the macro introduced in 1/4 when done with it's usage - simplified 4/4 by using the virNetDevBandwidthRate struct Ilias Stamatis (4): test_driver: introduce TEST_SET_PARAM macro test_driver: implement virDomainGetMemoryParameters test_driver: impl

[libvirt] [PATCH] test_driver: Implement virDomainSetPerfEvents

2019-07-03 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7c58d2c8ce..9974eba882 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt] [RFC] test_driver: Thoughts on the implementation of some FS-related APIs

2019-07-04 Thread Ilias Stamatis
On Thu, Jul 4, 2019 at 12:58 PM Pavel Hrdina wrote: > > On Wed, Jun 26, 2019 at 06:36:28PM +0200, Ilias Stamatis wrote: > > Hello, > > > > I was thinking about how to implement the following APIs in the test driver: > > -virDomainFSFreeze > > -virDomainFST

[libvirt] [PATCH] test_driver: sanitize user-provided array in testDomainGetDiskErrors

2019-07-04 Thread Ilias Stamatis
Zero out the user provided memory in order to avoid passing random pointers to VIR_FREE later. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7c58d2c8ce

[libvirt] [PATCH] test_driver: avoid using nerrors unitialized in testDomainGetDiskErrors

2019-07-04 Thread Ilias Stamatis
Right now nerrors can be used unitialized in the last for loop causing a bug. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ce4ff1a582..2371581f51 100644 --- a

[libvirt] [PATCH 0/2] test_driver: implement virDomainSetNumaParameters

2019-07-04 Thread Ilias Stamatis
I send these 2 patches together, since testConnectSupportsFeature needs to be implemented in order for testDomainSetNumaParameters to support string parameters. Ilias Stamatis (2): test_driver: implement virConnectSupportsFeature test_driver: implement virDomainSetNumaParameters src/test

[libvirt] [PATCH 2/2] test_driver: implement virDomainSetNumaParameters

2019-07-04 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 82 ++ 1 file changed, 82 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 74de8f13ad..fa690e2bd6 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 1/2] test_driver: implement virConnectSupportsFeature

2019-07-04 Thread Ilias Stamatis
Make the test driver only support the VIR_TYPED_PARAM_STRING flag for now. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 29 + 1 file changed, 29 insertions(+) mode change 100644 => 100755 src/test/test_driver.c diff --git a/src/test/test_driver.

[libvirt] [PATCH] test_driver: implement virDomainSetMemoryParameters

2019-07-04 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c14603e3af..2f4f94968b 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH] implement virDomainSetInterfaceParameters

2019-07-06 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 97 ++ 1 file changed, 97 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7dd448bb20..fd57c8c572 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt] [PATCH] implement virDomainSetInterfaceParameters

2019-07-06 Thread Ilias Stamatis
On Sat, Jul 6, 2019 at 1:24 PM Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 97 ++ > 1 file changed, 97 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver

[libvirt] [PATCH] test_driver: implement virDomainSetUserPassword

2019-07-09 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 49d7030d21..891a398a92 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -2602,6

[libvirt] [PATCH 0/4] test_driver: implement FS-related APIs

2019-07-09 Thread Ilias Stamatis
Ilias Stamatis (4): test_driver: introduce domain-private data test_driver: implement virDomainFSFreeze test_driver: implement virDomainFSThaw test_driver: implement virDomainFSTrim src/test/test_driver.c | 191 - 1 file changed, 190 insertions

[libvirt] [PATCH 2/4] test_driver: implement virDomainFSFreeze

2019-07-09 Thread Ilias Stamatis
On success update the domain-private data. Consider / and /boot to be the only mountpoints avaiable in order to be consistent with the other FS-related calls. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 58 ++ 1 file changed, 58 insertions

[libvirt] [PATCH 1/4] test_driver: introduce domain-private data

2019-07-09 Thread Ilias Stamatis
--- src/test/test_driver.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 49d7030d21..af3503c523 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -384,6 +384,35 @@ test

[libvirt] [PATCH 3/4] test_driver: implement virDomainFSThaw

2019-07-09 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 66 ++ 1 file changed, 66 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 8c25c679a5..097720bb0a 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 4/4] test_driver: implement virDomainFSTrim

2019-07-09 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 32 1 file changed, 32 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 097720bb0a..b491247e49 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3561,6

[libvirt] [PATCH 0/2] qemu and lxc: remove duplicate code and move some definitions to domain_conf

2019-07-10 Thread Ilias Stamatis
Ilias Stamatis (2): domain_conf: move DomainParseBlkioDeviceStr out of QEMU and LXC drivers domain_conf: move DomainMergeBlkioDevice out of QEMU and LXC drivers src/conf/domain_conf.c | 185 ++ src/conf/domain_conf.h | 13 +++ src/libvirt_private.syms

[libvirt] [PATCH 1/2] domain_conf: move DomainParseBlkioDeviceStr out of QEMU and LXC drivers

2019-07-10 Thread Ilias Stamatis
the test driver. Signed-off-by: Ilias Stamatis --- src/conf/domain_conf.c | 115 +++ src/conf/domain_conf.h | 6 ++ src/libvirt_private.syms | 1 + src/lxc/lxc_driver.c | 112 +- src/qemu/qemu_driver.c | 126

[libvirt] [PATCH 2/2] domain_conf: move DomainMergeBlkioDevice out of QEMU and LXC drivers

2019-07-10 Thread Ilias Stamatis
test driver. Signed-off-by: Ilias Stamatis --- src/conf/domain_conf.c | 70 ++ src/conf/domain_conf.h | 7 src/libvirt_private.syms | 1 + src/lxc/lxc_driver.c | 72 +-- src/qemu/qemu_driver.c | 81

[libvirt] [PATCH] test_driver: consider flags in testDomainSetMemoryFlags

2019-07-11 Thread Ilias Stamatis
Update the current or max memory, on the persistent or live definition depending on the flags which are currently ignored. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 51 +++--- 1 file changed, 43 insertions(+), 8 deletions(-) diff --git a/src

[libvirt] [PATCH] test_driver: implement virDomainSetMemoryStatsPeriod

2019-07-11 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c10344f6cd..b6394fad2b 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt] [PATCH] test_driver: consider flags in testDomainSetMemoryFlags

2019-07-11 Thread Ilias Stamatis
On Thu, Jul 11, 2019 at 4:03 PM Eric Blake wrote: > > On 7/11/19 6:04 AM, Ilias Stamatis wrote: > > Update the current or max memory, on the persistent or live definition > > depending on the flags which are currently ignored. > > > > Signed-off-by: Ilias S

[libvirt] [PATCH v2 0/3] test_driver: re-implement testDomainSetMemoryFlags

2019-07-11 Thread Ilias Stamatis
Ilias Stamatis (3): test_driver: consider flags in testDomainSetMemoryFlags test_driver: testDomainSetMemory should forward the call with VIR_DOMAIN_AFFECT_LIVE test_driver: testDomainSetMaxMemory should simply forward the call src/test/test_driver.c | 75

[libvirt] [PATCH v2 1/3] test_driver: consider flags in testDomainSetMemoryFlags

2019-07-11 Thread Ilias Stamatis
Update the current or max memory, on the persistent or live definition depending on the flags which are currently ignored. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 51 +++--- 1 file changed, 43 insertions(+), 8 deletions(-) diff --git a/src

[libvirt] [PATCH v2 2/3] test_driver: testDomainSetMemory should forward the call with VIR_DOMAIN_AFFECT_LIVE

2019-07-11 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 90910060ed..6b39b78a93 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -2532,7 +2532,7 @@ static

[libvirt] [PATCH v2 3/3] test_driver: testDomainSetMaxMemory should simply forward the call

2019-07-11 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6b39b78a93..8aea739387 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH] test_driver: implement virDomainMemoryStats

2019-07-16 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index fcb80c9e47..55976eedf1 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH] test_driver: implement virDomainGetCPUStats

2019-07-18 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 131 + 1 file changed, 131 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index fcb80c9e47..2907c043cb 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH] test_driver: implement virDomainInjectNMI

2019-07-18 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 24 1 file changed, 24 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2e33a9dd55..90e1ede7c4 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -6716,6 +6716,29

[libvirt] [PATCH 1/4] test_driver: implement virDomainAddIOThread

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2e33a9dd55..313cf5e7ef 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 0/4] test_driver: implement IOThread related APIs

2019-07-23 Thread Ilias Stamatis
Ilias Stamatis (4): test_driver: implement virDomainAddIOThread test_driver: implement virDomainDelIOThread test_driver: implement virDomainPinIOThread test_driver: implement virDomainGetIOThreadInfo src/test/test_driver.c | 248 + 1 file changed

[libvirt] [PATCH 2/4] test_driver: implement virDomainDelIOThread

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 72 ++ 1 file changed, 72 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 313cf5e7ef..29262e4d34 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 3/4] test_driver: implement virDomainPinIOThread

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 29262e4d34..47e28a01ec 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 4/4] test_driver: implement virDomainGetIOThreadInfo

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 47e28a01ec..4c6f3db8de 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 0/2] test_driver: implement emulator pinning APIs

2019-07-23 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement virDomainGetEmulatorPinInfo test_driver: implement virDomainPinEmulator src/test/test_driver.c | 92 ++ 1 file changed, 92 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH 1/2] test_driver: implement virDomainGetEmulatorPinInfo

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2e33a9dd55..235d70f793 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 2/2] test_driver: implement virDomainPinEmulator

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 235d70f793..5411a97a5b 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt] [PATCH] implement virDomainSetInterfaceParameters

2019-07-24 Thread Ilias Stamatis
On Wed, Jul 24, 2019 at 1:04 PM Erik Skultety wrote: > > On Sat, Jul 06, 2019 at 01:24:22PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > ... > > > + > > +/* average or floor are mandatory, peak and burst are optional */

[libvirt] [PATCH v2] implement virDomainSetInterfaceParameters

2019-07-24 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 106 + 1 file changed, 106 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7cf92e78a7..fce38acc17 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 2/2] test_driver: implement virDomainSetNumaParameters

2019-07-24 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 82 ++ 1 file changed, 82 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6221f5b9ae..127403bc0c 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetNumaParameters

2019-07-24 Thread Ilias Stamatis
Change since v1: * virDomainObjGetOneDefState is used instead of virDomainObjGetOneDef I send these 2 patches together, since testConnectSupportsFeature needs to be implemented in order for testDomainSetNumaParameters to support string parameters. Ilias Stamatis (2): test_driver: implement

[libvirt] [PATCH v2 1/2] test_driver: implement virConnectSupportsFeature

2019-07-24 Thread Ilias Stamatis
Make the test driver only support the VIR_TYPED_PARAM_STRING flag for now. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 29 + 1 file changed, 29 insertions(+) mode change 100644 => 100755 src/test/test_driver.c diff --git a/src/test/test_driver.

Re: [libvirt] [PATCH 2/4] test_driver: implement virDomainDelIOThread

2019-07-26 Thread Ilias Stamatis
On Thu, Jul 25, 2019 at 5:47 PM Erik Skultety wrote: > > On Tue, Jul 23, 2019 at 12:17:55PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 72 ++ > > 1 file changed, 72 in

Re: [libvirt] [PATCH 4/4] test_driver: implement virDomainGetIOThreadInfo

2019-07-26 Thread Ilias Stamatis
On Thu, Jul 25, 2019 at 5:43 PM Erik Skultety wrote: > > On Tue, Jul 23, 2019 at 12:17:57PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 74 ++ > > 1 file changed, 74 in

Re: [libvirt] [PATCH] test_driver: implement virDomainGetCPUStats

2019-07-26 Thread Ilias Stamatis
On Thu, Jul 25, 2019 at 2:01 PM Erik Skultety wrote: > > On Thu, Jul 18, 2019 at 12:02:43PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 131 + > > 1 file changed, 131 in

Re: [libvirt] [PATCH] test_driver: implement virDomainMemoryStats

2019-07-26 Thread Ilias Stamatis
On Wed, Jul 24, 2019 at 4:19 PM Erik Skultety wrote: > > On Tue, Jul 16, 2019 at 11:36:31PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 52 ++ > > 1 file changed, 52 in

[libvirt] [PATCH 0/2] test_driver: implement get/set BlockIoTune APIs

2019-07-27 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement virDomainGetBlockIoTune test_driver: implement virDomainSetBlockIoTune src/test/test_driver.c | 286 + 1 file changed, 286 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH 1/2] test_driver: implement virDomainGetBlockIoTune

2019-07-27 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ab0f8b06d6..9f4e255e35 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

  1   2   3   >