Hi Jim,
comments inline
Jim Meyering wrote:
diff --git a/proxy/libvirt_proxy.c b/proxy/libvirt_proxy.c
index d96d3db..a22ba6c 100644
--- a/proxy/libvirt_proxy.c
+++ b/proxy/libvirt_proxy.c
@@ -2,7 +2,7 @@
* proxy_svr.c: root suid proxy server for Xen access to APIs with no
*
Jim Meyering wrote:
It *could* perform that test, but I think it is slightly more
maintainable (no duplication of that potentially nontrivial expression)
and just as correct to check only ret 0.
Not having the duplicated expression is certainly good, if it's
correct to do so (and it seems
Jim Meyering wrote:
+ /* Record failure if any of these fails,
+and be careful always to close the stream. */
+ if ((fseek(fp, 0, SEEK_END) 0)
+ + (fprintf(fp, \n#UUID: %s\n, uuidstr) 0);
+ + (fclose(fp) == EOF))
+ ret = -1;
I don't think you want
Daniel P. Berrange wrote:
This patch finishes off the work from Rich / Soren to support network
interface model in both Xen and QEMU drivers, and adds test cases for
the new syntax
I still think our consensus from when I posted this patch last year
(nic model=...) makes more sense ... but
Daniel P. Berrange wrote:
Since we have CPU pinning support from my previous patch, adding in the
initial pinning is fairly easy. We first pass the '-S' arg to QEMU when
forking it.
If -S is always added, this becomes unnecessary (qemu_conf.c:2823):
if (vm-migrateFrom[0]) {
if
Richard W.M. Jones wrote:
Jim Paris wrote:
+if (strchr(path, '\'') || strchr(path, '\\') ) {
+qemudReportError(dom-conn, dom, NULL, VIR_ERR_OPERATION_FAILED,
+ invalid filename);
+return -1;
+}
[...]
+/* Migrate to file
Daniel Veillard wrote:
On Thu, Aug 09, 2007 at 10:55:10PM +0100, Daniel P. Berrange wrote:
Just been committed to KVM repos I see. Should be an easy patch to backport
too. As long as we can detect failure if this is missing report it back
then I'm fine depending on this.
Would
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_driver.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index 7c75d9c..b05c3f6 100644
--- a/src/qemu_driver.c
+++ b/src/qemu_driver.c
@@ -204,6 +204,7 @@ qemudStartup(void
itself.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_driver.c | 66 +
1 files changed, 66 insertions(+), 0 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index e487640..5d310fe 100644
--- a/src/qemu_driver.c
+++ b
Adds new fields in qemu_vm structure. vm-migrateFrom specifies the
argument to -incoming. vm-stdinFd specifies the file descriptor to
pass to virExec as stdin, which will be used for the -incoming stdio
case.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_conf.c | 12
If nonzero, uses the supplied fd instead of /dev/null.
Update callers accordingly.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/openvz_driver.c |4 ++--
src/qemu_driver.c |5 +++--
src/util.c | 12 ++--
src/util.h |4 ++--
4 files changed, 13
they are received.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_driver.c | 21 -
1 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index b05c3f6..8063ad2 100644
--- a/src/qemu_driver.c
+++ b/src/qemu_driver.c
@@ -1306,12 +1306,14
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_driver.c | 106 +++--
1 files changed, 102 insertions(+), 4 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index 50ab702..c6de8a0 100644
--- a/src/qemu_driver.c
+++ b/src
The save file format consists of a header, XML for the domain,
and the raw QEMU/KVM migration data stream.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_driver.c | 109 ++---
1 files changed, 103 insertions(+), 6 deletions(-)
diff --git
Daniel Veillard wrote:
+/* Copy data, skipping 3-byte escape sequences */
+for (i = 0; i got; i++) {
+if (data[i] == '\033')
+skip = 3;
+if (skip)
+skip--;
+else
+
commands to end with \r which
avoids both issues.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_driver.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index b05c3f6..e13e6a3 100644
--- a/src/qemu_driver.c
+++ b/src
itself.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_driver.c | 66 +
1 files changed, 66 insertions(+), 0 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index e649060..8125622 100644
--- a/src/qemu_driver.c
+++ b
The save file format consists of a header, XML for the domain,
and the raw QEMU/KVM migration data stream.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_driver.c | 112 ++--
1 files changed, 107 insertions(+), 5 deletions(-)
diff --git
Here's take 3 of the QEMU/KVM save/restore support. Thanks for your
input.
Changes since last time:
- Remove escape sequence filtering, it's not necessary.
- Clean up stdin handling in virExec, use -1 to signify unused
- Add signal-safe read/write wrappers that handle EINTR and use them.
-
Adds new fields in qemu_vm structure. vm-migrateFrom specifies the
argument to -incoming. vm-stdin specifies the file descriptor to
pass to virExec as stdin, which will be used for the -incoming stdio
case.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_conf.c | 13
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_driver.c | 113 +++--
1 files changed, 109 insertions(+), 4 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index f2c4316..b0b6d62 100644
--- a/src/qemu_driver.c
+++ b/src
Adds saferead() and safewrite(), which are like read() and write()
except that they retry in case of EINTR.
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/util.c | 37 +
src/util.h |2 ++
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git
Sorry, I'm still trying to learn these tools ... those subjects weren't
numbered.
The order should be:
Subject: [PATCH 1/7] Fix issues with QEMU monitor interface.
Subject: [PATCH 2/7] Add option to pass stdin fd to virExec
Subject: [PATCH 3/7] Add migration support to QEMU startup.
Subject:
With the latest KVM I'm having some issues with save/restore, but I
think it's a kvm issue and not libvirt. The problems did expose a
libvirt bug, though; patch below.
-jim
---
A failed restore of a configured VM would leave the migration source
set incorrectly, preventing the VM from being
Hi Dan,
That's definitely be a useful feature. Some comments...
@@ -453,7 +454,7 @@ static int qemudOpenMonitor(virConnectPt
char buf[1024];
int ret = -1;
-if (!(monfd = open(monitor, O_RDWR))) {
+if (!(monfd = open(monitor, O_NOCTTY |O_RDWR))) {
Is this just to
Richard W.M. Jones wrote:
+char *cmd;
+char *reply;
+/* XXX QEMU only supports a single CDROM for now */
+/*cmd = malloc(strlen(change ) + strlen(olddisk-dst) + 1 +
strlen(newdisk-src) + 2);*/
+cmd = malloc(strlen(change ) + strlen(cdrom) + 1 +
strlen(newdisk-src) +
Virt-manager is compiled from mercurial tree but it isn't working. I
don't know why. After run the virt-manager command, it was finished
without output error and the window wasn't created. If you need more
informations about ask me what informations I should sent.
I ran into that too -- make
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
docs/format.html |6 +-
docs/libvir.html |6 +-
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/docs/format.html b/docs/format.html
index 8a519af..5553d10 100644
--- a/docs/format.html
+++ b/docs/format.html
Hi,
Sometime between kvm-36 and kvm-46 I ran into problems with the
default QEMU network card (ne2k-pci). Switching it fixed the
problems, but libvirt doesn't support changing the NIC model.
These patches add support for:
interface
nic model=rtl8139/
/interface
which becomes
qemu
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
docs/format.html |9 +++--
docs/libvir.html | 13 +++--
2 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/docs/format.html b/docs/format.html
index 5553d10..d73adb1 100644
--- a/docs/format.html
+++ b/docs/format.html
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
docs/format.html |8
docs/libvir.html |8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/docs/format.html b/docs/format.html
index efdbcde..8a519af 100644
--- a/docs/format.html
+++ b/docs/format.html
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_conf.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index c463ffb..c1260ed 100644
--- a/src/qemu_conf.c
+++ b/src/qemu_conf.c
@@ -1738,7 +1738,8 @@ int qemudBuildCommandLine
Signed-off-by: Jim Paris [EMAIL PROTECTED]
---
src/qemu_conf.c | 21 +
src/qemu_conf.h |2 ++
2 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index f3b8f4e..c463ffb 100644
--- a/src/qemu_conf.c
+++ b/src/qemu_conf.c
Daniel P. Berrange wrote:
On Mon, Oct 22, 2007 at 04:33:40PM -0400, Daniel Veillard wrote:
On Mon, Oct 22, 2007 at 03:44:38PM -0400, Jim Paris wrote:
Hi,
Sometime between kvm-36 and kvm-46 I ran into problems with the
default QEMU network card (ne2k-pci). Switching it fixed
git rebase remotes/origin/HEAD
Also, perhaps some .gitignore files could be added upstream now?
Patch below.
-jim
From c8e2192c4e209908f37fbd02d8fd5b5437d2152b Mon Sep 17 00:00:00 2001
From: Jim Paris [EMAIL PROTECTED]
Date: Mon, 13 Aug 2007 11:23:55 -0400
Subject: [PATCH] Ignore generated
Jim Paris wrote:
Jim Meyering wrote:
Thanks. I've added -k, since libvirt has at least 8 files with $Id[*],
but don't seem to need the '-o master' -- at least not the way I'm pushing
the result afterwards. Do you need it, with a recent version of git?
Probably not. I was new to git
Daniel Veillard wrote:
Jim Paris wrote:
Hi,
The recent changes to src/xml.c breaks the build without xen:
okay, fixed in CVS
Yep, builds fine now, thanks.
-jim
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Fixes compile error when building --without-xen on a host that has no
Xen headers installed.
---
src/stats_linux.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/stats_linux.c b/src/stats_linux.c
index 5e6d06c..125af45 100644
--- a/src/stats_linux.c
+++
Signed one-bit bitfields are odd (values are 0 and -1?). The code
doesn't test for == 1, so it's not currently broken, but it's fragile.
(Noticed by Sparse).
---
src/qemu_conf.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu_conf.h b/src/qemu_conf.h
index
Serge Hallyn wrote:
On 03/16/2012 11:50 AM, Eric Blake wrote:
On 03/16/2012 10:36 AM, Serge Hallyn wrote:
Hi,
It seems I've run into quite the heisenbug, reported at
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/922628
It manifests itself as virPidWait returning status=4 for
17e5b9ebab76acb0d711e8bc308023372fbc4180 Mon Sep 17 00:00:00 2001
From: Jim Paris j...@jtan.com
Date: Sun, 22 Apr 2012 14:35:47 -0400
Subject: [PATCH] shorten udevadmin settle timeout
Otherwise, udevadmin settle can take so long that connections from
e.g. virt-manager will get closed.
---
src/util/util.c |4 ++--
1 files
Guido Günther wrote:
Hi,
On Sun, Apr 22, 2012 at 02:41:54PM -0400, Jim Paris wrote:
Hi,
http://bugs.debian.org/663931 is a bug I'm hitting, where virt-manager
times out on the initial connection to libvirt.
I reassigned the bug back to libvirt. I still wonder what triggers
Osier Yang wrote:
On 2012年04月24日 03:47, Guido Günther wrote:
Hi,
On Sun, Apr 22, 2012 at 02:41:54PM -0400, Jim Paris wrote:
Hi,
http://bugs.debian.org/663931 is a bug I'm hitting, where virt-manager
times out on the initial connection to libvirt.
I reassigned the bug back to libvirt. I
Daniel P. Berrange wrote:
But when accessing remotely, I get no useful error, and a hang:
$ virsh -c qemu+ssh://j...@server/system
libvir: Remote error : authentication failed
process hangs here
$ virsh --readonly -c qemu+ssh://j...@server/system
libvir: Remote error :
Daniel P. Berrange wrote:
On Wed, Jun 17, 2009 at 05:51:27PM -0400, Jim Paris wrote:
Daniel P. Berrange wrote:
17:34:59.360: debug : call:6947 : Doing call 70 (nil)
17:34:59.360: debug : call:7017 : We have the buck 70 0xbccef0 0xbccef0
17:34:59.433: debug : processCallRecvLen:6605 : Got
Daniel P. Berrange wrote:
We close the socket to the 'nc' process here so in theory it should
be getting a HUP event from poll or EOF from read, etc and then
exiting. Ominously though I see several patches to Fedora's 'nc'
RPM at least one of which is related to nc hanging forever after
Daniel P. Berrange wrote:
On Thu, Jun 18, 2009 at 12:20:40PM -0400, Jim Paris wrote:
I'm using Debian. I've already had to switch from the
netcat-traditional package to the netcat-openbsd package.
Debian does already include that patch, but what a mess...
I know the reason why it gets
Daniel P. Berrange wrote:
On Wed, Jul 15, 2009 at 11:40:42AM +0200, Daniel Veillard wrote:
On Tue, Jul 14, 2009 at 06:22:42PM -0400, Cole Robinson wrote:
Unlike the pty monitor (which we know exists since we scrape its path from
stdout), we have no way of knowing that the unix monitor
Daniel P. Berrange wrote:
On Tue, Jul 21, 2009 at 05:47:15PM +0900, Jun Koi wrote:
Hi,
I have a VM running under libvirt, and it is currently run with
-no-kvm option (I saw that in ps output).
Now I want to run this VM with KVM. How can I reconfigure it for that?
I looked into its
Daniel P. Berrange wrote:
On Tue, Jul 21, 2009 at 09:46:17AM -0400, Jim Paris wrote:
Speaking of this, I've noticed that
domain type='qemu'
os
type arch='i686' machine='pc'hvm/type
/os
/domain
runs WITH kvm on an x86_64 system. Is that intended?
No, its
Jun Koi wrote:
Hi,
I am running QEMU via libvirt (using virsh virt-manager). Now I want
to get access to the monitor interface of QEMU, so I can issue some
commands to monitor. Is there anyway to do that?
That isn't supported, because libvirt won't know what you've changed
and can't deal
Jiri Denemark wrote:
Hi,
We need to provide support for CPU ID masking. Xen and VMware ESX are examples
of current hypervisors which support such masking.
My proposal is to define new 'cpuid' feature advertised in guest
capabilities:
...
domain type='xen' id='42'
...
features
Garry Dolley wrote:
Dear libvirt,
Is there a way to tell a KVM/QEMU guest managed by libvirt to start
with the -no-kvm-irqchip argument?
I have some FreeBSD 7 guests with timing issues, and if I try to
start the VMs manually with -no-kvm-irqchip, the timing issues go
away (the only known
Daniel P. Berrange wrote:
On Tue, Sep 29, 2009 at 02:39:59AM -0400, Jim Paris wrote:
Hi,
After upgrading libvirt on one system, my kvm guests running a 2.6.26
kernel with virtio networking could no longer communicate with the
network.
It seems that the problem is caused by newer
Jim Paris wrote:
Daniel P. Berrange wrote:
On Tue, Sep 29, 2009 at 02:39:59AM -0400, Jim Paris wrote:
Hi,
After upgrading libvirt on one system, my kvm guests running a 2.6.26
kernel with virtio networking could no longer communicate with the
network.
It seems
Daniel P. Berrange wrote:
And in the struct
int fullscreen : 1;
unsigned int fullscreen : 1;
would be better (so the possible values are 0 and 1).
-jim
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
there is no limit on the size of the readline history,
so it just grows forever. Try this?
-jim
From a65339502c996dbeea9b6f3172a6cb8a2669f153 Mon Sep 17 00:00:00 2001
From: Jim Paris j...@jtan.com
Date: Thu, 5 Feb 2009 19:21:01 -0500
Subject: [PATCH] virsh: limit history entries
Limit the number of readline
Daniel P. Berrange wrote:
On Mon, Jun 08, 2009 at 11:35:00AM +0200, Christian Weyermann wrote:
Hello everybody,
I encountered the following problem. I want my users to only be able to
connect to their own virtual machines via VNC. Is there any way to do so?
The VNC authentication
Daniel P. Berrange wrote:
What about the VNC password?
That's per-VM, isn't it?
That is true by I don't really consider VNC password to be useful. It is
utterly insecure. ...
Garry Dolley wrote:
With KVM/QEMU, you can set a VNC password per VM.
But I think it is either/or though; you
Hi,
I have libvirt 0.6.4 running kvm instances on a headless server.
I'm using virt-manager 0.7.0 to manage them. In the past, I would SSH
in and run virt-manager as root. Since running GTK apps as root is no
good, I've switched to policykit authentication. By default, the
libvirt policy only
Eric Blake wrote:
On 05/05/2010 01:31 PM, Jim Meyering wrote:
Can we provide the option to specify the device serial number so that
it's really impossible to trash the wrong device?
Given that this is a good idea, next question is obviously
how to get the serial number. One way seems
61 matches
Mail list logo
