[libvirt] libvirtd segfault on latest git

2013-04-03 Thread Luiz Capitulino
Hi, Libvirtd from latest git (HEAD fc8c1787) is segfaulting when I try to restore a previously saved domain (backtrace below). I was testing a custom QEMU when it happened first time, but it also happens with latest qemu.git (HEAD 162cbbd17). What I did to run libvirt from source was: 1. Build

Re: [libvirt] [PATCH] security_manager: fix comparison

2013-04-03 Thread Luiz Capitulino
. This also fixes a bug I reported some minutes ago: https://www.redhat.com/archives/libvir-list/2013-April/msg00310.html Tested-by: Luiz Capitulino lcapitul...@redhat.com Introduced by 8d68cbeaa8a64759323da1d64526e2a941eb93e1 --- src/security/security_manager.c |2 +- 1 file changed, 1

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 12:05:12 -0600 Eric Blake ebl...@redhat.com wrote: On 05/24/2013 10:12 AM, Michael S. Tsirkin wrote: Event message contains the net client name, management might only want to query the single net client. The client can do the filtering itself. I'm not sure I

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Luiz Capitulino
for cont failures. If cont fails, management can then log that the VM remained paused and urge the administrator to update QEMU. I suggest that this patch be included in an 1.6.1 release as soon as possible, and perhaps in the 1.5 branch too. Looks good to me: Reviewed-by: Luiz Capitulino

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Luiz Capitulino
On Wed, 21 Aug 2013 14:43:11 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 21/08/2013 14:42, Laszlo Ersek ha scritto: (*) Hm I think I understand why. main_loop_should_exit(), when a reset was requested *and* runstate_needs_reset() evaluated to true, used to set the runstate to PAUSED

Re: [libvirt] [PATCH 0/5] fix query-command-line-options

2014-02-10 Thread Luiz Capitulino
On Tue, 28 Jan 2014 11:53:45 +0800 Amos Kong ak...@redhat.com wrote: This patchset fixed some issues of query-command-line-options: * some new options haven't arguments can't be queried. (eg: -enable-fips) * some legcy options have arguments can't be queried. (eg: -vnc display) Markus,

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-22 Thread Luiz Capitulino
On Tue, 22 May 2012 10:18:22 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: QMP commands should be added to qapi-schema.json as described in docs/writing-qmp-commands.txt. Looks like there's consensus on dropping this patch and enhancing getfd to return the fd number. This would require to

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-22 Thread Luiz Capitulino
On Tue, 22 May 2012 16:02:19 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: But there's a small problem. Today getfd commands are closely tied to the Monitor. In Anthony's development tree, the getfd commands are tied to the new QMP server's session support. Asking you to integrate

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-23 Thread Luiz Capitulino
On Tue, 22 May 2012 18:34:19 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 05/22/2012 04:26 PM, Luiz Capitulino wrote: On Tue, 22 May 2012 16:02:19 -0400 Corey Bryantcor...@linux.vnet.ibm.com wrote: But there's a small problem. Today getfd commands are closely tied

Re: [libvirt] [Qemu-devel] [PATCH v2 1/4] qapi: Convert getfd and closefd

2012-06-13 Thread Luiz Capitulino
On Fri, 8 Jun 2012 11:42:56 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: v2: - Convert getfd and closefd to QAPI (lcapitul...@redhat.com) - Remove changes that returned fd from getfd (lcapitul...@redhat.com) - Wrap hmp_* functions around qmp_* functions (kw...@redhat.com) - Move

Re: [libvirt] [Qemu-devel] [PATCH v2 1/4] qapi: Convert getfd and closefd

2012-06-13 Thread Luiz Capitulino
On Fri, 8 Jun 2012 11:42:56 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: v2: - Convert getfd and closefd to QAPI (lcapitul...@redhat.com) - Remove changes that returned fd from getfd (lcapitul...@redhat.com) - Wrap hmp_* functions around qmp_* functions (kw...@redhat.com) - Move

Re: [libvirt] [Qemu-devel] [PATCH v2 2/4] qapi: Add passfd QMP command

2012-06-13 Thread Luiz Capitulino
On Fri, 8 Jun 2012 11:42:57 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: This patch adds the passfd QMP command using the QAPI framework. Like the getfd command, it is used to pass a file descriptor via SCM_RIGHTS. However, the passfd command also returns the received file

Re: [libvirt] [Qemu-devel] [PATCH v2 2/4] qapi: Add passfd QMP command

2012-06-14 Thread Luiz Capitulino
On Wed, 13 Jun 2012 18:07:43 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 06/13/2012 04:47 PM, Eric Blake wrote: On 06/13/2012 02:25 PM, Corey Bryant wrote: Also, getfd automatically closes a fd if an existing fdname is passed again. I don't think this is a good behavior,

Re: [libvirt] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-15 Thread Luiz Capitulino
On Thu, 14 Jun 2012 11:55:02 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: This patch adds the pass-fd QMP command using the QAPI framework. Like the getfd command, it is used to pass a file descriptor via SCM_RIGHTS. However, the pass-fd command also returns the received file

Re: [libvirt] [PATCH v3 4/5] block: Convert open calls to qemu_open

2012-06-15 Thread Luiz Capitulino
On Thu, 14 Jun 2012 11:55:04 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: This patch converts all block layer open calls to qemu_open. This enables all block layer open paths to dup(X) a pre-opened file descriptor if the filename is of the format /dev/fd/X. This is useful if QEMU is

Re: [libvirt] [PATCH v3 5/5] block: Prevent /dev/fd/X filename from being detected as floppy

2012-06-15 Thread Luiz Capitulino
On Thu, 14 Jun 2012 11:55:05 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: Reported-by: Kevin Wolf kw...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com This too, would be better to move before the /dev/fd/X feature so that

Re: [libvirt] [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-15 Thread Luiz Capitulino
On Fri, 15 Jun 2012 11:04:16 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 06/15/2012 10:32 AM, Luiz Capitulino wrote: On Thu, 14 Jun 2012 11:55:02 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: This patch adds the pass-fd QMP command using the QAPI framework. Like

Re: [libvirt] [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-15 Thread Luiz Capitulino
On Fri, 15 Jun 2012 11:29:03 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: I'm not clear on what the problem is with returning the same error class for two different errors. Could you explain? I don't have a problem changing it if it's an issue. Because an mngt app/user won't

Re: [libvirt] [PATCH v4 2/7] qapi: Convert getfd and closefd

2012-06-26 Thread Luiz Capitulino
On Fri, 22 Jun 2012 14:36:09 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com If this patch doesn't change anymore you can add: Reviewed-by: Luiz Capitulino lcapitul...@redhat.com --- v2: -Convert getfd and closefd to QAPI

Re: [libvirt] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Luiz Capitulino
On Fri, 22 Jun 2012 14:36:11 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- v4: -This patch is new in v4. Can you explain why it's needed? monitor.c | 40 1 file changed, 20

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Luiz Capitulino
On Tue, 26 Jun 2012 13:45:52 +0200 Kevin Wolf kw...@redhat.com wrote: Am 26.06.2012 11:10, schrieb Daniel P. Berrange: I was thinking about some of the sources complexity when using FD passing from libvirt and wanted to raise one idea for discussion before we continue. With this

Re: [libvirt] [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Luiz Capitulino
On Tue, 26 Jun 2012 17:16:28 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 06/26/2012 04:45 PM, Luiz Capitulino wrote: On Fri, 22 Jun 2012 14:36:11 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- v4

Re: [libvirt] [PATCH v4 2/7] qapi: Convert getfd and closefd

2012-06-26 Thread Luiz Capitulino
On Tue, 26 Jun 2012 17:15:05 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 06/26/2012 04:44 PM, Luiz Capitulino wrote: On Fri, 22 Jun 2012 14:36:09 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com If this patch

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-28 Thread Luiz Capitulino
On Wed, 27 Jun 2012 10:58:01 +0200 Kevin Wolf kw...@redhat.com wrote: Am 26.06.2012 20:40, schrieb Corey Bryant: Here is a quick proof of concept (ie untested) patch to demonstrate what I mean. It relies on Cory's patch which converts everything to use qemu_open. It is also still valuable

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Thu, 05 Jul 2012 11:06:56 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 07/04/2012 04:09 AM, Kevin Wolf wrote: Am 03.07.2012 20:21, schrieb Corey Bryant: On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/2012 11:46 AM, Corey Bryant wrote: Yes, I think adding a +1 to

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Mon, 09 Jul 2012 17:46:00 +0200 Kevin Wolf kw...@redhat.com wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so I'll paste the current design that I am working from.

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Mon, 09 Jul 2012 13:35:19 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 07/09/2012 11:46 AM, Kevin Wolf wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so

Re: [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Mon, 09 Jul 2012 13:40:34 -0500 Anthony Liguori aligu...@us.ibm.com wrote: On 06/26/2012 04:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their

Re: [libvirt] [Qemu-devel] [PATCH v4 2/7] qapi: Convert getfd and closefd

2012-07-11 Thread Luiz Capitulino
On Fri, 22 Jun 2012 14:36:09 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com I've cherry-picked this one into the qmp tree. --- v2: -Convert getfd and closefd to QAPI (lcapitul...@redhat.com) -Remove changes that returned fd from

Re: [libvirt] [PATCH] Run 'qmp_capabilities' command at monitor startup

2010-02-17 Thread Luiz Capitulino
On Mon, 15 Feb 2010 15:16:32 + Daniel P. Berrange berra...@redhat.com wrote: On Mon, Feb 15, 2010 at 04:14:01PM +0100, Matthias Bolte wrote: 2010/2/15 Daniel P. Berrange berra...@redhat.com: ---  src/qemu/qemu_driver.c       |   18 ++  src/qemu/qemu_monitor.c      

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Luiz Capitulino
Hi Chris, On Thu, 11 Mar 2010 18:00:56 -0500 Chris Lalancette clala...@redhat.com wrote: The nodeGetInfo code was always assuming that machine had a single NUMA node, which is not correct. The good news is that libnuma gives us this information pretty easily, so let's properly report it.

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 12:42:16 +0200 Avi Kivity a...@redhat.com wrote: So, at best qemud is a toy for people who are annoyed by libvirt. Is the reason for doing this in qemu because libvirt is annoying? I don't see how adding yet another layer/daemon is going to improve ours and user's life (the

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 21:49:45 +0200 Avi Kivity a...@redhat.com wrote: On 03/24/2010 06:42 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 12:42:16 +0200 Avi Kivitya...@redhat.com wrote: So, at best qemud is a toy for people who are annoyed by libvirt. Is the reason

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 15:32:42 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 03/24/2010 03:12 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 21:49:45 +0200 Avi Kivitya...@redhat.com wrote: On 03/24/2010 06:42 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 12:42:16

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 21:54:09 +0100 Alexander Graf ag...@suse.de wrote: On 24.03.2010, at 21:32, Anthony Liguori wrote: On 03/24/2010 03:12 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 21:49:45 +0200 Avi Kivitya...@redhat.com wrote: On 03/24/2010 06:42 PM, Luiz Capitulino

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Luiz Capitulino
On Wed, 24 Mar 2010 16:40:18 -0500 Anthony Liguori anth...@codemonkey.ws wrote: We need to have a common management interface for third party tools. QMP? :-) Only if QMP is compatible with libvirt. I don't want a user to have to choose between QMP and libvirt. Why not? If

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Luiz Capitulino
On Thu, 25 Mar 2010 08:57:36 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 03/25/2010 08:48 AM, Avi Kivity wrote: But an awful lot of the providers for pegasus are written in C. But we're concerned with only one, the virt provider. None of the others will use libqemu? The

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-26 Thread Luiz Capitulino
On Thu, 25 Mar 2010 08:55:42 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 03/25/2010 08:23 AM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 16:40:18 -0500 Anthony Liguorianth...@codemonkey.ws wrote: We need to have a common management interface for third party tools

[libvirt] [PATCH 0/2]: Two small fixes

2010-04-09 Thread Luiz Capitulino
Two small issues I found while testing libvirt under QMP, there is also a third I won't fix today: dommemstat doesn't work under QMP. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/2] qemu_monitor_json: Drop timestamp from command object

2010-04-09 Thread Luiz Capitulino
It's not needed and is just discarded by the Server. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- src/qemu/qemu_monitor_json.c | 34 -- 1 files changed, 0 insertions(+), 34 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu

[libvirt] [PATCH 1/2] virsh.pod: Small fixes

2010-04-09 Thread Luiz Capitulino
- Two missing 's' - 'dominfo' is duplicated Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- tools/virsh.pod |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 1b5c1d6..46ba813 100644 --- a/tools/virsh.pod +++ b/tools

Re: [libvirt] [PATCH 2/2] qemu_monitor_json: Drop timestamp from command object

2010-04-12 Thread Luiz Capitulino
On Mon, 12 Apr 2010 14:25:25 +0200 Daniel Veillard veill...@redhat.com wrote: On Fri, Apr 09, 2010 at 04:31:43PM -0300, Luiz Capitulino wrote: It's not needed and is just discarded by the Server. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- src/qemu/qemu_monitor_json.c

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-12 Thread Luiz Capitulino
On Fri, 9 Apr 2010 15:27:17 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote: Hello, In response to a lot of the talk of qemud lately on qemu-devel, the libvirt community would like to put forward a proposal to help

Re: [libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread Luiz Capitulino
On Tue, 27 Apr 2010 11:20:39 +0200 jdene...@redhat.com wrote: From: Jiri Denemark jdene...@redhat.com With JSON qemu monitor, we get a STOP event from qemu whenever qemu stops guests CPUs. The downside of it is that vm-state is changed to PAUSED and a new generic paused event is send to

Re: [libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread Luiz Capitulino
On Tue, 27 Apr 2010 20:01:06 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Tue, Apr 27, 2010 at 03:50:20PM -0300, Luiz Capitulino wrote: On Tue, 27 Apr 2010 11:20:39 +0200 jdene...@redhat.com wrote: From: Jiri Denemark jdene...@redhat.com With JSON qemu monitor, we get

Re: [libvirt] FISL 11 - Abstract submited

2010-06-02 Thread Luiz Capitulino
On Wed, 02 Jun 2010 02:49:08 -0300 Eduardo Otubo ot...@linux.vnet.ibm.com wrote: Last year, Daniel Veillard was invited to talk about Libvirt. I was excited to see his lecture but ended up he couldn't come. This year, I volunteered myself to speak about the project on the event, DV said it

Re: [libvirt] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Luiz Capitulino
On Thu, 15 Dec 2011 13:02:40 + Stefan Hajnoczi stefa...@gmail.com wrote: What is the status of QEMU's transition from HMP to the QMP interface? Depends on what you consider the transition to be. For management tools the transition can be considered done already because we do not support

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Luiz Capitulino
On Thu, 15 Dec 2011 08:06:41 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 12/15/2011 07:57 AM, Luiz Capitulino wrote: On Thu, 15 Dec 2011 13:02:40 + Stefan Hajnoczistefa...@gmail.com wrote: What is the status of QEMU's transition from HMP to the QMP interface? Depends

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Luiz Capitulino
On Thu, 15 Dec 2011 14:57:51 +0100 Jan Kiszka jan.kis...@siemens.com wrote: On 2011-12-15 14:53, Stefan Hajnoczi wrote: On Thu, Dec 15, 2011 at 1:49 PM, Kevin Wolf kw...@redhat.com wrote: Am 15.12.2011 14:39, schrieb Jan Kiszka: On 2011-12-15 14:38, Lucas Meneghel Rodrigues wrote: On

[libvirt] QMP: Supporting off tree APIs

2012-01-05 Thread Luiz Capitulino
On Thu, 5 Jan 2012 13:48:43 + Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jan 4, 2012 at 12:59 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 13 Dec 2011 13:52:27 + Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Add the block_stream command, which starts

Re: [libvirt] QMP: Supporting off tree APIs

2012-01-05 Thread Luiz Capitulino
On Thu, 05 Jan 2012 09:56:44 -0600 Anthony Liguori aligu...@us.ibm.com wrote: On 01/05/2012 09:35 AM, Eric Blake wrote: On 01/05/2012 07:16 AM, Luiz Capitulino wrote: I know. We're stuck in a hard place here again because NotSupported has been in the Image Streaming API spec and hence

Re: [libvirt] QMP: Supporting off tree APIs

2012-01-06 Thread Luiz Capitulino
On Fri, 6 Jan 2012 11:06:12 + Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jan 5, 2012 at 8:26 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 05 Jan 2012 09:56:44 -0600 Anthony Liguori aligu...@us.ibm.com wrote: On 01/05/2012 09:35 AM, Eric Blake wrote: On 01/05

Re: [libvirt] [Qemu-devel] QMP: Supporting off tree APIs

2012-01-06 Thread Luiz Capitulino
On Fri, 06 Jan 2012 09:08:19 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/06/2012 06:45 AM, Luiz Capitulino wrote: On Fri, 6 Jan 2012 11:06:12 + Stefan Hajnoczistefa...@gmail.com wrote: Proper async support - if you mean the ability to have multiple QMP commands

Re: [libvirt] [Qemu-devel] QMP: Supporting off tree APIs

2012-01-10 Thread Luiz Capitulino
On Tue, 10 Jan 2012 13:18:41 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/06/2012 01:42 PM, Luiz Capitulino wrote: On Fri, 06 Jan 2012 09:08:19 -0600 We also need to look at this interface as a public interface whether we technically committed it to or not. The fact

Re: [libvirt] [Qemu-devel] QMP: Supporting off tree APIs

2012-01-10 Thread Luiz Capitulino
On Tue, 10 Jan 2012 15:02:48 -0600 Anthony Liguori aligu...@us.ibm.com wrote: On 01/10/2012 02:55 PM, Luiz Capitulino wrote: On Tue, 10 Jan 2012 13:18:41 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/06/2012 01:42 PM, Luiz Capitulino wrote: On Fri, 06 Jan 2012 09:08:19 -0600

Re: [libvirt] [RFC 0/5]: QMP: add balloon-get-memory-stats command

2012-01-20 Thread Luiz Capitulino
On Thu, 19 Jan 2012 10:15:55 -0700 Eric Blake ebl...@redhat.com wrote: On 01/19/2012 08:56 AM, Luiz Capitulino wrote: Long ago, commit 625a5be added the guest provided memory statistics to the query-balloon command. Unfortunately, it also introduced a severe bug: query-balloon would hang

Re: [libvirt] [Qemu-devel] libvirt doesn't work with qemu 1.0

2012-01-26 Thread Luiz Capitulino
On Wed, 25 Jan 2012 20:55:14 -0700 Eric Blake ebl...@redhat.com wrote: On 12/02/2011 01:32 PM, Anthony Liguori wrote: But we already have to call 'qemu -h' for other reasons; so we might as well be efficient and learn as much as possible from that result than by calling both 'qemu -h' and

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Luiz Capitulino
On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blake ebl...@redhat.com wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing, that you'll probably notice is this 'set-support-level' command. Basically, it tells GA what qemu version is it running on. Ideally,

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Luiz Capitulino
On Thu, 26 Jan 2012 20:41:13 +0100 Michal Privoznik mpriv...@redhat.com wrote: On 26.01.2012 20:35, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blake ebl...@redhat.com wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/26/2012 01:35 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blakeebl...@redhat.com wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/26/2012 01:35 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 11:07:10 -0600 Michael Roth mdr...@linux.vnet.ibm.com wrote: On 01/30/2012 09:58 AM, Eric Blake wrote: On 01/30/2012 07:44 AM, Luiz Capitulino wrote: I think we should do the following then: 1. Drop the set-support-level command 2. Split the guest-suspend

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 17:08:33 +0100 Michal Privoznik mpriv...@redhat.com wrote: On 30.01.2012 15:44, Luiz Capitulino wrote: On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600

Re: [libvirt] [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 13:08:16 +0100 Gerd Hoffmann kra...@redhat.com wrote: Hi, Isn't this something where it is easier to omit first and add later once we have a use case, than to add up front only to find that no one cares? Yes. I'll drop it. Yes, I think it's better to drop it for

[libvirt] QEMU json related fixes

2010-09-09 Thread Luiz Capitulino
Found these problems while running libvirt-tck with up to date libvirt and qemu.git. Details in the patches. Thanks. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Google Summer of Code 2011

2011-01-28 Thread Luiz Capitulino
Hi there, GSoC 2011 has been announced[1]. As we were pretty successful last year, I think we should participate again. I've already created a wiki page: http://wiki.qemu.org/Google_Summer_of_Code_2011 We should now populate it with projects and people willing to be mentors should say so (or

Re: [libvirt] Google Summer of Code 2011

2011-01-31 Thread Luiz Capitulino
On Sun, 30 Jan 2011 16:06:20 +0100 Alexander Graf ag...@suse.de wrote: On 28.01.2011, at 21:10, Luiz Capitulino wrote: Hi there, GSoC 2011 has been announced[1]. As we were pretty successful last year, I think we should participate again. I've already created a wiki page: http

[libvirt] Changing qemu's -help output

2012-07-25 Thread Luiz Capitulino
On Wed, 25 Jul 2012 20:02:53 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 25 July 2012 20:02, Luiz Capitulino lcapitul...@redhat.com wrote: On Wed, 25 Jul 2012 19:58:02 +0100 Peter Maydell peter.mayd...@linaro.org wrote: I think we should simply say no, parsing -help is broken

Re: [libvirt] [Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:14 -0500 Anthony Liguori aligu...@us.ibm.com wrote: We've had a cycle to tweak. It is time to commit to supporting them. qmp_qom_get() and qpm_qom_set() still use the legacy monitor interface, can't we convert it to the qapi? Signed-off-by: Anthony Liguori

Re: [libvirt] [Qemu-devel] [PATCH 1/7] qmp: introduce device-list-properties command

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:13 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This can be used in conjunction with qom-list-types to determine the supported set of devices and their parameters. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- qapi-schema.json | 28

Re: [libvirt] [Qemu-devel] [PATCH 3/7] qapi: add query-machines command

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:15 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This provides the same output as -M ? but in a structured way. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- qapi-schema.json | 28 qmp-commands.hx |6 ++ vl.c

Re: [libvirt] [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:17 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This command attempts to map to the behavior of -cpu ?. Unfortunately, the output of this command differs wildly across targets. To accomodate this, we use a weak symbol to implement a default version of the

Re: [libvirt] [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need to parse -help output

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:12 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This series implements the necessary commands to implements danpb's idea to remove -help parsing in libvirt. We would introduce all of these commands in 1.2 and then change the -help output starting in 1.3. I've

Re: [libvirt] [Qemu-devel] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-08 Thread Luiz Capitulino
On Wed, 08 Aug 2012 15:07:02 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 08/07/2012 06:16 PM, Eric Blake wrote: On 08/07/2012 11:07 AM, Corey Bryant wrote: +# +# Since: 1.2.0 We're not very consistent on '1.2' vs. '1.2.0' in since listings, but that's probably worth

Re: [libvirt] [Qemu-devel] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-08 Thread Luiz Capitulino
On Wed, 08 Aug 2012 16:52:41 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 08/08/2012 04:48 PM, Luiz Capitulino wrote: On Wed, 08 Aug 2012 15:07:02 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 08/07/2012 06:16 PM, Eric Blake wrote: On 08/07/2012 11:07 AM

Re: [libvirt] [Qemu-devel] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-08 Thread Luiz Capitulino
On Wed, 08 Aug 2012 17:18:33 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 08/08/2012 05:13 PM, Luiz Capitulino wrote: On Wed, 08 Aug 2012 16:52:41 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 08/08/2012 04:48 PM, Luiz Capitulino wrote: On Wed, 08 Aug 2012 15

Re: [libvirt] [Qemu-devel] [PATCH 3/7] qapi: add query-machines command

2012-08-10 Thread Luiz Capitulino
On Fri, 10 Aug 2012 09:41:20 -0500 Anthony Liguori aligu...@us.ibm.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 27 Jul 2012 08:37:15 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This provides the same output as -M ? but in a structured way. Signed-off

Re: [libvirt] [Qemu-devel] [PATCH 3/7] qapi: add query-machines command

2012-08-10 Thread Luiz Capitulino
On Fri, 10 Aug 2012 11:06:14 -0500 Anthony Liguori aligu...@us.ibm.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 10 Aug 2012 09:41:20 -0500 Anthony Liguori aligu...@us.ibm.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 27 Jul 2012 08:37:15

Re: [libvirt] [Qemu-devel] [PATCHv2] Don't log an internal error when the guest hasn't updated balloon stats

2014-05-16 Thread Luiz Capitulino
On Fri, 16 May 2014 00:11:24 -0600 Eric Blake ebl...@redhat.com wrote: Is no stats yet really an error? This is a special case where the guest hasn't ever filled QEMU with balloon stats. There are two possible cases. Either the guest hasn't done it yet, but will do in the future or the guest

Re: [libvirt] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Luiz Capitulino
On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Then the guest triggers an RTC update, so qemu sends an event, but the event is lost. Then libvirtd starts again, and doesn't realize the event is lost. Yes, but that case is also true for any other QMP

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Luiz Capitulino
On Fri, 23 May 2014 10:48:18 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, May 23, 2014 at 03:35:19PM +0200, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti mtosa...@redhat.com wrote

Re: [libvirt] [PATCH 0/8] Memory locking fixes

2017-03-24 Thread Luiz Capitulino
s and adds test suite coverage > to hopefully prevent more bugs from popping up in the future. Tested-by: Luiz Capitulino <lcapitul...@redhat.com> > > > [1] https://www.redhat.com/archives/libvir-list/2017-March/msg00534.html > > Andrea Bolognani (8): > Revert

Re: [libvirt] [PATCH 1/8] Revert "qemu: Forbid without "

2017-03-24 Thread Luiz Capitulino
On Thu, 23 Mar 2017 19:16:40 +0100 Andrea Bolognani wrote: > This reverts commit c2e60ad0e5124482942164e5fec088157f5e716a. > > Turns out this check is excessively strict: there are ways > other than to raise the memory locking > limit for QEMU processes, one prominent

Re: [libvirt] [PATCH 4/8] process: Translate "unlimited" correctly

2017-03-24 Thread Luiz Capitulino
On Thu, 23 Mar 2017 19:16:43 +0100 Andrea Bolognani wrote: > The value we use internally to represent the lack of a memory > locking limit, VIR_DOMAIN_MEMORY_PARAM_UNLIMITED, doesn't > match the value setrlimit() and prlimit() use for the same > purpose, RLIM_INFINITY, so we

Re: [libvirt] [PATCH 8/8] docs: Improve documentation related to memory locking

2017-03-24 Thread Luiz Capitulino
On Thu, 23 Mar 2017 19:16:47 +0100 Andrea Bolognani wrote: > --- > docs/formatdomain.html.in | 36 +++- > 1 file changed, 23 insertions(+), 13 deletions(-) > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > index

Re: [libvirt] [PATCH 1/8] Revert "qemu: Forbid without "

2017-03-28 Thread Luiz Capitulino
On Mon, 27 Mar 2017 10:33:52 +0200 Andrea Bolognani <abolo...@redhat.com> wrote: > On Fri, 2017-03-24 at 13:36 -0400, Luiz Capitulino wrote: > > > Turns out this check is excessively strict: there are ways > > > other than to raise the memory locking > > > lim

Re: [libvirt] [PATCH 8/8] docs: Improve documentation related to memory locking

2017-03-28 Thread Luiz Capitulino
On Mon, 27 Mar 2017 12:33:48 +0200 Andrea Bolognani <abolo...@redhat.com> wrote: > On Fri, 2017-03-24 at 13:58 -0400, Luiz Capitulino wrote: > [...] > > > +be allowed to swap them out, which might be required for some > > > +workloads such as RT. F

Re: [libvirt] [PATCH 8/8] docs: Improve documentation related to memory locking

2017-03-28 Thread Luiz Capitulino
On Tue, 28 Mar 2017 18:26:12 +0200 Andrea Bolognani <abolo...@redhat.com> wrote: > On Tue, 2017-03-28 at 09:43 -0400, Luiz Capitulino wrote: > > > Another stab at it (which plugs into my original version): > > >  > > >   [...] remove the limit on locked memor

Re: [libvirt] [BUG] mlock support breakage

2017-03-14 Thread Luiz Capitulino
On Tue, 14 Mar 2017 19:40:38 +0100 Andrea Bolognani wrote: > It's unfortunate that the current, buggy behavior made > it look like you didn't necessarily have to worry about > this. If we fix it, existing guests will fail to start > right away instead of possibly crashing in

Re: [libvirt] [BUG] mlock support breakage

2017-03-14 Thread Luiz Capitulino
On Tue, 14 Mar 2017 20:28:12 +0100 Andrea Bolognani <abolo...@redhat.com> wrote: > On Tue, 2017-03-14 at 14:54 -0400, Luiz Capitulino wrote: > > > It's unfortunate that the current, buggy behavior made > > > it look like you didn't necessarily have to worry

Re: [libvirt] [BUG] mlock support breakage

2017-03-17 Thread Luiz Capitulino
On Wed, 15 Mar 2017 14:29:13 -0400 Luiz Capitulino <lcapitul...@redhat.com> wrote: > > ... we could consider to be the explicit request for > > setting an infinite memory locking limit and letting users set a lower > > limit with hard_limit if they want. >

Re: [libvirt] [BUG] mlock support breakage

2017-03-22 Thread Luiz Capitulino
On Wed, 15 Mar 2017 10:11:50 +0100 Andrea Bolognani wrote: > On Wed, 2017-03-15 at 08:59 +0100, Jiri Denemark wrote: > > > > Removing all memory locking limits should be something that > > > > admins very carefully opt-in into, because of the potential > > > > host DoS

Re: [libvirt] [BUG] mlock support breakage

2017-03-16 Thread Luiz Capitulino
On Wed, 15 Mar 2017 08:59:34 +0100 Jiri Denemark <jdene...@redhat.com> wrote: > On Tue, Mar 14, 2017 at 15:54:25 -0400, Luiz Capitulino wrote: > > On Tue, 14 Mar 2017 20:28:12 +0100 > > Andrea Bolognani <abolo...@redhat.com> wrote: > > > > > On Tue,

Re: [libvirt] [BUG] mlock support breakage

2017-03-13 Thread Luiz Capitulino
On Mon, 13 Mar 2017 16:08:58 + "Daniel P. Berrange" <berra...@redhat.com> wrote: > On Mon, Mar 13, 2017 at 11:58:24AM -0400, Luiz Capitulino wrote: > > > > Libvirt commit c2e60ad0e51 added a new check to the XML validation > > logic where XMLs containing

[libvirt] [BUG] mlock support breakage

2017-03-13 Thread Luiz Capitulino
Libvirt commit c2e60ad0e51 added a new check to the XML validation logic where XMLs containing must also contain . This causes two breakages where working guests won't start anymore: 1. Systems where mlock limit was set in /etc/security/limits.conf 2. Guests using hugeTLB pages. In this case,

Re: [libvirt] [BUG] mlock support breakage

2017-03-13 Thread Luiz Capitulino
On Mon, 13 Mar 2017 16:43:46 + "Daniel P. Berrange" <berra...@redhat.com> wrote: > On Mon, Mar 13, 2017 at 12:35:42PM -0400, Luiz Capitulino wrote: > > On Mon, 13 Mar 2017 16:08:58 + > > "Daniel P. Berrange" <berra...@redhat.com> wr

Re: [libvirt] [BUG] mlock support breakage

2017-03-13 Thread Luiz Capitulino
On Mon, 13 Mar 2017 18:16:49 + "Daniel P. Berrange" <berra...@redhat.com> wrote: > On Mon, Mar 13, 2017 at 02:08:30PM -0400, Luiz Capitulino wrote: > > On Mon, 13 Mar 2017 13:53:33 -0400 > > Luiz Capitulino <lcapitul...@redhat.com> wrote: > > >

Re: [libvirt] [BUG] mlock support breakage

2017-03-13 Thread Luiz Capitulino
On Mon, 13 Mar 2017 13:53:33 -0400 Luiz Capitulino <lcapitul...@redhat.com> wrote: > OK, you're right. I personally don't like we're putting a random cap > on QEMU memory allocations, but if it's large enough it shouldn't be > a problem (I hope). The I hope part meaning, if we do

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Luiz Capitulino
> > > > On Thu, Feb 01, 2018 at 09:15:15PM +0100, Radim Krčmář wrote: > > > >> 2018-02-01 12:54-0500, Luiz Capitulino: > > > >>> > > > >>> Libvirt needs to know when a vCPU is halted. To get this information, > > >

Re: [libvirt] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Luiz Capitulino
On Fri, 2 Feb 2018 14:53:50 +0100 Viktor Mihajlovski <mihaj...@linux.vnet.ibm.com> wrote: > On 01.02.2018 21:26, Eduardo Habkost wrote: > > On Thu, Feb 01, 2018 at 09:15:15PM +0100, Radim Krčmář wrote: > >> 2018-02-01 12:54-0500, Luiz Capitulino: > >>> >

  1   2   >