[libvirt] [PATCH v3] Fixed URI parsing

2012-02-24 Thread Martin Kletzander
Function xmlParseURI does not remove square brackets around IPv6 address when parsing. One of the solutions is making wrappers around functions working with xmlURI*. This assures that uri-server will be always properly assigned and it doesn't have to be changed when used on some new place in the

[libvirt] [PATCH] Fixed URI parsing

2012-02-24 Thread Martin Kletzander
Function xmlParseURI does not remove square brackets around IPv6 address when parsing. One of the solutions is making wrappers around functions working with xmlURI*. This assures that uri-server will be always properly assigned and it doesn't have to be changed when used on some new place in the

[libvirt] [PATCH] Removed more AMD-specific features from cpu64-rhel* models

2012-03-08 Thread Martin Kletzander
We found few more AMD-specific features in cpu64-rhel* models that made it impossible to start qemu guest on Intel host (with this setting) even though qemu itself starts correctly with them. --- src/cpu/cpu_map.xml |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH v2] Removed more AMD-specific features from cpu64-rhel* models

2012-03-09 Thread Martin Kletzander
We found few more AMD-specific features in cpu64-rhel* models that made it impossible to start qemu guest on Intel host (with this setting) even though qemu itself starts correctly with them. This impacts one test, thus the fix in tests/cputestdata/. --- src/cpu/cpu_map.xml

Re: [libvirt] [PATCH] Removed more AMD-specific features from cpu64-rhel* models

2012-03-09 Thread Martin Kletzander
On 03/08/2012 04:11 PM, Eric Blake wrote: On 03/08/2012 08:02 AM, Martin Kletzander wrote: We found few more AMD-specific features in cpu64-rhel* models that made it impossible to start qemu guest on Intel host (with this setting) even though qemu itself starts correctly with them. --- src

[libvirt] [PATCH] Added support for AMD Bulldozer CPU

2012-03-13 Thread Martin Kletzander
AMD Bulldozer (or Opteron_G4 as called in QEMU) was added to the list of cpu models, flags were taken from upstream qemu cpu specifications and should be sorted by bit values (or first occurence in the feature specification part of cpu_map.xml). Based on QEMU upstream commit

Re: [libvirt] [PATCH] Added support for AMD Bulldozer CPU

2012-03-13 Thread Martin Kletzander
On 03/13/2012 12:56 PM, Peter Krempa wrote: On 03/13/2012 12:35 PM, Martin Kletzander wrote: AMD Bulldozer (or Opteron_G4 as called in QEMU) was added to the list of cpu models, flags were taken from upstream qemu cpu specifications and should be sorted by bit values (or first occurence

[libvirt] [PATCH] Fixed NULL pointer check

2012-03-17 Thread Martin Kletzander
This patch fixes a NULL pointer check that was causing SegFault on some specific configurations. --- src/util/conf.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/util/conf.c b/src/util/conf.c index 8ad60e0..e76362c 100644 --- a/src/util/conf.c +++

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Martin Kletzander
On 03/19/2012 08:43 AM, Wen Congyang wrote: At 03/18/2012 08:29 AM, Martin Kletzander Wrote: This patch fixes a NULL pointer check that was causing SegFault on some specific configurations. --- src/util/conf.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src

[libvirt] [PATCH v2] Fixed NULL pointer check

2012-03-19 Thread Martin Kletzander
This patch fixes a NULL pointer check that was causing SegFault on some specific configurations. --- src/util/conf.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/util/conf.c b/src/util/conf.c index 8ad60e0..3370337 100644 --- a/src/util/conf.c +++

[libvirt] [PATCH v3] Fixed NULL pointer check

2012-03-19 Thread Martin Kletzander
This patch fixes a NULL pointer check that was causing SegFault on some specific configurations. It also reverts commit 59d0c9801c1ab that was checking for this value in one place. --- v3: - added revert of 59d0c9801c1ab that's not needed anymore - (comment) ATTRIBUTE_RETURN_CHECK not added as

[libvirt] [PATCH] Cpu mapping cleanup

2012-03-19 Thread Martin Kletzander
Using inheritance, this patch cleans up the cpu_map.xml file and also sorts all CPU features according to the feature and registry values. Model features are sorted the same way as foeatures in the specification. Also few models that are related were organized together and parts of the XML are

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Martin Kletzander
On 03/19/2012 11:32 AM, Daniel P. Berrange wrote: On Mon, Mar 19, 2012 at 08:51:24AM +0100, Martin Kletzander wrote: On 03/19/2012 08:43 AM, Wen Congyang wrote: At 03/18/2012 08:29 AM, Martin Kletzander Wrote: This patch fixes a NULL pointer check that was causing SegFault on some specific

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Martin Kletzander
On 03/19/2012 04:43 PM, Eric Blake wrote: On 03/19/2012 06:43 AM, Daniel P. Berrange wrote: [...] since the open '(' lets the rest of the code indent nicely when using default emacs indentation. But it's still pretty easy to recognize the difference between complex returns and the real

Re: [libvirt] [PATCH] Cpu mapping cleanup

2012-03-19 Thread Martin Kletzander
On 03/19/2012 06:10 PM, Eric Blake wrote: On 03/19/2012 06:29 AM, Martin Kletzander wrote: Using inheritance, this patch cleans up the cpu_map.xml file and also sorts all CPU features according to the feature and registry values. Model features are sorted the same way as foeatures in the s

[libvirt] [PATCH] Minor docs fix

2012-03-19 Thread Martin Kletzander
End tag for host element was missing in example configuration --- docs/formatnetwork.html.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 907c046..7e8e991 100644 --- a/docs/formatnetwork.html.in +++

Re: [libvirt] [test-API PATCH 0/7] Multiple fixes and improvements series

2012-03-21 Thread Martin Kletzander
On 03/21/2012 01:46 PM, Peter Krempa wrote: This is a set of more or less independent fixes and improvements to the test API. I ran across these while trying to write a basic test case as a Hello world! to the test-API. Improvements are in fields of cross-distro compatibility, broken API's

Re: [libvirt] [test-API PATCH 7/7] domain/[start|destroy]: Add a optional noping flag to skip the ping test

2012-03-22 Thread Martin Kletzander
On 03/21/2012 06:13 PM, Guannan Ren wrote: On 03/21/2012 08:46 PM, Peter Krempa wrote: For some tests it's not needed to ping the guest in the startup process. This patch adds a flag to the start and destroy test to skip such attempts (that consume a lot of time) ---

[libvirt] [PATCH 0/2] Cleanup for return with parentheses

2012-03-22 Thread Martin Kletzander
. Martin Kletzander (2): Cleanup for a return statement in source files Added syntax-check rule for return with parentheses cfg.mk|6 + examples/dominfo/info1.c |2 +- examples/domsuspend/suspend.c |6 +- python

[libvirt] [PATCH 2/2] Added syntax-check rule for return with parentheses

2012-03-22 Thread Martin Kletzander
After cleanup introduced with previous commit, there is a need for syntax-check rule taking care of return(). Regexp used in 'prohibit' parameter is taken from the cleanup commit and modified so it fits 'grep -E' format. Semicolon at the end is needed, otherwise the regexp could match return with

Re: [libvirt] [PATCH 2/2] Added syntax-check rule for return with parentheses

2012-03-23 Thread Martin Kletzander
On 03/23/2012 07:21 AM, Osier Yang wrote: On 03/22/2012 07:33 PM, Martin Kletzander wrote: After cleanup introduced with previous commit, there is a need for syntax-check rule taking care of return(). Regexp used in 'prohibit' parameter is taken from the cleanup commit and modified so it fits

[libvirt] [PATCH v2 2/2] Added syntax-check rule for return with parentheses

2012-03-23 Thread Martin Kletzander
After cleanup introduced with previous commit, there is a need for syntax-check rule taking care of return(). Regexp used in 'prohibit' parameter is taken from the cleanup commit and modified so it fits 'grep -E' format. Semicolon at the end is needed, otherwise the regexp could match return with

[libvirt] [test-API PATCH 0/6] General improvements and fixes

2012-03-24 Thread Martin Kletzander
won't describe it all here again, I just didn't want to create unnecessary threads in the mailing list, so I'm sending this as a series. Martin Kletzander (6): Slight cross-distribution support Added support for Gentoo Fixed domain/start.py Add default 'uri' parameter to all tests Cleanup

[libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-24 Thread Martin Kletzander
I added support for 'uri' parameter and moved some functions into util/Python/utils.py in order not to lose them from the code and keep them accessible for other tests. --- repos/domain/define.py | 132 utils/Python/utils.py | 45

[libvirt] [test-API PATCH 1/6] Slight cross-distribution support

2012-03-24 Thread Martin Kletzander
There is no support for distributions without 'rpm' as a package manager. This patch modifies (at this time) the only distribution-specific import in order to ease the broadening of distribution list supported by libvirt-test-API. --- env_inspect.py = dist/redhat/env_inspect.py |0

[libvirt] [test-API PATCH 2/6] Added support for Gentoo

2012-03-24 Thread Martin Kletzander
In order to support libvirt-test-API on more distributions, this commit adds support for Gentoo. The file is copy-paste from dist/redhat/env_update.py just modified to make the get_* functions work on Gentoo, some removed. --- dist/gentoo/env_inspect.py | 98

[libvirt] [test-API PATCH 3/6] Fixed domain/start.py

2012-03-24 Thread Martin Kletzander
Function usage() was called in the code but was missing. Parameter 'flags' was defined as optional but it was still required in the code, so I fixed the handling of it. --- repos/domain/start.py | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git

[libvirt] [test-API PATCH 4/6] Add default 'uri' parameter to all tests

2012-03-24 Thread Martin Kletzander
Tests should be able to run on various hypervisors and machines. Now we have only two tests that have an option to do something remotely. This commit allows tests to see 'uri' parameter that they should connect to. However it doesn't have to be used always (migration etc.) --- generator.py |6

[libvirt] [test-API PATCH 6/6] Make use of new 'uri' parameter in tests

2012-03-24 Thread Martin Kletzander
I changed all tests to make use of the 'uri' parameter. This change should be more re-factored and lots of things could be changed to make the code more readable, but unfortunately there's no time for that right now, so at least this small step towards the goal. --- repos/domain/attach_disk.py

Re: [libvirt] [test-API PATCHv2] libs: Add flags for streams and the console

2012-03-26 Thread Martin Kletzander
On 03/26/2012 11:07 AM, Peter Krempa wrote: Add the local copy of the flags. --- lib/domainAPI.py |3 +++ lib/streamAPI.py |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py index bc0069b..43565c2 100644 ---

Re: [libvirt] [PATCH v2 2/2] Added syntax-check rule for return with parentheses

2012-03-26 Thread Martin Kletzander
On 03/26/2012 05:43 AM, Osier Yang wrote: On 2012年03月23日 15:34, Martin Kletzander wrote: After cleanup introduced with previous commit, there is a need for syntax-check rule taking care of return(). Regexp used in 'prohibit' parameter is taken from the cleanup commit and modified so it fits

Re: [libvirt] LIBVIRT-PHP List of domains

2012-03-27 Thread Martin Kletzander
On 03/24/2012 03:24 PM, Ali Raza Memon wrote: Hi.. I am trying to get the names of all the xen domains using libvirt-php. I saw this php script: ?php $conn = libvirt_connect('null', false); $doms = libvirt_list_domains($conn); print_r($doms); ? It gives me error. Could

Re: [libvirt] [test-API PATCH 1/6] Slight cross-distribution support

2012-03-27 Thread Martin Kletzander
On 03/26/2012 02:42 PM, Michal Novotny wrote: On 03/26/2012 02:30 PM, Peter Krempa wrote: On 03/24/2012 06:42 PM, Martin Kletzander wrote: There is no support for distributions without 'rpm' as a package manager. This patch modifies (at this time) the only distribution-specific import

Re: [libvirt] [test-API PATCH 2/6] Added support for Gentoo

2012-03-27 Thread Martin Kletzander
On 03/26/2012 02:23 PM, Peter Krempa wrote: On 03/24/2012 06:42 PM, Martin Kletzander wrote: In order to support libvirt-test-API on more distributions, this commit adds support for Gentoo. The file is copy-paste from dist/redhat/env_update.py just modified to make the get_* functions work

Re: [libvirt] [test-API PATCH 4/6] Add default 'uri' parameter to all tests

2012-03-27 Thread Martin Kletzander
On 03/26/2012 03:15 PM, Guannan Ren wrote: On 03/25/2012 01:42 AM, Martin Kletzander wrote: Tests should be able to run on various hypervisors and machines. Now we have only two tests that have an option to do something remotely. This commit allows tests to see 'uri' parameter

Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-27 Thread Martin Kletzander
On 03/26/2012 03:02 PM, Guannan Ren wrote: On 03/25/2012 01:42 AM, Martin Kletzander wrote: I added support for 'uri' parameter and moved some functions into util/Python/utils.py in order not to lose them from the code and keep them accessible for other tests. --- repos/domain/define.py

Re: [libvirt] [test-API PATCH 1/6] Slight cross-distribution support

2012-03-27 Thread Martin Kletzander
On 03/27/2012 10:32 AM, Christophe Fergeau wrote: On Mon, Mar 26, 2012 at 02:42:17PM +0200, Michal Novotny wrote: Fedora is using /etc/redhat-release file so you use the same handling for Fedora and RHEL then it's fine. I also have a /etc/fedora-release on my f17. systemd people are pushing

Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-27 Thread Martin Kletzander
On 03/27/2012 10:59 AM, Guannan Ren wrote: On 03/27/2012 03:57 PM, Martin Kletzander wrote: It's better not to use libvirt API to check the result of one another API. We should use native approach to do the checking. So I insist on the original checking

Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-27 Thread Martin Kletzander
On 03/27/2012 12:35 PM, Guannan Ren wrote: On 03/27/2012 05:42 PM, Martin Kletzander wrote: On 03/27/2012 10:59 AM, Guannan Ren wrote: On 03/27/2012 03:57 PM, Martin Kletzander wrote: It's better not to use libvirt API to check the result of one another API. We should

Re: [libvirt] [PATCH test-API 1/2] lib: pass instance of ConnectAPI into other lib modules

2012-03-29 Thread Martin Kletzander
On 03/26/2012 07:18 PM, Guannan Ren wrote: This change make any instance of subclasses in libvirt.py invisible to testcases in order to catch libvirtError. connectAPI.py domainAPI.py interfaceAPI.py networkAPI.py nodedevAPI.py

[libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-29 Thread Martin Kletzander
Hi everyone, following our minutes, I'd like to start a discussion on what should be done with libvirt-test-API so we can say it's stable and usable. I would like to stress out that everything mentioned here is just an opinion and I don't mean to talk down to someone as it may have seemed

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-30 Thread Martin Kletzander
On 03/29/2012 03:42 PM, Osier Yang wrote: On 2012年03月29日 20:14, Martin Kletzander wrote: Hi everyone, following our minutes, I'd like to start a discussion on what should be done with libvirt-test-API so we can say it's stable and usable. I would like to stress out that everything mentioned

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-30 Thread Martin Kletzander
On 03/29/2012 04:20 PM, Guannan Ren wrote: On 03/29/2012 08:14 PM, Martin Kletzander wrote: - fix hard-coded options into real options (e.g. commit 65449e) - fix some env_* and util* code (functions duplicated with different behavior) - fix or remove harmful and pointless code

[libvirt] [test-API PATCH] Added screenshot test

2012-04-02 Thread Martin Kletzander
This patch adds a test that obtains a screenshot of a domain and saves it in a file. --- repos/domain/screenshot.py | 57 1 files changed, 57 insertions(+), 0 deletions(-) create mode 100644 repos/domain/screenshot.py diff --git

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-04-02 Thread Martin Kletzander
On 04/01/2012 04:30 PM, Guannan Ren wrote: On 03/29/2012 10:20 PM, Guannan Ren wrote: On 03/29/2012 08:14 PM, Martin Kletzander wrote: [...] Hi Martin Could you have a review on the code. Anything require changes, you could sent patch based

Re: [libvirt] [test-API PATCH] Added screenshot test

2012-04-04 Thread Martin Kletzander
On 04/04/2012 07:13 AM, Guannan Ren wrote: Hi Currently, the testcase parser supports to cleanup testing environment after each testcase finished. we only need to add a flag command 'clean' after each testcase in testcase config, for example:

Re: [libvirt] [test-API PATCH] Added screenshot test

2012-04-04 Thread Martin Kletzander
On 04/04/2012 01:23 PM, Guannan Ren wrote: On 04/04/2012 06:30 PM, Martin Kletzander wrote: On 04/04/2012 07:13 AM, Guannan Ren wrote: --- repos/domain/screenshot.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/repos/domain/screenshot.py b/repos/domain

Re: [libvirt] [test-API PATCH] Added screenshot test

2012-04-04 Thread Martin Kletzander
On 04/04/2012 03:10 PM, Guannan Ren wrote: On 04/04/2012 07:53 PM, Martin Kletzander wrote: On 04/04/2012 01:23 PM, Guannan Ren wrote: On 04/04/2012 06:30 PM, Martin Kletzander wrote: On 04/04/2012 07:13 AM, Guannan Ren wrote: --- repos/domain/screenshot.py |5 + 1 files

Re: [libvirt] [test-API PATCHv2 2/2] repo: Add test for mutualy exclusive console access

2012-04-06 Thread Martin Kletzander
On 04/05/2012 01:58 PM, Peter Krempa wrote: This test case checks if the console connection code works in a safe way that the connection don't get messed up. --- Diff to v1: -- removed semicolons at the end of statements (the C language left some habits :D) -- added call to usage function

Re: [libvirt] [test-API PATCH 1/2] sharedmod: Add a new file for variable sharing in testcases

2012-04-10 Thread Martin Kletzander
On 04/06/2012 11:14 AM, Guannan Ren wrote: sharedmod.py: in root directory --- sharedmod.py | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 sharedmod.py diff --git a/sharedmod.py b/sharedmod.py new file mode 100644 index 000..f3de5a6

Re: [libvirt] [test-API PATCH 1/4] filter: new class for filter or extract data

2012-04-12 Thread Martin Kletzander
On 04/11/2012 04:04 PM, Guannan Ren wrote: activityfilter.py --- activityfilter.py | 74 + 1 files changed, 74 insertions(+), 0 deletions(-) create mode 100644 activityfilter.py diff --git a/activityfilter.py b/activityfilter.py

Re: [libvirt] [test-API PATCH 2/4] cfgcheck: new class implement testcase config file checking

2012-04-12 Thread Martin Kletzander
On 04/11/2012 04:04 PM, Guannan Ren wrote: casecfgcheck.py --- casecfgcheck.py | 66 +++ 1 files changed, 66 insertions(+), 0 deletions(-) create mode 100644 casecfgcheck.py diff --git a/casecfgcheck.py b/casecfgcheck.py new

Re: [libvirt] [test-API PATCH 0/4]Add feature to check case file before running

2012-04-13 Thread Martin Kletzander
On 04/12/2012 07:03 PM, Guannan Ren wrote: On 04/12/2012 09:43 PM, Guannan Ren wrote: On 04/12/2012 07:53 PM, Peter Krempa wrote: I don't think pushing this series without a review was a good idea. You actualy broke all of the tests in the repos/ as you didn't do the modifications to the

Re: [libvirt] [test-API PATCH] repo: Add test for console input and output operations

2012-04-13 Thread Martin Kletzander
On 04/13/2012 11:41 AM, Peter Krempa wrote: This test checks if the console input and output work as desired. The test takes as an argument a filename, whose contents are sent to the console. The optional parameter 'expect' can be set to a filename that should contain expected output from the

Re: [libvirt] [test-API PATCH 2/2] parser: put the syntax checking to testcase line at end of flags checking

2012-04-13 Thread Martin Kletzander
On 04/13/2012 09:56 AM, Guannan Ren wrote: we use the re.match(.+:.+, tripped_casename) only check testcase name line, such as domain:start, we don't want it to check flag. placing it just after flags checking is right place. --- parser.py |5 +++-- 1 files changed, 3

Re: [libvirt] [test-API PATCHv2 1/2] sharemod: Add a new file for variable sharing in testcases

2012-04-13 Thread Martin Kletzander
On 04/13/2012 02:23 PM, Guannan Ren wrote: On 04/10/2012 09:55 PM, Guannan Ren wrote: sharedmod.py --- sharedmod.py | 16 1 files changed, 16 insertions(+), 0 deletions(-) create mode 100644 sharedmod.py diff --git a/sharedmod.py b/sharedmod.py new file mode

[libvirt] [PATCH] domain:screenshot: fixed screen parameter

2012-04-13 Thread Martin Kletzander
The screen parameter must be an integer. I also chnaged it to variable parameter with the reasonable default. --- repos/domain/screenshot.py |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/repos/domain/screenshot.py b/repos/domain/screenshot.py index

[libvirt] [PATCH] domain:screenshot: Added cleanup function

2012-04-13 Thread Martin Kletzander
Added cleanup function to the screeshot testcase. This makes use of the new sharedmod module. --- WARNING: don't push this before the patch with sharedmod is pushed in the repo, otherwise this will not work. Thanks. repos/domain/screenshot.py |6 ++ 1 files changed, 6 insertions(+), 0

[libvirt] [PATCH v2] domain:screenshot: fixed screen parameter

2012-04-13 Thread Martin Kletzander
The screen parameter must be an integer. I also chnaged it to variable parameter with the reasonable default. --- v2: - fixed 'screen' to screen (stupid typo) repos/domain/screenshot.py |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/repos/domain/screenshot.py

Re: [libvirt] [PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Martin Kletzander
On 04/16/2012 04:43 AM, Osier Yang wrote: On 2012年04月13日 23:44, Martin Kletzander wrote: Added cleanup function to the screeshot testcase. This makes use of the new sharedmod module. --- WARNING: don't push this before the patch with sharedmod is pushed in the repo, otherwise

Re: [libvirt] [test-API PATCH 2/2] proxy: import each testcase file only once, initialize proxy once

2012-04-16 Thread Martin Kletzander
On 04/16/2012 08:15 AM, Guannan Ren wrote: *libvirt-test-api.py: initialize proxy module only once *casecfgcheck.py: use proxy object rather than initialize it by itself *proxy.py: make get_func_call_dict more flexible --- casecfgcheck.py |5 +

Re: [libvirt] [test-API PATCHv2 1/2] sharemod: Add a new file for variable sharing in testcases

2012-04-16 Thread Martin Kletzander
On 04/16/2012 08:03 AM, Osier Yang wrote: s/sharing in/sharing among/, but given it's already pushed. let's live with it. On 2012年04月10日 21:38, Guannan Ren wrote: sharedmod.py --- sharedmod.py | 16 1 files changed, 16 insertions(+), 0 deletions(-) create

Re: [libvirt] [PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Martin Kletzander
On 04/16/2012 10:00 AM, Osier Yang wrote: On 2012年04月16日 14:52, Martin Kletzander wrote: On 04/16/2012 04:43 AM, Osier Yang wrote: On 2012年04月13日 23:44, Martin Kletzander wrote: Added cleanup function to the screeshot testcase. This makes use of the new sharedmod module. --- WARNING: don't

[libvirt] [libvirt-test-API PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Martin Kletzander
--- v2: - removed sharedmod for persistence of the filename repos/domain/screenshot.py |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/repos/domain/screenshot.py b/repos/domain/screenshot.py index 82425f3..2761dc5 100644 --- a/repos/domain/screenshot.py +++

Re: [libvirt] [libvirt-test-API PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Martin Kletzander
On 04/16/2012 12:14 PM, Osier Yang wrote: On 2012年04月16日 17:32, Martin Kletzander wrote: --- v2: - removed sharedmod for persistence of the filename repos/domain/screenshot.py |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/repos/domain/screenshot.py b

[libvirt] [libvirt-test-API PATCH 2/2] Documentation: Update to current information

2012-04-16 Thread Martin Kletzander
Update of all the things found to be outdated. The test described in the chapter Writing a test case was changed to simpler one, with only one source file included. It shows how to use the libvirt API (no need for connectAPI etc. anymore) and mainly libvirt test API. ---

[libvirt] [libvirt-test-API PATCH 1/2] domain:screenshot: fixes and cleanup

2012-04-16 Thread Martin Kletzander
After the conn object was transferred into sharedmod, its import was missing. I also cleaned up and commented few lines in order to use them for documentation purposes. --- repos/domain/screenshot.py | 45 ++- 1 files changed, 35 insertions(+), 10

[libvirt] [libvirt-test-API PATCH 0/2] Documentation update

2012-04-16 Thread Martin Kletzander
on the reader. I'm not sure how the numbering goes in this case, but it can be updated later or I can send a v2 in case it needs to be fixed right away. Martin Kletzander (2): domain:screenshot: fixes and cleanup Documentation: Update to current information .../en-US/Understanding_libvirt-test

Re: [libvirt] [test-API 04/14] Move directory dist to src

2012-04-19 Thread Martin Kletzander
On 04/19/2012 11:38 AM, Guannan Ren wrote: On 04/19/2012 10:25 AM, Osier Yang wrote: env_inspect.py is part of the framework. --- {dist = src/dist}/__init__.py |0 {dist = src/dist}/redhat/__init__.py|0 {dist = src/dist}/redhat/env_inspect.py |0

Re: [libvirt] [test-API 01/17] Destroy src/dist and move env_inspect.py back

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: As env_inspect.py is rewrote, and has good portability now. --- src/{dist/redhat = }/env_inspect.py |0 src/generator.py |9 + 2 files changed, 1 insertions(+), 8 deletions(-) delete mode 100644

Re: [libvirt] [test-API 02/17] Substitute guest_names with domain_names

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: Same as commit af470a72, let's use the same TERM 'domain' instead of 'guest' in test-API, this patch just substitute guest_names with domain_names, there will be follow up patches to change others, because it will be really large patch if do all the

Re: [libvirt] [test-API 03/17] Rename src/env_parser.py as src/global_parser.py

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: And: % for i in $(grep 'envparser' * -r | awk -F':' '{print $1}' | uniq); do \ sed -i -e 's/envparser/global_parser/g' $i; \ done % for i in $(grep 'Envparser' * -r | awk -F':' '{print $1}' | uniq); do \ sed -i -e

Re: [libvirt] [test-API 05/17] Substitue guestobj with domobj

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: --- repos/domain/update_devflag.py | 10 +- .../multiple_thread_block_on_domain_create.py |4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/repos/domain/update_devflag.py

Re: [libvirt] [test-API 04/17] Substitute guest_ with domain_

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: --- repos/domain/attach_disk.py|4 ++-- repos/domain/attach_interface.py |2 +- repos/domain/autostart.py |4 ++-- repos/domain/balloon_memory.py |

Re: [libvirt] [test-API 06/17] Substitute guestxml with domxml

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: --- repos/domain/balloon_memory.py | 12 ++-- repos/domain/cpu_affinity.py | 12 ++-- repos/domain/cpu_topology.py |6 +++--- repos/domain/install_image.py

Re: [libvirt] [test-API 07/17] Substitute _guest with _domain

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: --- .../en-US/Creating_a_configuration_file.xml| 82 ++-- .../en-US/Writing_a_test_case.xml | 24 +++--- .../libvirt-test-API_Guide/en-US/extras/log.txt| 18 ++-- repos/domain/domain_list.py

Re: [libvirt] [test-API 09/17] Substitute guestos with os_type

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: --- cases/consumption_cpu_topology.conf|2 +- cases/consumption_domain_nfs_start.conf|2 +- cases/consumption_eventhandler.conf|2 +- cases/consumption_libvirtd.conf|2 +-

Re: [libvirt] [test-API 07/17] Substitute _guest with _domain

2012-04-20 Thread Martin Kletzander
On 04/20/2012 10:29 AM, Osier Yang wrote: On 2012年04月20日 16:17, Martin Kletzander wrote: On 04/20/2012 08:46 AM, Osier Yang wrote: --- .../en-US/Creating_a_configuration_file.xml| 82 ++-- .../en-US/Writing_a_test_case.xml | 24

Re: [libvirt] [test-API 07/17] Substitute _guest with _domain

2012-04-20 Thread Martin Kletzander
On 04/20/2012 11:16 AM, Alex Jia wrote: On 04/20/2012 04:29 PM, Osier Yang wrote: On 2012年04月20日 16:17, Martin Kletzander wrote: On 04/20/2012 08:46 AM, Osier Yang wrote: --- .../en-US/Creating_a_configuration_file.xml| 82 ++-- .../en-US/Writing_a_test_case.xml

Re: [libvirt] [test-API 08/17] Substitute 'guest ' with 'domain '

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: --- cases/migration/ssh_persistent_paused_no_dst.conf |2 +- .../migration/ssh_persistent_paused_with_dst.conf |2 +- cases/migration/ssh_persistent_running_no_dst.conf |2 +- .../migration/ssh_persistent_running_with_dst.conf |2 +-

Re: [libvirt] [test-API 11/17] Substitute 'guestip' with 'domip'

2012-04-20 Thread Martin Kletzander
On 04/20/2012 08:46 AM, Osier Yang wrote: --- repos/domain/update_devflag.py | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/repos/domain/update_devflag.py b/repos/domain/update_devflag.py index f1ecf32..e87b1e5 100644 ---

Re: [libvirt] [PATCH 1/3] usb: create functions to search usb device accurately

2012-04-30 Thread Martin Kletzander
On 04/28/2012 12:13 PM, Guannan Ren wrote: usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the most strict search usbFindDevByBus():get usb device according to bus, device it returns only one usb device

Re: [libvirt] [PATCH v2 1/3] usb: create functions to search usb device accurately

2012-05-02 Thread Martin Kletzander
On 05/01/2012 10:16 AM, Guannan Ren wrote: usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the most strict search usbFindDevByBus():get usb device according to bus, device it returns only one usb device

Re: [libvirt] [PATCH v2 2/3] qemu: make use of usb search function to initialize usb devices

2012-05-02 Thread Martin Kletzander
On 05/01/2012 10:16 AM, Guannan Ren wrote: refactor qemuPrepareHostdevUSBDevices function, make it focus on adding usb device to activeUsbHostdevs after check. After that, the usb hotplug function qemuDomainAttachHostDevice also could use it. expand qemuPrepareHostUSBDevices to perform the

Re: [libvirt] [PATCH v2 3/3] qemu: search usb device accurately to improve usb device hotplug

2012-05-02 Thread Martin Kletzander
On 05/01/2012 10:16 AM, Guannan Ren wrote: One usb device could be allowed to hotplug in at a time. If user give a xml as follows. Probably there are two usb devices avaiable but with different value of bus, device we give a error to let user use address to specify the desired one.

Re: [libvirt] [PATCH] Add support for qxl.revision in domain XML

2013-02-22 Thread Martin Kletzander
On 02/21/2013 04:32 PM, Christophe Fergeau wrote: Hey Martin, Sorry, took me a while to get back to this patch, No problem, I had the same issue :) On Thu, Feb 14, 2013 at 05:54:02PM +0100, Martin Kletzander wrote: On 02/04/2013 04:16 PM, Christophe Fergeau wrote: --- docs

[libvirt] [PATCH 0/4] Various virsh cleanups and enhancements

2013-03-14 Thread Martin Kletzander
Wanting to resolve rhbz#919372 (fixed in [3/4]) I came accross few things that could've used some polishing, so here's the series. Martin Kletzander (4): Make vshDebug work when parsing parameters Fix snapshot-create-as syntax in help output Allow multiple parameters for schedinfo Cleanup

[libvirt] [PATCH 3/4] Allow multiple parameters for schedinfo

2013-03-14 Thread Martin Kletzander
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=919372 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=919375 Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/virsh-domain.c | 55 ++-- 1 file changed, 27 insertions(+), 28

[libvirt] [PATCH 2/4] Fix snapshot-create-as syntax in help output

2013-03-14 Thread Martin Kletzander
: SYNOPSIS snapshot-create-as ... [memspec] ... ... OPTIONS [--memspec] string ... virsh help snapshot-create-as after this patch: SYNOPSIS snapshot-create-as ... [--memspec string] ... ... OPTIONS --memspec string ... Signed-off-by: Martin Kletzander mklet...@redhat.com

[libvirt] [PATCH 1/4] Make vshDebug work when parsing parameters

2013-03-14 Thread Martin Kletzander
The vshInit initializes ctl-debug by which vshDebug (which is also called in vshParseArgv) decides whether to print out the message or not. Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/virsh.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools

Re: [libvirt] [PATCH] Fix size probing for VDI images

2013-03-14 Thread Martin Kletzander
On 03/14/2013 01:45 PM, Ján Tomko wrote: Commit 027bf2ea used the wrong offset: the text field at the start of the header has 64 bytes, not 68. [1] Bug: https://bugzilla.redhat.com/show_bug.cgi?id=921452 [1] https://forums.virtualbox.org/viewtopic.php?p=29267#p29267 --- Relevant for

Re: [libvirt] [PATCH 1/4] Make vshDebug work when parsing parameters

2013-03-15 Thread Martin Kletzander
On 03/14/2013 06:15 PM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:32AM +0100, Martin Kletzander wrote: The vshInit initializes ctl-debug by which vshDebug (which is also called in vshParseArgv) decides whether to print out the message or not. Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 2/4] Fix snapshot-create-as syntax in help output

2013-03-15 Thread Martin Kletzander
On 03/14/2013 06:48 PM, Eric Blake wrote: On 03/14/2013 11:16 AM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:33AM +0100, Martin Kletzander wrote: According to the man page, the memspec parameter should have the '--memspec' option mandatory and this is as close as we can get

Re: [libvirt] [PATCH 1/4] Make vshDebug work when parsing parameters

2013-03-15 Thread Martin Kletzander
On 03/15/2013 02:17 PM, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 02:10:08PM +0100, Martin Kletzander wrote: On 03/14/2013 06:15 PM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:32AM +0100, Martin Kletzander wrote: The vshInit initializes ctl-debug by which vshDebug (which

Re: [libvirt] [PATCH 4/4] Cleanup useless flags specifications

2013-03-15 Thread Martin Kletzander
On 03/14/2013 06:25 PM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:35AM +0100, Martin Kletzander wrote: After we switched to C99 initialization, I noticed there were many places where the specification of .flags parameter differed. After going through many options and deciding

Re: [libvirt] [PATCH 3/4] Allow multiple parameters for schedinfo

2013-03-21 Thread Martin Kletzander
On 03/14/2013 09:53 PM, Eric Blake wrote: On 03/14/2013 03:27 AM, Martin Kletzander wrote: virsh schedinfo was able to set only one parameter at a time (not counting the deprecated options), but it is useful to set more at once, so this patch adds the possibility to do stuff like this: virsh

[libvirt] [PATCH] lxc: Prevent shutting down the host

2013-03-21 Thread Martin Kletzander
When the container has the same '/dev' mount as host (no chroot), calling domainShutdown(WithFlags) shouldn't shutdown the host it is running on. Signed-off-by: Martin Kletzander mklet...@redhat.com --- This is also valid for 1.0.[23]-maint branches, so in case this gets ACK'd I'll either send

[libvirt] [PATCH] Correct invalid RNG schemas.

2013-03-21 Thread Martin Kletzander
domain.rnc There were unescaped minuses in regular expressions and we were constraining int (which is by default in the range of [-2^31;2^31-1] to maximum of 2^32. But what we wanted was exactly an unsignedInt. Signed-off-by: Martin Kletzander mklet...@redhat.com --- Thanks to that, the '.rnc' files

[libvirt] [PATCH v2] Allow multiple parameters for schedinfo

2013-03-21 Thread Martin Kletzander
: https://bugzilla.redhat.com/show_bug.cgi?id=919375 Signed-off-by: Martin Kletzander mklet...@redhat.com --- v2: - correctly report unsupported options - man page updated tests/virsh-schedinfo | 4 +- tools/virsh-domain.c | 119 -- tools/virsh.pod

Re: [libvirt] [PATCH] Correct invalid RNG schemas.

2013-03-21 Thread Martin Kletzander
On 03/21/2013 05:00 PM, Ján Tomko wrote: On 03/21/2013 04:28 PM, Martin Kletzander wrote: The 'trang' utility, which is able to transform '.rng' files into '.rnc' files, reported some errors in our schemas that weren't caught by the tools we use in the build. I haven't added a test

  1   2   3   4   5   6   7   8   9   10   >