ping
-Original Message-
From: Shaleen Bathla
Sent: Tuesday, June 20, 2023 2:44 PM
To: libvir-list@redhat.com
Subject: [RFC] Adding timestamp to guest's serial console log
Hi,
Need some comments regarding the following feature :
Addition of timestamp support for serial console logs
ng (should be big
enough)
instead of unsigned int in sscanf, g_strdup_printf as required.
Signed-off-by: Shaleen Bathla
---
src/nwfilter/nwfilter_dhcpsnoop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c
b/src/nwfilter/nwfilter_dhcpsno
Coverity scan reports use after free issue.
In error case, don't free vm object as it will be unlocked+freed
in the parent function like qemuProcessHandleReset().
Signed-off-by: Shaleen Bathla
---
src/qemu/qemu_process.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_process.c
On Tue, Jan 10, 2023 at 09:00:42AM +0100, Peter Krempa wrote:
> On Tue, Jan 10, 2023 at 11:12:55 +0530, Shaleen Bathla wrote:
> > Coverity scan reports use after free issue.
> > In error case, don't free vm object as it will be unlocked+freed
> > in the parent function like q
ping
On Tue, Nov 22, 2022 at 03:08:43PM +0100, Peter Krempa wrote:
> From: Shaleen Bathla
>
> Use of qemuDomainValidateVcpuInfo in the helpers for hotplug and unplug
> of vCPUs can lead to spurious errors reported such as:
>
> internal error: qemu didn't report thre
Tested internally and v3 also works well.
Thanks and Regards,
Shaleen Bathla
On Tue, Nov 22, 2022 at 03:08:43PM +0100, Peter Krempa wrote:
> From: Shaleen Bathla
>
> Use of qemuDomainValidateVcpuInfo in the helpers for hotplug and unplug
> of vCPUs can lead to spurious err
ping
On Fri, Nov 11, 2022 at 02:54:38PM +0530, Shaleen Bathla wrote:
> Problem:
> libvirt has a 5 second timeout (generally) for hotplug/unplug
> operations which can time out due to heavy load in guest.
>
> vcpu hotunplug occurs one vcpu at a time.
> But, if we perform hotplug
Coverity scan reports use after free issue which is a false positive.
In error case, free event->vm instead of vm to avoid this warning in
coverity.
Coverty CID: 403592
Signed-off-by: Shaleen Bathla
---
src/qemu/qemu_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
In error case, free event->vm instead of vm.
This makes it easier for the reader to understand what we should free.
Signed-off-by: Shaleen Bathla
---
src/qemu/qemu_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_proces
On Tue, Jan 17, 2023 at 10:09:41AM +0100, Peter Krempa wrote:
> On Tue, Jan 17, 2023 at 11:51:07 +0530, Shaleen Bathla wrote:
> > Coverity scan reports use after free issue which is a false positive.
> > In error case, free event->vm instead of vm to avoid this warni
ping
On Tue, Jan 17, 2023 at 02:52:13PM +0530, Shaleen Bathla wrote:
> In error case, free event->vm instead of vm.
> This makes it easier for the reader to understand what we should free.
>
> Signed-off-by: Shaleen Bathla
> ---
> src/qemu/qemu_process.c | 2 +-
> 1 f
And we can remove a vcpu if it's alias was NULL by checking this alias.
During vcpu validation, we can skip to nextvcpu if this hotplug-timeout-alias
is set indicating that this vcpu is actually valid.
Co-authored-by: Partha Satapathy
Signed-off-by: Shaleen Bathla
---
src/qemu/qemu_domain.c | 6 +
fo refresh occurs.
Validation is also done for corresponding vcpus only, not all.
Co-authored-by: Partha Satapathy
Signed-off-by: Shaleen Bathla
---
src/qemu/qemu_domain.c | 6 --
src/qemu/qemu_hotplug.c | 39 +++
2 files changed, 35 insertions(+), 10
a user, a better understanding of the progress of
blockjob/blockcommit etc
This patch intends to do exactly that by adding more granularity to
blockjob/blockcommit etc progress.
Shaleen Bathla (2):
tools: virsh-domain: refactor variable initialization
tools: virsh-domain: display progress
Signed-off-by: Shaleen Bathla
---
tools/virsh-domain.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 6850843a259f..165aa0ee0f19 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1722,12 +1722,10
Switch from int to double for displaying job progress upto 2 decimal
places.
Signed-off-by: Shaleen Bathla
---
tools/virsh-domain.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 165aa0ee0f19..9f82722b2ac6
scenarios for now.
This will give a user, a better understanding of the progress of
blockjob/blockcommit etc
This patch intends to do exactly that by adding more granularity to
blockjob/blockcommit etc progress.
Shaleen Bathla (2):
tools: virsh-domain: refactor variable initialization
tools
Signed-off-by: Shaleen Bathla
---
tools/virsh-domain.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 6850843a259f..165aa0ee0f19 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1722,12 +1722,10
Switch from int to double for displaying job progress upto 2 decimal
places.
Signed-off-by: Shaleen Bathla
---
tools/virsh-domain.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 165aa0ee0f19..af2c0842079c
Missed adding V2 in subject title.
Can someone please guide, if I should resend the patch series with the title
correction or this can be taken forward ?
Thanks and Regards,
Shaleen Bathla
-Original Message-
From: Shaleen Bathla
Sent: Wednesday, April 26, 2023 4:59 PM
To: libvir-list
over-writing a variable in inner while-loop without freeing previous memory
leaks it over time.
To fix this, we can just change scope of bank variable to the inner loop.
Signed-off-by: Shaleen Bathla
---
src/conf/capabilities.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
comments regarding this change like what I should keep
in mind while implementing, whether it is a welcome addition or not,
issues I might face, any qemu changes required.
Thanks and Regards,
Shaleen Bathla
22 matches
Mail list logo
