Re: [libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

2016-09-16 Thread Matthias Bolte
2016-09-16 21:06 GMT+02:00 Matthias Bolte : > [please don't top-post] > > 2016-09-16 20:11 GMT+02:00 Jason Miesionczek : >> Not sure I understand what you mean by ‘not adding the string table’. Could >> you please elaborate? >> >> I understand what you are saying about splitting things up into mor

Re: [libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

2016-09-16 Thread Matthias Bolte
[please don't top-post] 2016-09-16 20:11 GMT+02:00 Jason Miesionczek : > Not sure I understand what you mean by ‘not adding the string table’. Could > you please elaborate? > > I understand what you are saying about splitting things up into more logical > chunks, by topic, so i will do that for

Re: [libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

2016-09-16 Thread Jason Miesionczek
Not sure I understand what you mean by ‘not adding the string table’. Could you please elaborate? I understand what you are saying about splitting things up into more logical chunks, by topic, so i will do that for the patches going forward. Thanks for your feedback, i’m still pretty new to C (

Re: [libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

2016-09-16 Thread Matthias Bolte
2016-09-16 18:35 GMT+02:00 Jason Miesionczek : > Second round of patches based on recently complete code review. Going > to submit patches in much smaller chunks, starting with this one. Future > patches will be submitted as each previous patch is reviewed and merged. 1-commit flow isn't ideal eit

[libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

2016-09-16 Thread Jason Miesionczek
Second round of patches based on recently complete code review. Going to submit patches in much smaller chunks, starting with this one. Future patches will be submitted as each previous patch is reviewed and merged. Jason Miesionczek (1): hyperv: add new WMI classes and improve generator src/h