Re: [libvirt] [PATCH 0/4] Add VCPU halted to domain statistics
On 25.10.2016 00:56, John Ferlan wrote: > [...] > Now pushed > > John > Thanks! -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Add VCPU halted to domain statistics
On 10/24/2016 11:24 AM, Viktor Mihajlovski wrote: > On 24.10.2016 16:29, John Ferlan wrote: > [...] >> >> The series looks good to me - do you think it's worthwhile to mention >> anywhere in virsh.pod that the "halted" could mean "really halted" or >> "not scheduled" or "not actively processing" depending on architecture? >> (and how best to say it). > As the other values' documentation is quite terse, I was tempted to stay > in style by being brief as well. Maybe something along the lines of: > ... halted: yes or no (may indicate the processor is idle or even > disabled, depending on the architecture). Perfect - I went with that. >> >> I can tweak virsh.pod before pushing based on your or others >> feedback/thoughts. >> > Surely no objections from my side. > [...] > > Now pushed John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Add VCPU halted to domain statistics
On 24.10.2016 16:29, John Ferlan wrote: [...] > > The series looks good to me - do you think it's worthwhile to mention > anywhere in virsh.pod that the "halted" could mean "really halted" or > "not scheduled" or "not actively processing" depending on architecture? > (and how best to say it). As the other values' documentation is quite terse, I was tempted to stay in style by being brief as well. Maybe something along the lines of: ... halted: yes or no (may indicate the processor is idle or even disabled, depending on the architecture). > > I can tweak virsh.pod before pushing based on your or others > feedback/thoughts. > Surely no objections from my side. [...] -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Add VCPU halted to domain statistics
On 10/13/2016 07:42 AM, Viktor Mihajlovski wrote: > As a result of the discussions on > https://www.redhat.com/archives/libvir-list/2016-October/msg00531.html: > > In order to be able to report the per VCPU halted condition as returned > by the QEMU monitor this series extends the VCPU-specific domain > statistics with a vcpu.n.halted value. > > This is done by > - extending the monitor to pass back the halted condition for the vcpus > - adding a new field to the private domain vcpu object reflecting the > halted condition for the vcpu > - modifying the driver code to report the new VCPU domain statistics value > > The halted condition is however not recorded in the internal XML format, since > the state can change asynchronously (without notification). > > Patches 1/4 and 2/4 are taken without modifications from the original > posting. In 4/4 I've only updated virsh.pod as I didn't want to > touch libvirt-domain.c in this context just for documentation purposes. > > Viktor Mihajlovski (4): > qemu: Add monitor support for CPU halted state > qemu: Add domain support for VCPU halted state > qemu: add vcpu.n.halted to vcpu domain stats > doc: update virsh domstats documentation for vcpu statistics > > src/qemu/qemu_domain.c | 66 > > src/qemu/qemu_domain.h | 5 > src/qemu/qemu_driver.c | 34 --- > src/qemu/qemu_monitor.c | 6 +++- > src/qemu/qemu_monitor.h | 3 ++ > src/qemu/qemu_monitor_json.c | 3 ++ > src/qemu/qemu_monitor_text.c | 8 +- > tests/qemumonitorjsontest.c | 8 +++--- > tools/virsh.pod | 7 + > 9 files changed, 130 insertions(+), 10 deletions(-) > The series looks good to me - do you think it's worthwhile to mention anywhere in virsh.pod that the "halted" could mean "really halted" or "not scheduled" or "not actively processing" depending on architecture? (and how best to say it). I can tweak virsh.pod before pushing based on your or others feedback/thoughts. Tks - John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
