Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-26 Thread Eduardo Habkost
On Thu, Nov 15, 2018 at 12:21:55PM +0100, Cornelia Huck wrote: > On Wed, 14 Nov 2018 21:38:31 -0200 > Eduardo Habkost wrote: > > > diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h > > index 813082b0d7..1d2a11504f 100644 > > --- a/hw/virtio/virtio-pci.h > > +++

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-21 Thread Andrea Bolognani
On Tue, 2018-11-20 at 14:14 -0500, Michael S. Tsirkin wrote: > On Tue, Nov 20, 2018 at 01:27:05PM +0100, Andrea Bolognani wrote: > > On Mon, 2018-11-19 at 14:14 -0500, Michael S. Tsirkin wrote: > > > Well it works now - connect it to a bus and it figures out whether it > > > should do transitional

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Michael S. Tsirkin
On Tue, Nov 20, 2018 at 01:27:05PM +0100, Andrea Bolognani wrote: > On Mon, 2018-11-19 at 14:14 -0500, Michael S. Tsirkin wrote: > > On Mon, Nov 19, 2018 at 07:56:38PM +0100, Cornelia Huck wrote: > > > On Mon, 19 Nov 2018 13:42:58 -0500 "Michael S. Tsirkin" > > > wrote: > > > > We have this

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Andrea Bolognani
On Mon, 2018-11-19 at 14:14 -0500, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2018 at 07:56:38PM +0100, Cornelia Huck wrote: > > On Mon, 19 Nov 2018 13:42:58 -0500 "Michael S. Tsirkin" > > wrote: > > > We have this assumption that if we force a choice then people will > > > choose the right

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Eduardo Habkost
On Tue, Nov 20, 2018 at 11:52:27AM +0100, Cornelia Huck wrote: > On Mon, 19 Nov 2018 22:44:54 -0200 > Eduardo Habkost wrote: > > > On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > > > On Thu, 15 Nov 2018 10:05:59 + > > > Daniel P. Berrangé wrote: > > > > > If libvirt did

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Cornelia Huck
On Mon, 19 Nov 2018 22:44:54 -0200 Eduardo Habkost wrote: > On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > > On Thu, 15 Nov 2018 10:05:59 + > > Daniel P. Berrangé wrote: > > > If libvirt did this compatibility approach, can you > > > confirm this would be live migration

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Daniel P . Berrangé
On Mon, Nov 19, 2018 at 10:44:54PM -0200, Eduardo Habkost wrote: > On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > > On Thu, 15 Nov 2018 10:05:59 + > > Daniel P. Berrangé wrote: > > > > > On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote: > > > > Many of the

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Cornelia Huck
On Mon, 19 Nov 2018 19:32:32 -0200 Eduardo Habkost wrote: > However, I wish this kind of usability magic didn't automatically > imposed us the burden of keeping guest ABI compatibility too. > Keeping ABI compatibility on the machine-friendly device types and > interfaces is already hard enough.

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 10:08:42PM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2018 at 07:47:40PM -0200, Eduardo Habkost wrote: > > On Mon, Nov 19, 2018 at 01:07:59PM -0500, Michael S. Tsirkin wrote: > > n > > > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > > > On Fri,

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 07:47:40PM -0200, Eduardo Habkost wrote: > On Mon, Nov 19, 2018 at 01:07:59PM -0500, Michael S. Tsirkin wrote: > n > > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > > On Fri, 16 Nov 2018 01:45:51 -0200 > > > Eduardo Habkost wrote: > > > > > > > On

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Eduardo Habkost
On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > On Thu, 15 Nov 2018 10:05:59 + > Daniel P. Berrangé wrote: > > > On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote: > > > Many of the current virtio-*-pci device types actually represent > > > 3 different types of

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 01:07:59PM -0500, Michael S. Tsirkin wrote: n > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > On Fri, 16 Nov 2018 01:45:51 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote: > > > > > > One

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 07:56:38PM +0100, Cornelia Huck wrote: > On Mon, 19 Nov 2018 13:42:58 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 07:32:38PM +0100, Cornelia Huck wrote: > > > On Mon, 19 Nov 2018 13:07:59 -0500 > > > "Michael S. Tsirkin" wrote: > > > > > And I

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 07:56:38PM +0100, Cornelia Huck wrote: > On Mon, 19 Nov 2018 13:42:58 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 07:32:38PM +0100, Cornelia Huck wrote: > > > On Mon, 19 Nov 2018 13:07:59 -0500 > > > "Michael S. Tsirkin" wrote: > > > > > And I

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Cornelia Huck
On Mon, 19 Nov 2018 13:42:58 -0500 "Michael S. Tsirkin" wrote: > On Mon, Nov 19, 2018 at 07:32:38PM +0100, Cornelia Huck wrote: > > On Mon, 19 Nov 2018 13:07:59 -0500 > > "Michael S. Tsirkin" wrote: > > > And I strongly believe command line users really really do not want all > > > this mess.

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 07:32:38PM +0100, Cornelia Huck wrote: > On Mon, 19 Nov 2018 13:07:59 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > > On Fri, 16 Nov 2018 01:45:51 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Thu,

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Cornelia Huck
On Mon, 19 Nov 2018 13:07:59 -0500 "Michael S. Tsirkin" wrote: > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > On Fri, 16 Nov 2018 01:45:51 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote: > > > > And once

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > On Fri, 16 Nov 2018 01:45:51 -0200 > Eduardo Habkost wrote: > > > On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote: > > > > One thing that I'm very much not convinced about is the naming, > > > specifically leaving

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Cornelia Huck
On Fri, 16 Nov 2018 01:45:51 -0200 Eduardo Habkost wrote: > On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote: > > One thing that I'm very much not convinced about is the naming, > > specifically leaving the virtio revision out: I get it that we > > Should Never Need™ another

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-15 Thread Eduardo Habkost
On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote: > On Wed, 2018-11-14 at 21:38 -0200, Eduardo Habkost wrote: > > Many of the current virtio-*-pci device types actually represent > > 3 different types of devices: > > * virtio 1.0 non-transitional devices > > * virtio 1.0

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-15 Thread Andrea Bolognani
On Wed, 2018-11-14 at 21:38 -0200, Eduardo Habkost wrote: > Many of the current virtio-*-pci device types actually represent > 3 different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transitional devices > * virtio 0.9 ("legacy device" in virtio 1.0 terminology) > >

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-15 Thread Cornelia Huck
On Thu, 15 Nov 2018 12:21:55 +0100 Cornelia Huck wrote: > After a quick look, this seems fine; have not actually tried to run it > yet. Played a bit with it (with zpci devices for a s390x machine), seems to work as expected. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-15 Thread Cornelia Huck
On Wed, 14 Nov 2018 21:38:31 -0200 Eduardo Habkost wrote: > diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h > index 813082b0d7..1d2a11504f 100644 > --- a/hw/virtio/virtio-pci.h > +++ b/hw/virtio/virtio-pci.h (...) > +/** > + * VirtioPCIDeviceTypeInfo: > + * > + * Template for

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-15 Thread Cornelia Huck
On Thu, 15 Nov 2018 10:05:59 + Daniel P. Berrangé wrote: > On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote: > > Many of the current virtio-*-pci device types actually represent > > 3 different types of devices: > > * virtio 1.0 non-transitional devices > > * virtio 1.0

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-15 Thread Daniel P . Berrangé
On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > On Thu, 15 Nov 2018 10:05:59 + > Daniel P. Berrangé wrote: > > > On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote: > > > Many of the current virtio-*-pci device types actually represent > > > 3 different types of

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-15 Thread Daniel P . Berrangé
On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote: > Many of the current virtio-*-pci device types actually represent > 3 different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transitional devices > * virtio 0.9 ("legacy device" in virtio 1.0 terminology)