Re: [libvirt] [PATCH v3 4/8] vsh: Extract vshCmddefCheckInternals from vshCmddefOptParse

2016-09-16 Thread Erik Skultety
On 16/09/16 13:58, Ján Tomko wrote: > On Fri, Sep 16, 2016 at 12:50:41PM +0200, Erik Skultety wrote: >> Originally introduced by commit 2432521e which correctly split >> vshCmddefOptParse into command's options validation and options parsing. >> However, command's 'internals' are not tied solely to

Re: [libvirt] [PATCH v3 4/8] vsh: Extract vshCmddefCheckInternals from vshCmddefOptParse

2016-09-16 Thread Ján Tomko
On Fri, Sep 16, 2016 at 12:50:41PM +0200, Erik Skultety wrote: Originally introduced by commit 2432521e which correctly split vshCmddefOptParse into command's options validation and options parsing. However, command's 'internals' are not tied solely to .options, rather it should be about the over