Re: [libvirt] [PATCHv3 12/13] build: switch --with-qemu default from yes to check

[Andrea Bolognani]

On Tue, 2018-05-15 at 16:00 +0200, Ján Tomko wrote:
> On Tue, May 15, 2018 at 03:14:33PM +0200, Peter Krempa wrote:
> > >  AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [
> > > -  LIBVIRT_ARG_WITH_FEATURE([QEMU], [QEMU/KVM], [yes])
> > 
> > Well if we've required it until now, I'd be inclined to continue doing
> > so.
> 
> The idea was to not introduce another dependency for default
> './autogen.sh', while still producing an error for someone requesting
> --with-qemu without having a JSON library installed.

I agree with your reasoning, so ACK on my part.

We should do the same for the VirtualBox and ESX drivers, too.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv3 12/13] build: switch --with-qemu default from yes to check

[Ján Tomko]

On Tue, May 15, 2018 at 03:14:33PM +0200, Peter Krempa wrote:

On Fri, May 11, 2018 at 14:59:13 +0200, Ján Tomko wrote:

Unless explicitly requested, enable the QEMU driver
only if the Jansson library is present.

Signed-off-by: Ján Tomko 
---
 m4/virt-driver-qemu.m4 | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4
index 80e1d3ad46..ddb2834705 100644
--- a/m4/virt-driver-qemu.m4
+++ b/m4/virt-driver-qemu.m4
@@ -18,7 +18,7 @@ dnl .
 dnl

 AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [
-  LIBVIRT_ARG_WITH_FEATURE([QEMU], [QEMU/KVM], [yes])


Well if we've required it until now, I'd be inclined to continue doing
so.


The idea was to not introduce another dependency for default
'./autogen.sh', while still producing an error for someone requesting
--with-qemu without having a JSON library installed.

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv3 12/13] build: switch --with-qemu default from yes to check

[Peter Krempa]

On Fri, May 11, 2018 at 14:59:13 +0200, Ján Tomko wrote:
> Unless explicitly requested, enable the QEMU driver
> only if the Jansson library is present.
> 
> Signed-off-by: Ján Tomko 
> ---
>  m4/virt-driver-qemu.m4 | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4
> index 80e1d3ad46..ddb2834705 100644
> --- a/m4/virt-driver-qemu.m4
> +++ b/m4/virt-driver-qemu.m4
> @@ -18,7 +18,7 @@ dnl .
>  dnl
>  
>  AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [
> -  LIBVIRT_ARG_WITH_FEATURE([QEMU], [QEMU/KVM], [yes])

Well if we've required it until now, I'd be inclined to continue doing
so.


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list