[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread Derek Chen-Becker
That's really odd. As far as I know the only thing JPA related that might have changed is for the JPA Demo site (pom Hibernate version change). The transaction handling code is all in ScalaJPA, which also hasn't changed. JndiEMF explicitly opens a transaction before it even retrieves the EM from

[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread Kris Nuttycombe
On Thu, Nov 12, 2009 at 5:57 PM, David Pollak feeder.of.the.be...@gmail.com wrote: Kris, There was a bunch of changes in the net.liftweb.mapper.DB code for transaction management, but I don't think that would impact JPA. Also, in M7, there were changes in how RequestVars are handled during

[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread Derek Chen-Becker
Looking at 81f1715f671e8b5ee4f6d3ce242cc9da272611d1, maybe the RequestVar needs to be changed to an UnboundRequestVar. It's not clear from the scaladocs on UnboundRequestVar, though, that this is the intent. It looks like those scaladocs were just copied and pasted from RequestVar. If this sounds

[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread Kris Nuttycombe
Hmmm is this now TransientRequestVar? It's private[http], but could it be protected instead? Kris On Fri, Nov 13, 2009 at 11:22 AM, Kris Nuttycombe kris.nuttyco...@gmail.com wrote: Let me just try it out since I've got a test case, and if need be I'll file the ticket commit. Kris On

[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread Kris Nuttycombe
Let me just try it out since I've got a test case, and if need be I'll file the ticket commit. Kris On Fri, Nov 13, 2009 at 10:45 AM, Derek Chen-Becker dchenbec...@gmail.com wrote: Looking at 81f1715f671e8b5ee4f6d3ce242cc9da272611d1, maybe the RequestVar needs to be changed to an

[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread Derek Chen-Becker
Looks like it. Probably private[liftweb] would work, too. In any case, the scaladocs need to be updated to reflect what it's for. On Fri, Nov 13, 2009 at 12:26 PM, Kris Nuttycombe kris.nuttyco...@gmail.com wrote: Hmmm is this now TransientRequestVar? It's private[http], but could it be

[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread Kris Nuttycombe
On Fri, Nov 13, 2009 at 11:46 AM, Derek Chen-Becker dchenbec...@gmail.com wrote: Looks like it. Probably private[liftweb] would work, too. In any case, the scaladocs need to be updated to reflect what it's for. On Fri, Nov 13, 2009 at 12:26 PM, Kris Nuttycombe kris.nuttyco...@gmail.com

[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread David Pollak
On Fri, Nov 13, 2009 at 12:12 PM, Kris Nuttycombe kris.nuttyco...@gmail.com wrote: On Fri, Nov 13, 2009 at 11:46 AM, Derek Chen-Becker dchenbec...@gmail.com wrote: Looks like it. Probably private[liftweb] would work, too. In any case, the scaladocs need to be updated to reflect what it's

[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread Kris Nuttycombe
On Fri, Nov 13, 2009 at 3:42 PM, David Pollak feeder.of.the.be...@gmail.com wrote: On Fri, Nov 13, 2009 at 12:12 PM, Kris Nuttycombe kris.nuttyco...@gmail.com wrote: On Fri, Nov 13, 2009 at 11:46 AM, Derek Chen-Becker dchenbec...@gmail.com wrote: Looks like it. Probably private[liftweb]

[Lift] Re: Changes to transaction handling since M6?

2009-11-13 Thread Ross Mellgren
FWIW regarding naming, since the change I've started to mentally rename RequestVar to PageVar. I don't think it's reasonable to rename the actual class, since everybody uses it, but I found it was a helpful mnemonic to remember what scope it has. -Ross On Nov 13, 2009, at 6:00 PM, Kris

[Lift] Re: Changes to transaction handling since M6?

2009-11-12 Thread David Pollak
Kris, There was a bunch of changes in the net.liftweb.mapper.DB code for transaction management, but I don't think that would impact JPA. Also, in M7, there were changes in how RequestVars are handled during Ajax requests... basically, state is snapshotted when the Ajax request is created and