Re: [Lift] CouchDB queryView Enhancements?

2010-02-20 Thread Ross Mellgren
Oh, no problem at all; I'm sorry that it's not as well tested as it ought to be though with your help that's rapidly improving. I'm glad you like it! Please continue to share your experience with it -- I'll try to smooth out any wrinkles as fast as I can. Thanks for the well reasoned and de

Re: [Lift] CouchDB queryView Enhancements?

2010-02-20 Thread Justin Reardon
Thanks for the fixes Ross! This library is a really great piece of work. On 2010-02-20, at 12:53 , Ross Mellgren wrote: > Pushed to master > http://github.com/dpp/liftweb/commit/39c475b373d925133b55437aa578cfc18b6a4442 > > -Ross > > On Feb 18, 2010, at 4:07 PM, Justin Reardon wrote: > >> From

Re: [Lift] CouchDB queryView Enhancements?

2010-02-20 Thread Ross Mellgren
Pushed to master http://github.com/dpp/liftweb/commit/39c475b373d925133b55437aa578cfc18b6a4442 -Ross On Feb 18, 2010, at 4:07 PM, Justin Reardon wrote: > From the review board diff it looks like you forgot to actually remove the > call to dontReduce (line 221). Perhaps a test case that will act

Re: [Lift] CouchDB queryView Enhancements?

2010-02-18 Thread Ross Mellgren
Once again unto the breach. http://reviewboard.liftweb.net/r/216/ -Ross On Feb 18, 2010, at 4:07 PM, Justin Reardon wrote: > From the review board diff it looks like you forgot to actually remove the > call to dontReduce (line 221). Perhaps a test case that will actually fail if > queryViewDo

Re: [Lift] CouchDB queryView Enhancements?

2010-02-18 Thread Justin Reardon
>From the review board diff it looks like you forgot to actually remove the >call to dontReduce (line 221). Perhaps a test case that will actually fail if >queryViewDocs were to include the dontReduce call would be good? For example >querying on view "people_by_age" using queryViewDocs would fai

Re: [Lift] CouchDB queryView Enhancements?

2010-02-18 Thread Ross Mellgren
Updated the patch up on review board, so if you think the new patch will work for you, I'll push it once it's reviewed. -Ross On Feb 18, 2010, at 12:28 AM, Justin Reardon wrote: > Wow you're fast. > > You probably shouldn't call dontReduce in queryViewDocsFrom, as recent > versions of couchd

Re: [Lift] CouchDB queryView Enhancements?

2010-02-18 Thread David Pollak
On Thu, Feb 18, 2010 at 5:58 AM, Ross Mellgren wrote: > Sensible. I'll make that change tonight. > > Rock on! > -Ross > > On Feb 18, 2010, at 12:28 AM, Justin Reardon wrote: > > > Wow you're fast. > > > > You probably shouldn't call dontReduce in queryViewDocsFrom, as recent > versions of couch

Re: [Lift] CouchDB queryView Enhancements?

2010-02-18 Thread Ross Mellgren
Sensible. I'll make that change tonight. -Ross On Feb 18, 2010, at 12:28 AM, Justin Reardon wrote: > Wow you're fast. > > You probably shouldn't call dontReduce in queryViewDocsFrom, as recent > versions of couchdb will return an error if this parameter is applied to a > view without a reduc

Re: [Lift] CouchDB queryView Enhancements?

2010-02-17 Thread Justin Reardon
Wow you're fast. You probably shouldn't call dontReduce in queryViewDocsFrom, as recent versions of couchdb will return an error if this parameter is applied to a view without a reduce function. This could easily happen in the case of the linked documents feature I mentioned, or in the case of

Re: [Lift] CouchDB queryView Enhancements?

2010-02-17 Thread Ross Mellgren
Thanks for the suggestion. I created a ticket: http://www.assembla.com/spaces/liftweb/tickets/356-add-ability-to-use-doc-result-of-query--not-just-value And the change is on review board: http://reviewboard.liftweb.net/r/216/ Once that's reviewed and pushed to master you'll be able to query thos

[Lift] CouchDB queryView Enhancements?

2010-02-17 Thread Justin Reardon
Hi, I've started working with the CouchRecord support and I've run into a bit of a problem with the queryView function. I've been writing views involving both map and reduce so I could generate statistics on some hierarchical data, and access leaves in one view, by using include_docs. As I disc