Re: [Lift] New logging code is in master

2010-03-01 Thread Jeppe Nejsum Madsen
On Mon, Mar 1, 2010 at 12:20 AM, David Pollak feeder.of.the.be...@gmail.com wrote: Excellent! We have the deprecations turned off in the pom.xml file by default... but gotta turn the deprecation warnings on post M3. Not sure what this means? Do the generated jars on scala-tools not contain

Re: [Lift] New logging code is in master

2010-02-28 Thread Indrajit Raychaudhuri
Finally! Great job, Jeppe. - IRC On 28/02/10 9:44 PM, Jeppe Nejsum Madsen wrote: The new logging code is now in master and should be fully usable. Therefore, the existing logging code has been deprecated. I've added a Wiki article here: http://wiki.github.com/dpp/liftweb/logging-in-lift

Re: [Lift] New logging code is in master

2010-02-28 Thread David Pollak
Excellent! We have the deprecations turned off in the pom.xml file by default... but gotta turn the deprecation warnings on post M3. On Sun, Feb 28, 2010 at 8:14 AM, Jeppe Nejsum Madsen je...@ingolfs.dkwrote: The new logging code is now in master and should be fully usable. Therefore, the

Re: [Lift] New logging code

2010-02-15 Thread Heiko Seeberger
On 14 February 2010 20:10, Jeppe Nejsum Madsen je...@ingolfs.dk wrote: Makes sense, and that was actually close to what I had initially: The Logger trait was called LiftLogger, but this clashed with the current LiftLogger. This name (Logger in current code) probably doesn't matter too much

Re: [Lift] New logging code

2010-02-15 Thread Jeppe Nejsum Madsen
On Mon, Feb 15, 2010 at 9:17 AM, Heiko Seeberger heiko.seeber...@googlemail.com wrote: On 14 February 2010 20:10, Jeppe Nejsum Madsen je...@ingolfs.dk wrote: Makes sense, and that was actually close to what I had initially: The Logger trait was called LiftLogger, but this clashed with the

Re: [Lift] New logging code

2010-02-15 Thread Heiko Seeberger
On 15 February 2010 09:45, Jeppe Nejsum Madsen je...@ingolfs.dk wrote: Even if (probably) not needed, we should try to name it the best possible way. Changing now causes no pain at all, but later ... you know. Agreed. Suggestions? I already made mine, just to make sure everyone has a

Re: [Lift] New logging code

2010-02-15 Thread Jeppe Nejsum Madsen
On Mon, Feb 15, 2010 at 9:52 AM, Heiko Seeberger heiko.seeber...@googlemail.com wrote: On 15 February 2010 09:45, Jeppe Nejsum Madsen je...@ingolfs.dk wrote: Even if (probably) not needed, we should try to name it the best possible way. Changing now causes no pain at all, but later ... you

Re: [Lift] New logging code

2010-02-15 Thread Indrajit Raychaudhuri
On 15/02/10 7:46 PM, Jeppe Nejsum Madsen wrote: On Mon, Feb 15, 2010 at 9:52 AM, Heiko Seeberger heiko.seeber...@googlemail.com wrote: On 15 February 2010 09:45, Jeppe Nejsum Madsenje...@ingolfs.dk wrote: Even if (probably) not needed, we should try to name it the best possible way.

Re: [Lift] New logging code

2010-02-15 Thread Jeppe Nejsum Madsen
On Mon, Feb 15, 2010 at 9:57 PM, Indrajit Raychaudhuri indraj...@gmail.com wrote: http://github.com/dpp/liftweb/blob/add01980aa81875617f38260d710e0558c7ae1b1/framework/lift-base/lift-common/src/main/scala/net/liftweb/common/Logging.scala One issue remains, which I don't know how to handle (if

Re: [Lift] New logging code

2010-02-15 Thread Naftoli Gugenheim
I don't think it's theoretically possible to have the same trait instance recognize which superclass that it was mixed in to is doing the logging. Because if A mixes in T, and B extends A and also mixes in T, T is not really mixed in twice. For the same reason using a type parameter would not help

Re: [Lift] New logging code

2010-02-14 Thread Heiko Seeberger
On 14 February 2010 14:40, Jeppe Nejsum Madsen je...@ingolfs.dk wrote: Hi, I've tried to keep it as simple as possible, really just a Scala layer on top of the SLF4J api. I think that's a very good decision! Note that no backend (log4j or logback) configuration is included. This has to

Re: [Lift] New logging code

2010-02-14 Thread Jeppe Nejsum Madsen
On Sun, Feb 14, 2010 at 5:59 PM, Heiko Seeberger heiko.seeber...@googlemail.com wrote: On 14 February 2010 14:40, Jeppe Nejsum Madsen je...@ingolfs.dk wrote: Hi, I've tried to keep it as simple as possible, really just a Scala layer on top of the SLF4J api. I think that's a very good