Re: [Lightning-dev] Fat Errors

2022-11-10 Thread Joost Jager
Pushed a golang implementation of the fat errors here: https://github.com/lightningnetwork/lightning-onion/pull/60 Joost. On Wed, Oct 19, 2022 at 1:12 PM Joost Jager wrote: > Hi list, > > I wanted to get back to a long-standing issue in Lightning: gaps in error > attribution. I've posted about

Re: [Lightning-dev] Fat Errors

2022-11-04 Thread Joost Jager
Hi Thomas, This is a very interesting proposal that elegantly solves the problem, with > however a very significant size increase. I can see two ways to keep the > size small: > - Each node just adds its hmac in a naive way, without deleting any part > of the message to relay. You seem to have

Re: [Lightning-dev] Fat Errors

2022-11-03 Thread Thomas HUET
Hi Joost, This is a very interesting proposal that elegantly solves the problem, with however a very significant size increase. I can see two ways to keep the size small: - Each node just adds its hmac in a naive way, without deleting any part of the message to relay. You seem to have

Re: [Lightning-dev] Fat Errors

2022-11-01 Thread Joost Jager
Hey Rusty, Great to hear that you want to try to implement the proposal. I can polish my golang proof of concept code a bit and share if that's useful? It's just doing the calculation in isolation. My next step after that would be to see what it looks like integrated in lnd. 16 hops sounds fine

Re: [Lightning-dev] Fat Errors

2022-10-25 Thread Rusty Russell
Joost Jager writes: > Hi list, > > I wanted to get back to a long-standing issue in Lightning: gaps in error > attribution. I've posted about this before back in 2019 [1]. Hi Joost! Thanks for writing this up fully. Core lightning also doesn't penalize properly, because of the

Re: [Lightning-dev] Fat Errors

2022-10-20 Thread Joost Jager
Ah, missed that. Thanks for the correction. Joost. On Thu, Oct 20, 2022 at 5:36 PM Bastien TEINTURIER wrote: > Hi Joost, > > I need more time to review your proposed change, but I wanted to quickly > correct a misunderstanding you had in quoting eclair's code: > > > Unfortunately it is possible

Re: [Lightning-dev] Fat Errors

2022-10-20 Thread Bastien TEINTURIER
Hi Joost, I need more time to review your proposed change, but I wanted to quickly correct a misunderstanding you had in quoting eclair's code: > Unfortunately it is possible for nodes on the route to hide themselves. > If they return random data as the failure message, the sender won't know >

[Lightning-dev] Fat Errors

2022-10-19 Thread Joost Jager
Hi list, I wanted to get back to a long-standing issue in Lightning: gaps in error attribution. I've posted about this before back in 2019 [1]. Error attribution is important to properly penalize nodes after a payment failure occurs. The goal of the penalty is to give the next attempt a better