- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
~~~
Change \partcombine (et al.) to \partCombine master staging
author Valentin Villenave
Fri, 28 Dec 2018 09:14:40 + (10:14 +0100)
committer Valentin Villenave
- **Patch**: countdown --> push
- **Comment**:
Patch counted down, please push.
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Mon Dec 24, 2018 10:26 AM UTC
- **Patch**: review --> countdown
- **Comment**:
Patch on countdown for Dec 27th
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Sat Dec 22, 2018 01:26 PM UTC
- **Needs**: -->
- **Patch**: new --> review
- **Type**: --> Enhancement
- **Comment**:
Passes make, make check and a full make doc.
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
Correct convert rules.
http://codereview.appspot.com/369930043
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Fri Dec 21, 2018 05:51 PM UTC
**Owner:** Valentin
- **Patch**: countdown --> push
- **Comment**:
Patch counted down - please push.
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Tue Dec 18, 2018 12:30 PM UTC
- **Patch**: review --> countdown
- **Comment**:
Patch on countdown for Dec 21st
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Mon Dec 17, 2018 01:17 PM UTC
- Description has changed:
Diff:
--- old
+++ new
@@ -20,13 +20,5 @@
> Cheers,
> Malte
-Response to Issue #4603: Syntax change from all instances "partcombine" to
"partCombine" and convert-ly rule added to go along with.
+New Rietveld - http://codereview.appspot.com/369930043
- **Needs**: -->
- **Patch**: new --> review
- **Type**: --> Enhancement
- **Comment**:
Passes make, make check and a full make doc.
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
Revamped patch. Passes make & makedoc; adds \autoChange.
http://codereview.appspot.com/369930043
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Sun Dec 16, 2018 02:33
- **Patch**: new --> needs_work
- **Comment**:
This fails make doc.
partcombine-and-autobeamoff.ly
has a '\partcombine' command (instead of '\partCombine') which breaks make doc.
I did a makelsr after applying and before 'make test' but I didn't run a
separate convert-ly (that is not so easy
- **assigned_to**: pkx166h --> Valentin Villenave
- **Needs**: -->
- **Type**: --> Enhancement
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Sat Dec 15, 2018
Change \partcombine (et al.) to \partCombine
I figured I’d try and rebase/update/complete Charles’ previous
proposal in case someone ever decides to apply it.
In which case, I guess \autochange should be updated as well;
that’s the only other multi-word command I could find that
had’nt been
Still cherry-picking stuff into the 2.20 branch, so we don't want extensive
departures (in particular large convert-ly orgies) in master yet. Once 2.20.1
is out, this can get back on the slate, but I'd actually want to get 2.21.1
(pretty much right after 2.20.1, however) without such changes
David,
This had been sat at Waiting for a whiile, I kind of stopped 'noticing' why.
Now I see we have 2.21 are you saying - in effect - that this patch as it
stands (assuming it still applies) is too little or could we apply this and
then keep the tracker open, or create a new tracker for the
- **assigned_to**: Charles Winston --> pkx166h
- **Patch**: new --> waiting
- **Type**: --> Enhancement
- **Comment**:
I'll set this to 'Waiting' for now as I have no problems with waiting until
2.20 is released and there is no pressing requirement for what has been done so
far.
---
**
Ok, this is really really late but I've taken a look at the output of
git grep '[pP]artCombine'
in the current code base and changing those occurences to `partcombine` would
be way less effort than the other way round: basically most of them are new.
I might be predisposed by lots of
- Description has changed:
Diff:
--- old
+++ new
@@ -26,3 +26,7 @@
http://codereview.appspot.com/326870043 - part 2 of 3
+http://codereview.appspot.com/327970043 - part 3 of 3
+
+Note this will require both a convert.ly and a makelsr.py run to make sure
that the patch passes all the
- Description has changed:
Diff:
--- old
+++ new
@@ -23,3 +23,6 @@
Response to Issue #4603: Syntax change from all instances "partcombine" to
"partCombine" and convert-ly rule added to go along with.
http://codereview.appspot.com/323040043 - part 1 of 3
+
Change all instances of \partcombine to \partCombine in the reg tests
Issue 4603 (3 of 3)
All instances of \partcombine in
../input/regression/ have been
changed to \partCombine.
http://codereview.appspot.com/327970043
---
** [issues:#4603] change all occurences of ‘partcombine’ to
Change all instances of \partcombine to \partCombine in the documentation
Issue 4603 (2 of 3)
All instances of \partcombine in
../Documentation (including translated
and snippets) have been changed to
\partCombine.
http://codereview.appspot.com/326870043
---
** [issues:#4603] change all
- Description has changed:
Diff:
--- old
+++ new
@@ -19,3 +19,7 @@
>
> Cheers,
> Malte
+
+Response to Issue #4603: Syntax change from all instances "partcombine" to
"partCombine" and convert-ly rule added to go along with.
+
+http://codereview.appspot.com/323040043 - part 1 of 3
- **Patch**: new --> needs_work
- **Type**: --> Enhancement
- **Comment**:
This fails the make stage.
Charles there needs to be changes done within the documentation - as Trevor
pointed out in the Rietveld issue - but not just the 'descriptive' part (i.e.
for the readers) but also to help
- **assigned_to**: Charles Winston
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Tue May 30, 2017 07:48 PM UTC
**Owner:** Charles Winston
On 13/08/15 21:42, Malte
- **Needs**: -->
- **Type**: -->
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Tue May 30, 2017 01:39 PM UTC
**Owner:** nobody
On 13/08/15 21:42, Malte Meyn
Response to Issue #4603: Syntax change from all instances "partcombine" to
"partCombine" and convert-ly rule added to go along with.
http://codereview.appspot.com/323040043
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun
I've uploaded a patch aiming to fix this. Changed all instances in the source
code and wrote a convert-ly rule to go along with it.
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Accepted
**Labels:** partcombine
**Created:** Sun Sep 13, 2015
27 matches
Mail list logo
