[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

This is unavoidable, I guess, since LilyPond doesn't have the ability to move grobs horizontally for such situations. BTW, this would be a *very* useful addition – just think of a vertically centered forte sign in piano music that makes the staves spread too much if not moved slightly to the

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

I compared the output of 2.20 v. master for all my scores today. Overall, I'm pleased with the impact of this change, but it's not all roses. Attachments: -

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: Due to the lack of confident feedback, I've pushed the changes without the unpure-pure container because they are simpler. I also don't want to set a precedent for using an unpure-pure

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **Patch**: countdown --> push - **Comment**: This patch has been counted down to push. If you want to change this (because of wanting more discussion, please do so). --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **Patch**: review --> countdown - **Comment**: Putting on Countdown for Jan 5th --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Tue Dec 31, 2019

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **Patch**: countdown --> review - **Comment**: Putting back for review. I've seen no updates but because of the holiday season ... --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- Description has changed: Diff: --- old +++ new @@ -5,8 +5,10 @@ \mark \default f'1 | f'1 | } -Dan's suggested Patch - +Dan's Patch (supercede's Werners) - https://codereview.appspot.com/547340043 -Werner's Original Patch - applies to attached png files at start of ticket.

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- Attachments has changed: Diff: --- old +++ new @@ -1 +0,0 @@ -before.png (2.8 kB; image/png) --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

This patch passes make, make check and a full make doc. diffs as follows Dan's suggested Patch - https://codereview.appspot.com/547340043 Reg Test diffs based on Dan's Patch #1: https://cloud-u8zj2dc4b.yourownnet.eu/s/H2fRD4fZtZo4Acw Dan's Patch #2: No test/diff done. Dan's Patch #3:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- Attachments has changed: Diff: --- old +++ new @@ -1,2 +1 @@ -after.png (2.8 kB; image/png) before.png (2.8 kB; image/png) --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

Leaving on Cuontdown --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Sat Dec 21, 2019 01:00 PM UTC **Owner:** Dan Eble **Attachments:** -

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

It looks like this isn't quite ready to push (at least from Discussions on Rietveld). I'll leave this on countdpwn (for Dec 23rd) and check again on the next path review. --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **Patch**: review --> countdown - **Comment**: Patch on countdown for Dec 21st --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Tue Dec 17, 2019 08:51

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **assigned_to**: Werner LEMBERG --> Dan Eble - **Patch**: new --> review - **Comment**: This patch passes make, make check and a full make doc. diffs as follows Dan's suggested Patch - https://codereview.appspot.com/547340043 Dan's Patch #1:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **Patch**: review --> new - **Comment**: This is ready for a full review now. https://codereview.appspot.com/547340043 --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **Patch**: new --> review - **Comment**: This patch passes make, make check and a full make doc. Dan's 17th dec patch's reg test diffs are here: https://cloud-u8zj2dc4b.yourownnet.eu/s/QXJB753MRD8xNnk older: Dan's 15th dec patch's reg test diffs are here:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- Description has changed: Diff: --- old +++ new @@ -5,5 +5,8 @@ \mark \default f'1 | f'1 | } +Dan's suggested Patch - +https://codereview.appspot.com/547340043 -https://codereview.appspot.com/553290043 +Werner's Original Patch - applies to attached png files at start of

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

remove/revise some regtests https://codereview.appspot.com/547340043 --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Mon Dec 16, 2019 03:18 PM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

Good job, Dan! Your patch is superior to my simple attempt. Xavier? --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Sun Dec 15, 2019 03:12 PM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **Needs**: --> - **Patch**: new --> review - **Type**: --> Enhancement --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Sun Dec 15, 2019 03:10 PM

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

Issue 5621: Improve rehearsal mark position at beginning of staff This is a work in progress. RehearsalMark uses a callback for self-alignment-X that yields the opposite of the direction specified by the anchor grob. I don't know if there should be some unpure-pure stuff involved. It looks

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

Leaving on review for now as there seems to be some discussion going on, --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Tue Dec 10, 2019 09:00 PM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc. All reg test diffs here https://cloud-u8zj2dc4b.yourownnet.eu/s/x82NgEnwzKKJykj (~1MB zipped) --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **status**: New --> Started --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** Started **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Tue Dec 10, 2019 07:58 AM UTC **Owner:** Werner LEMBERG **Attachments:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- **Patch**: --> new --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** New **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Tue Dec 10, 2019 07:22 AM UTC **Owner:** Werner LEMBERG **Attachments:** -

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- Description has changed: Diff: --- old +++ new @@ -5,3 +5,5 @@ \mark \default f'1 | f'1 | } + +https://codereview.appspot.com/553290043 --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** New **Created:** Tue Nov 26,

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

How to proceed? --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** New **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Tue Nov 26, 2019 05:43 PM UTC **Owner:** Werner LEMBERG **Attachments:** -

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

See issue https://sourceforge.net/p/testlilyissues/issues/1150/ for more. --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** New **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Tue Nov 26, 2019 01:59 PM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

By the way: Other elements of `break-align-symbols` are not affected by my suggested change. Is there anything else besides rehearsal marks that gets attached to clefs in a similar way? --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** New

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

Well, it's not that bad. { \clef "treble" f'1 | f'1 | \break \mark #1 f'1 | f'1 | \break \once\override Staff.Clef.break-align-anchor-alignment = #2 \mark #1 f'1 | f'1 | \break \clef "bass" \mark #1 f'1 | f'1 | \break \once\override Staff.Clef.break-align-anchor-alignment = #2

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

How does this look with clefs other than treble? And with other values for break-align-symbols? --- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** New **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Tue Nov 26,

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

- Description has changed: Diff: --- old +++ new @@ -1,4 +1,4 @@ -I suggest to change the `break-align-anchor-alignment` property from the `Clef` grob from `RIGHT` to value 2, as shown in the images. +I suggest to change the default value of the `break-align-anchor-alignment` property

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5621 Improve positioning of rehearsal marks at the beginning of staff

--- ** [issues:#5621] Improve positioning of rehearsal marks at the beginning of staff** **Status:** New **Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG **Last Updated:** Tue Nov 26, 2019 11:44 AM UTC **Owner:** Werner LEMBERG **Attachments:** -