Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)

2011-04-26 Thread m...@apollinemike.com
On Apr 25, 2011, at 10:09 PM, hanw...@gmail.com wrote: LGTM http://codereview.appspot.com/4446060/diff/11001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4446060/diff/11001/lily/beam.cc#newcode1209 lily/beam.cc:1209: if (is_cross_staff (me)

Re: Allows glissandi between chords (issue4442082)

2011-04-26 Thread Carl . D . Sorensen
Excellent work! A couple of comments below. http://codereview.appspot.com/4442082/diff/3001/scm/define-context-properties.scm File scm/define-context-properties.scm (right): http://codereview.appspot.com/4442082/diff/3001/scm/define-context-properties.scm#newcode260

Re: Allows glissandi between chords (issue4442082)

2011-04-26 Thread m...@apollinemike.com
On Apr 26, 2011, at 7:30 AM, carl.d.soren...@gmail.com wrote: Excellent work! Thanks! A couple of comments below. http://codereview.appspot.com/4442082/diff/3001/scm/define-context-properties.scm File scm/define-context-properties.scm (right):

Re: Allows glissandi between chords (issue4442082)

2011-04-26 Thread Carl Sorensen
On 4/26/11 5:55 AM, m...@apollinemike.com m...@apollinemike.com wrote: On Apr 26, 2011, at 7:30 AM, carl.d.soren...@gmail.com wrote: File scm/define-grob-properties.scm (right): http://codereview.appspot.com/4442082/diff/3001/scm/define-grob-properties.sc m#newcode412

Re: Allows glissandi between chords (issue4442082)

2011-04-26 Thread m...@apollinemike.com
On Apr 26, 2011, at 9:52 AM, Carl Sorensen wrote: On 4/26/11 5:55 AM, m...@apollinemike.com m...@apollinemike.com wrote: On Apr 26, 2011, at 7:30 AM, carl.d.soren...@gmail.com wrote: File scm/define-grob-properties.scm (right):

Re: Allows glissandi between chords (issue4442082)

2011-04-26 Thread m...@apollinemike.com
On Apr 26, 2011, at 7:55 AM, m...@apollinemike.com wrote: On Apr 26, 2011, at 7:30 AM, carl.d.soren...@gmail.com wrote: Excellent work! Thanks! A couple of comments below. http://codereview.appspot.com/4442082/diff/3001/scm/define-context-properties.scm File

Re: Allows glissandi between chords (issue4442082)

2011-04-26 Thread Carl Sorensen
On 4/26/11 11:00 AM, m...@apollinemike.com m...@apollinemike.com wrote: On Apr 26, 2011, at 7:55 AM, m...@apollinemike.com wrote: On Apr 26, 2011, at 7:30 AM, carl.d.soren...@gmail.com wrote: The old behavior can be achieved via: \set glissandoMap = #'((0 . 0)) What would be the

Gets rid of chordGlissando. (issue4444066)

2011-04-26 Thread mtsolo
Reviewers: , Message: To be pushed after 4442082 is pushed. Description: Gets rid of chordGlissando. Please review this at http://codereview.appspot.com/066/ Affected files: M Documentation/de/notation/fretted-strings.itely M