We have very few (or none) patches for python files, so a large
whitespace change should not break any pending patches.
And even if we have: It's straightforward to change tabs to spaces
even in diff files since such an operation doesn't change the number
of lines.
Werner
Hey all,
I see that the line-spanner print function looks for something that is called
anchor-alignment (git blame insinuates that it was Joe who added this). This
alignment, so far as I can see, is used nowhere in the code (nor is its use
documented). Is it vestigial, and if so, can I nix
multi-measure-rest.cc: In static member function 'static Stencil
Multi_measure_rest::church_rest(Grob*, Font_metric*, int, Real)':
multi-measure-rest.cc:246: error: call of overloaded 'pow(int, int)' is
ambiguous
/usr/include/architecture/i386/math.h:343: note: candidates are: double
2011/6/15 Martin Tarenskeen m.tarensk...@zonnet.nl
On Wed, 15 Jun 2011, Graham Percival wrote:
Mixing indentation styles is not a great idea, and in my
experience of python code documentation and examples online, the
4-space indent rule from PEP-8 is almost universally followed.
Graham Percival wrote Wednesday, June 15, 2011 12:14 AM
Subject: GOP-PROP 2: mentors and Frogs
GOP 2 - mentors and Frogs
Proposal summary
Many new contributors expect more help than they’re getting. We
should either:
1. give them more help, or
2. tell them up-front that they won’t be
Reviewers: ,
Message:
Yes, this is LilyPond patch morning.
This should get line-spanners synced up perfectly with
Spanner::spanner_length.
Description:
Modifies Spanner::spanner_length to better handle line-spanners.
Please review this at http://codereview.appspot.com/4621044/
Affected files:
On Wed, 15 Jun 2011, Federico Bruni wrote:
How can I change this behaviour, so that automatically 4-space
indentation is used. Can/should I change something in my .vimrc file
http://stackoverflow.com/questions/234564/tab-key-4-spaces-and-auto-indent
-after-curly-braces-in-vim
Reviewers: ,
Message:
This, in tandem with the modification to spanner_length, leads to better
optical results for feathered beam breaking.
Description:
Attaches bound info to beam for better normalized-endpoint calculations.
Also adds a slight modification to the print function to take into
@Graham:
perfect! you caught exactly the subtleties which i was worrying that
might be there!
http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode201
thanks,
http://code.google.com/p/lilypond/issues/detail?id=1694
http://codereview.appspot.com/4621044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/06/15 07:18:21, MikeSol wrote:
An aesthetic issue, but it seems to me that this is in better keeping
with what
a glissando represents.
What kind of padding does it use now?
I have a vague recollection of somebody complaining that the glissando
ran directly into the bar line and
thanks,
http://code.google.com/p/lilypond/issues/detail?id=1693
http://codereview.appspot.com/4605047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: Graham Percival, fedelogy_gmail.com,
Message:
I shouldn't have called scripts/auxiliar/makelsr.py?
Description:
doc: fixing snippet fretted-string-harmonics
I probably made it the wrong way - i changed
Documentation/snippets/new/
fretted-string-harmonics-in-tablature.ly
and called
As you wish :)
http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode201
indent indent indent
http://codereview.appspot.com/4490045/diff/25003/lily/tie-engraver.cc
File lily/tie-engraver.cc (right):
http://codereview.appspot.com/4490045/diff/25003/lily/tie-engraver.cc#newcode189
lily/tie-engraver.cc:189: /*
On 2011/06/14 23:07:54, Graham Percival wrote:
these
I've identified a few more questionable lines, although maybe you should
wait for a lilypond C++ expert to look at them.
Now do you see why I was apologizing so much for not starting the C++
GOP question this week? this stuff is ridiculous. :/
LGTM, please make one change, then send me the final version for
pushing.
http://codereview.appspot.com/4621041/diff/9001/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
no, this problem is because I didn't run makelsr.py myself after running
convert-ly on all the snippets.
I've just done this and pushed. If you do the same thing from a clean
git master, then you shouldn't see a ton of changes just from
freeted-string-harmonics and makelsr.py.
In other words,
On Wed, Jun 15, 2011 at 12:11:37AM +0100, Graham Percival wrote:
There should be absolutely no tab characters for indentation in
any .py file in lilypond git. All such files should be converted
to use spaces only.
I'd go a step further and recommend (for python files) that no tabs
are used at
2011/6/15 percival.music...@gmail.com
I think you did exactly the right thing; the problem was
git master, not you.
Ok, the correct Rietveld issue is here http://codereview.appspot.com/4624041/
I close this one.
cheers,
Janek
___
lilypond-devel
looks decent; I'll trust you or Federico about the actual musicality.
Please send me the final patch for pushing.
http://codereview.appspot.com/4624041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
2011/6/15 percival.music...@gmail.com:
looks decent; I'll trust you or Federico about the actual musicality.
Please send me the final patch for pushing.
Here it is.
From 16293abeac036744fb2334b8bc88be7d6b3bc845 Mon Sep 17 00:00:00 2001
From: Janek Warchol lemniskata.bernoull...@gmail.com
Date:
On Wed, Jun 15, 2011 at 12:24:51PM +0200, Janek Warchoł wrote:
2011/6/15 percival.music...@gmail.com:
looks decent; I'll trust you or Federico about the actual musicality.
Please send me the final patch for pushing.
Here it is.
thanks, pushed.
Cheers,
- Graham
On 2011/06/15 10:27:09, graham_percival-music.ca wrote:
thanks, pushed.
thanks, issue closed.
cheers,
Janek
http://codereview.appspot.com/4624041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
2011/6/15 percival.music...@gmail.com:
LGTM, please make one change, then send me the final version for
pushing.
http://codereview.appspot.com/4621041/diff/9001/Documentation/contributor/regressions.itexi#newcode215
Documentation/contributor/regressions.itexi:215: available (relative to
the
On Wed, Jun 15, 2011 at 12:33:54PM +0200, Janek Warchoł wrote:
I should've noticed that also.
Patches attached.
thanks, applied after squashing them into one patch. You might
want to look into
git rebase -i origin/master
also, your git repo might be unhappy the next time you do git
pull.
2011/6/15 Graham Percival gra...@percival-music.ca:
thanks, applied after squashing them into one patch.
issue closed.
You might want to look into
git rebase -i origin/master
I know this. This change was originally 4 commits long, i reduced it to 2 :P
Next time i'll reduce more.
also,
On Wed, Jun 15, 2011 at 11:46:01AM +0200, Matthias Kilian wrote:
On Wed, Jun 15, 2011 at 12:11:37AM +0100, Graham Percival wrote:
There should be absolutely no tab characters for indentation in
any .py file in lilypond git. All such files should be converted
to use spaces only.
I'd go a
2011/6/15 percival.music...@gmail.com:
I've identified a few more questionable lines, although maybe you should
wait for a lilypond C++ expert to look at them.
Well then, i'm stuffed.
If you don't want to make an exception to the indentation rules for
this issue, i'm not going to touch
All indentation should be done with spaces.
This is why I changed some tabs to spaces - sorry if this caused
confusion. I suggest that someone who knows the unwritten rules of
indentation finalizes the format issues.
http://codereview.appspot.com/4490045/
On Wed, Jun 15, 2011 at 08:56:54AM +0200, m...@apollinemike.com wrote:
1) Geographical proximity helps big time. I know that, in a 30ish minute
face-to-face conversation with Bertrand Bordage, I was able to work through
what would otherwise take up to a week over e-mail.
Absolutely!
W dniu 15 czerwca 2011 00:49 użytkownik Carl Sorensen
c_soren...@byu.edu napisał:
On 6/14/11 4:19 PM, Janek Warchoł lemniskata.bernoull...@gmail.com
wrote:
I'm disheartened by the idea of reverting tab-space conversion,
because CG 10.3.2 says All indentation should be done with spaces.
On Wed, Jun 15, 2011 at 08:23:00AM +0100, Trevor Daniels wrote:
Graham Percival wrote Wednesday, June 15, 2011 12:14 AM
Subject: GOP-PROP 2: mentors and Frogs
1. Frog (apprentice): any newcomer is directed to the frog
mailing list, and the Frog Meister will mentor all frogs. The
The
On Wed, Jun 15, 2011 at 01:02:07PM +0200, Janek Warchoł wrote:
2011/6/15 percival.music...@gmail.com:
I've identified a few more questionable lines, although maybe you should
wait for a lilypond C++ expert to look at them.
Well then, i'm stuffed.
yeah.
Enough screwing around. Send me
2011/6/15 Graham Percival gra...@percival-music.ca:
On Wed, Jun 15, 2011 at 01:02:07PM +0200, Janek Warchoł wrote:
2011/6/15 percival.music...@gmail.com:
I've identified a few more questionable lines, although maybe you should
wait for a lilypond C++ expert to look at them.
Well then, i'm
Hello
)-Original Message-
)From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
)[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of Carl Sorensen
)Sent: 15 June 2011 03:22
)To: Francisco Vila
)Cc: LilyPond-Devel list
)Subject: Re: 2.14.1 released;
On Wed, Jun 15, 2011 at 02:05:10PM +0200, Janek Warchoł wrote:
Patches attached. Rebased from 12 to 5 commits; i kept
aaa!! indent commit for historical reasons. I can
rebase more if you want.
Nah, I'm fine. Rebased down to 1, including some more whitespace
changes. Doing a
- Original Message -
From: Graham Percival gra...@percival-music.ca
After the initial tab-fixes (in at most 9 files), we'll use
python -tt for the build process, so no mistakes will creep in.
Doesn't this assume that the doc build is actually checked for errors?
--
Phil Holmes
On Wed, Jun 15, 2011 at 01:49:22PM +0100, Phil Holmes wrote:
- Original Message - From: Graham Percival
gra...@percival-music.ca
After the initial tab-fixes (in at most 9 files), we'll use
python -tt for the build process, so no mistakes will creep in.
Doesn't this assume that the
On 6/15/11 6:21 AM, James Lowe james.l...@datacore.com wrote:
\
Does that also mean that you need me to do something (apart from hurry up and
get the patches for the doc bugs done!)?
When you push a patch for a doc bug that applies to 2.14, please make sure
there's a google code issue
I've pushed a modified version of this.
Given the confusion about our C++ style, I removed a few changes which
were probably good. In some places I added an extra (pointless) space;
in other places I changed a tab character to a space to match the
existing (broken) indentation, etc. The goal
Carl,
)-Original Message-
)From: Carl Sorensen [mailto:c_soren...@byu.edu]
)Sent: 15 June 2011 14:04
)To: James Lowe; Francisco Vila
)Cc: LilyPond-Devel list
)Subject: Re: 2.14.1 released; attention span over
)Importance: Low
)
)
)
)
)On 6/15/11 6:21 AM, James Lowe james.l...@datacore.com
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Wednesday, June 15, 2011 2:02 PM
Subject: Re: GOP-PROP 1: python formatting - probable decision
On Wed, Jun 15, 2011 at 01:49:22PM +0100, Phil
The attached patch reduces the output from make doc slightly and produces
some new log files instead. Graham - could you push, please? (I have done
at least one make doc using it, with no problems).
--
Phil Holmes
Bug Squad
0001-Redirect-lilypond-output-making-midi-files.patch
2011/6/15 Graham Percival gra...@percival-music.ca:
On Wed, Jun 15, 2011 at 08:56:54AM +0200, m...@apollinemike.com wrote:
2) Many-a-university have open-source-upkeep CS (or music in
centers like CCRMA) courses (i.e. Case studies in advanced
algorithmic auto-reglation of white space
On Wed, Jun 15, 2011 at 01:14:09PM +, James Lowe wrote:
I cannot see an option to add a 'backport' tag - for example I can see how to
add the 'Type-Defect' and 'Priority-medium' etc. But nothing with 'Backport'
in the string. So is there a specific way to do this?
at the moment, it's a
On Wed, Jun 15, 2011 at 02:16:37PM +0100, Phil Holmes wrote:
I've not waded through the make output yet, so I don't know exactly
what happens during it. It's only 36,000 lines long, so barely a
challenge. I do know that some of the python scripts are put into
the build tree by linking to the
On 6/15/11 7:14 AM, James Lowe james.l...@datacore.com wrote:
Carl,
)-Original Message-
)From: Carl Sorensen [mailto:c_soren...@byu.edu]
)Sent: 15 June 2011 14:04
)To: James Lowe; Francisco Vila
)Cc: LilyPond-Devel list
)Subject: Re: 2.14.1 released; attention span over
On Wed, Jun 15, 2011 at 12:44:49PM +0100, Graham Percival wrote:
On Wed, Jun 15, 2011 at 08:23:00AM +0100, Trevor Daniels wrote:
I'm not convinced we need a Frog Meister. Anyone capable
of developing a patch to LilyPond code is capable of uploading
it to Reitveld. Any help required could
Original Message -
From: Graham Percival gra...@percival-music.ca
To: James Lowe james.l...@datacore.com
Cc: Carl Sorensen c_soren...@byu.edu; Francisco Vila
paconet@gmail.com; LilyPond-Devel list lilypond-devel@gnu.org;
Phil Holmes em...@philholmes.net
Sent: Wednesday, June 15,
2011/6/15 percival.music...@gmail.com:
I've pushed a modified version of this.
wOOt!
YEEHAW!
Hooray!
Given the confusion about our C++ style, I removed a few changes which
were probably good. In some places I added an extra (pointless) space;
in other places I changed a tab character to a
On Wed, Jun 15, 2011 at 02:19:23PM +0100, Phil Holmes wrote:
The attached patch reduces the output from make doc slightly and
produces some new log files instead. Graham - could you push,
please? (I have done at least one make doc using it, with no
problems).
Are you sure that it creates
On 6/15/11 5:44 AM, Graham Percival gra...@percival-music.ca wrote:
Perfect example: two weeks ago, issue 1630 chord autosplit was
almost finished (it only needed a few minor code formatting). But
then it stalled until I suggested to Janek that he should get in
touch with Karin 2 days ago.
Minor nit-pick? The doc build generates the following:
tab-example.ly:42:26: warning: ignoring too many clashing note columns
gis\4 d'\3 fis\2 2
--
Phil Holmes
Bug Squad
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 6/13/11 1:17 PM, Janek Warchoł lemniskata.bernoull...@gmail.com
wrote:
Bad news: it doesn't work (the flags are squashed) - i have no idea
why... Maybe i forgot to make clean when i tested it before, but i'm
almost sure i didn't. Still, this looks like the only possible
explanation.
Mike
On 6/15/11 7:35 AM, Phil Holmes m...@philholmes.net wrote:
Minor nit-pick? The doc build generates the following:
tab-example.ly:42:26: warning: ignoring too many clashing note columns
gis\4 d'\3 fis\2 2
Thanks, Phil. This is more than a minor nit pick. This is a bug.
The \voiceOne
On Wed, Jun 15, 2011 at 02:35:49PM +0100, Phil Holmes wrote:
Minor nit-pick? The doc build generates the following:
tab-example.ly:42:26: warning: ignoring too many clashing note columns
gis\4 d'\3 fis\2 2
I vaguely recall discussing this (or something similar to it)
while at anime club
On 15 June 2011 15:11, Carl Sorensen c_soren...@byu.edu wrote:
I'll see if I can get the bug down to a tiny example.
It's issue 630 again, which is a long-standing regression (see
property-grace-polyphony.ly).
Cheers,
Neil
___
lilypond-devel mailing
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Wednesday, June 15, 2011 2:42 PM
Subject: Re: Patch: small reduction in output from make doc
On Wed, Jun 15, 2011 at 02:19:23PM +0100, Phil Holmes
On Wed, Jun 15, 2011 at 03:22:14PM +0100, Phil Holmes wrote:
- Original Message - From: Graham Percival
gra...@percival-music.ca
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Wednesday, June 15, 2011 2:42 PM
Subject: Re: Patch: small reduction in output from
- Original Message -
From: Neil Puttock n.putt...@gmail.com
To: Carl Sorensen c_soren...@byu.edu
Cc: Phil Holmes m...@philholmes.net; lilypond-devel@gnu.org
Sent: Wednesday, June 15, 2011 4:14 PM
Subject: Re: Doc: clashing note columns in example
On 15 June 2011 15:11, Carl Sorensen
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Wednesday, June 15, 2011 3:35 PM
Subject: Re: Patch: small reduction in output from make doc
On Wed, Jun 15, 2011 at 03:22:14PM +0100, Phil Holmes
Am Mittwoch, 15. Juni 2011, 16:22:14 schrieb Phil Holmes:
It creates new logfiles, since there is no existing logfile. It uses the
name of the .ly file to generate the logfile name. So - there is a file
called key-initial.ly. Part of the build process calls lily to process
that, and since
I've moved all contributors' names from the current section to
the previous section. I added a few names I saw in the git
changelog as coming after release/2.15.0. We'll continue to add
names to the current section as patches get accepted to git
master.
Note that right now, there are no new
If you run:
make -s output.txt
You only get error information at the terminal, and the text in the text
file is only program information, not the make commands. I've just done
this, and towards the start of the make I see on the terminal:
langdefs.py: warning: lilypond-doc gettext domain
- Original Message -
From: Reinhold Kainhofer reinh...@kainhofer.com
To: lilypond-devel@gnu.org
Sent: Wednesday, June 15, 2011 5:02 PM
Subject: Re: Patch: small reduction in output from make doc
Am Mittwoch, 15. Juni 2011, 16:22:14 schrieb Phil Holmes:
21 sends error and normal
Hello,
I say 'odd' it's that while I don't sit and stare at the terminal while it
compiles the doc (well sometimes I do) I have not noticed this message - that
fills up the screen for a minute before carrying on as normal
Error: Illegal entry in bfrange block in ToUnicode CMap
Error: Illegal
On Wed, Jun 15, 2011 at 06:02:54PM +0200, Reinhold Kainhofer wrote:
Am Mittwoch, 15. Juni 2011, 16:22:14 schrieb Phil Holmes:
to the end of the call. redirects output. $*.log expands to
filename.log (in this case key-initial.log - this expansion is a make
feature). 21 sends error and
Question for GP really, but on the list for others to chime in as needed.
In the CG:
http://lilypond.org/doc/v2.13/Documentation/contributor/useful-make-variables
we already have a way of quietening the output. This is used in particular
in make with the font files and would, I think, reduce
http://codereview.appspot.com/4601060
Have at it!
James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Wed, Jun 15, 2011 at 05:03:14PM +, James Lowe wrote:
I say 'odd' it's that while I don't sit and stare at the terminal while it
compiles the doc (well sometimes I do) I have not noticed this message - that
fills up the screen for a minute before carrying on as normal
Error: Illegal
Phil Holmes mail at philholmes.net writes:
Question for GP really, but on the list for others to chime in as needed.
In the CG:
http://lilypond.org/doc/v2.13/Documentation/contributor/useful-make-variables
we already have a way of quietening the output. This is used in particular
in
- Original Message -
From: James Lowe james.l...@datacore.com
To: LilyPond-Devel list lilypond-devel@gnu.org
Sent: Wednesday, June 15, 2011 6:03 PM
Subject: Odd message during doc build
Hello,
I say 'odd' it's that while I don't sit and stare at the terminal while it
compiles the
On 15 June 2011 16:36, Phil Holmes m...@philholmes.net wrote:
Strikes me we shouldn't be having examples in the documentation that throw
errors in the compilation, though?
Ideally, no. Carl's suggested workaround looks fine.
Cheers,
Neil
___
LGTM.
http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc
File lily/spanner.cc (right):
http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode243
lily/spanner.cc:243:
whitespace
http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode249
lily/spanner.cc:249:
Reviewers: ,
Message:
This should improve the appearance of ties in split chords.
Description:
Add ties from Completion_note_heads_engraver to a TieColumn.
* lily/completion-note-heads-engraver.cc (process_music):
if note splitting causes creation of ties, also create a TieColumn and
add
- Original Message -
From: Phil Holmes m...@philholmes.net
To: Reinhold Kainhofer reinh...@kainhofer.com; lilypond-devel@gnu.org
Sent: Wednesday, June 15, 2011 5:51 PM
Subject: Re: Patch: small reduction in output from make doc
- Original Message -
From: Reinhold Kainhofer
2011/6/15 Graham Percival gra...@percival-music.ca:
On Wed, Jun 15, 2011 at 06:02:54PM +0200, Reinhold Kainhofer wrote:
Hiding all error messages together with the progress messages is throwing out
the baby with the bath water (as we say here in German).
Exactly the same phrase in English!
http://codereview.appspot.com/4605047/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4605047/diff/1/lily/beam.cc#newcode564
lily/beam.cc:564: + last_normal_stem (me)-extent (commonx,
X_AXIS).length ();
needs parentheses to keep indentation
On 14 June 2011 19:40, m...@apollinemike.com m...@apollinemike.com wrote:
I see that the line-spanner print function looks for something that is called
anchor-alignment (git blame insinuates that it was Joe who added this). This
alignment, so far as I can see, is used nowhere in the code
Reviewers: ,
Message:
This fixes issue #1696, ensuring breathing signs are always positioned
on extremal staff lines.
Description:
Fix breathing sign Y-offset when using line-positions.
* input/regression/breathing-sign-custom-staff.ly
new regtest
* lily/breathing-sign.cc
Reviewers: ,
Message:
Prompted by this thread on lilypond-user-fr:
http://lists.gnu.org/archive/html/lilypond-user-fr/2011-06/msg00048.html
Currently, the following code will fail with a syntax error, unless the
markup is recoded in scheme:
\version 2.15.2
\relative c' {
c1
}
\addlyrics {
On 11-06-15 01:13 PM, Colin Campbell wrote:
Phil Holmesmailat philholmes.net writes:
Question for GP really, but on the list for others to chime in as needed.
In the CG:
http://lilypond.org/doc/v2.13/Documentation/contributor/useful-make-variables
we already have a way of quietening the
84 matches
Mail list logo
