On Jul 18, 2011, at 11:00 AM, Bertrand Bordage wrote:
Thanks Dmytro !
I looked at what Mike said.
Could not there be more code in common between ties and slurs?
A tie isn't so different from a slur, is it ?
By doing so, we could get rid of TieColumn and many bugs.
[moving to devel]
I was referring to issues 1606, 590, 582, 570, 480, 409, 397.
These could be fixed with a Tie_collision_engraver.
I would like to try to implement this engraver if you are disposed to help
me.
Regards,
Bertrand
___
lilypond-devel mailing list
On Jul 18, 2011, at 11:43 AM, Bertrand Bordage wrote:
I was referring to issues 1606,
This should be fixed in the beam-collision-engraver such that it avoids ties.
A simple implementation would avoid the rectangular bounding box around tie,
whereas a more robust implementation would use the
Reviewers: ,
Message:
This fixes issue 1768.
Description:
Fixes note column skylines by adding stem tremolo to axis group.
Please review this at http://codereview.appspot.com/4754054/
Affected files:
A input/regression/stem-tremolo-note-column.ly
M lily/include/note-column.hh
M
On 2011/07/18 00:53:01, hanwenn wrote:
LGTM
There is some code that adjusts for the shape of the notehead as well
(look for
calls to
Note_head::stem_attachment_coordinate). Can you have a look if you can
work that
into your code too?
Done. New patch set uploaded.
2011/7/18 Joe Neeman joenee...@gmail.com:
2011/7/17 Janek Warchoł lemniskata.bernoull...@gmail.com:
I've searched in note-head.cc, note-column.cc, note-heads-engraver.cc
but found nothing...
I believe it defaults to ly:grob::stencil-width (probably in grob.cc).
2011/7/17 Neil Puttock
My review will be a bit non-standard (as i'm still a rookie
programmer): i understand what's going on here, so it's probably good :)
http://codereview.appspot.com/4752048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
2011/7/18 Janek Warchoł lemniskata.bernoull...@gmail.com:
i don't see anything called stencil-width in grob.cc...
78 if (get_property_data (X-extent) == SCM_EOL)
79 set_property (X-extent, Grob::stencil_width_proc);
The C++ name is Grob::stencil_width; the addition of _proc uses the
On Jul 18, 2011, at 8:00 PM, Janek Warchoł wrote:
2011/7/18 Joe Neeman joenee...@gmail.com:
2011/7/17 Janek Warchoł lemniskata.bernoull...@gmail.com:
I've searched in note-head.cc, note-column.cc, note-heads-engraver.cc
but found nothing...
I believe it defaults to ly:grob::stencil-width
Hi Mike,
I think this is too complicated; you can probably achieve the same
result via a Stem_tremolo::pure_height function.
Cheers,
Neil
http://codereview.appspot.com/4754054/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2011/07/18 19:24:26, Neil Puttock wrote:
Hi Mike,
I think this is too complicated; you can probably achieve the same
result via a
Stem_tremolo::pure_height function.
Cheers,
Neil
Thanks for the feedback!
How would pure height affect the calculation of horizontal skylines?
The issue
2011/7/18 Neil Puttock n.putt...@gmail.com:
No, the problem is that the code doesn't account for differences in
font-size between heads; all the hard-coded shifts it calculates
(split equally between heads; heads move away from each other by the
same amount) are based on the assumption that
On 2011/07/18 19:28:51, MikeSol wrote:
How would pure height affect the calculation of horizontal skylines?
It should ensure the skylines are correct, assuming there's an entry for
Stem_tremolo::height in pure-conversions-alist.
It looks like the existing height function is pure since it
On 2011/07/18 19:47:53, Neil Puttock wrote:
On 2011/07/18 19:28:51, MikeSol wrote:
How would pure height affect the calculation of horizontal skylines?
It should ensure the skylines are correct, assuming there's an entry
for
Stem_tremolo::height in pure-conversions-alist.
It looks
Hi,
My friend and I, having some spare time, wanted to fix a bug
http://code.google.com/p/lilypond/issues/detail?id=1301. It's related
to planning distribution of music notes and other signs, so we need
some overview how the whole process works. Comments in the source
code are rare and in the
Make works fine but I get a seg fault when I do a make check after a
test-baseline for the reg test comparison.
http://codereview.appspot.com/4754054/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Hello, can someone else verify?
I get a make fail:
--snip--
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm]
Writing internals.texi...ERROR: In procedure procedure-name:
ERROR: Wrong type argument in position 1: #f
make[1]: *** [out/internals.texi] Error 1
rm
http://codereview.appspot.com/4693043/diff/1/lily/system-start-delimiter.cc
File lily/system-start-delimiter.cc (right):
http://codereview.appspot.com/4693043/diff/1/lily/system-start-delimiter.cc#newcode117
lily/system-start-delimiter.cc:117: staffspace =
Staff_symbol_referencer::staff_space
Thanks for the input, I have some questions about three of the
corrections/suggestions.
http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
On 2011/07/18 20:01:00, J_lowe wrote:
Make works fine but I get a seg fault when I do a make check after a
test-baseline for the reg test comparison.
Same here. stem-tremolo.ly segfaults inside rhythmic-column.cc; the
acknowledged StemTremolo doesn't have an X-parent.
On 18 July 2011 22:00, pkx1...@gmail.com wrote:
Ok I tried
\relative c' {
c \footnoteGrob #'NoteHead #'(2 . 4) \markup \box a a. E flat es
1 } for myself and it works but I get two indicators and two footnotes
on each note inside the chord. So is this a special case? If so then I
can
Hi Mike,
This looks fine apart from the following change:
\relative c'' {
\voiceTwo
\times 2/3 { r r r }
}
- bracket still above stave
The simplest fix is probably to add TupletBracket to
direction-polyphonic-grobs.
Cheers,
Neil
http://codereview.appspot.com/4668045/
2011/7/18 pkx1...@gmail.com:
Hello, can someone else verify?
I get a make fail:
I get it too... Strange, it compiled some time ago.
Btw,
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm]
Writing internals.texi...ERROR: In procedure procedure-name:
ERROR:
2011/7/18 Janek Warchoł lemniskata.bernoull...@gmail.com:
Btw,
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm]
Writing internals.texi...ERROR: In procedure procedure-name:
ERROR: Wrong type argument in position 1: #f
make[1]: *** [out/internals.texi]
2011/7/18 Janek Warchoł lemniskata.bernoull...@gmail.com:
My friend and I, having some spare time, wanted to fix a bug
http://code.google.com/p/lilypond/issues/detail?id=1301. It's related
to planning distribution of music notes and other signs, so we need
some overview how the whole process
2011/7/18 Neil Puttock n.putt...@gmail.com:
2011/7/18 Janek Warchoł lemniskata.bernoull...@gmail.com:
Btw,
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm]
Writing internals.texi...ERROR: In procedure procedure-name:
ERROR: Wrong type argument in position
Reviewers: ,
Message:
here's a series of patches for the C++ formatting.
- final (?) set of changes to fixcc.py
- changes to CG
Description:
CG: describe new C++ formatting (GOP-PROP 3)
Adapt fixcc.py to use Astyle
Please review this at http://codereview.appspot.com/4760056/
Affected files:
2011/7/18 Janek Warchoł lemniskata.bernoull...@gmail.com:
My friend and I, having some spare time, wanted to fix a bug
http://code.google.com/p/lilypond/issues/detail?id=1301. It's related
to planning distribution of music notes and other signs, so we need
some overview how the whole process
New today, for 21:00 MST Wednesday July 20 (Where were you 42 years ago
that day?)
Issue 1678
http://code.google.com/p/lilypond/issues/detail?id=1678: Midi gives
false warnings - Rietveld issue4757043
http://codereview.appspot.com/4757043/: MIDI: reset channel counters
when done
On 7/18/11 8:44 PM, Colin Campbell c...@shaw.ca wrote:
New today, for 21:00 MST Wednesday July 20 (Where were you 42 years ago
that day?)
I was watching Neil Armstrong step on the moon in my living room, IIRC.
Issue 1752 http://code.google.com/p/lilypond/issues/detail?id=1752 :
On 7/18/11 8:44 PM, Colin Campbell c...@shaw.ca wrote:
Countdown done, but still open/not fixed:
21:00 MST Monday July 18
Issue 1695 http://code.google.com/p/lilypond/issues/detail?id=1695 :
Clef change placed outside score - Rietveld - 4683043
On Mon, Jul 18, 2011 at 08:44:13PM -0600, Colin Campbell wrote:
Countdown done, but still open/not fixed:
All those should be marked patch-needs_work. When a new version
of the patch is available, James will check that it passes the
regtests, and then they are simply patch-review items. They
On 7/18/11 9:48 PM, Graham Percival gra...@percival-music.ca wrote:
On Mon, Jul 18, 2011 at 08:44:13PM -0600, Colin Campbell wrote:
Countdown done, but still open/not fixed:
All those should be marked patch-needs_work. When a new version
of the patch is available, James will check that
33 matches
Mail list logo
