Re: Patchy email

2012-01-01 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: On Sat, Dec 31, 2011 at 11:27:38AM +0100, David Kastrup wrote: My guess is that two incantations of Patchy were at work here, and one of them copied a tested staging to master while the other one was still working with older material. There's

Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2012-01-01 Thread dak
Reviewers: lemzwerg, Keith, carl.d.sorensen_gmail.com, Message: On 2012/01/01 02:01:11, Keith wrote: Works nicely. Showing the input location will probably be very helpful. We probably want to remove the similar message from lily/misc.cc, because both message together are very noisy.

Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2012-01-01 Thread dak
http://codereview.appspot.com/5505090/diff/1/lily/lexer.ll File lily/lexer.ll (right): http://codereview.appspot.com/5505090/diff/1/lily/lexer.ll#newcode134 lily/lexer.ll:134: A[a-zA-Z\200-\377] On 2012/01/01 02:01:11, Keith wrote: non-ASCII characters are used internally as-read,

Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2012-01-01 Thread Keith OHara
On Sun, 01 Jan 2012 01:40:36 -0800, d...@gnu.org wrote: Our lexer has been written with the decision of using non-compressed tables and without backing up. Off topic, but maybe interesting to you: I don't think that decision was ever implemented. I don't see any %option full or similar that

Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2012-01-01 Thread dak
On 2012/01/01 10:05:42, Keith wrote: On Sun, 01 Jan 2012 01:40:36 -0800, mailto:d...@gnu.org wrote: Our lexer has been written with the decision of using non-compressed tables and without backing up. Off topic, but maybe interesting to you: I don't think that decision was ever

Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2012-01-01 Thread Keith OHara
On Sun, 01 Jan 2012 01:56:04 -0800, d...@gnu.org wrote: http://codereview.appspot.com/5505090/diff/1/lily/lexer.ll#newcode134 lily/lexer.ll:134: A[a-zA-Z\200-\377] On 2012/01/01 02:01:11, Keith wrote: non-ASCII characters are used internally as-read, tested below only to warn the

Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2012-01-01 Thread dak
On 2012/01/01 10:16:47, Keith wrote: On Sun, 01 Jan 2012 01:56:04 -0800, mailto:d...@gnu.org wrote: http://codereview.appspot.com/5505090/diff/1/lily/lexer.ll#newcode1083 lily/lexer.ll:1083: LexerWarning (_ (non-UTF-8 characters).c_str ()); On 2012/01/01 02:01:11, Keith wrote: I

Re: Web: Added 'Ripple' to easier-editing section (issue 5507044)

2012-01-01 Thread pkx166h
Reviewers: Graham Percival, Message: Sun, 1 Jan 2012 11:28:21 + (11:28 +) commit 99ff3c45ac880bc5ba46859ef8206d95a3c6521b James Description: Web: Added 'Ripple' to easier-editing section Also re-ordered existing listings for this section only in alphabetical order. Please

Re: Doc: NR added @knownissue for beam properties (issue 5504100)

2012-01-01 Thread pkx166h
Reviewers: carl.d.sorensen_gmail.com, Keith, Message: On 2012/01/01 03:08:19, Carl wrote: http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right):

Re: Segfault 2.15.23 Span_bar_stub_engraver

2012-01-01 Thread m...@apollinemike.com
On Jan 1, 2012, at 6:16 AM, Jay Anderson wrote: On Sat, Dec 31, 2011 at 6:47 PM, m...@apollinemike.com m...@apollinemike.com wrote: I wrote that engraver - could you send me the full file? I'll try to find the source of the bug...

Doc: LM adjusted explanation for \once (issue 5489129)

2012-01-01 Thread janek . lilypond
generally LGTM http://codereview.appspot.com/5489129/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/5489129/diff/1/Documentation/learning/tweaks.itely#newcode284 Documentation/learning/tweaks.itely:284: moment before

Build commits

2012-01-01 Thread Phil Holmes
Julien, If you look at http://code.google.com/p/lilypond/issues/detail?id=2156 you'll see there were problems with some commits leading up to December 23rd. As a result, a number weren't forwarded to master and staging was recreated. This left 3 of your commits unpushed. Please see that

Re: Hiding old website /web/install page (issue 5500069)

2012-01-01 Thread hashashin
On 2011/12/27 19:41:05, ambs wrote: github pull request sent. will work next in the copy procedure. Check http://codereview.appspot.com/5507046/edit for continuation on this. http://codereview.appspot.com/5500069/ ___ lilypond-devel mailing list

Re: Hiding old website /web/install page (issue 5500069)

2012-01-01 Thread hashashin
On 2012/01/01 14:52:11, ambs wrote: On 2011/12/27 19:41:05, ambs wrote: github pull request sent. will work next in the copy procedure. Check http://codereview.appspot.com/5507046/edit for continuation on this. http://codereview.appspot.com/5507046/ ... :)

Re: Doc: NR added @knownissue for beam properties (issue 5504100)

2012-01-01 Thread Carl . D . Sorensen
Can we show this using a single voice with non-chorded notes and by using something more 'obvious' than \hideNotes? Override the beam color to red? http://codereview.appspot.com/5504100/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Hiding old website /web/install page (issue 5500069)

2012-01-01 Thread hashashin
After that code merge (hope it has the needed quality) you need to think what to do regarding RSS and web/ links on 'old-news' page. Also, note that documentation is using the web/../languagedetection application. http://codereview.appspot.com/5500069/

And another dark corner...

2012-01-01 Thread David Kastrup
lexer.ll: lyric_fudge (string s) { char *chars = string_copy (s); for (char *p = chars; *p ; p++) { if (*p == '_' (p == chars || *(p-1) != '\\')) *p = ' '; } s = string (chars); delete[] chars; ssize i = 0; if ((i = s.find (\\,)) != NPOS) // change \,

Re: Doc: NR added @knownissue for beam properties (issue 5504100)

2012-01-01 Thread dak
On 2012/01/01 14:56:25, Carl wrote: Can we show this using a single voice with non-chorded notes and by using something more 'obvious' than \hideNotes? Override the beam color to red? Also \once\hideNotes might be a bit more snappy. http://codereview.appspot.com/5504100/

What's the deal with the LSR update?

2012-01-01 Thread David Kastrup
A number of files have been reverted to old syntax in the recent commit df2ed631752793f755c92b85640341d06ece7b0c Author: Phil Holmes m...@philholmes.net Date: Sun Jan 1 15:19:00 2012 + Updates to LSR Checked carefully and all OK, so pushed to staging. make, make doc OK.

Re: Doc: LM adjusted explanation for \once (issue 5489129)

2012-01-01 Thread pkx166h
Reviewers: janek, Message: Thanks Janek. http://codereview.appspot.com/5489129/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/5489129/diff/1/Documentation/learning/tweaks.itely#newcode284

Re: What's the deal with the LSR update?

2012-01-01 Thread David Kastrup
David Kastrup d...@gnu.org writes: A number of files have been reverted to old syntax in the recent commit df2ed631752793f755c92b85640341d06ece7b0c Author: Phil Holmes m...@philholmes.net Date: Sun Jan 1 15:19:00 2012 + Updates to LSR Checked carefully and all OK, so

Re: What's the deal with the LSR update?

2012-01-01 Thread Phil Holmes
It's a consequence of running makelsr.py on the download from the Lilypond Snippet Repository. AFAI understand it, makelsr runs convert-ly against each file and so should update the syntax where the update is in convert-ly. After running the update, make and make doc compiled clean, so there

Re: What's the deal with the LSR update?

2012-01-01 Thread Phil Holmes
Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, January 01, 2012 5:31 PM Subject: Re: What's the deal with the LSR update? David Kastrup d...@gnu.org writes: A number of files have been reverted to old syntax in the recent commit

Re: What's the deal with the LSR update?

2012-01-01 Thread David Kastrup
Phil Holmes m...@philholmes.net writes: It's a consequence of running makelsr.py on the download from the Lilypond Snippet Repository. AFAI understand it, makelsr runs convert-ly against each file and so should update the syntax where the update is in convert-ly. It isn't because it merely

Re: What's the deal with the LSR update?

2012-01-01 Thread Phil Holmes
- Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, January 01, 2012 5:31 PM Subject: Re: What's the deal with the LSR update? David Kastrup d...@gnu.org writes: A number of files have been reverted to old syntax in the recent commit

Re: What's the deal with the LSR update?

2012-01-01 Thread David Kastrup
Phil Holmes m...@philholmes.net writes: Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, January 01, 2012 5:31 PM Subject: Re: What's the deal with the LSR update? And what's this? make [...] lys-to-tely: writing out/rhythms.itely...

Patchy email

2012-01-01 Thread lilypond . patchy . graham
Begin LilyPond compile, commit: 2f25894efd8ad242b233d5a1d07afcfa087ebab2 Merged staging, now at: a14c8e86aa0a5e438d6b7a296617bb18ac08b5fb Success:./autogen.sh --noconfigure Success:../configure --disable-optimising *** FAILED BUILD ***

Re: What's the deal with the LSR update?

2012-01-01 Thread Phil Holmes
- Original Message - From: David Kastrup d...@gnu.org To: Phil Holmes m...@philholmes.net Cc: lilypond-devel@gnu.org Sent: Sunday, January 01, 2012 6:00 PM Subject: Re: What's the deal with the LSR update? Phil Holmes m...@philholmes.net writes: Original Message - From: David

Re: What's the deal with the LSR update?

2012-01-01 Thread David Kastrup
Phil Holmes m...@philholmes.net writes: git grep automatically-change-duration Documentation/snippets/rhythms.snippet-list:automatically-change-durations.ly dak@lola:/usr/local/tmp/lilypond$ find -name automatically-change-duration.ly dak@lola:/usr/local/tmp/lilypond$ Looks like that was

Re: What's the deal with the LSR update?

2012-01-01 Thread David Kastrup
David Kastrup d...@gnu.org writes: Phil Holmes m...@philholmes.net writes: git grep automatically-change-duration Documentation/snippets/rhythms.snippet-list:automatically-change-durations.ly dak@lola:/usr/local/tmp/lilypond$ find -name automatically-change-duration.ly

Re: What's the deal with the LSR update?

2012-01-01 Thread Neil Puttock
On 1 January 2012 19:37, David Kastrup d...@gnu.org wrote: Done, so let's see if this gets through to master, and if it does, you might want to try the LSR updating procedure again. You need to remove the comment block at the top, the texidoc translations and `% begin verbatim' comments.

Re: What's the deal with the LSR update?

2012-01-01 Thread David Kastrup
Neil Puttock n.putt...@gmail.com writes: On 1 January 2012 19:37, David Kastrup d...@gnu.org wrote: Done, so let's see if this gets through to master, and if it does, you might want to try the LSR updating procedure again. You need to remove the comment block at the top, the texidoc

Re: What's the deal with the LSR update?

2012-01-01 Thread David Kastrup
David Kastrup d...@gnu.org writes: Neil Puttock n.putt...@gmail.com writes: On 1 January 2012 19:37, David Kastrup d...@gnu.org wrote: Done, so let's see if this gets through to master, and if it does, you might want to try the LSR updating procedure again. You need to remove the comment

Re: What's the deal with the LSR update?

2012-01-01 Thread Graham Percival
On Sun, Jan 01, 2012 at 06:10:00PM -, Phil Holmes wrote: This is a live and learn. I typically don't add untracked files to patches, because there are loads of them - git-cl; the aborted_edits from lily-git, etc., etc. I'd not realised that updates from the LSR could also add files and

Re: What's the deal with the LSR update?

2012-01-01 Thread Graham Percival
On Sun, Jan 01, 2012 at 06:50:33PM +0100, David Kastrup wrote: obviously I have been too clever about this change done automatically and half-reverted. I did not commit the convert-ly rule since it was somewhat fishy IIRC and while it worked, I checked the results manually. I probably

GUB Build Success!

2012-01-01 Thread Carl Sorensen
I have successfully built lilypond with GUB on Ubuntu 10.04 LTS. I have the following files in the uploads directories: carl@carl-MacBookPro:~/src/gub$ ls uploads lilypond-2.15.24-1.darwin-ppc.tar.bz2 lilypond-2.15.24-1.darwin-x86.tar.bz2 lilypond-2.15.24-1.documentation.tar.bz2

Re: What's the deal with the LSR update?

2012-01-01 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: On Sun, Jan 01, 2012 at 06:50:33PM +0100, David Kastrup wrote: obviously I have been too clever about this change done automatically and half-reverted. I did not commit the convert-ly rule since it was somewhat fishy IIRC and while it worked,

Re: Doc: NR added @knownissue for beam properties (issue 5504100)

2012-01-01 Thread k-ohara5a5a
On 2012/01/01 15:06:05, dak wrote: On 2012/01/01 14:56:25, Carl wrote: Can we show this using a single voice with non-chorded notes and by using something more 'obvious' than \hideNotes? \relative c' { \voiceTwoStyle c8 e \voiceNeutralStyle g c \voiceTwoStyle c8 e

Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2012-01-01 Thread k-ohara5a5a
On 2012/01/01 10:12:27, dak wrote: Consider a comment in your case/switch statement that points to some reference on the various types of UTF-8 validators. I don't understand. Sorry, I wasn't making much sense. As a reader I want to *recognize* what the but switch/case is doing rather

Re: GUB Build Success!

2012-01-01 Thread Graham Percival
On Sun, Jan 01, 2012 at 08:43:05PM +, Carl Sorensen wrote: I have made one change to the spec files (the location of netpm on lilypond.org has changed), and I did a couple of manual downloads, so I'm not sure yet that GUB is ready to build out-of-the-box. But I have demonstrated that I

Re: What's the deal with the LSR update?

2012-01-01 Thread Graham Percival
On Sun, Jan 01, 2012 at 09:49:33PM +0100, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: 2) make the changes manually, then put those updated files in Documentation/snippets/new Whichever way you choose, I would like to see a local makelsr.py update after

Re: Doc: NR added @knownissue for beam properties (issue 5504100)

2012-01-01 Thread pkx166h
On 2012/01/01 21:31:50, Keith wrote: On 2012/01/01 15:06:05, dak wrote: On 2012/01/01 14:56:25, Carl wrote: Can we show this using a single voice with non-chorded notes and by using something more 'obvious' than \hideNotes? \relative c' { \voiceTwoStyle c8 e \voiceNeutralStyle

Re: Doc: NR added @knownissue for beam properties (issue 5504100)

2012-01-01 Thread pkx166h
See comments below, thanks. http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely#newcode1953

Re: GUB Build Success!

2012-01-01 Thread Colin Campbell
On 12-01-01 03:17 PM, Graham Percival wrote: On Sun, Jan 01, 2012 at 08:43:05PM +, Carl Sorensen wrote: I have made one change to the spec files (the location of netpm on lilypond.org has changed), and I did a couple of manual downloads, so I'm not sure yet that GUB is ready to build

Copy pdf docs to new website folder (issue 5507046)

2012-01-01 Thread graham
LGTM, but I had to add issue 2166 to track this. http://codereview.appspot.com/5507046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR added @knownissue for beam properties (issue 5504100)

2012-01-01 Thread Keith OHara
On Sun, 01 Jan 2012 14:33:33 -0800, pkx1...@gmail.com wrote: I disagree. The example in the tracker is overly complicated for what (I still maintain) is easily explained. However *if* we really do need an example then the \hideNotes one is not ideal. I struggled myself with that one in the

PATCH: Countdown to 20120103

2012-01-01 Thread Colin Campbell
For 20:00 MST Tuesday January 3rd, 2012 Documentation: Issue 2164 http://code.google.com/p/lilypond/issues/detail?id=2164: Learning Manual: Better explanation with updated example for \once tweak - R 5489129 http://codereview.appspot.com/5489129/ Issue 2152