Re: Completion_*_engraver: add means to preserve scale factor; issue 3650 (issue 35370043)

2013-12-01 Thread benko . pal
LSTGM https://codereview.appspot.com/35370043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Reduce offsets of \super and \sub (issue 35320043)

2013-12-01 Thread Keith OHara
On Sat, 30 Nov 2013 23:56:09 -0800, janek.lilyp...@gmail.com wrote: I have one request: this patch makes the situation better, and even if the baseline-skip approach is wrong, it was already used that way so it's not making things worse. I suggest to push this patch, and then work on making

Re: Reduce offsets of \super and \sub (issue 35320043)

2013-12-01 Thread dak
On 2013/12/01 09:16:14, Keith wrote: On Sat, 30 Nov 2013 23:56:09 -0800, mailto:janek.lilyp...@gmail.com wrote: I have one request: this patch makes the situation better, and even if the baseline-skip approach is wrong, it was already used that way so it's not making things worse. I

PATCHES: Countdown for December 4th - 06:00 GMT

2013-12-01 Thread James
Hello, *Countdown – December 4th – 06:00 GMT*

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread Phil Holmes
- Original Message - From: Werner LEMBERG w...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, December 01, 2013 6:42 AM Subject: tag for 2.17.96 is missing in git Please add a tag for the 2.17.96 release! That's strange - I did the release as close to the standard way as I

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread Janek Warchoł
2013/12/1 Phil Holmes m...@philholmes.net: - Original Message - From: Werner LEMBERG w...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, December 01, 2013 6:42 AM Subject: tag for 2.17.96 is missing in git Please add a tag for the 2.17.96 release! That's strange - I did the

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread Janek Warchoł
2013/12/1 Janek Warchoł janek.lilyp...@gmail.com: 2013/12/1 Phil Holmes m...@philholmes.net: - Original Message - From: Werner LEMBERG w...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, December 01, 2013 6:42 AM Subject: tag for 2.17.96 is missing in git Please add a tag for the

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread David Kastrup
Janek Warchoł janek.lilyp...@gmail.com writes: 2013/12/1 Janek Warchoł janek.lilyp...@gmail.com: 2013/12/1 Phil Holmes m...@philholmes.net: - Original Message - From: Werner LEMBERG w...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, December 01, 2013 6:42 AM Subject: tag for

hairpin: start at left edge of a rest (issue 34870044)

2013-12-01 Thread janek . lilypond
LGTM https://codereview.appspot.com/34870044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Changes.tely 2.18 release (issue 24180044)

2013-12-01 Thread janek . lilypond
LGTM thanks, James! https://codereview.appspot.com/24180044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

small padding adjustment; issue 3630 (issue 34910044)

2013-12-01 Thread janek . lilypond
LGTM! https://codereview.appspot.com/34910044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Rewrite the autobeam logic to use GUILE fractions rather than moments (issue 33930043)

2013-12-01 Thread janek . lilypond
LGTM (just a quick look) https://codereview.appspot.com/33930043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: let RhythmicStaff use default barline extent (issue 35060046)

2013-12-01 Thread janek . lilypond
Reviewers: Keith, Message: On 2013/11/30 05:56:50, Keith wrote: Looks good. Repeat bars look fine (as they do in Drum Staff). The book by Kurt Stone happens to have some bar-lines in single-line percussion staves that are as tall as a 4/4 time-signature. Other examples in the same

Implement \beamExceptions function fishing exceptions from beamed music. (issue 34880043)

2013-12-01 Thread janek . lilypond
I very much like the simplification in the user interface! If i understand correctly, this function will overwrite beamExceptions with the pattern extracted from the music. Would it be possible to instead have a function \addBeamException that would take just one pattern and _add it_ to the

Re: Implement \beamExceptions function fishing exceptions from beamed music. (issue 34880043)

2013-12-01 Thread dak
Reviewers: janek, Graham Percival, Message: On 2013/12/01 12:32:34, janek wrote: I very much like the simplification in the user interface! If i understand correctly, this function will overwrite beamExceptions with the pattern extracted from the music. No. It converts the given music into

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread Werner LEMBERG
Forget that: it seems that the tag already exists, it's just not present on the master branch (because it's in the stable branch): 050744bbb706525840a3014cd72b06fde945fa4d OK. Yes, I have it here as well. Hmm. So why do we have commit 9918cd9f8d8f5461c6ad7e086fd93de59960eb95 Author:

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread Phil Holmes
- Original Message - From: Werner LEMBERG w...@gnu.org To: d...@gnu.org Cc: lilypond-devel@gnu.org Sent: Sunday, December 01, 2013 3:23 PM Subject: Re: tag for 2.17.96 is missing in git Forget that: it seems that the tag already exists, it's just not present on the master branch

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread Werner LEMBERG
Hmm. So why do we have commit 9918cd9f8d8f5461c6ad7e086fd93de59960eb95 Author: Phil Holmes m...@philholmes.net Date: Sun Nov 24 22:05:16 2013 + Release: bump VERSION. in the `master' branch? This looks incorrect to me, given that we currently derive 2.17.9X tarballs from

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread Phil Holmes
- Original Message - From: Werner LEMBERG w...@gnu.org To: m...@philholmes.net Cc: d...@gnu.org; lilypond-devel@gnu.org Sent: Sunday, December 01, 2013 3:53 PM Subject: Re: tag for 2.17.96 is missing in git Hmm. So why do we have commit 9918cd9f8d8f5461c6ad7e086fd93de59960eb95

Re: Reduce offsets of \super and \sub (issue 35320043)

2013-12-01 Thread k-ohara5a5a
On 2013/12/01 09:31:20, dak wrote: \fontsize does, but \small, \large, \huge, \super (!) all do an override to font-size which does _not_ affect baseline-skip in contrast to the markup command \fontsize changing everything in concert. We know that, David. See above were we considered It

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread Werner LEMBERG
the VERSION_DEVEL is only used for text entries on the website, I believe. Ah, OK. This was my missing link. Builds from stable/2.18 will be version 2.17.97. So I think it's right that the tag for 2.17.96 is also in stable/2.18? The tag for 2.17.96 should *only* be in 2.18 – it was my

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread David Kastrup
Werner LEMBERG w...@gnu.org writes: Forget that: it seems that the tag already exists, it's just not present on the master branch (because it's in the stable branch): 050744bbb706525840a3014cd72b06fde945fa4d OK. Yes, I have it here as well. Hmm. So why do we have commit

Re: tag for 2.17.96 is missing in git

2013-12-01 Thread David Kastrup
Werner LEMBERG w...@gnu.org writes: the VERSION_DEVEL is only used for text entries on the website, I believe. Ah, OK. This was my missing link. Builds from stable/2.18 will be version 2.17.97. So I think it's right that the tag for 2.17.96 is also in stable/2.18? The tag for 2.17.96