Re: Issue 5310: find_top_context () maintenance (issue 341150043 by nine.fierce.ball...@gmail.com)

2018-04-25 Thread nine . fierce . ballads
On 2018/04/25 10:44:22, dak wrote: Please note that all of your proposals so far do _not_ provide the nullness information that you value in any manner: previously undefined behavior would continue to be undefined behavior and would just look differently. Yes, but what I believe you are

Re: Issue 5309: Refactor Context::get_score_context () (issue 346750043 by nine.fierce.ball...@gmail.com)

2018-04-25 Thread nine . fierce . ballads
On 2018/04/21 18:40:18, Dan Eble wrote: This will deserve some revision based on questions to be answered in the review for issue 5310. https://codereview.appspot.com/346750043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-25 Thread Noeck
Hi Torsten, I've confidence in your algorithm. I just thought I post a situation which I would have neglected at first – without knowing what your algorithm does. Thanks for your explanation! It seems pretty robust and straightforward to me, now. Are the two algorithms the equivalent if you make

Re: Syntax: lyric_mode_music might be a MUSIC_FUNCTION (issue 343820043 by knup...@gmail.com)

2018-04-25 Thread David Kastrup
carl.d.soren...@gmail.com writes: > On 2018/04/25 12:22:18, knupero wrote: > > >> @Everyone: I won't bother you here any longer. > > Knut, > > It's not a bother. > > But it's important to recognize that the parser is a difficult system to > work with, and we've had lots of problems over the years

Re: Syntax: lyric_mode_music might be a MUSIC_FUNCTION (issue 343820043 by knup...@gmail.com)

2018-04-25 Thread Carl . D . Sorensen
On 2018/04/25 12:22:18, knupero wrote: @Everyone: I won't bother you here any longer. Knut, It's not a bother. But it's important to recognize that the parser is a difficult system to work with, and we've had lots of problems over the years with lookahead not being handled properly. So

Abc2Ly + D-sharp minor = problem

2018-04-25 Thread Андрей Ф .
Hello! The Abc2Ly converts file.abc with "K:D#m a b c" to "\key dis \minor aes'' bes'' ces'' "es" instead of "is". Lilypond 2.18.2 Other keys are OK. Please, fix this. Thank you! Andrey ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Syntax: lyric_mode_music might be a MUSIC_FUNCTION (issue 343820043 by knup...@gmail.com)

2018-04-25 Thread dak
On 2018/04/25 12:22:18, knupero wrote: > I don't see the point in starting a formal review after this has already been > discussed on the mailing list. I was hoping, apparently in vain, that the formal process would lead to a more reasonable discussion. You make it appear like

Re: Syntax: lyric_mode_music might be a MUSIC_FUNCTION (issue 343820043 by knup...@gmail.com)

2018-04-25 Thread knupero
I don't see the point in starting a formal review after this has already been discussed on the mailing list. I was hoping, apparently in vain, that the formal process would lead to a more reasonable discussion. Apparently, however, this process also invites speculation about the amount of

Re: Issue 5310: find_top_context () maintenance (issue 341150043 by nine.fierce.ball...@gmail.com)

2018-04-25 Thread dak
On 2018/04/23 23:55:44, Dan Eble wrote: David, would you accept a template class wrapping a non-null pointer, perhaps non_null_ptr? Conversion to a raw pointer would be implicit, but construction from a raw pointer would be explicit. The person constructing such a pointer is responsible

Re: Syntax: lyric_mode_music might be a MUSIC_FUNCTION (issue 343820043 by knup...@gmail.com)

2018-04-25 Thread dak
On 2018/04/25 08:36:05, dak wrote: We don't state "please don't use that syntax in the following way or LilyPond will be silently confused into producing nonsense" in other respects so it is irrelevant that LilyPond can parse _some_ input correctly with that change and will "only" get

Re: Syntax: lyric_mode_music might be a MUSIC_FUNCTION (issue 343820043 by knup...@gmail.com)

2018-04-25 Thread dak
On 2018/04/25 06:33:19, knupero wrote: Please test & review the proposed syntax change. I don't see the point in starting a formal review after this has already been discussed on the mailing list. In particular since this differs from your originally proposed patch (where you did not switch

Re: parser.yy / grammar

2018-04-25 Thread David Kastrup
Knut Petersen writes: > Am 24.04.2018 um 21:16 schrieb David Kastrup: >> >>> >>> \version "2.21.0" >>> >>> \score{ { c'2 } \addlyrics { Hi there } \layout >>> {}} >>> \score{ { c'2 } \addlyrics \displayLilyMusic { Hi there } \layout

Syntax: lyric_mode_music might be a MUSIC_FUNCTION (issue 343820043 by knup...@gmail.com)

2018-04-25 Thread knupero
Reviewers: , Message: Please test & review the proposed syntax change. Description: Syntax: lyric_mode_music might be a MUSIC_FUNCTION With this patch, all four scores in the lilypond source below use a valid syntax and produce correct output. Without this patch only the first two scores use