LGTM, thanks.
https://codereview.appspot.com/571250043/
See https://codereview.appspot.com/547340043/ .
Looks promising, thanks!
https://codereview.appspot.com/553290043/
One early comment :-)
https://codereview.appspot.com/547340043/diff/575390044/lily/break-alignment-interface.cc
File lily/break-alignment-interface.cc (right):
https://codereview.appspot.com/547340043/diff/575390044/lily/break-alignment-interface.cc#newcode328
On 2019/12/14 22:42:05, dak wrote:
A callback function, if necessary due to early evaluation otherwise, a
pure/unpure container ?
See https://codereview.appspot.com/547340043/ .
https://codereview.appspot.com/553290043/
See: https://sourceforge.net/p/testlilyissues/issues/1245/
This is the state of festival.
https://codereview.appspot.com/571250043/
Urs Liska writes:
> Any LilyPond dev who does have a Facebook account might have a look at
> this interesting, although somewhat sad, discussion. I think it gives
> a clear picture of how our current state of development is perceived
> by users:
>
>
nine.fierce.ball...@gmail.com writes:
> On 2019/12/14 16:47:15, Dan Eble wrote:
>> I think it would be better for a RehearsalMark to be center-aligned at
> a bar
>> line, but left-aligned at a key signature or clef (maybe generalized
> to anything
>> with break-align-anchor-alignment = RIGHT?).
> On 14 Dec 2019, at 09:54, lemzwerg--- via Discussions on LilyPond development
> wrote:
>
> LGTM, thanks!
>
> https://codereview.appspot.com/553310045/
>
The C++11 range for statement is nice too, if the iterator self is not
addressed. For example, in beam.cc:
for (auto& s: stems) {
On 2019/12/14 18:23:08, lilypond_de-wolff.org wrote:
Great job, one remark:
Although the patch for ly/music-functions-init.ly is a good patch, I
do not
think it should be part of this patch-set.
Jaap
It's part of the commit titled "comments." What do you suggest I do
instead?
On 2019/12/14 16:47:15, Dan Eble wrote:
I think it would be better for a RehearsalMark to be center-aligned at
a bar
line, but left-aligned at a key signature or clef (maybe generalized
to anything
with break-align-anchor-alignment = RIGHT?). I don't know if it's
currently
possible to
On 2019/12/14 16:47:15, Dan Eble wrote:
I think it would be better for a RehearsalMark to be center-aligned at
a bar
line, but left-aligned at a key signature or clef (maybe generalized
to anything
with break-align-anchor-alignment = RIGHT?). I don't know if it's
currently
possible to
Any LilyPond dev who does have a Facebook account might have a look at
this interesting, although somewhat sad, discussion. I think it gives a
clear picture of how our current state of development is perceived by users:
https://www.facebook.com/groups/gnulilypond/permalink/10157762793383529/
> On 14 Dec 2019, at 13:07, d...@gnu.org wrote:
>
> I don't want to get your enthusiasm up prematurely, but I think that the
> GUB GCC versions we need(?)/use for PowerPC might not be entirely great
> with C++11 though they'll likely support it when given explicitly on the
> command line.
From
Great job, one remark:
Although the patch for ly/music-functions-init.ly is a good patch, I do not
think it should be part of this patch-set.
Jaap
Doesn't this shift _everything_ that one might try to align relative to
a clef, not just rehearsal marks?
What about key signatures? The break-align-symbols for RehearsalMark
are (staff-bar key-signature clef). This change won't do anything for
the alignment of a rehearsal mark that attaches
David Kastrup writes:
> Knut Petersen writes:
>
>> On 26.07.19 20:36, David Kastrup wrote:
>>>
Unless Knut is also running patchy now that he has commit access (and
perhaps didn't have a clean master?).
(I don't want to cast aspersions, but it might be a genuine mistake if
On 2019/12/14 10:18:33, hahnjo wrote:
Fabulous, thanks for putting this together!
I don't want to get your enthusiasm up prematurely, but I think that the
GUB GCC versions we need(?)/use for PowerPC might not be entirely great
with C++11 though they'll likely support it when given explicitly
Reviewers: ,
Description:
Fix regtests about Footnote
Several regtest about FootnoteItem/Spanner contained overrides
without specifying the context.
Footnote_engraver lives in Score-context, though. Thus the
Score-context is added to the overrides in:
Fabulous, thanks for putting this together!
https://codereview.appspot.com/553310045/
LGTM, thanks!
https://codereview.appspot.com/553310045/
20 matches
Mail list logo
