Re: is this code-style better? (more alphabetizing patches)

2009-08-21 Thread Joe Neeman
On Wed, 2009-08-19 at 23:35 -0700, Mark Polesky wrote: I made some changes to the code-style here.Let me know if you guys think anything is better or worse. I'll probably combine these into one patch. In script-init.ly, I prefer the old version. I find it easier to read (no chance of visually

Re: LilyPond strings and \markup

2009-08-17 Thread Joe Neeman
On Mon, 2009-08-17 at 00:59 -0700, Mark Polesky wrote: Carl Sorensen wrote: Because \[alphanum]+ is a STRING_IDENTIFIER. Not always: num = 1 sym = #'symbol % error: syntax error, unexpected NUMBER_IDENTIFIER (\num) % \num % error: syntax error, unexpected SCM_IDENTIFIER (\sym) %

Re: LilyPond strings and \markup

2009-08-16 Thread Joe Neeman
On Sun, 2009-08-16 at 14:05 -0700, Mark Polesky wrote: \version 2.13.4 % QUESTION 1 % quoted string is STRING strA = quoted string % #hash-quoted string is SCM_TOKEN strB = #hash-quoted string % these are both 'unexpected STRING_IDENTIFIER's: % \strA \strB % Why

Re: [PATCH] Re: feature-request / doc-actualization (right-margin)

2009-08-16 Thread Joe Neeman
On Sun, 2009-08-16 at 19:31 +0200, Michael Käppler wrote: Michael Käppler wrote: Hi Joe, get_paper is called more than once for each paper block. The first time is probably from parser.yy:847, which actually _creates_ the first paper block (so no variables have been parsed at all).

Re: [PATCH] Re: feature-request / doc-actualization (right-margin)

2009-08-15 Thread Joe Neeman
On Fri, 2009-08-14 at 19:00 +0200, Michael Käppler wrote: Hmm...there's a new problem I don't understand. If I set a breakpoint in lily-parser.cc:225 (get_paper) and call normalize() from there, it seems that all default variables which are set in paper-defaults-init.ly aren't accessible.

Re: Dead lyrics context still occupies vertical space

2009-08-14 Thread Joe Neeman
On Fri, 2009-08-14 at 17:09 +0200, Reinhold Kainhofer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Dienstag, 11. August 2009 02:57:08 schrieb Joe Neeman: I do intend to write some docs (once I've finished dealing with my TODO list), but in the absence of docs, here's a list

Re: [PATCH] Re: feature-request / doc-actualization (right-margin)

2009-08-13 Thread Joe Neeman
On Thu, 2009-08-13 at 23:46 +0100, Neil Puttock wrote: 2009/8/12 Michael Käppler xmichae...@web.de: hmm... somehow I'm completely stuck at this moment. Why does the affected output-def contain no paper-width / paper-height etc.? I don't really know how this can be triggered by my patch

Re: Implement new handling for margin and line-width settings.

2009-08-12 Thread Joe Neeman
On Wed, 2009-08-12 at 09:14 -0400, Dan Eble wrote: On 12 Aug 2009, at 00:06, joenee...@gmail.com wrote: In case there is rounding, it is better to check if (abs (paper_width - line_width - left_margin - right_margin) 1e-6) Wouldn't it be a good idea to define a name for 1e-6?

Re: InstrumentName misalignment in incipit snippets

2009-08-11 Thread Joe Neeman
On Tue, 2009-08-11 at 21:57 +0100, Neil Puttock wrote: Hi Joe, While fixing the last bug with the new instrument name code, I noticed that the instrument name positioning for both inicipit snippets (Documentation/snippets/incipit.ly and input/regression/incipit.ly) has changed for the

Re: Big Measures in Large Ensemble

2009-08-11 Thread Joe Neeman
(moved to lilypond-devel) On Tue, 2009-08-11 at 00:22 +0100, Neil Puttock wrote: 2009/8/10 Joe Neeman joenee...@gmail.com: If there's a \bar and a clef in the same place, then the BreakAlignGroup will have a non-empty extent, but I think we still want the column to be loose. I'm

Re: headers and footers with new vertical layout engine

2009-08-11 Thread Joe Neeman
On Tue, 2009-08-11 at 16:44 +0200, Werner LEMBERG wrote: Regarding your Top context: why do you override VerticalAxisGroup #'Y-extent = ##f? This is likely to confuse the layout algorithm even after the bug I mentioned is fixed. This was necessary for the old vertical layout engine --

Re: Guidelines for bounding boxes?

2009-08-11 Thread Joe Neeman
On Tue, 2009-08-11 at 20:03 -0700, Patrick McCarty wrote: On Mon, Aug 10, 2009 at 07:02:39AM +0200, Werner LEMBERG wrote: Another improvement would be to provide `shaped metrics': Currently, the metrics for a glyph consist of a single rectangle. This could be extended to a list of

Re: Spacing over a new piece beginning is too small

2009-08-10 Thread Joe Neeman
On Mon, 2009-08-10 at 11:00 +0200, Reinhold Kainhofer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Yet another small issue with the vertical layout: It seems that where one piece ends and another one begins, the piece title is completely ignored for spacing. Even worse, Sometimes

Re: Spacing over a new piece beginning is too small

2009-08-10 Thread Joe Neeman
On Mon, 2009-08-10 at 12:27 +0200, Werner LEMBERG wrote: The overlap between Ecce panis and Allegro is due to a bug (that you and Werner have already found) regarding rehearsal marks not being counted in the spacing problem. You haven't fixed this, right? I have now :)

Re: Fixing configure with Autoconf 2.64

2009-08-10 Thread Joe Neeman
On Thu, 2009-08-06 at 10:53 -0700, Patrick McCarty wrote: On Thu, Aug 06, 2009 at 06:22:05PM +0200, John Mandereau wrote: Le mercredi 05 août 2009 à 21:03 -0700, Patrick McCarty a écrit : I need this patch to run ./autogen.sh with the latest Autoconf version (2.64). The only earlier

Re: Fixing configure with Autoconf 2.64

2009-08-10 Thread Joe Neeman
On Mon, 2009-08-10 at 14:23 -0700, Patrick McCarty wrote: On Mon, Aug 10, 2009 at 8:11 AM, Joe Neemanjoenee...@gmail.com wrote: On Thu, 2009-08-06 at 10:53 -0700, Patrick McCarty wrote: On Thu, Aug 06, 2009 at 06:22:05PM +0200, John Mandereau wrote: Le mercredi 05 août 2009 à 21:03 -0700,

Re: Dead lyrics context still occupies vertical space

2009-08-10 Thread Joe Neeman
On Mon, 2009-08-10 at 13:03 +0200, Francisco Vila wrote: Hello. The example below shows that the new vertical engine makes dead lyrics contexts to occup space. This did not happen before, IMO the new lyrics should (IF it has enough room) to align with the previous one. Did this work before

Re: Dead lyrics context still occupies vertical space

2009-08-10 Thread Joe Neeman
On Tue, 2009-08-11 at 01:10 +0200, Francisco Vila wrote: 2009/8/11 Joe Neeman joenee...@gmail.com: On Mon, 2009-08-10 at 13:03 +0200, Francisco Vila wrote: Hello. The example below shows that the new vertical engine makes dead lyrics contexts to occup space. This did not happen before, IMO

Re: Dead lyrics context still occupies vertical space

2009-08-10 Thread Joe Neeman
On Tue, 2009-08-11 at 01:46 +0200, Reinhold Kainhofer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Dienstag, 11. August 2009 00:24:25 schrieb Joe Neeman: On Mon, 2009-08-10 at 13:03 +0200, Francisco Vila wrote: Hello. The example below shows that the new vertical engine makes

Re: Dead lyrics context still occupies vertical space

2009-08-10 Thread Joe Neeman
On Tue, 2009-08-11 at 01:54 +0200, Reinhold Kainhofer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Dienstag, 11. August 2009 01:10:33 schrieb Francisco Vila: It looks much better now, except for the footer, when stretched. Yes, I also noticed this with my scores: It appears

Re: Dead lyrics context still occupies vertical space

2009-08-10 Thread Joe Neeman
On Tue, 2009-08-11 at 02:19 +0200, Reinhold Kainhofer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Dienstag, 11. August 2009 02:04:28 schrieb Joe Neeman: With the uninitialized variables fix, the remaining issues might just be due to bad default settings (see below). I would

Re: Dead lyrics context still occupies vertical space

2009-08-10 Thread Joe Neeman
On Tue, 2009-08-11 at 02:17 +0200, Francisco Vila wrote: 2009/8/11 Joe Neeman joenee...@gmail.com: Is the footer too close to the lyrics? The default value (in the paper block) for bottom-system-spacing is bottom-system-spacing = #'((space . 1) (padding . 1) (min-distance . 0

Re: does ancient music work correctly?

2009-08-09 Thread Joe Neeman
On Sun, 2009-08-09 at 21:16 +0200, Werner LEMBERG wrote: I'm not sure what's going on here, Werner, but something which might improve matters would be to use barlines for divisiones instead of breathing signs: since Joe's fixed the spacing problems associated with empty barlines, it should

Re: Lyrics before new piece title are printed after piece title

2009-08-09 Thread Joe Neeman
On Mon, 2009-08-10 at 00:52 +0200, Reinhold Kainhofer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Another issue with the new vertical layout engine: I have a score with lyrics and multiple pieces. With the new vertical laytout engine, the lyrics of the last staff before a new

Re: headers and footers with new vertical layout engine

2009-08-09 Thread Joe Neeman
On Sun, 2009-08-09 at 09:05 +0200, Werner LEMBERG wrote: [git b6e82e5a from today] Joe, since documentation of your changes is not yet available, I have to ask directly: What's the new method for providing proper distances between the header, the body, and the footer of a page? If I

Re: cross-staff versions of \arpeggioArrowUp etc.

2009-08-06 Thread Joe Neeman
to the X-extent binding one line below? Grob names are capitalized in lilypond code, but not in scheme code. X-extent (and X-offset and other such things) are capitalized for consistency with existing code. Joe Neeman wrote: I'd like to second Neil's objection regarding the hard-coding

Re: cross-staff versions of \arpeggioArrowUp etc.

2009-08-06 Thread Joe Neeman
On Thu, 2009-08-06 at 07:11 -0700, Mark Polesky wrote: Joe Neeman wrote: There doesn't seem to be. As a workaround, you could add a context property called, say, spanArpeggioInThisContext and document somewhere that the \connectArpeggiosOn command works in the lowermost context where

Re: documentation of `after-title-spacing' is missing

2009-08-04 Thread Joe Neeman
On Mon, 2009-08-03 at 13:28 +0200, Werner LEMBERG wrote: The documentation of the new `after-title-spacing' property and its siblings is missing. Additionally, there are no regression tests showing those parameters in action. Thanks, I'll add this to my todo list. Joe

Re: cross-staff versions of \arpeggioArrowUp etc.

2009-08-04 Thread Joe Neeman
On Tue, 2009-08-04 at 14:01 -0700, Mark Polesky wrote: Mark Polesky wrote: Otherwise, does this look good? I'm sorry to keep doing this, but I keep finding ways of improving this. Now I think users should find this very intuitive, although the internal workings are more complex. I've

Re: Problem with VerticalAlignment

2009-08-04 Thread Joe Neeman
On Tue, 2009-08-04 at 19:02 -0600, Carl Sorensen wrote: On 8/4/09 5:49 AM, Graham Percival gra...@percival-music.ca wrote: On Tue, Aug 04, 2009 at 09:13:40PM +1000, Cameron Horsburgh wrote: I'm having trouble with a brand new clone of the git repo. Running lilypond on even the

Re: RFC: new vertical layout engine

2009-08-03 Thread Joe Neeman
On Mon, 2009-08-03 at 12:22 -0600, Andrew Hawryluk wrote: On Thu, Jul 30, 2009 at 7:18 PM, Joe Neemanjoenee...@gmail.com wrote: After fixing the latest round of bugs (pointed out by Neil Puttock and Michael Käppler), I've pushed the changes to git's master branch. That is, you should test

Re: Adjusting Piano centered dynamics template and Les Néréides

2009-08-03 Thread Joe Neeman
On Mon, 2009-08-03 at 12:24 +0200, John Mandereau wrote: Le dimanche 02 août 2009 à 00:38 -0700, Joe Neeman a écrit : I've added some more stretchable space and a little padding to Dynamics, so the pedals look better. If you think pedals and dynamics should be treated differently, feel free

Re: Adjusting Piano centered dynamics template and Les Néréides

2009-08-02 Thread Joe Neeman
On Fri, 2009-07-31 at 22:57 +0100, Neil Puttock wrote: 2009/7/31 Joe Neeman joenee...@gmail.com: It should be sufficient to simply remove the definition of the Dynamics context from these files (and the \accepts Dynamics part from PianoStaff). The default Dynamics context is very similar

Re: New vertical engine: first system too close to title

2009-08-02 Thread Joe Neeman
On Mon, 2009-08-03 at 01:53 +0200, Francisco Vila wrote: 2009/8/1 Joe Neeman joenee...@gmail.com: On Sat, 2009-08-01 at 11:44 +0200, Francisco Vila wrote: Hello. The new vertical algorythm is nearly perfect. Here is another problem, though. \version 2.13.4 \header{ title

Re: Vertical spacing docs

2009-07-31 Thread Joe Neeman
On Fri, 2009-07-31 at 16:49 +0200, John Mandereau wrote: Hi guys, Could someone checks paragraphs and the snippet I @ignored today in Notation, chapter Spacing, in order to compile docs? Maybe they should be deleted. They should be deleted, yes. I'll get working on some new docs. Joe

Re: Adjusting Piano centered dynamics template and Les Néréides

2009-07-31 Thread Joe Neeman
On Fri, 2009-07-31 at 14:00 -0700, Patrick McCarty wrote: Hello, Since Joe added a new Dynamics context to LilyPond, the two examples mentioned in the subject are currently broken. Thanks for pointing this out. How should they be modified? It should be sufficient to simply remove the

Re: cross-staff versions of \arpeggioArrowUp etc.

2009-07-31 Thread Joe Neeman
On Fri, 2009-07-31 at 18:58 -0700, Mark Polesky wrote: Mark Polesky wrote: Interesting idea. As a first attempt, I tried making the functionality of the \arpeggioArrowUp command dependent on the 'connectArpeggios context property, but obviously I'm doing something wrong. Does anyone

Re: RFC: new vertical layout engine

2009-07-30 Thread Joe Neeman
On Mon, 2009-07-27 at 23:36 +0100, Neil Puttock wrote: Hi Joe, Here's an attachment with three examples for you to test. Hi Neil, Thanks for the test files. I think they're all fixed now. Note, however, that I've changed how alignment-distances works; its arguments now should be positive

Re: RFC: new vertical layout engine

2009-07-30 Thread Joe Neeman
After fixing the latest round of bugs (pointed out by Neil Puttock and Michael Käppler), I've pushed the changes to git's master branch. That is, you should test master instead of dev/jneeman and bugs now belong on the bug list instead of in this thread. Thanks for all the comments and testing,

Re: top-margin bug?

2009-07-27 Thread Joe Neeman
On Mon, 2009-07-27 at 11:31 -0700, Patrick McCarty wrote: On Mon, Jul 27, 2009 at 10:07:26AM +, Werner wrote: Are you checking the dimensions with \paper { annotate-spacing = ##t } or by printing out a page and measuring manually? I measured manually. But this is an

Re: RFC: new vertical layout engine

2009-07-27 Thread Joe Neeman
On Sun, 2009-07-26 at 14:54 -0700, Graham Percival wrote: On Sun, Jul 26, 2009 at 04:24:03PM -0400, Kieren MacMillan wrote: Hello Joe (et al.), (It's not that I'm afraid of building Lilypond, it's just that spending three days installing the prerequisites is currently low on my list

Re: RFC: new vertical layout engine

2009-07-27 Thread Joe Neeman
On Mon, 2009-07-27 at 15:14 +, Han-Wen Nienhuys wrote: On Sun, Jul 26, 2009 at 9:54 PM, Graham Percivalgra...@percival-music.ca wrote: (It's not that I'm afraid of building Lilypond, it's just that spending three days installing the prerequisites is currently low on my list of

Re: Rewrite the vertical layout of staves/systems.

2009-07-27 Thread Joe Neeman
On Mon, 2009-07-27 at 05:42 +, pnor...@gmail.com wrote: I don't really understand the code from this patchset, but I just have one quick comment. Thanks, Patrick http://codereview.appspot.com/97119/diff/1/22 File lily/staff-grouper-engraver.cc (right):

Re: top-margin bug?

2009-07-27 Thread Joe Neeman
On Mon, 2009-07-27 at 13:54 -0700, Patrick McCarty wrote: On Mon, Jul 27, 2009 at 08:32:55PM +, Werner wrote: Patrick McCarty pnorcks at gmail.com writes: Since those measurements are in staff-spaces, the conversion to millimeters is as follows: 4.84 * 5 * 25.4 / 72.27 =

Re: RFC: new vertical layout engine

2009-07-26 Thread Joe Neeman
On Sun, 2009-07-26 at 21:46 +1000, Cameron Horsburgh wrote: Joe Neeman joenee...@gmail.com writes: On Fri, 2009-07-10 at 17:09 +0200, Reinhold Kainhofer wrote: Am Montag, 22. Juni 2009 15:31:14 schrieb Joe Neeman: A quick update on the new vertical spacing: [...] Anything I've missed

Re: RFC: new vertical layout engine

2009-07-26 Thread Joe Neeman
On Sun, 2009-07-26 at 20:02 +0100, Neil Puttock wrote: Hi Joe, 2009/7/26 Joe Neeman joenee...@gmail.com: Please do send me the files. But first, check to see if they give the same behaviour with current git. I pushed some changes yesterday that may have helped. Have you carried

Re: RFC: new vertical layout engine

2009-07-26 Thread Joe Neeman
On Sun, 2009-07-26 at 15:57 -0400, Dan Eble wrote: On 26 Jul 2009, at 13:41, Joe Neeman wrote: Please do send me the files. But first, check to see if they give the same behaviour with current git. I pushed some changes yesterday that may have helped. I have a book of 243 scores

Re: tabs vs. spaces in source code

2009-07-25 Thread Joe Neeman
On Sat, 2009-07-25 at 09:58 -0700, Mark Polesky wrote: ...tabs in the source code... Werner Lemberg wrote: I dislike them, too, but there are many editors which handle them just fine. I don't see a problem here. But would you be *opposed* to a strict no-tab rule? I like spaces just

Re: RFC: new vertical layout engine

2009-07-24 Thread Joe Neeman
I've uploaded the patch for review at http://codereview.appspot.com/97119 It's pretty huge, but many of the changes are just due to changes in the properties that control vertical spacing. Also, annotate-spacing is broken, but the fixes for that should be confined to scm/page.scm. Joe

Re: Possible bug with system-count

2009-07-21 Thread Joe Neeman
On Tue, 2009-07-21 at 16:43 +1000, Cameron Horsburgh wrote: Joe Neeman joenee...@gmail.com writes: On Tue, 2009-07-21 at 10:08 +1000, Cameron Horsburgh wrote: Hi Joe, You may already be aware of this issue, but I'll report it anyway. I'm currently typesetting a piece that should

Re: Possible bug with system-count

2009-07-20 Thread Joe Neeman
On Tue, 2009-07-21 at 10:08 +1000, Cameron Horsburgh wrote: Hi Joe, You may already be aware of this issue, but I'll report it anyway. I'm currently typesetting a piece that should comfortably fit two systems to a page. For consistency's sake I've added system-count = 2 in the \layout

Re: change clef inside a grob-callback?

2009-07-17 Thread Joe Neeman
On Thu, 2009-07-16 at 23:06 -0700, Mark Polesky wrote: Joe Neeman wrote: Is there a way to change the clef from within a grob callback? Not really. You can change the clef's glyph, but you can't really change the clef's influence on the following notes. I presume you mean I can

Re: change clef inside a grob-callback?

2009-07-16 Thread Joe Neeman
On Thu, 2009-07-16 at 19:10 -0700, Mark Polesky wrote: Is there a way to change the clef from within a grob callback? Not really. You can change the clef's glyph, but you can't really change the clef's influence on the following notes. Reason being, the NoteHead grobs are created around the same

Re: centering of instrument names

2009-07-15 Thread Joe Neeman
On Wed, 2009-07-15 at 22:07 +0100, Neil Puttock wrote: 2009/5/30 Joe Neeman joenee...@gmail.com: The sanest behaviour IMO is the behaviour of your current patch, but with a different meaning for 'padding. I can see two ways to do this: the quickdirty way to get this is to replace

Re: RFC: new vertical layout engine

2009-07-13 Thread Joe Neeman
On Fri, 2009-07-10 at 17:09 +0200, Reinhold Kainhofer wrote: Am Montag, 22. Juni 2009 15:31:14 schrieb Joe Neeman: A quick update on the new vertical spacing: [...] Anything I've missed? While the new vertical spacing looks great for full scores (one system per page), I have now run

Re: RFC: new vertical layout engine

2009-07-11 Thread Joe Neeman
On Fri, 2009-07-10 at 19:21 -0600, Andrew Hawryluk wrote: On Fri, Jul 10, 2009 at 9:09 AM, Reinhold Kainhoferreinh...@kainhofer.com wrote: Am Montag, 22. Juni 2009 15:31:14 schrieb Joe Neeman: A quick update on the new vertical spacing: [...] Anything I've missed? While the new

Re: [PATCH v2] Fix crash when a stencil routine is missing

2009-07-07 Thread Joe Neeman
On Tue, 2009-07-07 at 01:24 -0700, Patrick McCarty wrote: On Tue, Jul 07, 2009 at 08:16:45AM +0200, Werner LEMBERG wrote: The new option, -dwarning-as-error, does *not* turn every warning into an error. It only turns specific warnings (that don't exist without this patch) into

Re: Issue #612 still not fixed

2009-07-04 Thread Joe Neeman
On Sat, 2009-07-04 at 07:07 +0200, Werner LEMBERG wrote: Since this is one of the most serious elementary typesetting bugs which lilypond exposes, and which can easily happen in any piano score, I vote for quick inclusion. Well, Joe had a lot of comments for Chris, and I can't find a

Re: RFC: new vertical layout engine

2009-06-30 Thread Joe Neeman
On Mon, 2009-06-29 at 13:48 +0200, Reinhold Kainhofer wrote: Am Montag, 22. Juni 2009 15:31:14 schrieb Joe Neeman: A quick update on the new vertical spacing: the version now in dev/jneeman has most of the features that I had planned Wow, I just tried it out for the first time, and I must

Re: First release of ly/tablature.ly

2009-06-24 Thread Joe Neeman
On Tue, 2009-06-23 at 12:53 -0600, Carl D. Sorensen wrote: http://codereview.appspot.com/67174/diff/1/2#newcode237 Line 237: \layout { It seems to me that we have 3 versions of tablature now: the default version in engraver-init.ly, the version that appears if the user includes

Re: 2.14 release plans

2009-06-23 Thread Joe Neeman
On Mon, 2009-06-22 at 21:25 -0700, Graham Percival wrote: Progress has been slow for the past month. I'd like to be able to claim that I'll be getting more done in the next few weeks, but in all honesty I doubt it. If anything, I'll be engaged in *more* household projects, not less. With

Re: RFC: new vertical layout engine

2009-06-22 Thread Joe Neeman
A quick update on the new vertical spacing: the version now in dev/jneeman has most of the features that I had planned (although there are still lots of loose ends to tie up). In particular, you can - space staves in groups using \override StaffGroup.StaffGrouper #'after-last-staff-spacing =

Re: RFC: new vertical layout engine

2009-06-18 Thread Joe Neeman
On Wed, Jun 17, 2009 at 6:46 PM, Kieren MacMillan kieren_macmil...@sympatico.ca wrote: Hi Joe, What I would *really* love are high-level commands to set intra-piece (section) system-count and page-count options. For example, I'd like to say that in an ABA form piece, the B section must be

Re: RFC: new vertical layout engine

2009-06-17 Thread Joe Neeman
On Tue, Jun 16, 2009 at 2:50 PM, Reinhold Kainhofer reinh...@kainhofer.comwrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Dienstag, 16. Juni 2009 11:52:09 schrieb Joe Neeman: On Mon, Jun 15, 2009 at 9:05 PM, Reinhold Kainhofer This will certainly the possible in the layout code

Re: RFC: new vertical layout engine

2009-06-16 Thread Joe Neeman
On Mon, Jun 15, 2009 at 9:05 PM, Reinhold Kainhofer reinh...@kainhofer.comwrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Montag, 15. Juni 2009 17:25:54 schrieb Joe Neeman: I've started working on a new system for doing vertical layout in one pass (ie. positioning and stretching

Re: [PATCH] Make some local functions public (was: Re: lily-library.scm question)

2009-06-15 Thread Joe Neeman
On Mon, Jun 8, 2009 at 3:59 AM, Mark Polesky markpole...@yahoo.com wrote: my version: (define-public (split-at-predicate predicate lst) Split LST (into 2 lists) at the first element that returns #f for (PREDICATE previous_element element), and return the 2 new lists as a pair.

Re: [Issue?] hiding Accidental(s) on tied note(s) after a line break

2009-05-30 Thread Joe Neeman
From 057d39e33c669dacc98833bbc766d8ca693f084a Mon Sep 17 00:00:00 2001 From: Joe Neeman joenee...@gmail.com Date: Sat, 30 May 2009 19:14:42 -0700 Subject: [PATCH] Make tied accidentals after line breaks configurable. --- input/regression/accidental-tie-overridden.ly | 23

Re: [Issue?] hiding Accidental(s) on tied note(s) after a line break

2009-05-30 Thread Joe Neeman
On Saturday 30 May 2009 08:10:46 pm Kieren MacMillan wrote: Hi Joe, Not really =\ the code that places a tied accidental after a line break isn't accessible from scheme (it lives in lily/accidental.cc, in the print function). Ah... here's a patch (to be applied with git am) that

Re: [Issue?] hiding Accidental(s) on tied note(s) after a line break

2009-05-30 Thread Joe Neeman
On Saturday 30 May 2009 10:23:31 pm Werner LEMBERG wrote: shortest note playing here.) (shortest-starter-duration ,ly:moment? The duration of the shortest note that starts here.) + (hide-tied-accidental-after-break ,boolean? If set, an accidental +that appears on a tied note

Re: centering of instrument names

2009-05-29 Thread Joe Neeman
On Wed, 2009-05-27 at 21:35 +0100, Neil Puttock wrote: 2009/5/24 Joe Neeman joenee...@gmail.com: Fair enough, but I don't think 'padding has the right meaning here. Ideally, 'padding should be the smallest distance between an InstrumentName and the SystemStartXXX to its right. Here, it's

Re: suspicious break-align values

2009-05-27 Thread Joe Neeman
On Wed, 2009-05-27 at 02:17 -0700, Mark Polesky wrote: line 408 of define-grobs.scm lists staff in a break-align-orders vector. Is that a typo? I think so. line 49 of lsr/creating-simultaneous-rehearsal-marks.ly reads: \once \override Score.RehearsalMark #'break-align-symbols = #'(bar-line)

Re: page breaking changed in 2.13 ???

2009-05-24 Thread Joe Neeman
On Sun, 2009-05-24 at 11:53 -0700, ArnoWaschk wrote: Werner LEMBERG wrote: i am using a 2.13 lilypond compiled from today's git repo, and i am observing - in comparison to a version from around 10th of April - that the page breaking strategy seems to have changed significantly.

Re: centering of instrument names

2009-05-23 Thread Joe Neeman
On Fri, 2009-05-22 at 23:46 +0100, Neil Puttock wrote: 2009/5/20 Francisco Vila paconet@gmail.com: 2009/5/20 Francisco Vila paconet@gmail.com: The key code is this. Given a (big) amount of time I could figure out how it works and try to improve it.

Re: centering of instrument names

2009-05-23 Thread Joe Neeman
On Sat, 2009-05-23 at 23:38 +0100, Neil Puttock wrote: 2009/5/23 Joe Neeman joenee...@gmail.com: If I understand this correctly, you're suggesting that we pad each instrument name according to the largest (wrt X-extent) SystemStartXXX. That's basically it, though the extent would

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-22 Thread Joe Neeman
On Thu, 2009-05-14 at 14:17 -0700, Joe Neeman wrote: To summarize: there are more fixes to come, but I think page-count=8, ragged-bottom=##f, ragged-last-bottom=##f gives decent results now. After a couple more fixes, I get reasonable results with or without ragged and with or without page

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-14 Thread Joe Neeman
On Tue, 2009-05-05 at 12:22 +0200, Reinhold Kainhofer wrote: Hi all, I already sent this to lilypond-user last week, but didn't get any hint for a solution, so maybe the devel list is more helpful: I'm currently trying to squeeze the choir part of a mass onto 8 pages. Here is the

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-06 Thread Joe Neeman
On Tue, 2009-05-05 at 12:22 +0200, Reinhold Kainhofer wrote: Hi all, I already sent this to lilypond-user last week, but didn't get any hint for a solution, so maybe the devel list is more helpful: I'm currently trying to squeeze the choir part of a mass onto 8 pages. Here is the

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-06 Thread Joe Neeman
On Wed, 2009-05-06 at 23:45 +0200, Reinhold Kainhofer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Mittwoch, 6. Mai 2009 19:01:46 schrieb Joe Neeman: On Tue, 2009-05-05 at 12:22 +0200, Reinhold Kainhofer wrote: On the first page there is more than enough space to add a fourth

Re: Improve implementation of dashed slurs

2009-04-18 Thread Joe Neeman
On Fri, 2009-04-17 at 22:17 -0600, Carl D. Sorensen wrote: On 4/17/09 1:47 PM, joenee...@gmail.com joenee...@gmail.com wrote: Very pretty slurs! Thanks! http://codereview.appspot.com/41099/diff/1021/59 File lily/bezier.cc (right):

Re: Improve implementation of dashed slurs

2009-04-18 Thread Joe Neeman
On Sat, 2009-04-18 at 21:08 -0600, Carl D. Sorensen wrote: On 4/18/09 7:56 PM, Joe Neeman joenee...@gmail.com wrote: On Fri, 2009-04-17 at 22:17 -0600, Carl D. Sorensen wrote: http://codereview.appspot.com/41099/diff/1021/62#newcode347 Line 347: SCM dash_details) Since

Re: tab characters in the source code

2009-04-07 Thread Joe Neeman
On Tue, 2009-04-07 at 17:18 -0600, Carl D. Sorensen wrote: On 4/7/09 4:17 PM, dem...@suffolk.lib.ny.us dem...@suffolk.lib.ny.us wrote: As to LY not accepting tabs, thats a shame, tabs should be treated as white space, along with bel nul lf VT and other now-disused characters

Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space)

2009-03-29 Thread Joe Neeman
On Sun, 2009-03-29 at 02:34 -0300, Han-Wen Nienhuys wrote: On Sat, Mar 28, 2009 at 11:31 PM, Joe Neeman joenee...@gmail.com wrote: The problem is that the current support for conditional accidentals is insufficient if there are multiple accidentals, not all of which are tied (see bug

Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space)

2009-03-28 Thread Joe Neeman
On Sat, 2009-03-28 at 16:16 -0300, Han-Wen Nienhuys wrote: On Thu, Mar 26, 2009 at 3:21 PM, Joe Neeman joenee...@gmail.com wrote: One solution might be the following, which involves modifying only accidental-placement: make 2 copies of every accidental, one for the start-of-a-line case

Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space)

2009-03-28 Thread Joe Neeman
On Sat, 2009-03-28 at 22:51 -0400, Chris Snyder wrote: On Saturday, March 28, 2009, Joe Neeman wrote: The problem is that the current support for conditional accidentals is insufficient if there are multiple accidentals, not all of which are tied (see bug 612). The reason

Re: Tied accidentals in chords still taking up space

2009-03-27 Thread Joe Neeman
On Fri, 2009-03-27 at 15:04 -0400, Chris Snyder wrote: Joe Neeman wrote: On Thu, 2009-03-26 at 10:26 -0400, Chris Snyder wrote: Joe Neeman wrote: It's not necessary to announce every grob (for example, of the three copies of every breakable grob, only the middle-of-line copy gets

Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space)

2009-03-26 Thread Joe Neeman
On Thu, 2009-03-26 at 10:26 -0400, Chris Snyder wrote: Joe Neeman wrote: [explanation of spacing code...] One solution might be the following, which involves modifying only accidental-placement: make 2 copies of every accidental, one for the start-of-a-line case and one for the middle

Re: polyphonic shorthand; line-spanner-interface in Hairpin

2009-03-17 Thread Joe Neeman
On Tue, 2009-03-17 at 06:55 -0400, Kieren MacMillan wrote: Hello, Thanks to Carl's patient help, I've successfully submitted my first patch as a Frog! insert sound of trumpets, throw confetti, etc. 1. For my next task, I was thinking of fixing the polyphonic shorthand. Unfortunately,

Re: polyphonic shorthand; line-spanner-interface in Hairpin

2009-03-17 Thread Joe Neeman
On Tue, 2009-03-17 at 16:47 -0600, Carl D. Sorensen wrote: On 3/17/09 3:48 PM, Kieren MacMillan kieren_macmil...@sympatico.ca wrote: Hi Carl, One issue that comes up in your proposal is that a 1/16 note column does not take up 1/16 of a whole note column. So exactly what space

systems-per-page

2009-03-13 Thread Joe Neeman
I have a (largish, sorry) code review up for new min-systems-per-page, max- systems-per-page and systems-per-page variables in the paper block: http://codereview.appspot.com/28041 Also, the code is in the dev/jneeman git branch, if anyone wants to test. Joe

Re: Enabling item-interface

2009-03-02 Thread Joe Neeman
On Mon, 2009-03-02 at 21:05 -0700, Carl D. Sorensen wrote: I'm working to enable the chordChanges property for a FretBoards object. I've changed the fretboard-engraver to keep track of the last fretboard, using the chord-name-engraver as a model. I've verified that the code works to keep

Re: [PATCH] Completion_heads_engraver broken?

2009-03-01 Thread Joe Neeman
On Sat, 2009-02-28 at 10:23 +0100, Michael Käppler wrote: Joe Neeman wrote: On Thu, 2009-02-26 at 13:24 +0100, Michael Käppler wrote: Both fixed. Other comments? Just one: can you set the environment variables GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL so that an actual name

Re: [PATCH] Completion_heads_engraver broken?

2009-02-27 Thread Joe Neeman
On Thu, 2009-02-26 at 13:24 +0100, Michael Käppler wrote: Both fixed. Other comments? Just one: can you set the environment variables GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL so that an actual name and email show up in the patch? Thanks, Joe ___

Re: [PATCH] Completion_heads_engraver broken?

2009-02-26 Thread Joe Neeman
On Thu, 2009-02-26 at 11:23 +0100, Michael Käppler wrote: Hi all, I don't completely understand the way how Duration::Duration(Rational r, bool scale) converts a rational number into a note and dots, but it's clear that the Completion_heads issue with splitting up breve and longa notes was

Re: Completion_heads_engraver broken?

2009-02-25 Thread Joe Neeman
On Wed, 2009-02-25 at 22:37 +0100, Michael Käppler wrote: I think I've found the error. In duration.cc, starting from line 37, the left-shifting-operator is used for some calculation. This works, if the amount of shifted bytes is positive; otherwise the operator returns zero. In some

Re: Discourse on the Consumption of Dog Food

2009-02-05 Thread Joe Neeman
On Thu, 2009-02-05 at 23:08 +0800, Graham Percival wrote: On Wed, Feb 04, 2009 at 07:03:19PM +0100, Maximilian Albert wrote: Just a few random nitpicks so far (I haven't read the whole thing, though): Ok. Chapter 7 is mostly Carl's domain, but I'll fix most of these issues. - The last

Re: PATCH: Allow setting of arpeggio type for spanned arpeggios

2009-01-22 Thread Joe Neeman
On Thu, 2009-01-22 at 08:06 -0700, Carl D. Sorensen wrote: Graham asked me to take this patch on as part of my FrogMeister duties, so here goes. Chris, Can you make a brief regression test that shows why this patch is desirable? Joe seems to feel like it's unnecessary, because you can set

Re: PATCH: Allow setting of arpeggio type for spanned arpeggios

2009-01-21 Thread Joe Neeman
On Wed, Jan 21, 2009 at 7:26 AM, Chris Snyder csny...@adoromusicpub.comwrote: On December 20, 2008, Chris Snyder wrote: I did realize that the ly_symbol2scm call was not needed. I've attached a new patch that does not include it. Is there any chance of my patch being accepted into master?

Re: ideas for Google Summer of Code

2009-01-16 Thread Joe Neeman
On Fri, 2009-01-16 at 08:18 +0800, Graham Percival wrote: On Thu, Jan 15, 2009 at 05:19:48PM +0100, Anne Ghisla wrote: Johannes Schindelin ha scritto: (unfortunately, no I don't have time to mentor.) But that probably means a no-go for any Lilypond project. Depends on what it is.

Re: ideas for Google Summer of Code

2009-01-13 Thread Joe Neeman
Hi Anne, I'd suggest you start by joining the Frogs [1]. As a Frog, you will get some get some help in exploring lilypond's internals for the first time. You could also have a look at the bug tracker [2] if you want ideas for a project. Have a look, in particular, at the bugs with priority Low or

Re: bugfix patch reviewing

2009-01-03 Thread Joe Neeman
On Sat, Jan 3, 2009 at 10:06 PM, Trevor Daniels t.dani...@treda.co.ukwrote: Graham Percival wrote Saturday, January 03, 2009 2:40 AM How much oversight should the Frog patches receive? These patches have been reviewed by Carl. They compile cleanly, adhere to our code standards (to the

<    1   2   3   4   5   6   >