Re: ugly boxes

2011-06-12 Thread Trevor Daniels
Phil Holmes m...@philholmes.net wrote in message news:it2a6b$kgt$1...@dough.gmane.org... I'm continuing to look at the build system, and studying the output of make doc see lots of the following: Overfull \hbox (plus some other stuff) It would seem there are 2 options: either fix the

Re: git help - previous rebase directory

2011-06-09 Thread Trevor Daniels
Janek Delete the rebase-apply directory. Trevor - Original Message - From: Janek Warchoł lemniskata.bernoull...@gmail.com To: lilypond-devel@gnu.org Sent: Thursday, June 09, 2011 6:01 PM Subject: git help - previous rebase directory Hi, probably i'm doing something stupid, but

Re: does git reset change whole repository or just current branch?

2011-06-09 Thread Trevor Daniels
Janek Just the current branch. Trevor - Original Message - From: Janek Warchoł lemniskata.bernoull...@gmail.com To: lilypond-devel@gnu.org Sent: Thursday, June 09, 2011 5:35 PM Subject: does git reset change whole repository or just current branch? does git reset --hard

Re: GOP-PROP 1: python formatting

2011-06-06 Thread Trevor Daniels
Graham Percival wrote Monday, June 06, 2011 12:01 AM Proposal: let’s follow PEP-8. http://www.python.org/dev/peps/pep-0008/ * use 4 spaces per indentation level * never max tabs and spaces * Code indented with a mixture of tabs and spaces should be converted to using spaces

Re: Outside staff priority for tuplet bracket and tuplet number

2011-06-06 Thread Trevor Daniels
m...@apollinemike.com wrote Monday, June 06, 2011 8:42 AM On Sun, 5 Jun 2011 12:34:59 +0100, Trevor Daniels Shouldn't you be using the TupletNumber grob? Thanks for the suggestion! I just tried it with TupletNumber. I hadn't done that before because of these lines in Tuplet_number

Re: Outside staff priority for tuplet bracket and tuplet number

2011-06-06 Thread Trevor Daniels
m...@apollinemike.com wrote Monday, June 06, 2011 9:47 AM I am currently working off of a home-brewed branch of LilyPond that places articulations on the inside of tuplet numbers. It uses the Pointer_group_interface to make the tuplet bracket aware of scripts in tuplet-engraver.cc and then

Re: Outside staff priority for tuplet bracket and tuplet number

2011-06-05 Thread Trevor Daniels
Hi Mike Shouldn't you be using the TupletNumber grob? Trevor - Original Message - From: m...@apollinemike.com To: lilypond-devel@gnu.org Sent: Sunday, June 05, 2011 12:00 PM Subject: Outside staff priority for tuplet bracket and tuplet number Hey all, I'm running into a problem

Re: what is the correct terminology for...

2011-05-31 Thread Trevor Daniels
James Lowe wrote Tuesday, May 31, 2011 6:18 PM Consider a function: \transposedCueDuring #piccolo #UP Are the ' # ' variables, arguments, values, identifiers or what? What is the correct term for these two 'things' in this context? I'd call them arguments, but if you feel the need to use

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread Trevor Daniels
pkx1...@gmail.com wrote Monday, May 23, 2011 9:37 PM I've made a change to the example. I wasn't sure which file I could @ref to as it wasn't really obvious (to me) to see which default values quoteDuring used - the text says 'etc.' and it may use them all by default. So if you think we

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread Trevor Daniels
percival.music...@gmail.com wrote Tuesday, May 24, 2011 10:14 AM On 2011/05/24 08:34:42, t.daniels_treda.co.uk wrote: I think it is worth adding Music classes to the Internal Reference section. This lists all the event classes linearly. That would be a separate issue, of course.

Re: Allows LilyPond to ignore certain note-heads in a stem. (issue4547058)

2011-05-22 Thread Trevor Daniels
Hi Mike The interface to this looks rather clumsy. As you want to ignore only the extreme note head on a stem I'd prefer this to be controlled by a property of Stem, rather than NoteHead. Then you don't need to use tweak, with the need for careful positioning, and could even define predefs like

Re: Question about Music Classes in Internals and how to find\function properties

2011-05-21 Thread Trevor Daniels
Carl Sorensen wrote Friday, May 20, 2011 4:47 PM On 5/20/11 8:24 AM, James Lowe james.l...@datacore.com wrote: So my questions are 1. I know that I can use 'dynamic-event' for instance (because I have tried it) but there doesn't seem to be an easy way to know if an *-event will or will

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-20 Thread Trevor Daniels
pkx1...@gmail.com wrote Thursday, May 19, 2011 5:57 PM Trevor, do you still object to my last comment about that para? The main use for adjusting quotedEventTypes is to prevent irrelevant clutter being inserted into the quoting score, for example dynamics or markup might not be appropriate

Re: Might understand this music stuff a bit better in the future

2011-05-12 Thread Trevor Daniels
Colin Campbell wrote Thursday, May 12, 2011 2:19 PM On 11-05-12 05:08 AM, Phil Holmes wrote: I've just received an unconditional offer to study a part-time BA(Hons) in music from a local university. I'm well pleased :-) Up the geezers! Good for you, Phil. Make us old farts proud! I'll

Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042)

2011-05-12 Thread Trevor Daniels
Neil wrote Wednesday, May 11, 2011 7:28 PM LGTM. Thanks! I'll push after a couple of days if there are no more comments. http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode3 input/regression/clef-octavation.ly:3: \header{ \header { Done

Re: Might understand this music stuff a bit better in the future

2011-05-12 Thread Trevor Daniels
Graham Percival wrote Thursday, May 12, 2011 1:06 PM Also, isn't the (Hons) decided when you graduate, not when you appy? ;) Many UK universities have both Hons and Ord courses from the outset (or at least they used to when I was involved with them.) Students can also opt to drop from

Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042)

2011-05-10 Thread Trevor Daniels
Janek Warchoł wrote Tuesday, May 10, 2011 6:11 AM I remember that someone once told me that such canges should be done separately from the actual coding stuff - that's why i thought your changes were accidental (i didn't examine them closely indeed). Honestly i'm not sure if this policy of

Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042)

2011-05-08 Thread Trevor Daniels
lemniskata.bernoull...@gmail.com wrote Sunday, May 08, 2011 7:17 AM Style nitpick. http://codereview.appspot.com/4489042/diff/1/lily/side-position-interface.cc#newcode65 lily/side-position-interface.cc:65: bool include_staff = I see quite a lot of whitespace diffs here and there. IIRC we

Re: Fix error messages in website build (issue4428077)

2011-05-07 Thread Trevor Daniels
Phil Holmes wrote Saturday, May 07, 2011 10:39 AM OK. I'm not understanding how Rietveld works. On my machine I have 2 separate patches. The first is the one you responded LGTM to and I still have. My aim was then to do some more work to get rid of the rest of the warning, building on

Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042)

2011-05-06 Thread Trevor Daniels
Carl, you wrote Friday, May 06, 2011 11:26 PM LGTM. Thanks! I tried fixing this but couldn't track down all the interfaces to figure it out. I saw that we were going off staff position rather than parent position, but didn't know where to fix it. I've done little else in my LilyPond

Re: Doc: Adjusted CG Policy on @lilypond[] variables (issue4445070)

2011-05-02 Thread Trevor Daniels
pkx1...@gmail.com wrote Monday, May 02, 2011 5:22 PM http://codereview.appspot.com/4445070/diff/4001/Documentation/contributor/doc-work.itexi#newcode314 Documentation/contributor/doc-work.itexi:314: inlcude the @code{papersize=X} variable, where @code{X} is a defined Done the typo..where's

Re: Backporting / stable

2011-05-01 Thread Trevor Daniels
Carl Sorensen wrote Saturday, April 30, 2011 1:59 PM So it appears that the biggest source of Critical bugs, and the thing that is holding up release of 2.14, is the beam-collision-engraver. Should we try to remove the beam-collision-engraver from 2.14.0? Or should we wait for it to settle

Re: branching

2011-04-16 Thread Trevor Daniels
Carl Sorensen wrote Friday, April 15, 2011 8:40 PM How do we define the difference between stable development and unstable development? It seems to me that stable development means we pass the regtests -- we've been doing that for at least a couple of years. But we still end up with

Re: Partcombine clarification

2011-04-12 Thread Trevor Daniels
James, you wrote Tuesday, April 12, 2011 10:07 AM )bruys . notenoir at gmail.com writes: ) ) I wondered if ) \partcombine is supposed to work with more than two parts. The ) documentation refers to combining several parts, but only shows ) examples with two parts. The word several is used

Re: Add some polyphonically directed grobs (issue4387046)

2011-04-12 Thread Trevor Daniels
bordage.bertr...@gmail.com Ok. But you agree with the other grobs ? I'm not sure (best be cautious this time :) In keyboard music multiple voices have to be used when notes with different durations occur at the same time, but normally a cautionary accidental would be placed above the staff

Re: please close rietveld issues after pushing

2011-04-07 Thread Trevor Daniels
Graham Percival wrote Thursday, April 07, 2011 12:46 AM If you've put anything on rietveld recently, please go here: http://codereview.appspot.com/mine You'll probably see a bunch of issues under created by me. If you recognize anything that you pushed, could you go to that issue, click

Re: Adds stem acknowledgement to beam collision engraver to fix issue 795. (issue4337045)

2011-04-06 Thread Trevor Daniels
mts...@gmail.com wrote Tuesday, April 05, 2011 10:35 PM I'd like to get this pushed in the next 24 hours if possible (which will require 2 LGTMs). This way, { c'8 [ s c' ] } \\ { s c''8 s } will be prettier. Here's one. LGTM. It certainly improves the revised regtest, but I don't

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-04 Thread Trevor Daniels
Han-Wen Nienhuys wrote Monday, April 04, 2011 6:13 AM I think it is good that these are fixed, but not important enough to spend serious time on finding and plugging all of them. The question is how much of the code we should consider user-serviceable. If one C++ part of Lily passes data

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Trevor Daniels
Werner LEMBERG wrote Sunday, April 03, 2011 7:16 AM (lily segfaults all the time when I accidentally feed her a PDF file instead of a .ly file, but I don't consider this to be a bug) I do. Any user program *must not* produce a segfault IMHO if fed with user data, regardless of its

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Trevor Daniels
m...@apollinemike.com wrote Sunday, April 03, 2011 7:31 PM I'll chime in here and say that I am still for applying my patch to beam quanting as a general fix. I agree that refining how stems meet up w/ noteheads is a better solution, but I think the bigger problem lies in the fact that

Re: Search of context hierarchy for voice for lyrics is made optional (issue4323045)

2011-04-02 Thread Trevor Daniels
From: d...@gnu.org Personally, I think that an association with some respective higher context (aka inheritance) is such a common type of operation that we should rather try thinking about how to provide a general mechanism for this kind of thing rather than a one-shot special mechanism just

Re: Search of context hierarchy for voice for lyrics is made optional (issue4323045)

2011-03-31 Thread Trevor Daniels
http://codereview.appspot.com/4323045/diff/1/ly/engraver-init.ly#oldcode424 ly/engraver-init.ly:424: instrumentName = #'() I'm missing something from the commit message -- why are you removing these? They were in the context definition twice, so I deleted one of the duplicates. Sorry, I

Re: Don't set 'tieMelismaBusy until old waiting heads have been cleared (issue4309052)

2011-03-28 Thread Trevor Daniels
percival.music...@gmail.com wrote Monday, March 28, 2011 3:02 PM Time for complaints is over; please push. http://codereview.appspot.com/4309052/ Actually the time-out is 23.59 tonight. I'll wait 'til then. (But I already pushed http://codereview.appspot.com/4313047/, which times out

Re: Suppress continuing LyricHyphen under grace note at start of line (issue4313047)

2011-03-28 Thread Trevor Daniels
n.putt...@gmail.com wrote Monday, March 28, 2011 9:17 PM I hope you don't mind the following late comments. :) Not at all; I pushed it earlier than I should anyway. Thanks! http://codereview.appspot.com/4313047/diff/1/input/regression/lyric-hyphen-grace.ly#newcode15

Re: shortened flags affair, part 7 - downstem full-length 64th and 128th flags

2011-03-18 Thread Trevor Daniels
Janek Warchoł wrote Friday, March 18, 2011 11:41 AM I've prepared flag touch-ups, including changes suggested by Carl. They are here: http://codereview.appspot.com/4273074/ I attach a simple proof-sheet showing these changes. I prefer your suggested flags. Thanks. Trevor

Re: Messed up adding issue 1499

2011-03-14 Thread Trevor Daniels
Graham Percival wrote Wednesday, February 02, 2011 7:42 PM On Wed, Feb 02, 2011 at 11:37:43AM -, Trevor Daniels wrote: Graham Percival wrote Tuesday, February 01, 2011 9:28 PM If you mean why can't I be set to be the owner of this issue, then... I couldn't set it to you

Re: Indexing the new spacing properties

2011-03-14 Thread Trevor Daniels
James Lowe wrote Friday, March 11, 2011 11:34 PM From: Trevor Daniels [t.dani...@treda.co.uk] I just noticed that none of the new spacing properties in spacing.itely have @funindex entries. These are needed so people can follow-up error messages like staff-affinities should only decrease

Re: shortened flags affair, part 5 - length of notes extending far from staff

2011-03-10 Thread Trevor Daniels
Janek Warchoł wrote Wednesday, March 09, 2011 11:11 PM next thing is to decide what the output of { c32 c[ c] c64 c[ c] } should be. Currently the stems of unbeamed notes are lenghtened to middle line only (current output.png). In my opinion this looks weird, i'd suggest something like

Re: [PATCH] ly/property-init.ly: remove cautionary accidentals inimprovisation

2011-03-09 Thread Trevor Daniels
Hi Xavier Thanks. Pushed to origin/master. Trevor - Original Message - From: Xavier Scheuer x.sche...@gmail.com To: lilypond-devel lilypond-devel@gnu.org Cc: e.cauchemez e.cauche...@laposte.net Sent: Wednesday, March 09, 2011 2:51 PM Subject: [PATCH] ly/property-init.ly: remove

Re: shortened flags affair, part 3 - 32nds stem length

2011-03-08 Thread Trevor Daniels
Janek Warchoł wrote Tuesday, March 08, 2011 3:42 PM i don't see any discussion going on here, so i assume you agree to shortening the 32nd unbeamed stem. I attach the patch. I'm happy with it. Trevor ___ lilypond-devel mailing list

Re: shortened flags affair, part 4 - downstem 8th flag

2011-03-06 Thread Trevor Daniels
Janek Warchoł wrote Sunday, March 06, 2011 1:54 AM I was curious too, so i wrote it down. Indeed it looks like he used non-default layout (by default Lily uses 3 systems), but i won't call it non-optimal. In my opinion fitting this music in two systems is perfectly reasonable here (and

Re: a list of manually fine-tuned beaming exceptions?

2011-03-06 Thread Trevor Daniels
m...@apollinemike.com wrote Saturday, March 05, 2011 11:05 PM On Mar 5, 2011, at 17:33, Janek Warchoł lemniskata.bernoull...@gmail.com wrote: 2011/3/5 Trevor Daniels t.dani...@treda.co.uk: When I suggested investigating the automatic beaming I didn't mean messing with the code

Re: shortened flags affair, part 3 - 32nds stem length

2011-03-05 Thread Trevor Daniels
Janek Warchoł wrote Friday, March 04, 2011 11:42 PM this is the next step of making stems and flags more beautiful: i suggest making unbeamed 32nd stems a bit shorter than they are now. The main reason for doing so is to better match the stem length of the beamed notes. As we know, the

Re: a list of manually fine-tuned beaming exceptions?

2011-03-05 Thread Trevor Daniels
Janek Warchoł wrote Saturday, March 05, 2011 12:05 PM while i'd love to improve beaming algorithm itself so that it would produce perfect beams on its own, it's a task way beyond my current skills. Still some wrong beams bother me very much, for example this one \relative c'' { b8[ a16 g]

Fw: VirtualBox

2011-03-04 Thread Trevor Daniels
Hi Phil I did this a few days ago. No problems. I sent a note about it to -devel, but it didn't seem to get distributed. I've attached it. Trevor - Original Message - From: Phil Holmes m...@philholmes.net To: lilypond-devel@gnu.org Sent: Friday, March 04, 2011 12:58 PM Subject:

Re: Doc: harmonics and slides (issue4186049)

2011-03-04 Thread Trevor Daniels
Patrick Schmidt wrote Friday, March 04, 2011 4:17 PM Hmm, it doesn't apply for me. Could you do a git pull -r , and then try making the patch again? Sorry for that. Don't know what I'm doing wrong. How about this one? The problem is the line endings. They are DOS but should be Unix in

Re: 13.52 regtests

2011-03-02 Thread Trevor Daniels
Phil Holmes m...@philholmes.net wrote in message news:iklsd6$r1v$1...@dough.gmane.org... lyrics-bar.png - the music now breaks over the line to accommodate the text (which is OK), but see the no now sitting in the stave. Anyone know what's going on here? This is OK. The no is part of

Re: improving the transition between full-length and shortenedstems. (issue4210051)

2011-03-02 Thread Trevor Daniels
Janek Warchoł wrote Wednesday, March 02, 2011 8:53 PM 2011/3/1 Trevor Daniels t.dani...@treda.co.uk Yes, they are longer, but the stems on the full-size notes look too long in this context to my eye. I've attached the output from 2.13.52. In my opinion it is ok. It's OK; just

Re: improving the transition between full-length and shortenedstems. (issue4210051)

2011-02-28 Thread Trevor Daniels
Graham Percival wrote Monday, February 28, 2011 7:39 AM On 2/27/11, Janek Warchoł lemniskata.bernoull...@gmail.com wrote: Here you are. This contains all the changes and should apply cleanly to origin/master. Thanks, pushed. This commit causes many changes to the reg tests due to the

Regression test failure in 2.13.52

2011-02-27 Thread Trevor Daniels
Several regression tests fail in 2.13.52. Beams are misplaced, some randomly in different runs, and some fail with no beam positions? error. Here's the output of one: GNU LilyPond 2.13.52 Processing `collision-merge-differently-dotted.ly' Parsing... Interpreting music... Preprocessing

Re: 13.51 regtests

2011-02-24 Thread Trevor Daniels
Francisco Vila wrote Wednesday, February 23, 2011 6:38 PM 2011/2/23 Phil Holmes m...@philholmes.net: Another change I don't understand. Although I don't understand much about regtests, this difference could show that printing order of objects in the same layer (with the same value of the

Re: pdfTex failure

2011-02-24 Thread Trevor Daniels
Graham Percival wrote Wednesday, February 23, 2011 2:23 AM On Tue, Feb 22, 2011 at 04:33:34PM +, James Lowe wrote: Hello )After increasing save size to 1 the doc build completed perfectly, so )all is OK at the moment, but as I hacked a file which says don't hack this )I guess it

Re: pdfTex failure

2011-02-22 Thread Trevor Daniels
Graham, you wrote Sunday, February 20, 2011 10:07 PM On Thu, Feb 17, 2011 at 11:47:17PM -, Trevor Daniels wrote: make doc was failing for me with TeX capacity exceeded, sorry [save size=5000]. I hacked etc/texmf/texmf.cnf to increase save size, which allowed make doc to proceed

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-18 Thread Trevor Daniels
From: percival.music...@gmail.com Thursday, February 17, 2011 6:32 PM Ok, it seems we're all ok with this. Keith, please email the patch to Trevor for pushing. http://codereview.appspot.com/4187043/ Pushed: 6d751144f402dc58ff3f65df0fcaab021a86908c and reg tests bumped to 2.13.51:

Re: Add modal transformations provided by Mike Ellis (issue4079064)

2011-02-17 Thread Trevor Daniels
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely#newcode830 Documentation/notation/pitches.itely:830: left untransformed and a warning given.} I'd omit the and a warning given. I mean, the warning will be obvious, right? Just end with ... left

Re: Add modal transformations provided by Mike Ellis (issue4079064)

2011-02-17 Thread Trevor Daniels
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely#newcode861 Documentation/notation/pitches.itely:861: A scale of any length and with any intervals may be specified: An ascending scale of any length ... The octaves are linked smoothly if the scale is

pdfTex failure

2011-02-17 Thread Trevor Daniels
Graham (or any TeX wizard) make doc was failing for me with TeX capacity exceeded, sorry [save size=5000]. I hacked etc/texmf/texmf.cnf to increase save size, which allowed make doc to proceed, but what is the correct way to fix this? Trevor

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-16 Thread Trevor Daniels
percival.music...@gmail.com http://codereview.appspot.com/4160048/diff/11001/Documentation/notation/rhythms.itely#newcode2229 Documentation/notation/rhythms.itely:2229: changed, so that when the time signature is set the desired What about: ... changed, so that the desired beaming is always

Re: Lyric alignment

2011-02-16 Thread Trevor Daniels
Carl Sorensen wrote Saturday, February 12, 2011 9:09 PM I've attached a .ly file and its output. I think it gives the desired output. I'd welcome any comments. Looks useful. What about adding a third argument so 'staff-affinity becomes set within the function too? \setLyricSpacing #25

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-16 Thread Trevor Daniels
Keith OHara wrote Wednesday, February 16, 2011 8:54 PM On Wed, 16 Feb 2011 08:08:10 -0800, tdanielsmu...@googlemail.com wrote: On 2011/02/15 18:36:06, Keith wrote: If there is /any/ protrusion on the lyrics side of the staff, anywhere in the score, then the PaperColumn skylines used for

Re: Add modal transformations provided by Mike Ellis (issue4079064)

2011-02-15 Thread Trevor Daniels
percival.music...@gmail.com wrote Saturday, February 05, 2011 6:20 PM http://codereview.appspot.com/4079064/diff/1/Documentation/notation/pitches.itely#newcode827 Documentation/notation/pitches.itely:827: it may be converted to its @notation{retrograde} (written backwards). I'm not certain

Re: Lyric alignment

2011-02-14 Thread Trevor Daniels
Carl Sorensen wrote Saturday, February 12, 2011 3:39 PM On 2/12/11 6:39 AM, Phil Holmes m...@philholmes.net wrote: and go to Spacing of non-staff lines and then mod that a bit, we get the attached file (it's a bit long for in-line, IMO). This produces the output attached. Don't think

Re: pushing patches

2011-02-13 Thread Trevor Daniels
Graham, you wrote Sunday, February 13, 2011 2:32 AM Hey guys, could you push your patches that have passed review? That's: 1499 Modal transformations Still waiting for an update from Mike Ellis. 1426 Better support for beat slashes 1211 Optimizations for pure-heigh approximations Cheers,

Re: use of @I{} in documentation

2011-02-12 Thread Trevor Daniels
Carl Sorensen wrote Saturday, February 12, 2011 4:03 AM In my opinion, we should never use direct formatting commands such as @i{} in the text. We want logical descriptors, rather than formatting descriptors. Does anybody else agree with me? Yes, I do. Although it was quite likely

Re: Add Modal transformations (issue4126042)

2011-02-05 Thread Trevor Daniels
Pal wrote Friday, February 04, 2011 5:11 PM http://codereview.appspot.com/4126042/diff/3009/scm/modal-transforms.scm#newcode68 scm/modal-transforms.scm:68: (lambda (pivot-pitch pitch) I'm afraid this is not a good interface, as there are inversions where the pivot is between two notes. e.g.

Re: Add Modal transformations (issue4126042)

2011-02-05 Thread Trevor Daniels
Changes made in http://codereview.appspot.com/4079064/ - Original Message - From: n.putt...@gmail.com Sent: Friday, February 04, 2011 10:24 AM Subject: Re: Add Modal transformations (issue4126042)

Re: Add Modal transformations (issue4126042)

2011-02-05 Thread Trevor Daniels
Changes in http://codereview.appspot.com/4079064/ From: percival.music...@gmail.com Sent: Friday, February 04, 2011 1:43 AM Subject: Re: Add Modal transformations (issue4126042) LGTM. I don't think you need to wait until Sat. Perhaps I should have waited :(

Re: Add Modal transformations (issue4126042)

2011-02-05 Thread Trevor Daniels
Michael Ellis wrote Saturday, February 05, 2011 4:23 PM In practice, it will be more efficient to code it as Pal suggests, with two index operations -- although I have no idea whether the efficiency gain would be significant in terms of LilyPond's total processing overhead. I'm not unhappy

Re: Add Modal transformations (issue4126042)

2011-02-03 Thread Trevor Daniels
Keith wrote Thursday, February 03, 2011 7:22 AM http://codereview.appspot.com/4126042/diff/5002/ly/music-functions-init.ly#newcode465 ly/music-functions-init.ly:465: modalInversion = Since it is an operator, should it be a verb, modalInvert ? The distinction between \transpose and

Re: Add Modal transformations (issue4126042)

2011-02-03 Thread Trevor Daniels
Graham Percival wrote Wednesday, February 02, 2011 7:38 PM IIRC, diatonic can refer to any church mode. Let me rephrase / alter my initial suggestion: might it be worth having some predefined scales for actually well-defined scales? Like \major or \locrian or the like? They could go in a

Re: Add Modal transformations (issue4126042)

2011-02-03 Thread Trevor Daniels
Benkő Pál wrote Thursday, February 03, 2011 3:28 PM I think for these purposes all church modes are equivalent. the different minor scales are truly different. Don't some church modes have an optional flat? For pentatonic scales there are even more in common use, I believe. Even the five

Re: Messed up adding issue 1499

2011-02-02 Thread Trevor Daniels
Graham Percival wrote Tuesday, February 01, 2011 9:28 PM On Tue, Feb 01, 2011 at 09:09:50PM -, Trevor Daniels wrote: Any idea why my entry as contributor fails? It looks right. If you mean why couldn't I edit that field, then I'd double-check that you're logged in. If you mean why

Messed up adding issue 1499

2011-02-01 Thread Trevor Daniels
While adding issue 1499 I inadvertently made John Mandereau the owner. Sorry John! Phil, could you please fix this up for me? Although I am listed as a contributor the entry for me that appears in the pull-down list for owner is not acceptable for some reason. Trevor

Re: Messed up adding issue 1499

2011-02-01 Thread Trevor Daniels
Graham Percival wrote Tuesday, February 01, 2011 7:16 PM On Tue, Feb 01, 2011 at 04:18:38PM -, Trevor Daniels wrote: Phil, could you please fix this up for me? Although I am listed as a contributor the entry for me that appears in the pull-down list for owner is not acceptable for some

Re: fine-tuning new flags - feedback needed

2011-01-30 Thread Trevor Daniels
Nice work! My preference is the compromise solution too, for both stems up and stems down Trevor - Original Message - From: Janek Warchoł lemniskata.bernoull...@gmail.com To: lilypond-devel@gnu.org; Carl Sorensen c_soren...@byu.edu; Werner LEMBERG w...@gnu.org; Xavier Scheuer

Re: NR 2.1.2 Lyrics and repeats, improvement proposals

2011-01-27 Thread Trevor Daniels
Xavier Scheuer wrote Thursday, January 27, 2011 1:06 PM Issue #1401: Doc: NR 2.1.2 Lyrics and repeats, improvement proposals http://code.google.com/p/lilypond/issues/detail?id=1401 has been opened further to my message. Could you update it accordingly? OK, I'll have a look. Also Mats

Re: Pentatonic Diatonic Transposition?

2011-01-24 Thread Trevor Daniels
Thanks Carl. I'll check with Mike to see how he'd like to proceed with this. Trevor - Original Message - From: Carl Sorensen c_soren...@byu.edu To: Trevor Daniels t.dani...@treda.co.uk; LilyPond-Devel list lilypond-devel@gnu.org Sent: Monday, January 24, 2011 2:08 AM Subject: Re

Re: Vocal headword

2011-01-23 Thread Trevor Daniels
Francisco Vila wrote Sunday, January 23, 2011 10:01 AM The patch (attached) for English docs only; compiles fine. Not my most favourite piece of vocal music, but it makes a fine headword! LG to push TM. Trevor ___ lilypond-devel mailing list

Re: global staff-staff spacing fails in 2.13.46

2011-01-21 Thread Trevor Daniels
Trevor Daniels wrote Wednesday, January 19, 2011 12:43 PM Keith OHara wrote Wednesday, January 19, 2011 7:25 AM Follow-up patch attached. This looks fine to me. I'll push it in a day or two if there are no adverse comments. Pushed. Trevor

Re: Example for melismaBusyProperties in NR extremely misleading

2011-01-21 Thread Trevor Daniels
Reinhold Kainhofer wrote Thursday, January 20, 2011 7:31 PM In NR 2.1.1 (Multiple notes to a syllable) we have an example for melismaBusyProperties, which is extremely misleading, as it gives the expression that this property can be used to skip notes without assigning a lyrics syllable:

Re: global staff-staff spacing fails in 2.13.46

2011-01-19 Thread Trevor Daniels
Keith OHara wrote Wednesday, January 19, 2011 7:25 AM Follow-up patch attached. The misleading bit was the implication that the properties always contain alists, when one of them is by default a function returning whichever alist is appropriate depending on whether the staff is in a

Re: Docs: automatic accidentals (was: Odd output)

2011-01-19 Thread Trevor Daniels
Thanks Keith Pushed Trevor - Original Message - From: Keith OHara k-ohara5...@oco.net To: James Lowe james.l...@datacore.com; lilypond-devel@gnu.org Cc: Trevor Daniels t.dani...@treda.co.uk Sent: Wednesday, January 19, 2011 7:25 AM Subject: Re: Docs: automatic accidentals (was: Odd

Re: global staff-staff spacing fails in 2.13.46

2011-01-16 Thread Trevor Daniels
:? But the first method fails on (at least) staff-staff-spacing. Trevor - Original Message - From: Keith OHara k-ohara5...@oco.net To: James Worlton jworl...@gmail.com; lilypond-u...@gnu.org Cc: lilypond-devel@gnu.org; Trevor Daniels t.dani...@treda.co.uk Sent: Sunday, January 16, 2011 1

Re: Text at linebreaks

2011-01-07 Thread Trevor Daniels
Graham Percival wrote Friday, January 07, 2011 11:01 AM I'd quite like to go with a default good output; optional poor output but faster processing policy. +1 Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: critical issues

2011-01-01 Thread Trevor Daniels
Graham Percival wrote Saturday, January 01, 2011 7:16 AM Nope, for precisely the reason you gave earlier: our documentation generally has zero input from programmers, so it's not at all a good representation of what's intended. We have a set of intended to be working examples. They're

Re: critical issues

2010-12-31 Thread Trevor Daniels
Graham Percival wrote Friday, December 31, 2010 11:20 PM On Thu, Dec 30, 2010 at 08:43:36PM +, Keith OHara wrote: Trevor Daniels t.daniels at treda.co.uk writes: Graham Percival wrote Thursday, December 30, 2010 3:56 AM I want to keep the word intentionally, though

Re: critical issues

2010-12-30 Thread Trevor Daniels
Graham Percival wrote Thursday, December 30, 2010 3:56 AM On Wed, Dec 29, 2010 at 12:32:56PM -, Phil Holmes wrote: From: Carl Sorensen c_soren...@byu.edu On 12/28/10 4:18 PM, Graham Percival gra...@percival-music.ca wrote: The difference between Phil's version and the previous version

Re: [PATCH] Re: Clef support for cue notes (issue2726043)

2010-12-29 Thread Trevor Daniels
Reinhold Kainhofer wrote Tuesday, December 28, 2010 9:10 PM I have now uploaded a final patch for cue notes with custom clef, which I think is in a state so that it can be included in lilypond master: http://codereview.appspot.com/2726043/ Any further objectsions/suggestions? Or can I push

Re: Doc: NR cross-staff (issue3782042)

2010-12-29 Thread Trevor Daniels
tdanielsmu...@googlemail.com wrote Saturday, December 25, 2010 9:07 AM If there are no averse comments over Christmas I'll push this next week. Now pushed. Thanks again Keith. http://codereview.appspot.com/3782042/ Trevor ___

Re: [PATCH] Re: Clef support for cue notes (issue2726043)

2010-12-29 Thread Trevor Daniels
Reinhold, you wrote Wednesday, December 29, 2010 12:13 PM Am Mittwoch, 29. Dezember 2010, um 12:13:08 schrieb Trevor Daniels: I see this has been pushed now, but I wondered why ambitus was removed from the space-alist of Clef? AFAIU, the space-alist controls spacing of the current grob

Re: including gregorian.ly breaks lyrics alignment in melismas

2010-12-28 Thread Trevor Daniels
Janek Warchoł wrote Tuesday, December 28, 2010 3:28 PM 2010/12/27 Trevor Daniels t.dani...@treda.co.uk I know next to nothing about ancient notation, but whoever wrote gregorian.ly clearly intended this behaviour as the file contains the override \override SpacingSpanner #'packed-spacing

Re: DOC: NR Dynamics context and postfix dynamics (issue3743045)

2010-12-23 Thread Trevor Daniels
Thanks Keith - checked and pushed to origin/master. Trevor - Original Message - From: Keith OHara k-ohara5...@oco.net To: carl.d.soren...@gmail.com; tdanielsmu...@googlemail.com; percival.music...@gmail.com; lilypond-devel@gnu.org; re...@codereview.appspotmail.com;

Re: LM 4.4.2 \fooDown \fooUp (and how about \textDown?)

2010-12-22 Thread Trevor Daniels
Valentin Villenave wrote Tuesday, December 21, 2010 8:14 PM I've been looking at the LM 4.4.2 Placement of objects Within-staff objects, and I'm not sure we want to use Down/Left and Up/Right in the table. Yes, we all know that -1 and 1 may respectively mean either down or left and either

Re: LM 4.4.2 \fooDown \fooUp (and how about \textDown?)

2010-12-22 Thread Trevor Daniels
Carl Sorensen wrote Tuesday, December 21, 2010 10:22 PM On 12/21/10 1:14 PM, Valentin Villenave valen...@villenave.net wrote: Oh, and by the way: we have \textSpannerDown for text spanners, but not \textDown for simple TextScript objects (that are quite likely to be needed by new users).

Re: Lily dances

2010-12-22 Thread Trevor Daniels
Federico Bruni wrote Wednesday, December 22, 2010 4:10 PM 2010/12/22 Mike Solomon mike...@ufl.edu 1) svgdance.svg (best viewed in something that's not Internet Explorer - click on the notes and/or accidentals and see what happens!) Actually, only clicks on notes work here (FF4 and

Re: Doc indexing confusion

2010-12-21 Thread Trevor Daniels
http://lists.gnu.org/archive/html/lilypond-devel/2005-05/msg00200.html Mark Polesky wrote Tuesday, December 21, 2010 5:12 AM In texinfo: @cindex foo-- add foo to the concept index @findex foo-- add foo to the function index @kindex foo-- add foo to the keystroke index

Re: lilybuntu 2

2010-12-17 Thread Trevor Daniels
Colin Campbell wrote Friday, December 17, 2010 4:44 AM Hi Colin - pleased you found this easy. Just one comment .. 3. Working with source code (was section 2) * left as is, although why do we use git on Windows if we can't build? If we're pointing Windows and MacOS users to lilybuntu, let's

Re: lilybuntu 2

2010-12-17 Thread Trevor Daniels
Phil Holmes wrote Friday, December 17, 2010 10:12 AM From: Trevor Daniels t.dani...@treda.co.uk 64 bit vista. 6 Gigs RAM. The odd 1 Gig for a VM has no effect :-) Lucky you ! It certainly does on my 3Gb laptop (at its maximum). Trevor

Re: scripts/auxiliar/update-with-convert-ly.sh appears not to work on Documentation/notation/rhythms.itely

2010-12-16 Thread Trevor Daniels
Graham, you wrote Thursday, December 16, 2010 5:25 PM Could you try replacing it with an -o ? apparently -or is not posix compliant, but it doesn't say that -o is not posix. find Documentation/ -path 'Documentation/snippets' -prune -o -name '*.itely' | grep rhythms In case it's helpful,

Re: accidental.ly regtest

2010-12-14 Thread Trevor Daniels
Carl Sorensen wrote Tuesday, December 14, 2010 12:55 PM On Dec 14, 2010, at 5:45 AM, Dmytro O. Redchuk brownian@gmail.com wrote: I fail to see why this test (accidental.ly) would be less valuable if there would be \key c \major, let's say. Because you want to ensure that it behaves

<    2   3   4   5   6   7   8   9   10   11   >