Re: Gets rid of length in the docs. (issue 4965053)

2011-08-29 Thread Mike Solomon
On Aug 29, 2011, at 9:53 AM, Graham Percival wrote: On Mon, Aug 29, 2011 at 07:45:04AM +, tdanielsmu...@googlemail.com wrote: I can't say I like this change: it makes a complex user interface more complex. Shouldn't we be moving in the opposite direction? I disagree. There used to be

Re: Gets rid of length in the docs. (issue 4965053)

2011-08-29 Thread Mike Solomon
On Aug 29, 2011, at 10:55 AM, Graham Percival wrote: On Mon, Aug 29, 2011 at 09:15:54AM +0100, Trevor Daniels wrote: Graham Percival wrote Monday, August 29, 2011 8:53 AM Moral of the story? pay more attention to patch countdowns, I I've given up looking at code-change patch

Re: Uses Y-offset for stem tremolos instead of translated stencil. (issue 4867043)

2011-08-29 Thread Mike Solomon
On Aug 28, 2011, at 12:51 PM, pkx1...@gmail.com wrote: Mike I get a failed patch apply here on the current tre (28 Aug) --snip-- You were applying an old patch that conflicted with current master. I rebased and pushed as 7623fef74bf21fc726a8c60b535e7794f9776700. Also we have a number

Re: Lets auto numbering of footnotes kick in from commands alone. (issue 4837047)

2011-08-29 Thread Mike Solomon
On Aug 28, 2011, at 12:44 PM, pkx1...@gmail.com wrote: passes make and reg tests. http://codereview.appspot.com/4837047/ Pushed as 181366ec566a338c265ff4960724202d0d55ef79. Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org

beam-slope-stemlet.ly

2011-08-28 Thread Mike Solomon
Hey all, Just a note to say that the intermittent inconsistencies that I was getting in the regtests for beam-slope-stemlet.ly (check out my first e-mail about the stem patch under The Ugly) have come up again in a regtest I recently ran. I'm almost 100% positive that this is due to my stem

Going on vacation on Thursday (was Re: Gets rid of length in the docs. (issue 4965053))

2011-08-28 Thread Mike Solomon
On Aug 28, 2011, at 7:23 PM, mts...@gmail.com wrote: Hey all, I got a clean doc build with this newest patch set - please confirm. Cheers, MS http://codereview.appspot.com/4965053/ A heads up to everyone that I'm going on vacation on Thursday for two weeks and that I'll be without

Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

2011-08-27 Thread Mike Solomon
On Aug 27, 2011, at 10:40 AM, pkx1...@gmail.com wrote: ok, this passes make but I get a lot of reg tests show up but I cannot see any diffs at all (i.e no 'green' shadows that indicate the changes). Either it's unbelievably subtle or something else is triggering the reg tests to show up.

Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

2011-08-27 Thread Mike Solomon
On Aug 27, 2011, at 4:23 PM, hanw...@gmail.com wrote: I read through this patch, but I can't tell what it does or is supposed to do. Maybe one of our pure gurus should look at this. Joe? On an immediate level, it fixes Issue 910. On a more long-term level, it lays down some code that will

Re: PATCH: 48-hour countdown to 20110828

2011-08-27 Thread Mike Solomon
On Aug 27, 2011, at 4:40 AM, Colin Campbell wrote: Issue 1235: Accidental overlays stem - R 4898044: Fixes heights and pure heights of stems. Issue 1114: A later note's stem can be to the left of an earlier note's stem - R Issue 4898044: Fixes heights and pure heights of stems.

Re: PATCH: 48-hour countdown to 20:00 MDT 20110826

2011-08-25 Thread Mike Solomon
On Aug 25, 2011, at 3:56 AM, Colin Campbell wrote: For Friday, August 26 (and where did the Summer go?) Issue 509: collision nested tuplet numbers - R Issue 4808082: Prevents nested tuplets from colliding. Issue 1328: Slurs collides with fermata - R Issue 4860042: Does better

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-25 Thread Mike Solomon
On Aug 25, 2011, at 9:05 AM, Martin Tarenskeen wrote: 2. Finale's and Sibelius' MusicXML import isn't 100% perfect either. Yes, when Finale exports a MusicXML file and then imports the same MusicXML file the result will be quite good. But I would not be surprised if importing MusicXML

Re: Creates a Flag grob. (issue 4922042)

2011-08-25 Thread Mike Solomon
On Aug 25, 2011, at 12:03 PM, Mike Solomon wrote: On Aug 24, 2011, at 11:53 PM, n.putt...@gmail.com wrote: Thanks for your suggestions Neil! I'm holding off on pushing the patch because I have noticed a spacing discrepancy in a few regtests. See the attached, where old is current

Re: Creates a Flag grob. (issue 4922042)

2011-08-25 Thread Mike Solomon
On Aug 25, 2011, at 3:17 PM, Han-Wen Nienhuys wrote: On Thu, Aug 25, 2011 at 7:03 AM, Mike Solomon mike...@ufl.edu wrote: I have verified via pacifier prints that the pure heights of the flag are being taken from the stencil function and are going into the spacing engine in separation

Re: Creates a Flag grob. (issue 4922042)

2011-08-25 Thread Mike Solomon
On Aug 25, 2011, at 9:08 PM, Mike Solomon wrote: On Aug 25, 2011, at 3:17 PM, Han-Wen Nienhuys wrote: On Thu, Aug 25, 2011 at 7:03 AM, Mike Solomon mike...@ufl.edu wrote: I have verified via pacifier prints that the pure heights of the flag are being taken from the stencil function

Re: Fixes heights and pure heights of stems. (issue 4898044)

2011-08-24 Thread Mike Solomon
On Aug 24, 2011, at 12:09 AM, Janek Warchoł wrote: 2011/8/16 Han-Wen Nienhuys hanw...@gmail.com: #2) sounds neat, but maybe Janek (who has spent some time messing around with flags) wants to weigh in. As i've said in a private mail to Mike, i don't have anything against doing so. Mike

Re: Fixes heights and pure heights of stems. (issue 4898044)

2011-08-24 Thread Mike Solomon
On Aug 24, 2011, at 1:46 PM, Janek Warchoł wrote: 2011/8/24 Mike Solomon mike...@ufl.edu: On Aug 24, 2011, at 12:09 AM, Janek Warchoł wrote: 2011/8/16 Han-Wen Nienhuys hanw...@gmail.com: #2) sounds neat, but maybe Janek (who has spent some time messing around with flags) wants to weigh

Broken beams' slopes

2011-08-24 Thread Mike Solomon
Hey all, I'll be leaving on vacation in a week-ish, and as my summer-of-lily comes to a close, I can likely do one more medium-scale thing before I have to start correcting parallel fifths. I'd like to work on broken beam slopes such that a beam can break across lines and pick up where it left

Re: Broken beams' slopes

2011-08-24 Thread Mike Solomon
On Aug 24, 2011, at 5:42 PM, David Kastrup wrote: Mike Solomon mike...@ufl.edu writes: Hey all, I'll be leaving on vacation in a week-ish, and as my summer-of-lily comes to a close, I can likely do one more medium-scale thing before I have to start correcting parallel fifths. I'd like

Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060)

2011-08-23 Thread Mike Solomon
Hey all, My patch did change output (it prevented duplicate ledger lines), although I did not spot the result that Janek sees. The old patch is also flawed, in that it only changes the ledger line directly next to the accidental. The entire bounding box of the accidental should, however, be

Re: PATCH: 48-hour countdown 22:00 MDT 20110824

2011-08-23 Thread Mike Solomon
On Aug 23, 2011, at 5:31 AM, Colin Campbell wrote: For Wednesday August 25th, 22:00 Issue 1735: modifying default behaviour of tremolo slashes - R 4636081 Issue 1628: Fingerings collide with slurs when used in - R 4876051: Fixes issue 1628. Issue 1328: Slurs collides with fermata - R

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-23 Thread Mike Solomon
On Aug 23, 2011, at 6:21 AM, hanw...@gmail.com wrote: http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc File flower/polynomial.cc (right): http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc#newcode80 flower/polynomial.cc:80: return ret_max ? sols.back

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-23 Thread Mike Solomon
On Aug 23, 2011, at 6:55 AM, joenee...@gmail.com wrote: http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc File lily/bezier.cc (right): http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode239 lily/bezier.cc:239: return p.minmax (sol[LEFT][0], sol[RIGHT][0], d !=

Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060)

2011-08-23 Thread Mike Solomon
On Aug 23, 2011, at 4:03 PM, Han-Wen Nienhuys wrote: On Tue, Aug 23, 2011 at 3:59 AM, Mike Solomon mike...@ufl.edu wrote: \override Staff.Accidental #'layer = #-100 \override Staff.LedgerLineSpanner #'layer = #-101 \override Staff.Accidental #'whiteout = ##t des ces' } Which

dotcol_ variable in rhythmic-column-engraver.cc

2011-08-22 Thread Mike Solomon
This variable is unused - is it OK to get rid of it, or is someone planning on building around it (I'm pretty sure it has been just hanging out not doing anything for at least a year). Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread Mike Solomon
On Aug 22, 2011, at 12:06 PM, reinhold.kainho...@gmail.com wrote: http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly File input/regression/color.ly (right): http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24 input/regression/color.ly:24:

Re: Creates pure closures (issue 4894052)

2011-08-20 Thread Mike Solomon
On Aug 20, 2011, at 12:02 AM, Neil Puttock wrote: On 18 August 2011 13:44, Mike Solomon mike...@ufl.edu wrote: What about pure-container ? unpure-pure-container ? Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https

Re: Creates pure closures (issue 4894052)

2011-08-20 Thread Mike Solomon
On Aug 20, 2011, at 12:39 AM, n.putt...@gmail.com wrote: http://codereview.appspot.com/4894052/diff/9001/input/regression/pure-closure.ly File input/regression/pure-closure.ly (right): http://codereview.appspot.com/4894052/diff/9001/input/regression/pure-closure.ly#newcode18

Re: beamlets and tuplets

2011-08-20 Thread Mike Solomon
Can you send a test case without dots (i.e. \times 4/5 { c8 [ c16 c8 c16 c8 c8 ] } to see if that's changed in the new patch ? Cheers, MS On Aug 20, 2011, at 10:47 PM, Carl Sorensen wrote: For several weeks now, I've been working in fits and starts, with lots of dead ends, on the oldest bug

Re: Has piano pedal brackets end on the right of a note column. (issue 4899050)

2011-08-19 Thread Mike Solomon
On Aug 19, 2011, at 5:01 AM, k-ohara5...@oco.net wrote: A swing and a miss, I'm afraid. See input/regression/pedal-bracket for what the original alignment goals were. (You could expand that reg-test to cover issue 723) I think the correct fix is merely to ignore suspended heads, which

Re: Has piano pedal brackets end on the right of a note column. (issue 4899050)

2011-08-19 Thread Mike Solomon
On Aug 19, 2011, at 9:51 AM, Keith OHara wrote: You mean your new 'bound-alignment-interfaces. I didn't follow issue 620, but looking now I don't see how it helps. We would want to find the left extent of the note-heads in the main note column, excluding suspended note-heads.

Re: Lilypond's SVG output

2011-08-19 Thread Mike Solomon
On Aug 19, 2011, at 10:04 AM, Sandor Spruit wrote: Hello, I recently had an informal discussion with some collegues on the use of SVG, in general. They are in music research, I am a developer working on a completely unrelated topic - so please forgive me my ignorance w.r.t. music-related

Re: Creates pure closures (issue 4894052)

2011-08-18 Thread Mike Solomon
On Aug 18, 2011, at 1:06 PM, Reinhold Kainhofer wrote: Am Thursday, 18. August 2011, 11:21:59 schrieb mts...@gmail.com: This is a more extensible way to deal with pure properties. I'd like this patch to be the first step, with the second step being rewriting define-grob-properties.scm such

Re: Creates pure closures (issue 4894052)

2011-08-18 Thread Mike Solomon
On Aug 18, 2011, at 2:31 PM, n.putt...@gmail.com wrote: Hi Mike, I have reservations about the naming, since you're basically creating a smob which acts as a container for a pair of callbacks; it doesn't work like a simple-closure in that you can evaluate the closure and get something

Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060)

2011-08-18 Thread Mike Solomon
On Aug 18, 2011, at 2:51 PM, Han-Wen Nienhuys wrote: On Thu, Aug 18, 2011 at 9:27 AM, mts...@gmail.com wrote: I figured not making a regtest just cuz there will already be little changes to several regtests. But, I can certainly add one. Cheers, MS

Re: how many patches can we review?

2011-08-16 Thread Mike Solomon
On Aug 16, 2011, at 10:08 AM, Graham Percival wrote: We're up to 59 patches now, plus 17 patches on the plz review; no known problems list. We're losing ground quickly, and this will soon become a serious problem for developers and contributors (if it isn't already). This is not an

Re: Fixes issue 1628. (issue 4876051)

2011-08-16 Thread Mike Solomon
On Aug 16, 2011, at 1:06 PM, Han-Wen Nienhuys wrote: Your patch is doing much more than address issue 1628. Can you do just the change to the engraver to close issue 1628? Any ensuing collisions should be made into a new issue. OK. The reason that I added all that extra stuff was for a

Re: Fixes heights and pure heights of stems. (issue 4898044)

2011-08-15 Thread Mike Solomon
On Aug 15, 2011, at 11:33 PM, Neil Puttock wrote: On 15 August 2011 13:31, mts...@gmail.com wrote: Also, just a quick reply to let you know that the calc_stem_end and calc_stem_begin methods are left in the code base for people who want to override the Y-extent of the stem while

Re: \footnote 'bug' (or not?)

2011-07-25 Thread mike
for footnotes --snip-- \footnote associates a single footnote with a particular event in the music (usually a NoteEvent); in a certain sense it behaves like \tweak, though I'd suggest to Mike that it actually be changed so its behaviour is identical. Currently we have the situation where it's

Re: Makes parameters for hairpin rotation available in Scheme (issue4809051)

2011-07-25 Thread mike
On Jul 24, 2011, at 11:29 PM, Neil Puttock wrote: On 23 July 2011 15:48, mts...@gmail.com wrote: (a) is currently impossible to calculate in all circumstances, and (c) would require a code dup. I think by making these available as properties, the user can then use this data to fix the

make check still failing with midis

2011-07-24 Thread mike
Hey all, I finally got a new branch of the source up and running on my mac after updating fontforge, and even in the new branch, I get the following error during make check: LILYPOND_VERSION=2.15.6 /Library/Frameworks/Python.framework/Versions/2.7/bin/python ../../../scripts/lilypond-book.py

Grobs that are their own ancestors.

2011-07-15 Thread mike
I've now gone on a quest for parental loops in the source, and I've found some: chord-repetition.ly chord-tremolo-articulations.ly dynamics-alignment-breaker.ly dynamics-alignment-no-line.ly dynamics-glyphs.ly dynamics-line.ly dynamics-rest-positioning.ly dynamics-text-right-padding.ly

Need some input on a new patch for glissando-friendly stems

2011-06-29 Thread mike
for more formal reviewing. Thanks! ~Mike 0001-Adds-glissando-stems-to-Lilypond.patch Description: Binary data glissando-stem.ly Description: Binary data ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-13 Thread mike
On Jun 12, 2011, at 5:49 PM, n.putt...@gmail.com wrote: On 2011/06/05 10:18:18, mike_apollinemike.com wrote: On Jun 2, 2011, at 9:00 PM, mailto:n.putt...@gmail.com wrote: http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm File scm/output-lib.scm (right):

En vacances jusqu'� dimanche : on vacation until Sunday

2011-06-12 Thread Mike Solomon
Je suis en vacances en Espagne jusqu'? dimanche. En cas d'urgence, je vous prie de contacter Apolline Rov?re au +33 6 61 33 81 86. Cordialement, Mike Solomon ** I'm on vacation in Spain until Sunday. If this is an emergency, please contact Apolline Rov?re

On creating a new all-encompassing drum mode (with example)

2011-06-08 Thread Mike J. Bell
\with { \consists Parenthesis_engraver } \set DrumStaff.drumStyleTable = #(alist-hash-table mydrums) \new DrumVoice { \voiceOne \up } \new DrumVoice { \voiceTwo \down } -- Mike J. Bell on gmail ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: On creating a new all-encompassing drum mode (with example)

2011-06-08 Thread Mike J. Bell
is high, and I like Scheme to boot! =) I'll be in touch... Mike -- Mike J. Bell on gmail ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Valgrinding lilypond for a stack trace

2011-05-31 Thread Mike Solomon
Hey all, I am doing some devel on lilypond and I'm getting a persistent Scheme error at a certain point. Before I insert a litany of pretty-prints to figure out where this is happening, is there a way to valgrind lilypond so that it dumps all functions called into a file in linear order? I'd

Re: Better width functions for the current arpeggio print functions. (issue4517051)

2011-05-11 Thread mike
On May 11, 2011, at 12:02 PM, n.putt...@gmail.com wrote: http://codereview.appspot.com/4517051/diff/1/lily/arpeggio.cc File lily/arpeggio.cc (right): http://codereview.appspot.com/4517051/diff/1/lily/arpeggio.cc#newcode98 lily/arpeggio.cc:98: MAKE_SCHEME_CALLBACK (Arpeggio,

Re: [Regression] Beam_collision_engraver and StaffSymbol overrides

2011-04-08 Thread Mike Solomon
On Apr 8, 2011, at 6:41 AM, Bertrand Bordage wrote: Hello, When we use a smaller staff, Beam_collision_engraver creates collisions that where not in 2.12. \version 2.13 music = \relative c'' { e16 f e c } \\ \relative c''' { g a g e } \new Staff \music \new Staff \with {

Re: Potential fix for issue 1504. (issue4237057)

2011-03-14 Thread mike
On Mar 13, 2011, at 10:30 PM, hanw...@gmail.com wrote: http://codereview.appspot.com/4237057/diff/11001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4237057/diff/11001/lily/beam.cc#newcode206 lily/beam.cc:206: orig-set_property (feather-fraction, scm_cons

Re: Footnotes: empty fill-lines in header footer

2011-03-13 Thread Mike Solomon
On Mar 13, 2011, at 3:17 PM, Nicolas Sceaux wrote: Le 13 mars 2011 à 19:53, Nicolas Sceaux a écrit : Hi Mike, First of all, thank you very much for your precious work on footnotes. The following example demonstrates a strange behavior wrt footnotes: %% For each empty \fill-line

Re: Implements footnotes in LilyPond (issue4245062)

2011-03-06 Thread Mike Solomon
On Mar 5, 2011, at 10:43 AM, Neil Puttock wrote: On 5 March 2011 14:38, Mike Solomon mike...@ufl.edu wrote: Done - thanks for bearing with me as I learn about break-visibility. It is a corner of the code that I never had to deal with directly, so I'm still getting my sea legs. I

Re: Implements footnotes in LilyPond (issue4245062)

2011-03-05 Thread Mike Solomon
Hey all, After a bit of back and forth w/ Han Wen, I have drummed up a way to split this up such that it can be part of LilyPond in two phases. It follows his suggestion to push all of the non-balloon-related stuff first, and to push that second. It will set the stencil property of

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-04 Thread Mike Solomon
! Cheers, Mike ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-03 Thread Mike Solomon
On Mar 2, 2011, at 6:39 PM, Joe Neeman wrote: On Thu, Mar 3, 2011 at 3:08 AM, Mike Solomon mike...@ufl.edu wrote: On Mar 2, 2011, at 8:05 AM, Mike Solomon wrote: On Mar 2, 2011, at 7:23 AM, joenee...@gmail.com wrote: I haven't had time to look at this carefully, but I'll have closer

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-02 Thread Mike Solomon
On Mar 1, 2011, at 10:19 PM, pnor...@gmail.com wrote: Hi Mike, I have a quick comment for you below. Thanks, Patrick http://codereview.appspot.com/4213042/diff/24035/scm/define-stencil-commands.scm File scm/define-stencil-commands.scm (right): http://codereview.appspot.com

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-02 Thread Mike Solomon
On Mar 2, 2011, at 7:23 AM, joenee...@gmail.com wrote: I haven't had time to look at this carefully, but I'll have closer look later. What I don't understand, though, is why this problem needs such extensive changes. If it's just a matter of preventing repeated footnotes at the beginning/end

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-02 Thread Mike Solomon
On Mar 2, 2011, at 8:05 AM, Mike Solomon wrote: On Mar 2, 2011, at 7:23 AM, joenee...@gmail.com wrote: I haven't had time to look at this carefully, but I'll have closer look later. What I don't understand, though, is why this problem needs such extensive changes. If it's just a matter

Re: build failure for freebsd-x86 in beam-quanting.cc

2011-03-01 Thread Mike Solomon
On Mar 1, 2011, at 8:05 AM, Graham Percival wrote: On 2/28/11, Graham Percival gra...@percival-music.ca wrote: On 2/28/11, Jan Nieuwenhuizen jann...@gnu.org wrote: Graham Percival schreef op ma 28-02-2011 om 09:35 [+]:

msgfmt -o out/nl.mo nl.po weirdness

2011-03-01 Thread Mike Solomon
Got this during a build. msgfmt -o out/nl.mo nl.po nl.po:946: `msgid' and `msgstr' entries do not both end with '\n' msgfmt: found 1 fatal error make[1]: *** [out/nl.mo] Error 1 make: *** [install] Error 2 I think this comes from the most recent commit. Is this an OS X thing, or is it a bigger

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-03-01 Thread Mike Solomon
On Mar 1, 2011, at 4:36 PM, Neil Puttock wrote: On 28 February 2011 23:02, Mike Solomon mike...@ufl.edu wrote: I can use either (cross-staff . #t) , (Y-extent . #f) , or both depending on what floats people's boats. (Y-extent . #f) is less hackish. Done. Sorry - I've since fixed

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-28 Thread Mike Solomon
On Feb 28, 2011, at 5:42 PM, Neil Puttock wrote: On 28 February 2011 00:32, mts...@gmail.com wrote: For now, I'm just gonna remove this kludge and leave it as is. It means that certain spanners may budge when annotations are attached to them, but I'll need more time to figure out a

Re: Beam collision engraver weirdness

2011-02-28 Thread Mike Solomon
scores royally, however. The solution in my old code was to turn off collision avoidance for cross staff beams. If you think that is an acceptable solution, I can implement it. Cheers, MS On Feb 28, 2011, at 8:59 PM, Han-Wen Nienhuys wrote: Hey mike, have a look at the .ly below

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-27 Thread Mike Solomon
On Feb 27, 2011, at 4:24 PM, n.putt...@gmail.com wrote: On 2011/02/27 04:11:56, MikeSol wrote: http://codereview.appspot.com/4213042/diff/40001/lily/footnote-engraver.cc File lily/footnote-engraver.cc (right):

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-27 Thread Mike Solomon
On Feb 27, 2011, at 8:07 PM, Han-Wen Nienhuys wrote: On Sun, Feb 27, 2011 at 1:25 PM, Mike Solomon mike...@ufl.edu wrote: Should be fixed... Can you dedicate a commit to documenting/commenting how the engraver deals with beams? I couldn't work out reading how the engraver deals with (auto

Beam collision push

2011-02-24 Thread Mike Solomon
to Neil. Please, again, I urge you to undo this before people start building on it. I do not believe that it is a tractable long-term solution, and I feel that pushing this early kills any dialogue on a better way of going about this. ~Mike

Re: Draws a line above footnotes (issue4213042)

2011-02-23 Thread Mike Solomon
On Feb 23, 2011, at 2:19 AM, Joe Neeman wrote: On Wed, Feb 23, 2011 at 3:14 PM, Mike Solomon mike...@ufl.edu wrote: On Feb 22, 2011, at 7:17 PM, joenee...@gmail.com wrote: On 2011/02/22 15:23:00, MikeSol wrote: On 2011/02/22 01:05:49, joeneeman wrote: Have you checked the performance

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-23 Thread Mike Solomon
On Feb 23, 2011, at 11:16 PM, Joe Neeman wrote: On Thu, Feb 24, 2011 at 2:49 PM, Han-Wen Nienhuys hanw...@gmail.com wrote: On Wed, Feb 23, 2011 at 11:11 PM, Joe Neeman joenee...@gmail.com wrote: - SCM footnotes_ to Stencil, - scm_gc_mark (footnotes_) to Stencil::mark_smob (for SCM

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-23 Thread Mike Solomon
On Feb 23, 2011, at 11:18 PM, Mike Solomon wrote: On Feb 23, 2011, at 11:16 PM, Joe Neeman wrote: On Thu, Feb 24, 2011 at 2:49 PM, Han-Wen Nienhuys hanw...@gmail.com wrote: On Wed, Feb 23, 2011 at 11:11 PM, Joe Neeman joenee...@gmail.com wrote: - SCM footnotes_ to Stencil

Re: Draws a line above footnotes (issue4167063)

2011-02-22 Thread Mike Solomon
I cooked up something that more or less does the job. It's up on Rietveld. Cheers, MS foo.ly Description: Binary data foo.pdf Description: Adobe PDF document On Feb 22, 2011, at 12:24 PM, bordage.bertr...@gmail.com wrote: I meant : we can't use this to do a footnote when in a markup or

Re: Draws a line above footnotes (issue4167063)

2011-02-22 Thread Mike Solomon
On Feb 22, 2011, at 7:17 PM, joenee...@gmail.com wrote: On 2011/02/22 15:23:00, MikeSol wrote: On 2011/02/22 01:05:49, joeneeman wrote: Why not make the separator a (stencil-valued) property of the paper-book? I could, but currently, this patch employs its current stencil kludge for the

Footnotes in lilypond patch

2011-02-20 Thread Mike Solomon
that kinda sorta maybe works. Note that it only works w/ the optimized page breaker - it'll need 20ish more lines of code to work for other page breakers. Cheers, Mike 0001-Footnote-sketch.patch Description: Binary data pagebreak.ly Description: Binary data

Fix to clarinet key names (issue 4182071)

2011-02-19 Thread Mike Solomon
Should do the trick. http://codereview.appspot.com/4182071 I have no clue how convert-ly works: would anyone like to take on the task of implementing these conversions in that script? Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org

More on 1504

2011-02-15 Thread Mike Solomon
This snippet of code: \paper { ragged-right = ##t } \new Staff { \relative c' { \cadenzaOn \override Beam #'breakable = ##t \override Beam #'grow-direction = #RIGHT a32 [ b c d e f \bar \break g ] } } \new Staff { \relative c' { \cadenzaOn \override Beam #'breakable = ##t \override Beam

Issue 4160050 : First attempt at tackling issue 1504

2011-02-12 Thread Mike Solomon
http://codereview.appspot.com/4160050 I think I have the slopes right, but I have not tocuhed the Y offset yet because I don't get the difference between: local_slope * (segments[i].horizontal_[LEFT] - span.linear_combination (feather_dir)) and pos.linear_combination (feather_dir) in

Re: collision between beams and grace notes

2011-02-08 Thread Mike Solomon
On Feb 7, 2011, at 3:17 PM, Werner LEMBERG wrote: [git commit cfe87695] \version 2.13.49 \header { texidoc = The beaming algorithm should handle collisions between beams and grace notes too. Here is a counterexample. } \relative c' { e'8[ f e \grace { f,16[ a] } e'8] }

Re: Adds beam collision engraver (issue4128059)

2011-02-07 Thread Mike Solomon
Yikes! Sorry... http://codereview.appspot.com/4080057 is the real deal. Cheers, MS On Feb 7, 2011, at 9:30 AM, han...@google.com wrote: looks like this patch grew some erroneous edits from other commits. http://codereview.appspot.com/4128059/

Re: Feature? Bug? (part 1)

2011-02-07 Thread Mike Solomon
beambug.ly Description: Binary data probably not the most minimal example in the world, but it gets the job done! Cheers, MS On Feb 6, 2011, at 11:35 PM, Colin Campbell wrote: On Sun, 2011-02-06 at 10:14 -0500, Mike Solomon wrote: Hey all, In the attached png, you'll see

Difficult tweaks section - problem w/ tie in the example

2011-02-07 Thread Mike Solomon
While trying to eradicate the bug that's been giving me problems today, I found this: http://lilypond.org/doc/v2.13/Documentation/extending/difficult-tweaks I think it's the same issue. Das ist nicht gut :( Should I git-bisect, or is someone already working on this? ~Mike

Re: Difficult tweaks section - problem w/ tie in the example

2011-02-07 Thread Mike Solomon
On Feb 7, 2011, at 12:18 PM, Jan Warchoł wrote: 2011/2/7 Mike Solomon mike...@ufl.edu: Is it supposed to be repositioned so high on the staff? Cheers, MS I see 'extra-offset '(-2 . 5) and the tie is just about 2 staffspaces to the left and 5 staffspaces above its default position, so

Feature? Bug? (part 1)

2011-02-06 Thread Mike Solomon
Hey all, In the attached png, you'll see that the feathered beam resets to 0 feather @ the line break. Actually, it even regresses a bit: you'll see that it's actually fatter at the linebreak than it is a couple beats after, after which it starts to spread out again. I would argue that the

Feature? Bug? (part 2)

2011-02-06 Thread Mike Solomon
Well, no, I lied, just plain bug. I can't imagine this being a feature. But, before I start working on it, does anyone have a clean work-around to get the bendAfter spanning the line break correctly? Cheers, MS inline: bendbug.png \score { \new Staff { s1*3 \break } \relative c' { s1*2

Feature? Bug? (third and final part)

2011-02-06 Thread Mike Solomon
To round out my feature/bug tryptych (yes, this is the day that I make my score not look crappy...sorry for all the traffic @ once...) inline: staffbug.png \relative c'' { b1 \stopStaff \override Staff . StaffSymbol #'line-count = #1 \startStaff \tempo Langsam b1 b1 b1 } \relative c'' { b1

Re: Introduce Beam_scoring_problem::quant_range, for quickly filtering out invalid positions. (issue4129050)

2011-02-05 Thread Mike Solomon
On Feb 5, 2011, at 7:40 AM, Han-Wen Nienhuys wrote: On Fri, Feb 4, 2011 at 1:30 PM, Mike Solomon mike...@ufl.edu wrote: On Feb 4, 2011, at 10:19 AM, Han-Wen Nienhuys wrote: On Fri, Feb 4, 2011 at 10:08 AM, mts...@gmail.com wrote: LGTM, but I can't do a regtest today :( http

Re: Introduce Beam_scoring_problem::quant_range, for quickly filtering out invalid positions. (issue4129050)

2011-02-04 Thread Mike Solomon
On Feb 4, 2011, at 10:19 AM, Han-Wen Nienhuys wrote: On Fri, Feb 4, 2011 at 10:08 AM, mts...@gmail.com wrote: LGTM, but I can't do a regtest today :( http://codereview.appspot.com/4129050/diff/1/lily/beam-quanting.cc File lily/beam-quanting.cc (right):

Re: PATCHES: 48-hour notice for note spacing and negative frets

2011-02-03 Thread Mike Solomon
On Feb 2, 2011, at 9:32 PM, Han-Wen Nienhuys wrote:On Thu, Feb 3, 2011 at 12:26 AM, m...@apollinemike.comm...@apollinemike.com wrote:The most recent patch set only has a single pass through beam quanting. Idon't believe it adds significant overhead to a score's compile time,although I'd need

Re: PATCHES: 48-hour notice for note spacing and negative frets

2011-02-03 Thread Mike Solomon
go about sharing it w/ all interested parties staying w/in the realm of what's legal @ the same time? Cheers, MS On Feb 3, 2011, at 9:41 AM, Han-Wen Nienhuys wrote: On Thu, Feb 3, 2011 at 11:58 AM, Mike Solomon mike...@ufl.edu wrote: In the attached example bad.png, I have a difficult

Re: PATCHES: 48-hour notice for note spacing and negative frets

2011-02-03 Thread Mike Solomon
:55 AM, David Kastrup wrote: Mike Solomon mike...@ufl.edu writes: Hey all, I have scanned examples from Boulez's Third Piano Sonata, Elliot Carter's Night Fantasies, Elliot Carter's Sonata, and Stockhausen's Klavierstücke II IV. However, I don't want to go to jail for sending out a link

My issue 37 work finally on Rietveld after fixing mimetypes issue

2011-01-28 Thread Mike Solomon
http://codereview.appspot.com/4022045 Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 37 - new work

2011-01-28 Thread Mike Solomon
inline: hanwen6.png I cooked up this musical example that shows both responses to upward and downward pressure to give you an idea of where I'm coming from. Is there a way to get this type of collision avoidance w/o a 2nd quanting pass? Cheers, ~Mike On Jan 28, 2011, at 7:45 AM, Han-Wen

Re: Issue 37 - new work

2011-01-28 Thread Mike Solomon
On Jan 28, 2011, at 6:12 PM, Mike Solomon wrote: On Jan 28, 2011, at 1:15 PM, Han-Wen Nienhuys wrote: pressed send too soon. On Fri, Jan 28, 2011 at 4:14 PM, Han-Wen Nienhuys hanw...@gmail.com wrote: On Fri, Jan 28, 2011 at 11:22 AM, Mike Solomon mike...@ufl.edu wrote: I cooked up

New patch set w/ expanded regtest

2011-01-27 Thread Mike Solomon
Hey all, 0003-Tweaks-regtest-and-adds-avoid-collisions-property.patch Description: Binary data 0002-Triggers-second-quant-pass-for-collisions.patch Description: Binary data 0001-Implements-a-more-robust-solution-to-issue-37.patch Description: Binary data I still can't post properly to

Multimeasure rest print function

2011-01-27 Thread Mike Solomon
Hey all, I noticed the following lines of code in Multi_measure_rest::print (SCM smob): snip int measures = 0; SCM m (me-get_property (measure-count)); if (scm_is_number (m)) measures = scm_to_int (m); /snip It seems that the variable `measures' is unused in this function - can this

Issue 37 - new work

2011-01-26 Thread Mike Solomon
that in that particular scenario. Otherwise, all of Han-Wen's concerns are addressed. And, as before, the truly heinous collisions are unavoidable because there is no way to anticipate desired output. I still need to do a make check. Cheers, Mike 0002-Triggers-second-quant-pass-for-collisions.patch

Quanting and issue 37

2011-01-24 Thread mike
Hey all, I am trying to understand beam-quanting.cc better, and I think I know how I'm gonna tackle this. I'm going to put my collision callback before beam quanting, and then try something to the effect of: if (the beam was pushed up during the collision callback) impose an insanely

Re: Fixing issue 37 with extra position callback (issue3928041)

2011-01-24 Thread Mike Solomon
lead to a very squashed result. I'm just not sure how low is too low before you have to give up and print a collision. Cheers, MS On Jan 24, 2011, at 7:46 AM, Han-Wen Nienhuys wrote: On Mon, Jan 24, 2011 at 9:42 AM, Mike Solomon mike...@ufl.edu wrote: Fixed, although I have no idea what

Re: biweekly Critical issues plea

2011-01-19 Thread Mike Solomon
(2.13.46). Graham identifies that the output was correct on the bugtracker (2.12.3). 1/19 Mike confirms that the regression is indeed due to 1190 and realizes that he is not subscribed to the bug list. Mike proposes a patch based on the discussion between Neil and Keith, which is attached to this e

Re: biweekly Critical issues plea

2011-01-19 Thread Mike Solomon
for NonMusicalPaperColumn, whereas key signatures are completely ignored. We can ensure KeySignature is accounted for by adding it to `pure-print-callbacks'. 0001-Alternative-1472-fix.patch Description: Binary data Cheers, MS On Jan 19, 2011, at 7:22 PM, Carl Sorensen wrote: On 1/19/11 4:33 PM, Mike

Re: Fixes issue 39 by raising stems (issue3934041)

2011-01-13 Thread Mike Solomon
Thanks Keith, I think that the case you're talking about ( e'32. \\ e'2) is a problem with my code, which triggers stem raising for flags that fall on the right even though these flags do note cause intersection problems. Is there a good way to weed this out? On Jan 13, 2011, at 1:03 AM,

Re: Potential fix for issue 37

2011-01-13 Thread Mike Solomon
? Jan Mike Solomon schreef op vr 07-01-2011 om 20:54 [-0500]: Kinda meh, but it gets the job done! I've included three patches, including the original. The second preserves the flat beams but gets rid of the crashing lily, whereas the third implements some bendiness. Cheers, MS

<    1   2   3   4   >