Re: Web: revise navigation bars with CSS gradients (issue 193140043 by paulwmor...@gmail.com)

2015-01-22 Thread pkx166h
author Paul Morris paulwmor...@gmail.com Thu, 22 Jan 2015 18:09:39 + (18:09 +) committer James Lowe pkx1...@gmail.com Fri, 23 Jan 2015 03:42:30 + (03:42 +) commit 0a89d9ec5ab4b03a6396c0970aa0a227f8950c31 https://codereview.appspot.com/193140043/

Re: Articulate.ly: Fix mordent and prall timing for short notes (issue 190530043 by botialo...@gmail.com)

2015-01-21 Thread pkx166h
On 2015/01/20 22:08:16, Peter Chubb wrote: articulate.ly: Fix \trillSpan problem Peter, I can see 4 patches uploaded here but it looks like from the time stamps that this was some git-cl error or something similar? Can you confirm in case you need anything testing James

Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by pkx1...@gmail.com)

2015-01-20 Thread pkx166h
Thanks for your patience. https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely File Documentation/de/usage/running.itely (right): https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely#newcode166

Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by pkx1...@gmail.com)

2015-01-20 Thread pkx166h
On 2015/01/11 20:13:29, lemzwerg wrote: Thanks for your help and assistance! For better orientation, please reformat this to have a fixed number of entries per line (I suggest 4 items), I did 3 items maximum and kept things within the line length. Basically, this is fine. However,

Re: Web: revise navigation bars with CSS gradients (issue 193140043 by paulwmor...@gmail.com)

2015-01-19 Thread pkx166h
On 2015/01/17 16:59:29, pwm wrote: On 2015/01/16 18:26:07, J_lowe wrote: You forgot to set the tracker to patch-new ;) OK I still got failed to apply to current master when using the automatic scripts which should just scrape the download raw file from here. Manually downloading and

Re: Web: revise navigation bars with CSS gradients (issue 193140043 by paulwmor...@gmail.com)

2015-01-16 Thread pkx166h
On 2015/01/15 04:32:19, pwm wrote: The images are now included in this patch for lilypond-git and also in a pull-request to the lilypond-extra repo. (From the CG I got the impression that they only went in lilypond-extra, but on second glance it appears that they live in both places.)

Re: Enhancement: LilyPond-mode for packaging emacs 24 (issue 189520045 by pkx1...@gmail.com)

2015-01-16 Thread pkx166h
Peter, see David's comments and you can give me a new patch when you are ready for me to resubmit. James https://codereview.appspot.com/189520045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Web: revise navigation bars with CSS gradients (issue 193140043 by paulwmor...@gmail.com)

2015-01-16 Thread pkx166h
On 2015/01/16 15:37:09, pwm wrote: On 2015/01/16 09:25:19, J_lowe wrote: Fails to apply to current master. Please also make sure that when you make a new patch set you change the tracker label to patch-new so that it gets tested automatically. Ok, trying again with patch set #4. See

Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by pkx1...@gmail.com)

2015-01-14 Thread pkx166h
On 2015/01/14 08:42:27, lemzwerg wrote: Knut, *your* patch set has this, but James's version (in patch set 2) misses it. Yes that's true. I thought this was a 'lost in translation' error. So we have: +Generate really big pdf files with as less as possible +optimization of font data.

Re: Articulate.ly: Fix mordent and prall timing for short notes (issue 190530043 by botialo...@gmail.com)

2015-01-12 Thread pkx166h
On 2015/01/12 00:57:47, Dan Eble wrote: If Dr. Chubb likes Tristan's patch, please don't let my comments prevent progress. Peter can you just confirm that Tristan's patch is OK https://codereview.appspot.com/173750043 Then I can push what you sent me yesterday. James

Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by pkx1...@gmail.com)

2015-01-12 Thread pkx166h
On 2015/01/12 08:52:02, lemzwerg wrote: I don't object to the name! I only state that the option's name doesn't have an explanation in the English documentation, and I think it would be good if it gets added. Knut already did and I 'rewrote' this (as per the stated summary of patch #2).

Re: Fix trill timing in articulate.ly (issue 173750043 by tristanjela...@gmail.com)

2015-01-12 Thread pkx166h
This has been pushed: author Tristan Jelacic tristanjela...@gmail.com Mon, 12 Jan 2015 18:41:33 + (18:41 +) committer James Lowe pkx1...@gmail.com Mon, 12 Jan 2015 19:11:06 + (19:11 +) commit 6802aea5ad26c060c91cdff2c7b206347f58b88d you can

Re: Articulate.ly: Fix mordent and prall timing for short notes (issue 190530043 by botialo...@gmail.com)

2015-01-12 Thread pkx166h
This has been pushed: author Peter Chubb peter.ch...@nicta.com.au Mon, 12 Jan 2015 18:45:55 + (18:45 +) committer James Lowe pkx1...@gmail.com Mon, 12 Jan 2015 19:11:12 + (19:11 +) commit 88e1d22cbd8dc37a886b1733ee95c48da1b0f06d thanks for your

Enhancement: LilyPond-mode for packaging emacs 24 (issue 189520045 by pkx1...@gmail.com)

2015-01-11 Thread pkx166h
Reviewers: , Message: Patch on countdown for Jan 13th Description: Enhancement: LilyPond-mode for packaging emacs 24 Issue 4230 Ready lilypond-mode for packaging for emacs 24 package system, such that lilypond-mode will work with Melpa. Please review this at

Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by pkx1...@gmail.com)

2015-01-11 Thread pkx166h
Thanks https://codereview.appspot.com/194090043/diff/1/Documentation/de/usage/running.itely File Documentation/de/usage/running.itely (right): https://codereview.appspot.com/194090043/diff/1/Documentation/de/usage/running.itely#newcode160 Documentation/de/usage/running.itely:160: pdftex-,

Re: Articulate.ly: Fix mordent and prall timing for short notes (issue 190530043 by botialo...@gmail.com)

2015-01-11 Thread pkx166h
Peter this patch has been counted down - if you don't have push permissions, then send me a git-formatted patch and I can push it for you. Regards James https://codereview.appspot.com/190530043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc: Clarified how to use clip-systems option (issue 186640043 by pkx1...@gmail.com)

2015-01-11 Thread pkx166h
On 2015/01/11 17:43:04, Jean-Charles wrote: Sorry to come so late https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/input.itely File Documentation/notation/input.itely (right):

Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by pkx1...@gmail.com)

2015-01-11 Thread pkx166h
On 2015/01/11 20:13:46, lemzwerg wrote: https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely File Documentation/de/usage/running.itely (right): https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely#newcode160

Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by pkx1...@gmail.com)

2015-01-09 Thread pkx166h
The English Documentation is not very well written - which I completely understand of course - so once this patch has passed all the tests, and because I have the patch file (as I am managing this patch for Knut), I will re-do the English documentation. As I cannot speak German I won't touch

Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by pkx1...@gmail.com)

2015-01-08 Thread pkx166h
Reviewers: knut_petersen_t-online.de, Message: Added Knut as I 'own' this patch while it is being reviewed. James Description: Reduce size of PDF files when inc. in *TeX docs Issue 4251 This changes the way lilypond uses fonts to draw glyphs. It avoids to used glyphshow for all emmentaler

Re: Articulate.ly: Fix mordent and prall timing for short notes (issue 190530043 by botialo...@gmail.com)

2015-01-07 Thread pkx166h
Patch on countdown for Jan 10th https://codereview.appspot.com/190530043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Clarified how to use clip-systems option (issue 186640043 by pkx1...@gmail.com)

2015-01-04 Thread pkx166h
Thanks https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2541 Documentation/notation/input.itely:2541: This will extract a

Re: Edit Kievan documentation (issue 193890043 by aleksandr.andr...@gmail.com)

2015-01-04 Thread pkx166h
1. I cannot find a tracker for this issue (is that important for translations?). 2 I cannot find an equivalent set of entries in the English documentation. It looks like these translations are now out of sync with the English one. Can someone please check?

Re: Edit Kievan documentation (issue 193890043 by aleksandr.andr...@gmail.com)

2015-01-04 Thread pkx166h
On 2015/01/04 13:17:15, aleksandr.andreev wrote: On 2015/01/04 12:13:31, J_lowe wrote: 1. I cannot find a tracker for this issue (is that important for translations?). The tracker is here: https://code.google.com/p/lilypond/issues/detail?id=4241 2 I cannot find an equivalent set of

Re: Ready lilypond-mode for packaging for emacs 24 package system, such that lilypond-mode will work wi… (issue 191260043 by pe...@thoughtspot.net)

2015-01-01 Thread pkx166h
Just for the record this is logged as https://code.google.com/p/lilypond/issues/detail?id=4230 James https://codereview.appspot.com/191260043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc; CG - add more specific note for Guile (issue 193870043 by pkx1...@gmail.com)

2015-01-01 Thread pkx166h
Reviewers: Trevor Daniels, Message: On 2015/01/02 00:09:19, Trevor Daniels wrote: https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi File Documentation/included/compile.itexi (right):

Re: Ready lilypond-mode for packaging for emacs 24 package system, such that lilypond-mode will work wi… (issue 191260043 by pe...@thoughtspot.net)

2014-12-26 Thread pkx166h
On 2014/12/23 01:21:48, pschmied wrote: Hi all, I was hoping to create a lilypond-mode package to load into emacs via the excellent and popular Melpa package repository. I had done an initial packaging, however the Melpa maintainer has noted some issues with the lilypond-mode

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-12-21 Thread pkx166h
Thanks to Trevor and Heikki. Issues still to be resolved: Do we still need to move the articulate section and if so, where? https://codereview.appspot.com/120480043/diff/21/Documentation/notation/input.itely File Documentation/notation/input.itely (right):

Re: Docs: state that LilyPond input is in terms of pitches (issue 185140043 by k-ohara5...@oco.net)

2014-12-12 Thread pkx166h
https://codereview.appspot.com/185140043/diff/40001/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/185140043/diff/40001/Documentation/learning/common-notation.itely#newcode184

Re: Docs: state that LilyPond input is in terms of pitches (issue 185140043 by k-ohara5...@oco.net)

2014-12-08 Thread pkx166h
Fails make. https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely#newcode119

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-11-23 Thread pkx166h
On 2014/10/26 22:00:14, Trevor Daniels wrote: I still have a couple of difficulties with this. It is very difficult to see what articulations are represented in basic Midi output and what are not. Clear lists are needed, ideally quite early rather than buried in the detail. And

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-11-23 Thread pkx166h
With Heikki's and Trevor's suggestions https://codereview.appspot.com/120480043/diff/21/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/120480043/diff/21/Documentation/notation/input.itely#newcode2699

Re: Added recorder diagram (issue 153380043 by pkx1...@gmail.com)

2014-11-02 Thread pkx166h
I'm not comfortable pushing this, there were some things on the original email http://lists.gnu.org/archive/html/bug-lilypond/2014-10/msg00024.html (after which I offered to help move a patch through the list) that I am simply not qualified to say if it is still OK to push or still needs some

Re: Added recorder diagram (issue 153380043 by pkx1...@gmail.com)

2014-10-21 Thread pkx166h
I'm going to leave this on for another round of countdown. I know there has been some discussion on the mails from Erik (the author of the patch) but I cannot (or have not) seen any replies or confirmation this is good to push as it is. @Erik, it seemed to me there were some things that were

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-10-20 Thread pkx166h
Thanks for the input as always. Still one question remains (see thread below) https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely File Documentation/notation/input.itely (right):

Re: Added recorder diagram (issue 153380043 by pkx1...@gmail.com)

2014-10-18 Thread pkx166h
Patch on countdown for October 21st Although I am not sure if this still needs some more work based on some of the previous emails. https://codereview.appspot.com/153380043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Additions in event-listener.ly (issue 8165043)

2014-10-15 Thread pkx166h
On 2013/04/09 19:08:56, phil Hezaine wrote: only add drum-note and drum-name This has now been moved to https://codereview.appspot.com/152600043 for tracker issue http://code.google.com/p/lilypond/issues/detail?id=4164 someone asked for this on the user lists, and I saw that it had never been

Re: Added recorder diagram (issue 153380043 by pkx1...@gmail.com)

2014-10-13 Thread pkx166h
passes tests. Includes a full make doc https://codereview.appspot.com/153380043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Added recorder diagram (issue 153380043 by pkx1...@gmail.com)

2014-10-12 Thread pkx166h
Reviewers: erik.flister_gmail.com, Message: Please review and give advice. Description: Provided by Erik Flister Added recorder diagram issues still to be resolved and need help:- 1h (half-covered) works for eg 'flute two', but on my recorder thumb (T) it doesn't work it just shows fully

Re: Add an alternative Drum Style - agostini-drums-style (issue 150860044 by pkx1...@gmail.com)

2014-10-06 Thread pkx166h
Patch counted down - Frederic, can you give me a new git formatted patch (just to make sure it is rebased against current master), and I'll push it for you. James https://codereview.appspot.com/150860044/ ___ lilypond-devel mailing list

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-10-03 Thread pkx166h
Thanks Valentine https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely#newcode2654

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-10-03 Thread pkx166h
Thanks. https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely#newcode2784 Documentation/notation/input.itely:2784:

Re: Doc: Usage 1.2 - Added note about using wildcards (issue 151920044 by pkx1...@gmail.com)

2014-10-02 Thread pkx166h
Thanks David. https://codereview.appspot.com/151920044/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/151920044/diff/1/Documentation/usage/running.itely#newcode103 Documentation/usage/running.itely:103: Many standard

Re: Doc: Usage 1.2 - Added note about using wildcards (issue 151920044 by pkx1...@gmail.com)

2014-10-01 Thread pkx166h
Reviewers: dak, https://codereview.appspot.com/151920044/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/151920044/diff/1/Documentation/usage/running.itely#newcode127 Documentation/usage/running.itely:127: terminal

Re: Add an alternative Drum Style - agostini-drums-style (issue 150860044 by pkx1...@gmail.com)

2014-09-30 Thread pkx166h
New patch uploaded. https://codereview.appspot.com/150860044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Roman string numbers (issue 145490043 by v.villen...@gmail.com)

2014-09-29 Thread pkx166h
Welcome back Valentine! P.S. don't forget to update the google tracker (if not using git-cl) - Patch-New means the patch gets automatic testing. https://codereview.appspot.com/145490043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right):

Re: Roman string numbers (issue 145490043 by v.villen...@gmail.com)

2014-09-29 Thread pkx166h
:) Sorry. Some more tightening of the text. https://codereview.appspot.com/145490043/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right):

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-09-29 Thread pkx166h
Thanks Marc. https://codereview.appspot.com/120480043/diff/11/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/120480043/diff/11/Documentation/notation/input.itely#newcode2747 Documentation/notation/input.itely:2747:

Re: Roman string numbers (issue 145490043 by v.villen...@gmail.com)

2014-09-29 Thread pkx166h
Fails make: --snip-- [/tmp/lilypond-autobuild/ly/generate-documentation.ly [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/documentation-lib.scm] [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/lily-sort.scm]

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-09-27 Thread pkx166h
Note, I won't be pushing this through using 'normal' patch countdown time frames so it gets a proper review. Thanks for understanding https://codereview.appspot.com/120480043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-09-27 Thread pkx166h
Thanks Marc and Heikki. https://codereview.appspot.com/120480043/diff/11/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/120480043/diff/11/Documentation/notation/input.itely#newcode2656

Re: Add an alternative Drum Style - agostini-drums-style (issue 150860044 by pkx1...@gmail.com)

2014-09-24 Thread pkx166h
Hello, please find attached , the new version thanks for you help to create the new patch set Cordialement, GOHIER Frédéric https://codereview.appspot.com/150860044/diff/1/Documentation/notation/percussion.itely File Documentation/notation/percussion.itely (right):

Re: CG: add new instructions for LilyDev 3 (issue 2538) (issue 150830043 by fedel...@gmail.com)

2014-09-23 Thread pkx166h
Thanks Federico. https://codereview.appspot.com/150830043/diff/1/Documentation/contributor/quick-start.itexi File Documentation/contributor/quick-start.itexi (right): https://codereview.appspot.com/150830043/diff/1/Documentation/contributor/quick-start.itexi#newcode28

Add an alternative Drum Style - agostini-drums-style (issue 150860044 by pkx1...@gmail.com)

2014-09-23 Thread pkx166h
Reviewers: fgohier49_hotmail.com, Message: Please review - note I am merely shepherding this patch for Frederic Gohier. Description: Add an alternative Drum Style - agostini-drums-style An alternative to the existing drum-style provided in lilypond. This allows the typesetting of a typical

Re: Add an alternative Drum Style - agostini-drums-style (issue 150860044 by pkx1...@gmail.com)

2014-09-23 Thread pkx166h
https://codereview.appspot.com/150860044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes.tely updated - 2.19.x up to September 2014 (issue 147860043 by pkx1...@gmail.com)

2014-09-23 Thread pkx166h
https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tely#newcode104 Documentation/changes.tely:104: @end example On 2014/09/22 18:19:52, ht wrote: Just

Changes.tely updated - 2.19.x up to September 2014 (issue 147860043 by pkx1...@gmail.com)

2014-09-21 Thread pkx166h
Reviewers: , Message: Hello, if those that have put in these recent features and enhancements that are listed in this checkin to the 'Changes' list can come up with some minimal examples to illustrate them I'd be very appreciative. I don't pretend to understand all the enhancements and if you

Re: Changes.tely updated - 2.19.x up to September 2014 (issue 147860043 by pkx1...@gmail.com)

2014-09-21 Thread pkx166h
Thanks to those that checked. New patch uploaded https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode69 Documentation/changes.tely:69: \once

Re: Doc: LM - correct @example for Tweak Command (issue 140630043 by pkx1...@gmail.com)

2014-09-16 Thread pkx166h
Created new issue for the general #@var{variable} vs @var{variable} discussion. http://code.google.com/p/lilypond/issues/detail?id=4105 https://codereview.appspot.com/140630043/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right):

Re: Doc: NR and CG - fix some Doc Compilation warnings in logs (issue 143990043 by pkx1...@gmail.com)

2014-09-16 Thread pkx166h
Reviewers: Trevor Daniels, Message: On 2014/09/16 11:21:15, Trevor Daniels wrote: Looks OK to me. The alternative would be to add menu's and nodes, but I don't really mind which. Whichever looks best to you. Your choice, James. Trevor For the Contributor's Guide, in this specific case,

Re: Doc: LM - correct @example for Tweak Command (issue 140630043 by pkx1...@gmail.com)

2014-09-15 Thread pkx166h
Reviewers: dak, Message: On 2014/09/15 07:26:45, dak wrote: https://codereview.appspot.com/140630043/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/140630043/diff/1/Documentation/learning/tweaks.itely#newcode453

Re: Check for Note_column interface before using grob. (issue 141190043 by e...@ticalc.org)

2014-09-11 Thread pkx166h
Patch on countdown for September 14th https://codereview.appspot.com/141190043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Limit looping in Grob::common_refpoint (issue 4079) (issue 134600043 by e...@ticalc.org)

2014-09-10 Thread pkx166h
Passes make, make check and a full make doc but the reg tests show numerous 'Programming Errors' (see http://code.google.com/p/lilypond/issues/detail?id=4079#c4) https://codereview.appspot.com/134600043/ ___ lilypond-devel mailing list

Re: Check for Note_column interface before using grob. (issue 141190043 by e...@ticalc.org)

2014-09-09 Thread pkx166h
Dan, just note that this patch has had no testing whatsover. At this time it is just a Rietveld review so won't be considered for pushing to git. I will manually update the tracker issue for this, but please make sure that if you do any updates to an issue that you also update the tracker so

Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by janek.lilyp...@gmail.com)

2014-08-30 Thread pkx166h
On 2014/08/29 22:21:31, dak wrote: https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc File lily/note-column.cc (right): https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc#newcode167 lily/note-column.cc:167: Grob *main_head; This is a catastrophic

indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

2014-08-25 Thread pkx166h
Excuse my ignorance, is this going to need any extra documentation or perhaps a changes.tely entry? https://codereview.appspot.com/133840043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Appendix - Articulations and Ornamentation - part 3 (issue 127000043 by pkx1...@gmail.com)

2014-08-11 Thread pkx166h
Thanks, Trevor. https://codereview.appspot.com/12743/diff/20001/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right): https://codereview.appspot.com/12743/diff/20001/Documentation/notation/notation-appendices.itely#newcode1891

Re: Doc: NR Fixes mis-ordered menu section for 4.3 (issue 121310043 by pkx1...@gmail.com)

2014-08-07 Thread pkx166h
author James Lowe pkx1...@gmail.com Wed, 6 Aug 2014 21:07:49 + (22:07 +0100) committer James Lowe pkx1...@gmail.com Thu, 7 Aug 2014 18:18:38 + (19:18 +0100) commit 2bcfd84f0d276e0db06d6248ed54a05685e8cca6 Sorry for the noise. James

Re: Support for controlling MIDI expression (issue 114500045 by ht.lilypond.developm...@gmail.com)

2014-08-07 Thread pkx166h
author Heikki Tauriainen g034...@welho.com Sat, 28 Dec 2013 09:49:58 + (11:49 +0200) committer James Lowe pkx1...@gmail.com Fri, 8 Aug 2014 05:47:53 + (06:47 +0100) commit 60afb018b9ec6c6969fac90a31974a4e30cfd712 Thanks James

Support for controlling MIDI expression (issue 114500045 by ht.lilypond.developm...@gmail.com)

2014-08-05 Thread pkx166h
This has now been approved, I assume you still have push access so if so make sure you push to HEAD:staging and not directly to master. Also, as I indicated in the Tracker, does this require any additional documentation in the Notation Reference (sections 3.5.x) and if so can you make a new

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

2014-08-03 Thread pkx166h
On 2014/08/03 22:06:29, Trevor Daniels wrote: Looks good James, although the node structure looks rather suspect. I'm surprised this built without error. I've indicated some changes, but these may not be correct or complete. Please check this carefully. The text reorganisation looks fine

Re: Remove tied accidentals after line-breaking (issue 46060045)

2014-08-02 Thread pkx166h
On 2014/08/02 19:26:11, dak wrote: On 2014/08/02 18:56:19, Keith wrote: LGTM Cannot find the corresponding Google Code issue. http://code.google.com/p/lilypond/issues/detail?id=3646 https://codereview.appspot.com/46060045/ ___ lilypond-devel

Re: CG: Update of Patchy instructions (issue 112280043 by pkx1...@gmail.com)

2014-07-25 Thread pkx166h
Thanks for checking. https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor/administration.itexi File Documentation/contributor/administration.itexi (right): https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor/administration.itexi#newcode354

Re: Doc: Appendix - Articulations and Ornamentation - part 2 (issue 114840043 by pkx1...@gmail.com)

2014-07-25 Thread pkx166h
Thanks Mark. Note I went with @code{} or @code{} and have had to include a forced break for \stacatissimo as the automatic linebreak looked awkward. https://codereview.appspot.com/114840043/diff/80001/Documentation/notation/notation-appendices.itely File

Re: CG: Update of Patchy instructions (issue 112280043 by pkx1...@gmail.com)

2014-07-21 Thread pkx166h
Thanks Julien https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi File Documentation/contributor/administration.itexi (right): https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode161

Re: Doc: Appendix - Articulations and Ornamentation - part 2 (issue 114840043 by pkx1...@gmail.com)

2014-07-20 Thread pkx166h
Thanks David for the review, I have also edited the commit message. https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right):

Re: Doc: Appendix - Articulations and Ornamentation - part 2 (issue 114840043 by pkx1...@gmail.com)

2014-07-20 Thread pkx166h
You can download a 2 page PDF showing just the lilypond-book output from here: https://www.hightail.com/download/ZUcyak96Y1NCSWNkVU1UQw https://codereview.appspot.com/114840043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)

2014-07-15 Thread pkx166h
Fails make check --snip-- regression/font-expert-selection.ly --snip-- Processing `/tmp/build-lilypond-autobuild/out/lybook-testdb/73/lily-16d682d4.ly' Parsing... Renaming input to: `/tmp/lilypond-autobuild/input/regression/font-expert-selection.ly'

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by pkx1...@gmail.com)

2014-07-09 Thread pkx166h
https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely#newcode68 Documentation/changes.tely:68: Add support for @code{\once}@code{\unset} On 2014/07/04

Re: Doc: notation-appendices.itely - added 2 Clefs (issue 104520043 by pkx1...@gmail.com)

2014-07-08 Thread pkx166h
Thanks. https://codereview.appspot.com/104520043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Updated Roadmap text file (issue 106160043 by pkx1...@gmail.com)

2014-07-05 Thread pkx166h
Thanks https://codereview.appspot.com/106160043/diff/20001/ROADMAP File ROADMAP (right): https://codereview.appspot.com/106160043/diff/20001/ROADMAP#newcode21 ROADMAP:21: | | Note: Snippets and Internals Reference are auto-generated On 2014/07/04 07:28:48, Mark Polesky wrote: | |

Re: Doc: notation-appendices.itely - added 2 Clefs (issue 104520043 by pkx1...@gmail.com)

2014-07-04 Thread pkx166h
Reviewers: Mark Polesky, https://codereview.appspot.com/104520043/diff/1/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right): https://codereview.appspot.com/104520043/diff/1/Documentation/notation/notation-appendices.itely#newcode1489

Issue 3991: \magnifyMusic - reluctantly surrender to issues 3987 and 3990. (issue 101690043 by markpole...@gmail.com)

2014-07-04 Thread pkx166h
https://codereview.appspot.com/101690043/diff/20001/Documentation/notation/editorial.itely File Documentation/notation/editorial.itely (right): https://codereview.appspot.com/101690043/diff/20001/Documentation/notation/editorial.itely#newcode310 Documentation/notation/editorial.itely:310:

Re: Doc: notation-appendices.itely - added 2 Clefs (issue 104520043 by pkx1...@gmail.com)

2014-07-04 Thread pkx166h
On 2014/07/04 21:12:38, Mark Polesky wrote: On 2014/07/04 10:29:15, J_lowe wrote: The problem is (else I would have done what you suggested) is that one cannot just use \clef moderntab { c1 } and it will print like \clef tab { c1 }, so I was trying to show that to get that specific clef

Re: Doc: NR Pitches.itely - added 2 new snippets (issue 110240044 by pkx1...@gmail.com)

2014-07-01 Thread pkx166h
On 2014/07/01 06:56:42, Keith wrote: On Mon, 30 Jun 2014 14:40:17 -0700, mailto:pkx1...@gmail.com wrote: Is it worth making the Notation Reference longer? What do you suggest? Depending on your opinion about the NR length, maybe leaving these examples in lsr only.

Re: Doc: NR Pitches.itely - added 2 new snippets (issue 110240044 by pkx1...@gmail.com)

2014-06-30 Thread pkx166h
Is it worth making the Notation Reference longer? What do you suggest? https://codereview.appspot.com/110240044/diff/40001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right):

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by pkx1...@gmail.com)

2014-06-30 Thread pkx166h
Thanks https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tely#newcode141 Documentation/changes.tely:141: A new markup command @code{\justify-line} has

Re: Doc: Updated Roadmap text file (issue 106160043 by pkx1...@gmail.com)

2014-06-28 Thread pkx166h
With Mark P's comments - many thanks. It looks much better now. https://codereview.appspot.com/106160043/diff/1/ROADMAP File ROADMAP (right): https://codereview.appspot.com/106160043/diff/1/ROADMAP#newcode21 ROADMAP:21: | | Note: The Snippets and Internals manual are auto-generated On

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by pkx1...@gmail.com)

2014-06-28 Thread pkx166h
Thanks https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#newcode68 Documentation/changes.tely:68: Improved the automatic @q{x-extent} placement of

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by pkx1...@gmail.com)

2014-06-28 Thread pkx166h
Now added an example for the horizontal and parenthesis padding for fretted diagrams https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#newcode90

Re: Extending: 2.3.2 - Music Function usage (issue 108110043 by pkx1...@gmail.com)

2014-06-25 Thread pkx166h
Thanks David, Please check my changes as I really don't pretend to understand this other than from a conceptual basis. https://codereview.appspot.com/108110043/diff/20001/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right):

Re: Doc: NR Section 4.3 (issue 105370043 by pkx1...@gmail.com)

2014-06-22 Thread pkx166h
Thanks Trevor. https://codereview.appspot.com/105370043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/105370043/diff/1/Documentation/notation/spacing.itely#newcode1714 Documentation/notation/spacing.itely:1714:

Re: Doc: Usage: Added para about diagnosing Errors (issue 105360043 by pkx1...@gmail.com)

2014-06-22 Thread pkx166h
Thanks Trevor https://codereview.appspot.com/105360043/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/105360043/diff/1/Documentation/usage/running.itely#newcode921 Documentation/usage/running.itely:921: if the same music

Re: Extending: 2.3.2 - Music Function usage (issue 108110043 by pkx1...@gmail.com)

2014-06-22 Thread pkx166h
Thanks Trevor https://codereview.appspot.com/108110043/diff/1/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://codereview.appspot.com/108110043/diff/1/Documentation/extending/programming-interface.itely#newcode341

Re: Issue 3951: Fix broken LSR links in docs. (issue 102410043 by markpole...@gmail.com)

2014-06-14 Thread pkx166h
I am not sure this is the best/correct method for the snippets. Shouldn't you be editing those in ../snippets/new/.. and then using makelsr.py to 'update' the snippets in the usual way? Else if someone comes and edits a snippet in new *after* this patch, all your work is undone as the 'new'

Re: Color and/or parenthesize single dots in fret-diagrams (issue 102450043 by thomasmorle...@gmail.com)

2014-06-14 Thread pkx166h
https://codereview.appspot.com/102450043/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): https://codereview.appspot.com/102450043/diff/1/Documentation/notation/fretted-strings.itely#newcode1002

Re: Doc: NR Clarify repeats w\ partials and barchecks (issue 61530043)

2014-02-16 Thread pkx166h
https://codereview.appspot.com/61530043/diff/20001/Documentation/notation/repeats.itely File Documentation/notation/repeats.itely (right): https://codereview.appspot.com/61530043/diff/20001/Documentation/notation/repeats.itely#newcode168 Documentation/notation/repeats.itely:168: measure,

Re: Authors.itexi - Updated Current Developers list (issue 61360043)

2014-02-16 Thread pkx166h
Reviewers: Graham Percival, fedelogy, Message: On 2014/02/15 09:34:06, fedelogy wrote: The Bug Squad list in Authors is out of date: http://lists.gnu.org/archive/html/bug-lilypond/2013-11/msg00138.html This list list should be also updated:

Re: Doc: NR Clarify repeats w\ partials and barchecks (issue 61530043)

2014-02-15 Thread pkx166h
Reviewers: Graham Percival, https://codereview.appspot.com/61530043/diff/1/Documentation/notation/repeats.itely File Documentation/notation/repeats.itely (right): https://codereview.appspot.com/61530043/diff/1/Documentation/notation/repeats.itely#newcode167

Re: Doc: Point-and-Click has wrong default value and ref to SVG output needs adding (issue 61630045)

2014-02-15 Thread pkx166h
Looking at the TexInfo page for @acronym https://www.gnu.org/software/texinfo/manual/texinfo/html_node/_0040acronym.html It doesn't seem to give us anything that useful and perhaps (as it also says in the link above): - In general, it's not essential to use either of these commands for all

<    1   2   3   4   5   6   7   8   9   10   >