Re: Fixes issue 1881 (cyclic dependency with beam calculations) (issue 5038042)

2011-09-17 Thread m...@apollinemike.com
On Sep 17, 2011, at 1:28 PM, Neil Puttock wrote: > On 17 September 2011 12:16, m...@apollinemike.com > wrote: > >> They should be applied separately - 5038042 fixes 1881, and 5057041 prunes >> down bloated code. There is a chance that 5057041 is effected by 5038042 (I >> haven't tested them

Re: Fixes issue 1881 (cyclic dependency with beam calculations) (issue 5038042)

2011-09-17 Thread Neil Puttock
On 17 September 2011 12:16, m...@apollinemike.com wrote: > They should be applied separately - 5038042 fixes 1881, and 5057041 prunes > down bloated code.  There is a chance that 5057041 is effected by 5038042 (I > haven't tested them together yet) though I doubt it.  After their countdowns, >

Re: Fixes issue 1881 (cyclic dependency with beam calculations) (issue 5038042)

2011-09-17 Thread m...@apollinemike.com
On Sep 17, 2011, at 1:06 PM, Peekay Ex wrote: > Mike, > > On Sat, Sep 17, 2011 at 10:27 AM, m...@apollinemike.com > wrote: >> On Sep 17, 2011, at 11:07 AM, n.putt...@gmail.com wrote: >> >>> LGTM. >>> >>> BTW, I have a few queries about stem::length: >>> >>> 76 (let* ((d (ly:grob-property gr

Re: Fixes issue 1881 (cyclic dependency with beam calculations) (issue 5038042)

2011-09-17 Thread Peekay Ex
Mike, On Sat, Sep 17, 2011 at 10:27 AM, m...@apollinemike.com wrote: > On Sep 17, 2011, at 11:07 AM, n.putt...@gmail.com wrote: > >> LGTM. >> >> BTW, I have a few queries about stem::length: >> >> 76   (let* ((d (ly:grob-property grob 'direction)) >> >> You don't use 'direction; is it still neces

Re: Fixes issue 1881 (cyclic dependency with beam calculations) (issue 5038042)

2011-09-17 Thread m...@apollinemike.com
On Sep 17, 2011, at 11:07 AM, n.putt...@gmail.com wrote: > LGTM. > > BTW, I have a few queries about stem::length: > > 76 (let* ((d (ly:grob-property grob 'direction)) > > You don't use 'direction; is it still necessary to get it to trigger > other calculations? > I doubt it - it's likely v

Re: Fixes issue 1881 (cyclic dependency with beam calculations) (issue 5038042)

2011-09-17 Thread n . puttock
LGTM. BTW, I have a few queries about stem::length: 76 (let* ((d (ly:grob-property grob 'direction)) You don't use 'direction; is it still necessary to get it to trigger other calculations? 79 (beam (ly:grob-object grob 'beam))) Why do you need to access 'beam? AFAICT, the cal

Fixes issue 1881 (cyclic dependency with beam calculations) (issue 5038042)

2011-09-17 Thread mtsolo
Reviewers: , Message: Hey all, A one-line-deletion patch to fix 1881. I think the re-introduction of length and stem-begin-position both made this line obsolete and triggered cyclic dependencies. I'm still not sure why these dependencies resulted in changed visual output, but this patch seems