Re: Implements footnotes in LilyPond (issue4245062)

2011-03-06 Thread Mike Solomon
On Mar 5, 2011, at 10:43 AM, Neil Puttock wrote: On 5 March 2011 14:38, Mike Solomon mike...@ufl.edu wrote: Done - thanks for bearing with me as I learn about break-visibility. It is a corner of the code that I never had to deal with directly, so I'm still getting my sea legs. I

Re: Implements footnotes in LilyPond (issue4245062)

2011-03-05 Thread Mike Solomon
Hey all, After a bit of back and forth w/ Han Wen, I have drummed up a way to split this up such that it can be part of LilyPond in two phases. It follows his suggestion to push all of the non-balloon-related stuff first, and to push that second. It will set the stencil property of

Re: Implements footnotes in LilyPond (issue4245062)

2011-03-05 Thread Joe Neeman
On Sat, Mar 5, 2011 at 10:18 PM, Mike Solomon mike...@ufl.edu wrote: Hey all, After a bit of back and forth w/ Han Wen, I have drummed up a way to split this up such that it can be part of LilyPond in two phases. It follows his suggestion to push all of the non-balloon-related stuff first,

Re: Implements footnotes in LilyPond (issue4245062)

2011-03-05 Thread Neil Puttock
On 5 March 2011 12:57, Mike Solomon mike...@ufl.edu wrote: Patch attached.  The stuff that comes from your comments regarding break-visibility is implemented in Balloon_interface::is_visible. The patch currently represents about 85% of the original, omitting the 15% that Han Wan had

Re: Implements footnotes in LilyPond (issue4245062)

2011-03-05 Thread Joe Neeman
On Sat, Mar 5, 2011 at 11:57 PM, Mike Solomon mike...@ufl.edu wrote: On Mar 5, 2011, at 7:19 AM, Joe Neeman wrote: On Sat, Mar 5, 2011 at 10:18 PM, Mike Solomon mike...@ufl.edu wrote: Hey all, After a bit of back and forth w/ Han Wen, I have drummed up a way to split this up such that it

Re: Implements footnotes in LilyPond (issue4245062)

2011-03-05 Thread Neil Puttock
On 5 March 2011 14:38, Mike Solomon mike...@ufl.edu wrote: Done - thanks for bearing with me as I learn about break-visibility.  It is a corner of the code that I never had to deal with directly, so I'm still getting my sea legs. I suggest you remove the fallback value from