https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode117
input/regression/scheme-text-spanner.ly:117: (event-drul
Instead, complete-grob-entry (or whatever it was
called)
needs to be changed in order to work non-destructively. It does not
make sense to do this separately from the original code.
OK, I won't bother yet with add-grob-definition here, but I wonder: if I
use copy-tree on a literal
Reviewers: ,
Message:
Please review.
Thanks,
David
Description:
input/regression/scheme-text-spanner.ly: fix problem with constants
The file `input/regression/scheme-text-spanner.ly' assigns a constant
pair to the variable `event-drul' and subsequently attempts to modify
the pair. This can
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode28
input/regression/scheme-text-spanner.ly:28: (set!
On 2013/07/23 13:05:47, david.nalesnik wrote:
On 2013/07/23 12:31:25, dak wrote:
Frankly, just throw out the crap event-drul and current-event, and
instead use
event-start and event-stop instead of (car event-drul) and (cdr
event-drul).
OK, will do.
Thank you, David.
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode28
On 2013/07/23 13:27:49, dak wrote:
On 2013/07/23 13:05:47, david.nalesnik wrote:
On 2013/07/23 12:31:25, dak wrote:
Frankly, just throw out the crap event-drul and current-event, and
instead
use
event-start and event-stop instead of (car event-drul) and (cdr
event-drul).
OK, will do.
On 2013/07/23 13:52:13, david.nalesnik wrote:
Sorry, replied a bit hastily!
[...]
I've thought some more about the issue of trying to change constants
elsewhere
in the file.
Specifically, regarding the addition of the new grob description to
all-grob-descriptions, would the following
On 2013/07/23 15:06:51, dak wrote:
On 2013/07/23 13:52:13, david.nalesnik wrote:
Sorry, replied a bit hastily!
[...]
I've thought some more about the issue of trying to change constants
elsewhere
in the file.
Specifically, regarding the addition of the new grob description to
On 2013/07/23 20:05:40, david.nalesnik wrote:
Hmmm, so if I understand correctly:
The problem in the regtest is that add-grob-definition should not be
applied to
the quasiquoted list. In doing so, however, nothing is being done that
doesn't
have precedent in define-grobs.scm.
Pretty
On 2013/07/23 20:16:24, dak wrote:
On 2013/07/23 20:05:40, david.nalesnik wrote:
I hesitate to do something like the following!
#(add-grob-definition
'SchemeTextSpanner
(list
(cons
'bound-details
(list
[...]
No, that's nonsensical. Instead, complete-grob-entry
11 matches
Mail list logo
