David Kastrup wrote
> https://codereview.appspot.com/341140043/diff/20001/lily/stencil-integral.cc#newcode393
> lily/stencil-integral.cc:393: for (vsize i = 0; i < (vsize) points.size
> () - 1; i++)
> Why would the last point not be transformed?
Oh, the last point actually is being transformed,
https://codereview.appspot.com/341140043/diff/20001/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/341140043/diff/20001/lily/stencil-integral.cc#newcode393
lily/stencil-integral.cc:393: for (vsize i = 0; i < (vsize) points.size
() - 1; i++)
Why
lily/stencil-integral.cc:410: int quantization = max (0, (int)
(rounded *
(x_scale + y_scale) * radius * M_PI / QUANTIZATION_UNIT / 4));
[Please use a line length of at most 78 characters if possible.]
In the original coding, many lines exceed 78 characters (including the
one you mention
LGTM, thanks!
https://codereview.appspot.com/341140043/diff/1/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/341140043/diff/1/lily/stencil-integral.cc#newcode410
lily/stencil-integral.cc:410: int quantization = max (0, (int) (rounded
* (x_scale +
Reviewers: ,
Message:
Please review...
Thanks
Torsten
Description:
issue 5307: Skyline Refinements (Rounded Boxes and Rotated Ellipses)
lily/stencil-integral.cc
function make_partial_ellipse_boxes:
Use correct scaling factors for x_rad and y_rad for an arbitrary
transformation matrix
This
