Re: Issue 5773: Quarter Tones for all Languages incl. MusicXML import (issue 577520043 by torsten.haemme...@web.de)

2020-02-29 Thread Wols Lists
On 23/02/20 11:50, torsten.haemme...@web.de wrote: > modified: scm/define-note-names.scm > - Missing quarter-tone definitions added, now all languages are > complete. > - Slightly changed sort order of norsk so that the commonly used forms > (the ones with doulbe-s) are in front of the less

Re: #5703 Run scripts/auxiliar/fixcc.py imminent

2020-02-29 Thread Jonas Hahnfeld
Am Samstag, den 29.02.2020, 02:36 +0100 schrieb David Kastrup: > Hi, I've run scripts/auciliar/fixcc.py on the stable branch now. So > that it is reasonably easy to cherry-pick new commits from master into > the stable branch, it would make sense doing that in staging/master as > well. This is a

Re: web/introduction.itexi: replace opera series with opera seria

2020-02-29 Thread pkx166h
On 19/02/2020 16:32, Federico Bruni wrote: Can anybody fix this typo in the website? http://lilypond.org/productions.html /opera series/opera seria/ See https://en.wikipedia.org/wiki/Opera_seria It was reported by Luca Rossetto. He suggests the following wording: Luca Rossetto Casel, for his

Re: Fixes for cross-compilation to x86_64-w64-mingw32 (issue 579340043 by jonas.hahnf...@gmail.com)

2020-02-29 Thread jonas . hahnfeld
On 2020/02/29 10:37:28, hahnjo wrote: > Rename DATADIR to CONFIG_DATADIR I need this additional fix to make it work with Guile 2.2 https://codereview.appspot.com/579340043/

Re: output-distance: treat non-existent files as empty string (issue 583590043 by hanw...@gmail.com)

2020-02-29 Thread hanwenn
Reviewers: hahnjo, Dan Eble, Message: On 2020/02/28 23:33:32, Dan Eble wrote: > On 2020/02/28 23:31:17, Dan Eble wrote: > > This does not look good. I expect this change to break the feature I added in > > 0d72930e579a5784ecb26da2f9880d8c9da05e71 (Issue 5635). Well, a call to strip > > (None) is

Re: build cleanups. (issue 547690053 by hanw...@gmail.com)

2020-02-29 Thread dak
https://codereview.appspot.com/547690053/diff/567300043/config.make.in File config.make.in (right): https://codereview.appspot.com/547690053/diff/567300043/config.make.in#newcode48 config.make.in:48: GROFF = @GROFF@ These sort of drive-by changes without any mention in commit message or issue

Re: mf: use python scripting for generating Emmentaler fonts (issue 553580043 by hanw...@gmail.com)

2020-02-29 Thread hanwenn
https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile#newcode130 mf/GNUmakefile:130: $(outdir)/emmentaler-brace.otf: emmentaler-brace.fontforge.py

Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-02-29 Thread lemzwerg--- via Discussions on LilyPond development
Very nice, thanks! LGTM. https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf File mf/feta-arrowheads.mf (right): https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf#newcode58 mf/feta-arrowheads.mf:58: y5 = 0; Please use an indentation of 8

Re: mf: use python scripting for generating Emmentaler fonts (issue 553580043 by hanw...@gmail.com)

2020-02-29 Thread lemzwerg--- via Discussions on LilyPond development
LGTM; some minor nits https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile#newcode130 mf/GNUmakefile:130: $(outdir)/emmentaler-brace.otf: emmentaler-brace.fontforge.py

Re: build cleanups. (issue 547690053 by hanw...@gmail.com)

2020-02-29 Thread hanwenn
added * Remove unused GROFF and LD autoconf vars to the commit msg. https://codereview.appspot.com/547690053/diff/567300043/config.make.in File config.make.in (right): https://codereview.appspot.com/547690053/diff/567300043/config.make.in#newcode48 config.make.in:48: GROFF = @GROFF@ On

Re: build cleanups. (issue 547690053 by hanw...@gmail.com)

2020-02-29 Thread dak
On 2020/02/29 22:13:42, hanwenn wrote: > added > > * Remove unused GROFF and LD autoconf vars > > to the commit msg. > > https://codereview.appspot.com/547690053/diff/567300043/config.make.in > File config.make.in (right): > >

Re: build cleanups. (issue 547690053 by hanw...@gmail.com)

2020-02-29 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/547690053/

Re: output-distance: treat non-existent files as empty string (issue 583590043 by hanw...@gmail.com)

2020-02-29 Thread nine . fierce . ballads
https://codereview.appspot.com/583590043/diff/571790043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/583590043/diff/571790043/scripts/build/output-distance.py#newcode531 scripts/build/output-distance.py:531: if self.contents[0]

Remove unused .1 => .txt rule (issue 557560044 by hanw...@gmail.com)

2020-02-29 Thread hanwenn
Reviewers: , Message: tested by running 'make dist' Description: Remove unused .1 => .txt rule Please review this at https://codereview.appspot.com/557560044/ Affected files (+0, -5 lines): M stepmake/stepmake/documentation-rules.make Index: stepmake/stepmake/documentation-rules.make diff

Re: build cleanups. (issue 547690053 by hanw...@gmail.com)

2020-02-29 Thread hanwenn
On 2020/02/29 22:28:14, dak wrote: > On 2020/02/29 22:13:42, hanwenn wrote: > > added > > > > * Remove unused GROFF and LD autoconf vars > > > > to the commit msg. > > > > https://codereview.appspot.com/547690053/diff/567300043/config.make.in > > File config.make.in (right): > > > > >

Re: build cleanups. (issue 547690053 by hanw...@gmail.com)

2020-02-29 Thread hanwenn
https://codereview.appspot.com/557560044/ https://codereview.appspot.com/547690053/

Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-02-29 Thread torsten . haemmerle
Reviewers: , Message: Please review. Description: Issue 5806: Tweak mf files to avoid FontForge internal overlap error When compiling LilyPond, there were 352 error messages caused by FontForge trying to resolve overlapping path problems: >>> Internal Error (overlap) in [...] Fortunately, the

Re: Issue 5773: Quarter Tones for all Languages incl. MusicXML import (issue 577520043 by torsten.haemme...@web.de)

2020-02-29 Thread torsten . haemmerle
On 2020/02/29 10:44:40, antlists_youngman.org.uk wrote: > Smelling pistake, sorry ... - just spotted it. Hi Wol, Too late - this has already been pushed. But as it's only the commit message description, it won't have any effect anyway. But taking a closer look, I've found "propoer" with an extra

Re: mf: use python scripting for generating Emmentaler fonts (issue 553580043 by hanw...@gmail.com)

2020-02-29 Thread lemzwerg--- via Discussions on LilyPond development
> > Can we assume that FontForge's python support and is > > always enabled? Shall we check this? > > the FF page doesn't say that python is optional. It's a build option in both the old (configure) and new (cmake) builds... https://codereview.appspot.com/553580043/

Re: Remove unused .1 => .txt rule (issue 557560044 by hanw...@gmail.com)

2020-02-29 Thread dak
On 2020/02/29 22:37:03, hanwenn wrote: > tested by running 'make dist' Maybe move the removal of the GROFF test/flag here? If there should be some unexpected breakage at some point of time, that makes it more likely that it can be handled with a single revert.

Re: Remove unused .1 => .txt rule (issue 557560044 by hanw...@gmail.com)

2020-02-29 Thread dak
On 2020/02/29 23:57:03, dak wrote: > On 2020/02/29 22:37:03, hanwenn wrote: > > tested by running 'make dist' > > Maybe move the removal of the GROFF test/flag here? If there should be some > unexpected breakage at some point of time, that makes it more likely that it can > be handled with a

Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-02-29 Thread torsten . haemmerle
Re-formatted: spaces inserted and strictly 8 char indentations. https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf File mf/feta-arrowheads.mf (right): https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf#newcode58 mf/feta-arrowheads.mf:58: y5