Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-07-01 Thread mtsolo
http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc#newcode693 lily/skyline.cc:693: Skyline::padded (Real horizon_padding) const On 2012/07/01 23:04:17, Keith wrote: The horizon_padding b

Re: building master / fixed all Critical?

2012-07-01 Thread David Kastrup
Graham Percival writes: > I'm not certain where we stand. Over the weekend, some patches > were pushed (by accident?) to master. One (or more?) of those > commits broke compiling, and were reverted. This fix was (or will > be?) pushed to staging, and people can (or can not?) now compile > git

Re: building master / fixed all Critical?

2012-07-01 Thread m...@apollinemike.com
On 2 juil. 2012, at 01:26, Keith OHara wrote: > Graham Percival percival-music.ca> writes: > >> Could we get a clear note about which commit(s) were reverted and >> are presumably in limbo? If the remaining commits fixed 2604 and >> 2524 (which at a first glance appear to be resolved), then co

Re: whitespace issue with ly:one-line-breaking

2012-07-01 Thread Werner LEMBERG
>> Where do the additional vertical 1000px come from? Looks like a >> bug... > > It comes from the height of the page: ly:one-line-breaking doesn't > (currently) adjust the height, but only the width. Ah, ok. I've only skimmed the code with gitk and missed that. I suggest to (optionally?) adj

Re: formatted GNUmakefile

2012-07-01 Thread Werner LEMBERG
>> SUBDIRS = \ >> python scripts \ > > I'm a big fan of splitting lists into one entry per line; esp. if > you break at position 20 rather than 78. Yes! Of course, if you have a lot of small entries like SUBDIRS = \ foo bar baz foz fuz buz vertical alignment is probably harder to read

PATCH: Countdown to 20120703

2012-07-01 Thread Colin Campbell
For 20:00 MDT Tuesday July 3 Enhancement: Issue 2626 : Patch: which-page - R6352049 Cheers, Colin -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You

Re: building master / fixed all Critical?

2012-07-01 Thread Aleksandr Andreev
On Sun, Jul 1, 2012 at 6:29 PM, Graham Percival wrote: > I'm not certain where we stand. Over the weekend, some patches > were pushed (by accident?) to master. One (or more?) of those > commits broke compiling, and were reverted. This fix was (or will I was just able to make doc from scratch w

Re: building master / fixed all Critical?

2012-07-01 Thread Keith OHara
Graham Percival percival-music.ca> writes: > Could we get a clear note about which commit(s) were reverted and > are presumably in limbo? If the remaining commits fixed 2604 and > 2524 (which at a first glance appear to be resolved), then could > we get those marked as fixed so that I can try ma

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-07-01 Thread k-ohara5a5a
http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc#newcode693 lily/skyline.cc:693: Skyline::padded (Real horizon_padding) const The horizon_padding built in to Skyline::Skyline had nice b

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-07-01 Thread k-ohara5a5a
I like the direction in which this goes, making things closer, because it is easier for users to add padding when needed than to persuade LilyPond to space things more closely. I did a quick test on some music. Ledger lines might not be getting the space they n

building master / fixed all Critical?

2012-07-01 Thread Graham Percival
I'm not certain where we stand. Over the weekend, some patches were pushed (by accident?) to master. One (or more?) of those commits broke compiling, and were reverted. This fix was (or will be?) pushed to staging, and people can (or can not?) now compile git master without problems. Could we g

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-07-01 Thread m...@apollinemike.com
On 1 juil. 2012, at 17:08, David Kastrup wrote: > mts...@gmail.com writes: > >> It's back... >> >> The only thing that doesn't the work the way I'd expect it is >> Skyline::padded. It seems to not be adding the padding correctly (Joe - >> any ideas)? This causes tighter than desired spacing in

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-07-01 Thread David Kastrup
mts...@gmail.com writes: > It's back... > > The only thing that doesn't the work the way I'd expect it is > Skyline::padded. It seems to not be adding the padding correctly (Joe - > any ideas)? This causes tighter than desired spacing in > alignment-order.ly. Other than that it is all reviewabl

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-07-01 Thread mtsolo
It's back... The only thing that doesn't the work the way I'd expect it is Skyline::padded. It seems to not be adding the padding correctly (Joe - any ideas)? This causes tighter than desired spacing in alignment-order.ly. Other than that it is all reviewable! For those who were keeping score

Spurious functions in lily/span-bar.cc

2012-07-01 Thread Marc Hohl
Hello list, while still working on Issue 1320, I found out that the functions defined in lily/span-bar.cc Span_bar::center_on_spanned_callback and Span_bar::get_spanned_interval are apparently not used since SHA1 ID 4995fea559cd5399b4f462de546a15195d76f4c3 dated 2001-06-29. Is it ok to remov

Re: TablEdit

2012-07-01 Thread Graham Percival
On Fri, Jun 29, 2012 at 08:55:31PM -0600, Colin Campbell wrote: > While TablEdit certainly looks impressive, I think we couldn't list > it on our website, as it is commercial software. Being a GNU > project, Lilypond is free as in beer and free as in speech, so we > really can only recommend the s

Re: Fw: GNU Source-highlight 3.1.7

2012-07-01 Thread Federico Bruni
Il 01/07/2012 08:06, Werner LEMBERG ha scritto: This might be of interest to some of you. Search for `Lilypond'. Werner See issue 1005: http://code.google.com/p/lilypond/issues/detail?id=1005 Still two steps to have highlight in documentation. -- Federico __

Re: whitespace issue with ly:one-line-breaking

2012-07-01 Thread Joe Neeman
On Sat, Jun 30, 2012 at 7:42 AM, Werner LEMBERG wrote: > > Consider this example file `foo.ly': > > \version "2.15.41" > > \paper { > page-breaking = #ly:one-line-breaking > } > > \header { > copyright = ##f > footer = ##f > tagline = ##f > } > > \relative c' { > \