Re: rest/mm-rest-markup

[David Nalesnik]

On Mon, Jul 31, 2017 at 11:53 AM, Thomas Morley
 wrote:
> 2017-07-31 18:09 GMT+02:00 David Kastrup :
>> David Nalesnik  writes:
>>
>>> On Mon, Jul 31, 2017 at 9:08 AM, David Kastrup  wrote:
 Thomas Morley  writes:

> Hi David,
>
> this refers to
> http://lists.gnu.org/archive/html/lilypond-devel/2017-07/msg00144.html
> I opened a new thread, because this one will be about rest-markups only.
>
> rest-by-number-markup and rest-markup were impemented by myself
> commit ffa21bb1a55d2436bb432c4dff7ec04df95dc6f0
> My second patch at all.

 Ah, I thought that it wasn't quite in the line of code I see you doing
 these days.  A few corners looked like copying idioms of David Nalesnik
 in cases for which they appeared overengineered.
>>>
>>> Goodness!  Hopefully, I'm not as guilty of "open coding" these days.
>>
>> Anybody else needs his toes stepped on while I'm on a run?
>
>
> rofl

I laughed too.

>
> More seriously. I learned a lot studying your code, David N and David
> K and from several others.
> And I plan to continue this behaviour ;)
>

Can't say how much I've learned from studying code on the lists and
from feedback.  Best computer course I've had.

Best,
DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 4678: Fix spaces in metronome mark (issue 323420043 by beauleetien...@gmail.com)

[beauleetienne0]

Reviewers: ,

Message:
Even though this part is fixed, it would be important to combine all
consecutive
text parts of the tempo indication into one  tag. This would make
the
output neater, as there can be a very wide gap between the text and
metronome
mark, and the excessive space before the last bracket (as seen in the
issue).

With those issues out of the way, it should be easier to fix the more
important
bug: https://sourceforge.net/p/testlilyissues/issues/3778/

Thank you for reviewing this patch and for improving the SVG
functionality.

Description:
Issue 4678: Fix spaces in metronome mark

This change specifies the types of spaces used in the metronome
markings as comments. It also changes the type of space to non-breaking
around the equals sign. The change also improves readability by
combining chars into strings.

Please review this at https://codereview.appspot.com/323420043/

Affected files (+4, -6 lines):
  M scm/translation-functions.scm


Index: scm/translation-functions.scm
diff --git a/scm/translation-functions.scm b/scm/translation-functions.scm
index  
0ed0deff0a24817edc4f53b42fb902313f0e75bc..e911b7c3c5f5209266f282034301e9d0a8f4160f  
100644

--- a/scm/translation-functions.scm
+++ b/scm/translation-functions.scm
@@ -65,9 +65,8 @@ way the transposition number is displayed."
(list
 (make-simple-markup
 (number->string (car count)))
-(make-simple-markup " ")
-(make-simple-markup "–")
-(make-simple-markup " ")
+; Spaces are thin U+2009
+(make-simple-markup " - ")
 (make-simple-markup
 (number->string (cdr count))
  (else #f)))
@@ -75,9 +74,8 @@ way the transposition number is displayed."
   (make-concat-markup
(list
 (make-general-align-markup Y DOWN note-mark)
-(make-simple-markup " ")
-(make-simple-markup "=")
-(make-simple-markup " ")
+; Spaces are non-breaking U+00A0
+(make-simple-markup " = ")
 count-markup))
   #f))
  (text-markup (if (not (null? text))


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issues write access

[Étienne Beaulé]

I plan to contribute patches related to SVG rendering.

Thank you!

Étienne

2017-08-10 6:15 GMT-03:00 Trevor Daniels :

>
> Étienne Beaulé wrote Thursday, August 10, 2017 2:51 AM
>
>
> > Hello. May I be granted write access on our issue tracker? My username is
> > ebe123. Thank you!
>
> Added.  Welcome!
>
> Trevor
>
>
> ---
> This email has been checked for viruses by AVG.
> http://www.avg.com
>
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issues write access

[Trevor Daniels]

Étienne Beaulé wrote Thursday, August 10, 2017 2:51 AM


> Hello. May I be granted write access on our issue tracker? My username is
> ebe123. Thank you!

Added.  Welcome!

Trevor


---
This email has been checked for viruses by AVG.
http://www.avg.com
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issues write access

[Phil Holmes]

- Original Message - 
From: "Étienne Beaulé" 

To: 
Sent: Thursday, August 10, 2017 2:51 AM
Subject: Issues write access



Hello. May I be granted write access on our issue tracker? My username is
ebe123. Thank you!


Could you tell us what you plan to contribute, please?


--
Phil Holmes 



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel